Function Error Unexpected | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

required to function call function 2 replies

EA error message (0) no error 6 replies

ProRealTime Function Error (ProScreener & Dhigh) 0 replies

stop loss function and edit time function for Breakout EA 1 reply

Function Definition Unexpected 6 replies

Attachments: Function Error Unexpected
Exit Attachments

Function Error Unexpected

  • #1
  • First Post: Mar 6, 2009 5:43pm Mar 6, 2009 5:43pm
I am getting an error "function definition unexpected" I typed it into the search engine and couldn't find anything on debugging it.. does anyone know what this means and what I should be looking for to correct it?
  • #2
  • Mar 6, 2009 7:09pm Mar 6, 2009 7:09pm
when you double click the error what line does it take you to? Also, attach your EA so people can help you, otherwise we will waste time guessing what the problem could be.
  • #3
  • Edited Mar 7, 2009 7:59am Mar 6, 2009 11:48pm | Edited Mar 7, 2009 7:59am
As you will see, I am trying to clean an old EA and input my style into it and make it dynamic.... it will be challenging since I am not familiar with this program language

I will be going one by one and adding adjustments once I have a decent framework in place

==========================

Edited it as I cleaned out a little more..... and went back through my notes and added more credits in it....
Attached File(s)
File Type: mq4 Coach StdDev.mq4   14 KB | 269 downloads
  • #4
  • Mar 7, 2009 8:13am Mar 7, 2009 8:13am
in your start function you are missing 2 } which is causing your issue.
  • #5
  • Mar 7, 2009 8:23am Mar 7, 2009 8:23am
Is there a good program or something that will help with seeing the layout of the code? It seems to me that it would be easier to write in some other area and then transfer over to the MetaEditor because it is really hard to line up the brackets.... I added it to the end and it compiles now, but I am sure it isn't properly aligned most likely, and I will have to take care of that when I change the guts of the start function up
  • #6
  • Mar 7, 2009 8:29am Mar 7, 2009 8:29am
no, that's the joy of working with mt4. nothing to help you troubleshoot the code at all. I would print it out and mark each one and make sure there is one to close it out. Probably the easiest way.

As a habit of mine, each time I open a new { I put in two blank lines and put the opposing } so I don't forget. Then I go back and fill in the blank lines.
  • #7
  • Mar 7, 2009 9:10am Mar 7, 2009 9:10am
Quoting magnumfreak
As a habit of mine, each time I open a new { I put in two blank lines and put the opposing } so I don't forget. Then I go back and fill in the blank lines.
That's what I do too. And to facilitate indentation, I use the "tab" key a lot. it's equivalent to 3 spaces (configurable in options).
Programming for a better future.
  • #8
  • Mar 7, 2009 7:43pm Mar 7, 2009 7:43pm
Inserted Code
   for(cnt=0;cnt<OrdersTotal();cnt++)   
   {
     if (OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES))
     {
       if (OrderSymbol()==Symbol() && OrderMagicNumber() == MagicNumber)
       {                
            if (OrderType()==OP_BUY || OrderType()==OP_SELL) 
            {
             MarketOpenOrders++;
             LastOrderOpenTime=OrderOpenTime();
            }
            if (OrderType()==OP_SELLLIMIT || OrderType()==OP_BUYLIMIT) LimitOpenOrders++;
            OpenOrders++;
       }
      }
   }
Ok, I am trying to figure out logistically what exactly this is doing... both from a programming standpoint and a Forex trading standpoint

It looks like it is counting the number of open trades, but I don't have a fullf grasp of the logic behind what is truly being done here... here is my interpretation

It is looking to see if there are any opentrades... then if there are, it is checking the magic number/symbol combination.... then whether it is a market or limit order.... then running a count of each... the OrderSelect function isn't explained to me clearly in the metratrader library
  • #9
  • Mar 7, 2009 7:44pm Mar 7, 2009 7:44pm
Inserted Code
    {
  I f price hits line1 && line1openorders<1  || price hits line2 && line2openorders<1 && currency || or price hits line3&& line3openorders <1 && currency  || price hits line4 && line4openorders <1 && currency
                                  Then
Determine Lot Size

  Open Order
                                                  Else
  If price hits line0 or hits line 5, close trade
  }
And this is the pseudo code logic that I am trying to implement... I am sure it may be missing some checks, but basically, I want it to check if the currency is tradeable based on a market scan script... if it is then to only allow it to have only one order opened per line
  • #10
  • Mar 8, 2009 7:31am Mar 8, 2009 7:31am
Anyone have any advice here?
  • #11
  • Last Post: Mar 9, 2009 1:06am Mar 9, 2009 1:06am
After doing more analysis, this thing would work really well if I convert it to a trend trader, and use the Stoch indicator with it

So, if it is in the StdDev levels, and the stoch shows a buy or sell in its levels, then it buys or sells at each line hit.... once outside of the StdDev levels, it closes at a cross.... so I am looking at this on the EurUsd chart for a long time, and the losses are minimal, but the gains are nice trades because the further the StdDev are out, the bigger the lot size factor so it gains more.... is also looks like a scalper with this method as well... doesn't open up trades regardless of stoch until it is in the StdDev ranges, and doesn't close based on Stoch until between MA and StdDev ranges or if it hits the MA line first

Because of this, I can use a regular money manager since draw down won't be much at all and won't need a market scanner... can have it going with multiple currencies... thus, also keep diversified... this should be easier to code now and looks like it will work better
0 traders viewing now