Open several pairs at specific time | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

EA to open a position at a specific time 10 replies

Need a free EA that closes any open trade at a specific time 0 replies

How to get an Open price at specific time? 4 replies

EA to place order on specific time and specific price 2 replies

Howto get a Candle (High/Low/Open/Close) at any specific time 4 replies

Open several pairs at specific time

  • #1
  • First Post: Edited 11:37am Nov 14, 2008 12:58am | Edited 11:37am
Can some body help to write a script to open multiple pairs at specific time or point me where to get it? I try to search FF but could not find it.

I tried to write this . It compiled but didn't do anything.

#property show_inputs
extern double Lot = 1.0;
extern int OpenHour = 00; // Time to close, hours
extern int OpenMinute = 00; // Time to close, minutes

void start()
{
if (Hour()==OpenHour && Minute()>=OpenMinute) {

OrderSend("GBPUSD",OP_BUY, Lot, MarketInfo("GBPUSD",MODE_ASK), 2, NULL, NULL, NULL, 0, 0, CLR_NONE);
OrderSend("EURUSD",OP_BUY, Lot, MarketInfo("EURUSD",MODE_ASK), 2, NULL, NULL, NULL, 0, 0, CLR_NONE);
OrderSend("GBPJPY",OP_BUY, Lot, MarketInfo("GBPJPY",MODE_ASK), 2, NULL, NULL, NULL, 0, 0, CLR_NONE);
OrderSend("EURJPY",OP_BUY, Lot, MarketInfo("EURJPY",MODE_ASK), 2, NULL, NULL, NULL, 0, 0, CLR_NONE);

return(0);
}
}

Thank you very much.
  • #2
  • Nov 14, 2008 1:58am Nov 14, 2008 1:58am
Check the first book of MQL

I believe you can only open one order at time, Per second or so?

Regards

Dale

Maybee not a complete fix, but it may help
  • #3
  • Nov 14, 2008 7:52am Nov 14, 2008 7:52am
You could try changing your hours and minutes to "0" - I dont think "00" is valid
  • #4
  • Nov 14, 2008 11:46am Nov 14, 2008 11:46am
Quoting LongToBeFree
You could try changing your hours and minutes to "0" - I dont think "00" is valid
Thank you all for your suggestions. "0" still doesn't fix the problem.

Thanks
  • #5
  • Nov 14, 2008 12:09pm Nov 14, 2008 12:09pm
Try this:
extern string TradingTimes = "Trading Times";
extern int StartHour=0;
extern int StartMinute=10;
extern int EndHour=22;
extern int EndMinute=00;
-------------------
start()
{
etc.

if(Hour()<StartHour) return(0);
if(Hour()==StartHour && Minute()<StartMinute) return(0);
if(Hour()>EndHour) return(0);
if(Hour()==EndHour && Minute()>EndMinute) return(0);
}
  • #6
  • Nov 14, 2008 12:27pm Nov 14, 2008 12:27pm
did you tick the box for the "Allow Live Trading" in Tools -> Options -> Expert Advisor ?

all scripts that sends orders requires this to be done cos you don't get to choose this setting like an EA allow. Note that once you do this, "Allow Live Trading" will become the default for your EAs as well.

code wise, set Stop Loss and Take Profit to 0 instead of NULL
Programming for a better future.
  • #7
  • Nov 14, 2008 12:31pm Nov 14, 2008 12:31pm
It's a script, right?

Scripts only run for the tick they are attached to the chart. That means if the time doesn't match on that Tick, the script shuts down.

Also, your Hour() and Minute() functions are wrong
Here is the revised code:

Inserted Code
#property show_inputs
extern double Lot = 1.0;
extern int OpenHour = 00; // Time to close, hours
extern int OpenMinute = 00; // Time to close, minutes
 
void start()
{
if (TimeHour(TimeCurrent())==OpenHour && TimeMinute(TimeCurrent())>=OpenMinute) {
 
OrderSend("GBPUSD",OP_BUY, Lot, MarketInfo("GBPUSD",MODE_ASK), 2, NULL, NULL, NULL, 0, 0, CLR_NONE);
OrderSend("EURUSD",OP_BUY, Lot, MarketInfo("EURUSD",MODE_ASK), 2, NULL, NULL, NULL, 0, 0, CLR_NONE);
OrderSend("GBPJPY",OP_BUY, Lot, MarketInfo("GBPJPY",MODE_ASK), 2, NULL, NULL, NULL, 0, 0, CLR_NONE);
OrderSend("EURJPY",OP_BUY, Lot, MarketInfo("EURJPY",MODE_ASK), 2, NULL, NULL, NULL, 0, 0, CLR_NONE);
 
return(0);
}
}


Here's what the script does:

  1. Check the time
  2. If the time matches, enter the orders
  3. If the time doesn't match, stop.

  • #8
  • Nov 14, 2008 1:02pm Nov 14, 2008 1:02pm
Quoting Ronald Raygun
It's a script, right?

Scripts only run for the tick they are attached to the chart. That means if the time doesn't match on that Tick, the script shuts down.

Also, your Hour() and Minute() functions are wrong
Here is the revised code:

[code]#property show_inputs
extern double Lot = 1.0;
extern int OpenHour = 00; // Time to close, hours
extern int OpenMinute = 00; // Time to close, minutes

void start()
{
if (TimeHour(TimeCurrent())==OpenHour && TimeMinute(TimeCurrent())>=OpenMinute) {

OrderSend("GBPUSD",OP_BUY, Lot, MarketInfo("GBPUSD",MODE_ASK),...
not to be overly picky on words but that's not entirely accurate. scripts doesn't wait for a tick before running start(). it runs immediately after attached, initialised and only run once.

just stating this to avoid confusion.
Programming for a better future.
  • #9
  • Nov 14, 2008 2:32pm Nov 14, 2008 2:32pm
Quoting Ronald Raygun
It's a script, right?

Scripts only run for the tick they are attached to the chart. That means if the time doesn't match on that Tick, the script shuts down.

Also, your Hour() and Minute() functions are wrong
Here is the revised code:

[code]#property show_inputs
extern double Lot = 1.0;
extern int OpenHour = 00; // Time to close, hours
extern int OpenMinute = 00; // Time to close, minutes

void start()
{
if (TimeHour(TimeCurrent())==OpenHour && TimeMinute(TimeCurrent())>=OpenMinute) {

OrderSend("GBPUSD",OP_BUY, Lot, MarketInfo("GBPUSD",MODE_ASK),...
Thanks Ronald Raygun for your input. According to your comments, it looks like I can't do this in a Script. What I want to do is to open an order for each pair at specific time of my choice (user input) then shut down the script. Is there any way to make a script waiting for that time?

When I put the above code in an EA format, it open orders when 'time' and 'minute' equal to the setting time but it continuosly open a lot of orders for the same pair until the minute is different to the 'minute' in the setting. So I need some codes to stop the EA from open orders if there is an order already open for that pair. I hope it not complicated the problem.

Thank you all.
  • #10
  • Nov 14, 2008 3:37pm Nov 14, 2008 3:37pm
there's a few ways to achieve this. a quick and dirty way is to use a boolean variable called maybe "bool TradeOpened = false;". check if its false before opening orders, set it to true after all those OrderSend has ran.

Inserted Code
extern double Lot = 1.0;
extern int OpenHour = 00; // Time to close, hours
extern int OpenMinute = 00; // Time to close, minutes
 
bool TradeOpened = false;
void start()
{
if (TimeHour(TimeCurrent())==OpenHour && TimeMinute(TimeCurrent())==OpenMinute && TradeOpened == false) {
 
OrderSend("GBPUSD",OP_BUY, Lot, MarketInfo("GBPUSD",MODE_ASK), 2, 0, 0, NULL, 0, 0, CLR_NONE);
OrderSend("EURUSD",OP_BUY, Lot, MarketInfo("EURUSD",MODE_ASK), 2, 0, 0, NULL, 0, 0, CLR_NONE);
OrderSend("GBPJPY",OP_BUY, Lot, MarketInfo("GBPJPY",MODE_ASK), 2, 0, 0, NULL, 0, 0, CLR_NONE);
OrderSend("EURJPY",OP_BUY, Lot, MarketInfo("EURJPY",MODE_ASK), 2, 0, 0, NULL, 0, 0, CLR_NONE);

TradeOpened = true;
return(0);
}
}

The above method although easy, isn't a good practise cos it doesn't cater for scenarios whereby the EA gets reinitialised for whatever reasons within the minute. And it doesn't track whether those orders were opened successfully.

A better method would be to check the Running Orders and OrderHistory first before doing an OrderSend.

Inserted Code
extern double Lot = 1.0;
extern int OpenHour = 0; // Time to close, hours
extern int OpenMinute = 0; // Time to close, minutes
extern int EA_MAGIC_NUM = 546284;
//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int init()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+

void start()
{
   if (TimeHour(TimeCurrent())==OpenHour && TimeMinute(TimeCurrent())==OpenMinute) 
   {
      if (DecideToOpenTrade("GBPUSD"))
      {
         OrderSend("GBPUSD",OP_BUY, Lot, MarketInfo("GBPUSD",MODE_ASK), 2, 0, 0, NULL, 0, 0, CLR_NONE);
      }
      if (DecideToOpenTrade("EURUSD"))
      {
         OrderSend("EURUSD",OP_BUY, Lot, MarketInfo("EURUSD",MODE_ASK), 2, 0, 0, NULL, 0, 0, CLR_NONE);
      }
      if (DecideToOpenTrade("GBPJPY"))
      {
         OrderSend("GBPJPY",OP_BUY, Lot, MarketInfo("GBPJPY",MODE_ASK), 2, 0, 0, NULL, 0, 0, CLR_NONE);
      }
      if (DecideToOpenTrade("EURJPY"))
      {
         OrderSend("EURJPY",OP_BUY, Lot, MarketInfo("EURJPY",MODE_ASK), 2, 0, 0, NULL, 0, 0, CLR_NONE);
      }
   }
   return (0);
}
//+------------------------------------------------------------------+
//| Trade Checking Logic                                             |
//+------------------------------------------------------------------+
bool DecideToOpenTrade(string SymbolToUse)
{
   int total = OrdersTotal();
   if (total > 0)
   {
      for(int cnt=0;cnt<total;cnt++)
      {
         if(OrderSelect(cnt,SELECT_BY_POS))
         {
            if(OrderSymbol()==SymbolToUse && OrderMagicNumber() == EA_MAGIC_NUM)
            {
               if (Time[0] <= OrderOpenTime()) // don't open a new position if we're still on the same candle
               {
                  return (false);
               }
            }
         }
      }
   }
   // in case trades has already opened and closed within the candle
   int histotal = OrdersHistoryTotal();
   if (histotal > 0)
   {
      for(cnt=0;cnt<histotal;cnt++)
      {
         if(OrderSelect(cnt,SELECT_BY_POS,MODE_HISTORY))
         {
            if(OrderSymbol()==SymbolToUse && OrderMagicNumber() == EA_MAGIC_NUM)
            {
               if (Time[0] <= OrderOpenTime()) // don't open a new position if we're still on the same candle
               {
                  return (false);
               }
            }
         }
      }
   }
   return (true);
}

hope this helps.

regards,
Zen
Programming for a better future.
  • #11
  • Nov 14, 2008 3:55pm Nov 14, 2008 3:55pm
Quoting greenfx08
Thanks Ronald Raygun for your input. According to your comments, it looks like I can't do this in a Script.
again that's not entirely true. you can do this with a script. just have to make sure it keeps running till you close it or when the conditions were met.

We can write scripts to do something like checks etc after each predefined interval. It's kinda like an EA except this script is time based and not tick based like an EA.

Inserted Code
extern double Lot = 1.0;
extern int OpenHour = 0; // Time to close, hours
extern int OpenMinute = 0; // Time to close, minutes
extern int EA_MAGIC_NUM = 546284;
extern int interval = 1000;
//+------------------------------------------------------------------+
//| script program start function                                    |
//+------------------------------------------------------------------+
void start()
{
   while (true)
   {
      if (TimeHour(TimeCurrent())==OpenHour && TimeMinute(TimeCurrent())==OpenMinute) 
      {
         if (DecideToOpenTrade("GBPUSD"))
         {
            OrderSend("GBPUSD",OP_BUY, Lot, MarketInfo("GBPUSD",MODE_ASK), 2, 0, 0, NULL, 0, 0, CLR_NONE);
         }
         if (DecideToOpenTrade("EURUSD"))
         {
            OrderSend("EURUSD",OP_BUY, Lot, MarketInfo("EURUSD",MODE_ASK), 2, 0, 0, NULL, 0, 0, CLR_NONE);
         }
         if (DecideToOpenTrade("GBPJPY"))
         {
            OrderSend("GBPJPY",OP_BUY, Lot, MarketInfo("GBPJPY",MODE_ASK), 2, 0, 0, NULL, 0, 0, CLR_NONE);
         }
         if (DecideToOpenTrade("EURJPY"))
         {
            OrderSend("EURJPY",OP_BUY, Lot, MarketInfo("EURJPY",MODE_ASK), 2, 0, 0, NULL, 0, 0, CLR_NONE);
         }
         // Check if all trades were opened.
         if (!DecideToOpenTrade("GBPUSD") && !DecideToOpenTrade("EURUSD") && !DecideToOpenTrade("GBPJPY") && !DecideToOpenTrade("EURJPY"))
         {
            break; // this gets out of the while loop and ends the script
         }
      }
      Sleep(interval); // sleep for a second at every round so that it doesn't hog up CPU usage.
   }
   return (0);
}
//+------------------------------------------------------------------+
//| Trade Checking Logic                                             |
//+------------------------------------------------------------------+
bool DecideToOpenTrade(string SymbolToUse)
{
   int total = OrdersTotal();
   if (total > 0)
   {
      for(int cnt=0;cnt<total;cnt++)
      {
         if(OrderSelect(cnt,SELECT_BY_POS))
         {
            if(OrderSymbol()==SymbolToUse && OrderMagicNumber() == EA_MAGIC_NUM)
            {
               if (Time[0] <= OrderOpenTime()) // don't open a new position if we're still on the same candle
               {
                  return (false);
               }
            }
         }
      }
   }
   // in case trades has already opened and closed within the candle
   int histotal = OrdersHistoryTotal();
   if (histotal > 0)
   {
      for(cnt=0;cnt<histotal;cnt++)
      {
         if(OrderSelect(cnt,SELECT_BY_POS,MODE_HISTORY))
         {
            if(OrderSymbol()==SymbolToUse && OrderMagicNumber() == EA_MAGIC_NUM)
            {
               if (Time[0] <= OrderOpenTime()) // don't open a new position if we're still on the same candle
               {
                  return (false);
               }
            }
         }
      }
   }
   return (true);
}
//+------------------------------------------------------------------+
Programming for a better future.
  • #12
  • Nov 14, 2008 3:57pm Nov 14, 2008 3:57pm
btw, I've not compiled or tested those codes I printed. currently only have WordPad to type with.
Programming for a better future.
  • #13
  • Nov 14, 2008 6:39pm Nov 14, 2008 6:39pm
Quoting Zen_Leow
btw, I've not compiled or tested those codes I printed. currently only have WordPad to type with.
Thank you Zen_Leow for all the codes. Since the market is already close, I'll let you know on Sunday.

Thanks and have a great weekend.
  • #14
  • Last Post: Nov 16, 2008 7:54pm Nov 16, 2008 7:54pm
Quoting Zen_Leow
btw, I've not compiled or tested those codes I printed. currently only have WordPad to type with.
Thanks Zen_Leow and others for helping me. Using the code above in an EA, I changed this line:

if(OrderSymbol()==SymbolToUse && OrderMagicNumber() == EA_MAGIC_NUM)

to this line:
if(OrderSymbol()==SymbolToUse ) // && OrderMagicNumber() == EA_MAGIC_NUM)

It now opens only 1 order for each pair as I want.

Thanks again.
gFX
0 traders viewing now