Indicators development for T101's not very simple method

Quoting Ronald Raygun

Disliked

That's hard to believe lol. The only real coding I've done on FF is EA-coding, not indicator coding.

Ignored

Quoting RobertHill

Disliked

Here is the other indicator on first post with no m required. The "m" is put there automatically like the other I posted.
Robert

Ignored

Quoting Orest

Disliked

Robert,
could you point me to the error you mentioned?
Thanks

Ignored

Quoting tazmaan

Disliked

Hey RR,
I have a question regarding your T101 v2.4 ea. I finally got it working a little bit ago, and once started I noticed it opened trades immediately, even though it said 'ranging'.
Is this normal?
Also, now it has changed to a BUY signal, but I still have all the sells open from when it first started. Is it possible to have the EA see the signal reversal, close trades and open them based on the new signal? (ie close all my sells now and open all buys).
Just curious.
Thanks

Ignored

Quoting Ronald Raygun

Disliked

That's hard to believe lol. The only real coding I've done on FF is EA-coding, not indicator coding.

Here is the code:

Inserted Code

//+------------------------------------------------------------------+
//|                                        Trader101 TradeBasket.mq4 |
//|                      Copyright © 2008, MetaQuotes Software Corp. |
//|                                        http://www.metaquotes.net |
//+------------------------------------------------------------------+
#property copyright "Copyright © 2008, MetaQuotes Software Corp."
#property link      "http://www.metaquotes.net"
 
#property indicator_separate_window
#property indicator_minimum 0
#property indicator_maximum 15
#property indicator_buffers 1
#property indicator_color1 Red
 
extern string Remark4 = "== Global Settings ==";
extern int BarsBack = 10;
extern color Color = Red;
extern string Remark5 = "";
extern string Remark1 = "== Buy Direction Pairs ==";
extern string Buy1 = "GBPUSD";
extern bool ShowRank1 = False;
extern string Buy2 = "EURGBP";
extern bool ShowRank2 = False;
extern string Buy3 = "GBPCHF";
extern bool ShowRank3 = False;
extern string Buy4 = "CHFJPY";
extern bool ShowRank4 = False;
extern string Buy5 = "AUDJPY";
extern bool ShowRank5 = False;
extern string Buy6 = "EURJPY";
extern bool ShowRank6 = False;
extern string Buy7 = "USDCHF";
extern bool ShowRank7 = False;
 
extern string Remark2 = "";
extern string Remark3 = "== Sell Direction Pairs ==";
extern string Sell1 = "CADJPY";
extern bool ShowRank8 = False;
extern string Sell2 = "AUDUSD";
extern bool ShowRank9 = False;
extern string Sell3 = "USDJPY";
extern bool ShowRank10 = False;
extern string Sell4 = "EURUSD";
extern bool ShowRank11 = False;
extern string Sell5 = "EURCHF";
extern bool ShowRank12 = False;
extern string Sell6 = "GBPJPY";
extern bool ShowRank13 = False;
extern string Sell7 = "USDCAD";
extern bool ShowRank14 = False;
 
 
//---- buffers
double Rank[];
double StartingArray[13];
double ReferenceArray[13];
int RankArray[13];
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int init()
  {
//---- indicators
   SetIndexStyle(0,DRAW_LINE, EMPTY, 1, Color);
   SetIndexBuffer(0,Rank);
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator deinitialization function                       |
//+------------------------------------------------------------------+
int deinit()
  {
//----
 
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int start()
  {
   int    i,counted_bars=IndicatorCounted();
//----
 
i=Bars-counted_bars-1;
 
while(i>=0) 
{
   StartingArray[0] = BuyProfit(Buy1, i);
   StartingArray[1] = BuyProfit(Buy2, i);
   StartingArray[2] = BuyProfit(Buy3, i);
   StartingArray[3] = BuyProfit(Buy4, i);
   StartingArray[4] = BuyProfit(Buy5, i);
   StartingArray[5] = BuyProfit(Buy6, i);
   StartingArray[6] = BuyProfit(Buy7, i);
   StartingArray[7] = SellProfit(Sell1, i);
   StartingArray[8] = SellProfit(Sell2, i);
   StartingArray[9] = SellProfit(Sell3, i);
   StartingArray[10] = SellProfit(Sell4, i);
   StartingArray[11] = SellProfit(Sell5, i);
   StartingArray[12] = SellProfit(Sell6, i);
   StartingArray[13] = SellProfit(Sell7, i);
   Print("Establish Starting Array");
 
   ReferenceArray[0] = BuyProfit(Buy1, i);
   ReferenceArray[1] = BuyProfit(Buy2, i);
   ReferenceArray[2] = BuyProfit(Buy3, i);
   ReferenceArray[3] = BuyProfit(Buy4, i);
   ReferenceArray[4] = BuyProfit(Buy5, i);
   ReferenceArray[5] = BuyProfit(Buy6, i);
   ReferenceArray[6] = BuyProfit(Buy7, i);
   ReferenceArray[7] = SellProfit(Sell1, i);
   ReferenceArray[8] = SellProfit(Sell2, i);
   ReferenceArray[9] = SellProfit(Sell3, i);
   ReferenceArray[10] = SellProfit(Sell4, i);
   ReferenceArray[11] = SellProfit(Sell5, i);
   ReferenceArray[12] = SellProfit(Sell6, i);
   ReferenceArray[13] = SellProfit(Sell7, i);
   Print("Establish Reference Array");
 
 
   bool swapped = true;
   int pos;
   double tempd;
   string temps;
 
   while (swapped)
   {
   swapped = false;
   pos = 0;
   while (pos < 13)
   {
   if (StartingArray[pos] > StartingArray[pos+1]) // flip to > if you want smallest to largest
   {
   tempd = StartingArray[pos];
   StartingArray[pos] = StartingArray[pos+1];
   StartingArray[pos+1] = tempd;
   swapped = true;
   }
   pos++;
   }
   }
   Print("Sorting");
 
   for(int j = 0; j<14; j++) {
      for(int k = 0; k <14; k++){
         if(StartingArray[j] == ReferenceArray[k]) RankArray[k] = j;
         Print("Pairing");
         }
      }
  int RankCount = 0;    
  if(ShowRank1) RankCount++;
  if(ShowRank2) RankCount++;
  if(ShowRank3) RankCount++;
  if(ShowRank4) RankCount++;
  if(ShowRank5) RankCount++;
  if(ShowRank6) RankCount++;
  if(ShowRank7) RankCount++;
  if(ShowRank8) RankCount++;
  if(ShowRank9) RankCount++;
  if(ShowRank10) RankCount++;
  if(ShowRank11) RankCount++;
  if(ShowRank12) RankCount++;
  if(ShowRank13) RankCount++;
  if(ShowRank14) RankCount++;
  if(RankCount != 1) Alert("ERROR: Please select one rank to display only");
  Print("Checking Rank Count");
 
  if(ShowRank1 && RankCount == 1) Rank[i] = RankArray[0];
  if(ShowRank2 && RankCount == 1) Rank[i] = RankArray[1];
  if(ShowRank3 && RankCount == 1) Rank[i] = RankArray[2];
  if(ShowRank4 && RankCount == 1) Rank[i] = RankArray[3];
  if(ShowRank5 && RankCount == 1) Rank[i] = RankArray[4];
  if(ShowRank6 && RankCount == 1) Rank[i] = RankArray[5];
  if(ShowRank7 && RankCount == 1) Rank[i] = RankArray[6];
  if(ShowRank8 && RankCount == 1) Rank[i] = RankArray[7];
  if(ShowRank9 && RankCount == 1) Rank[i] = RankArray[8];
  if(ShowRank10 && RankCount == 1) Rank[i] = RankArray[9];
  if(ShowRank11 && RankCount == 1) Rank[i] = RankArray[10];
  if(ShowRank12 && RankCount == 1) Rank[i] = RankArray[11];
  if(ShowRank13 && RankCount == 1) Rank[i] = RankArray[12];
  if(ShowRank14 && RankCount == 1) Rank[i] = RankArray[13];
  Print("Drawing Rank");
 
 
 
   }
 
 
//----
   return(0);
  }
//+------------------------------------------------------------------+
 
 
double BuyProfit(string Symbols, int Shift) {
 
   double ProfitsBuy = (iClose(Symbols, 0, Shift) - iClose(Symbols, 0, BarsBack)) / MarketInfo(Symbols, MODE_POINT);
 
   return(ProfitsBuy);
   }
 
double SellProfit(string Symbols, int Shift) {
 
   double ProfitsSell = (iClose(Symbols, 0, BarsBack) - iClose(Symbols, 0, Shift)) / MarketInfo(Symbols, MODE_POINT);
 
   return(ProfitsSell);
   }

Here's what I'm trying to get the indicator to do:

1. Find the profit for each pair
2. Rank the pairs
3. Assign each ranked pair a value from 1 - 14.
4. Plot the selected pair.

That way, I can just attach 14 of these indicators and effectively have a more orderly version of this (see attached):

Ignored

Quoting Orest

Disliked

RR,
you have infinitive loop there -
replace "while(i>=0)" with "for (i = 0; i<(Bars-counted_bars); i ++)"

Also,
if(RankCount != 1) Alert("ERROR: Please select one rank to display only");

should be

if(RankCount < 1) Alert("ERROR: Please select one rank to display only");

After I've done this I've got some kind of graph on the screen, didn't look any further.

Orest

Ignored

Quoting comdoc

Disliked

Hi Orest,

Thanks for starting this thread. I second Icicle re adding the jump slot number to the right of each pair, eg: EURJPY +2 Maybe the colored pip gain or loss number plus/minus colored arrow next: EUR JPY +2 (8 pips gain).

I (and others) still need to see the smaller timeframes included in this indicator. I tried to modify it, but new to programming in MT4; bungled it. *LOL* Can send anyone salvage my modified 101 file?

The signal algorithm definitely needs to be refined. It lags enough that some of potential profit is lost.

Thanks for responses.

George

Ignored

Quoting Orest

Disliked

Another good idea, comdoc!
I wonder why do you guys need smaller timeframes though?
It's dancing on 1h like crazy...

Ignored

Quoting Orest

Disliked

Robert,
could you point me to the error you mentioned?
Thanks

Ignored

Quoting Orest

Disliked

Folks,
I have very modest and humble request if you would...

We all know that basket trading is all about pure Price Action, nothing else, right? No Fibo lines, no Bollinger bands and other nuclear weapons of mass destruction. Please, don't combine any of lagging indicators like RSI, ATR, CCI, DMI,Gravity, Heikin Ashi, MACD, ect with this strategy. Let's get serious here do you know any proven successful results based on them?

Thanks!

Ignored

Quoting RobertHill

Disliked

I am finding that some of the problems are resulting from the different pairs lists being used.
Some indicators have been written using the IBFX pais list while others are written using the FXDD pairs list.

It might be a good idea to have each indicator and ea specify which boker list is used in the name.

I just looked at the trader101_basket and it crashed IBFX. I looked at the pairs and they were for FXDD.

Here is the version for IBFX. Note that no "m" is needed in the symbol names as it is automatically added if a mini account.

Robert

Ignored