Detecting if last trade hit stop loss | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Stop Loss vs. Hidden Stop Loss 26 replies

my broker didn't execute buy stop, and stop loss hit 6 replies

EA to close trade when 'x' negative profit is hit (stop loss) 0 replies

Detecting definition of a 'pip' 1 reply

Detecting stopped order? 1 reply

Attachments: Detecting if last trade hit stop loss
Exit Attachments

Detecting if last trade hit stop loss

  • #1
  • First Post: Feb 11, 2007 11:47am Feb 11, 2007 11:47am
I would like to know if there is a way to determine if my last trade was long or short and if it hit the stop loss. Advice appreciated.
  • #2
  • Feb 11, 2007 12:10pm Feb 11, 2007 12:10pm
Never mind. Code from another forum:

Inserted Code
[color=#000000][color=#ff8000]#define PLUS 1 
#define MINUS 2 
[/color][color=#0000bb]int TradeHistory[/color][color=#007700](){ 
   [/color][color=#0000bb]int cnt[/color][color=#007700]=[/color][color=#0000bb]HistoryTotal[/color][color=#007700](),[/color][color=#0000bb]tkt[/color][color=#007700];[/color][color=#0000bb]datetime ord[/color][color=#007700]; 
   for([/color][color=#0000bb]int i[/color][color=#007700]=[/color][color=#0000bb]0[/color][color=#007700];[/color][color=#0000bb]i[/color][color=#007700]<[/color][color=#0000bb]cnt[/color][color=#007700];[/color][color=#0000bb]i[/color][color=#007700]++){ 
      if([/color][color=#0000bb]OrderSelect[/color][color=#007700]([/color][color=#0000bb]i[/color][color=#007700],[/color][color=#0000bb]SELECT_BY_POS[/color][color=#007700],[/color][color=#0000bb]MODE_HISTORY[/color][color=#007700])){ 
         if([/color][color=#0000bb]OrderCloseTime[/color][color=#007700]()>[/color][color=#0000bb]ord[/color][color=#007700]){ 
            [/color][color=#0000bb]tkt[/color][color=#007700]=[/color][color=#0000bb]OrderTicket[/color][color=#007700](); 
            [/color][color=#0000bb]ord[/color][color=#007700]=[/color][color=#0000bb]OrderCloseTime[/color][color=#007700](); 
         } 
      } 
   } 
   if([/color][color=#0000bb]OrderSelect[/color][color=#007700]([/color][color=#0000bb]tkt[/color][color=#007700],[/color][color=#0000bb]SELECT_BY_TICKET[/color][color=#007700],[/color][color=#0000bb]MODE_HISTORY[/color][color=#007700])){ 
      if([/color][color=#0000bb]OrderProfit[/color][color=#007700]()>=[/color][color=#0000bb]0[/color][color=#007700])return([/color][color=#0000bb]PLUS[/color][color=#007700]);else return([/color][color=#0000bb]MINUS[/color][color=#007700]); 
   } 
   return(-[/color][color=#0000bb]1[/color][color=#007700]); 
}  [/color][/color]
  • #3
  • Feb 11, 2007 12:30pm Feb 11, 2007 12:30pm
Am I missing something here.....
you don't know if your last trade was long or short and if it hit the SL......hmmmmmm
man I must be thick......
Same Whore .... Different Dress
  • #4
  • Feb 11, 2007 12:43pm Feb 11, 2007 12:43pm
Well, if you're doing an EA and going through an automated system, how WOULD you know if you weren't standing in front of the trading station all day long??? Doesn't that defeat the purpose of using an EA?

The question is valid within the context that you're using automated code, in which case a position may open and close without you even knowing it.

Perhaps you should be more attentive before you poke fun at something that you didn't get on the first pass.

Quoting johnedoe
Am I missing something here.....
you don't know if your last trade was long or short and if it hit the SL......hmmmmmm
man I must be thick......
  • #5
  • Feb 11, 2007 12:46pm Feb 11, 2007 12:46pm
Quoting johnedoe
Am I missing something here.....
you don't know if your last trade was long or short and if it hit the SL......hmmmmmm
man I must be thick......
lol. yes, mrmikal is right. it is for an automated system.
  • #6
  • Feb 11, 2007 1:10pm Feb 11, 2007 1:10pm
Yes, I think Mr Doe was approaching the idea without knowing it is a trading robot we are talking about. Although, this thread is in the MetaTrader Forum

This is a nice and compact piece of code.. thanks for posting it. Coincidentally it is something I have been working on as well and can make use of it... Thanks

PS, where did you find it? I would like to look at more of this stuff.. thanks again.
  • #7
  • Feb 11, 2007 1:30pm Feb 11, 2007 1:30pm
  •  tesla
  • | Joined Oct 2006 | Status: Friendly Neighborhood Programmer | 533 Posts
Just a note:

That code snippet simply identifies whether a trade closed out at a profit or a loss, it doesn't identify if the loss was at the stoploss price. A technicality, but it might be important depending on what you're doing.

If you need to confirm it was the StopLoss price, you can compare OrderStopLoss() to OrderClosePrice().
  • #8
  • Feb 11, 2007 1:50pm Feb 11, 2007 1:50pm
Quoting smjones
Yes, I think Mr Doe was approaching the idea without knowing it is a trading robot we are talking about. Although, this thread is in the MetaTrader Forum

This is a nice and compact piece of code.. thanks for posting it. Coincidentally it is something I have been working on as well and can make use of it... Thanks

PS, where did you find it? I would like to look at more of this stuff.. thanks again.
Exact post:
http://www.forex-tsd.com/metatrader-...ous-trade.html

I searched www.forex-tsd.com for: MODE_HISTORY
  • #9
  • Feb 11, 2007 2:00pm Feb 11, 2007 2:00pm
Quoting tesla
Just a note:

That code snippet simply identifies whether a trade closed out at a profit or a loss, it doesn't identify if the loss was at the stoploss price. A technicality, but it might be important depending on what you're doing.

If you need to confirm it was the StopLoss price, you can compare OrderStopLoss() to OrderClosePrice().
I wish there was an OrderType for StopLoss but these are the only order types:
OP_BUY - buying position,
OP_SELL - selling position,
OP_BUYLIMIT - buy limit pending position,
OP_BUYSTOP - buy stop pending position,
OP_SELLLIMIT - sell limit pending position,
OP_SELLSTOP - sell stop pending position.
But it's funny because when I look in strategy tester I can see a order type of "s/l" (See Screen Shot).
The thing is the my actual loss may not be exactly the same as my stop loss because of slippage even though it was triggered by my stop loss. It may be more or less. It would be a nice feature but it doesn't look like it's available at this time.
Attached Image
  • #10
  • Feb 11, 2007 2:09pm Feb 11, 2007 2:09pm
I think I might have just found what I was looking for. In case it will be useful to others I'm posting here.

Post from : http://forum.mql4.com/5049
Inserted Code
bool IsLastTrade(string closedBy)
{
     int totalOrders = HistoryTotal();
     if(totalOrders>=1)
     {
          if(OrderSelect(totalOrders-1,SELECT_BY_POS,MODE_HISTORY))
          {
               string orderComment = OrderComment()                              
               return (StringFind(orderComment,closedBy, 0)!=-1);
          }
     }     
     return(0);
}
Quoting original poster
Hi, mike. Try it. PS.: In "closedBy" parameter you put "[tp]" to know if last trade closed by Take Profit or put "[sl]" to know if closed by Stop Loss.

Bye,

Alessandro Paulino
  • #11
  • Last Post: Edited 11:11pm Mar 11, 2007 10:26pm | Edited 11:11pm
Quoting dumbmoney
In "closedBy" parameter you put "[tp]" to know if last trade closed by Take Profit or put "[sl]" to know if closed by Stop Loss.
This worked for my demo account and for MT tester. But in my live account it is registered as "[complete]". Anyone else have any experience with this.
1 trader viewing now