Determine Friday close in an EA? | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

How do you determine 84 replies

Open Monday-Close Friday - strategy test 28 replies

How do you determine High, Low, Close 2 replies

How to determine if a trade has been closed. 2 replies

How do I determine what a pip is worth? 1 reply

Determine Friday close in an EA?

  • #1
  • First Post: Edited Jul 30, 2008 12:39pm Jul 23, 2008 3:32pm | Edited Jul 30, 2008 12:39pm
Does anyone know of a way to determine, in an EA, when the market will close on Friday. I'm writing an EA and would like to program it to close any open/pending trades before the market closes on Friday. Currently it closes the trades first thing on Sunday but by then prices may have shifted and sometimes by a large amount either for or against you. The problem is that everyone uses different brokers which all have different times.
  • #2
  • Jul 23, 2008 5:39pm Jul 23, 2008 5:39pm
Well...I don't think there's a feature in metatrader which tells you broker close time.

Best thing I can suggest is:

if(DayOfWeek() == 5) Close all trades.
  • #3
  • Jul 23, 2008 6:20pm Jul 23, 2008 6:20pm
Quoting Ronald Raygun
Well...I don't think there's a feature in metatrader which tells you broker close time.

Best thing I can suggest is:

if(DayOfWeek() == 5) Close all trades.

Thanks for the reply. Unfortunately I thought that would be the answer. Problem is that I would like it to run for as long as possible on Friday before close but all the brokers are different time zones. I guess I could figure out what the earliest stop is and just take it that far. I just don't want to stop the trades on Sunday market open because of the possible shift over the weekend. This is for my WeeklyOpen EA by the way. Programming EAs can truely be frustrating some times.
  • #4
  • Jul 23, 2008 6:31pm Jul 23, 2008 6:31pm
extern int CloseHour = 17; // enter brokers closing hour
extern int CloseMinute = 55; // enter brokers closing minute less some time to close trade

start()
{
...


if (DayOfWeek() ==5 && Hour() == CloseHour && Minute == CloseMinute)
Close all trades();// a void function to close all pending and open trades

return(0);

}
  • #5
  • Jul 23, 2008 7:26pm Jul 23, 2008 7:26pm
Quoting stevejames
extern int CloseHour = 17; // enter brokers closing hour
extern int CloseMinute = 55; // enter brokers closing minute less some time to close trade

start()
{
...


if (DayOfWeek() ==5 && Hour() == CloseHour && Minute == CloseMinute)
Close all trades();// a void function to close all pending and open trades

return(0);

}

I appreciate your input but I already knew I could do something like that . I was hoping to avoid questions from users asking me how to set things for their broker. My question was just hoping there was a better way that I didn't know about. Anytime you can do something for them then you're better off, well maybe most of the time.
  • #6
  • Jul 23, 2008 7:33pm Jul 23, 2008 7:33pm
Quoting mtaboneweb
I appreciate your input but I already knew I could do something like that . I was hoping to avoid questions from users asking me how to set things for their broker. My question was just hoping there was a better way that I didn't know about. Anytime you can do something for them then you're better off, well maybe most of the time.
Well, you could build a list of broker's closing times and just have them enter the broker name and then your EA looks up the closing time from a list, that matches their broker timezone and closing time.
  • #7
  • Jul 23, 2008 10:21pm Jul 23, 2008 10:21pm
Just do this:
PHP Code
//-Parameters-
extern int HourHour=-1;
extern bool Got;
//-Code-
if(DayOfWeek()==5 && Hour()>HourHour)HourHour=Hour();
if(DayOfWeek()==0 && HourHour>0)Got=true;
 
if(Got && DayOfWeek()==5 && Hour()==HourHour && Minute()>=55)CloseAll();
//---
Something like that.
Hope I helped.
Dan.
Request custom Expert Advisor or Indicator: dostapyuk "at" gmail . com
  • #8
  • Jul 24, 2008 12:40am Jul 24, 2008 12:40am
Quoting Oksana17
Just do this:
PHP Code
//-Parameters-
extern int HourHour=-1;
extern bool Got;
//-Code-
if(DayOfWeek()==5 && Hour()>HourHour)HourHour=Hour();
if(DayOfWeek()==0 && HourHour>0)Got=true;
 
if(Got && DayOfWeek()==5 && Hour()==HourHour && Minute()>=55)CloseAll();
//---
Something like that.
Hope I helped.
Dan.

Wouldn't this just close trades when it rolled over to Sunday?
  • #9
  • Jul 24, 2008 12:59am Jul 24, 2008 12:59am
Quoting mtaboneweb
Wouldn't this just close trades when it rolled over to Sunday?
No, it closes on Friday. Read the code more carefully.
Dan.
Request custom Expert Advisor or Indicator: dostapyuk "at" gmail . com
  • #10
  • Jul 24, 2008 10:23am Jul 24, 2008 10:23am
Quoting Oksana17
if(DayOfWeek()==0 && HourHour>0)Got=true;
Here's where I'm not following you. Wouldn't the line above only set "Got=true" on Sunday? Because "DayOfWeek()==0" is Sunday and would not be true if you were currently on the Friday bar.
  • #11
  • Jul 24, 2008 10:46am Jul 24, 2008 10:46am
Let me clarify for a moment and maybe you can tell me where I'm looking at this wrong.

This line will only set "Got=true" if "DayOfWeek()==0" (Sunday)

if(DayOfWeek()==0 && HourHour>0)Got=true;

"Got" and "DayOfWeek==5" can't be true because it was "DayOfWeek()==0" (Sunday) that made "Got" true in the first place so when is check if "Got" is true (which it will be eventually), then DayOfWeek would also equal 0 now.

if(Got && DayOfWeek()==5 && Hour()==HourHour && Minute()>=55)CloseAll();

Am I reading this wrong? Maybe it would work for the following Friday having figured out when Friday ended from last week but anytime the user resets anything then it would have to figure it out again which would miss another Friday.
  • #12
  • Jul 24, 2008 12:18pm Jul 24, 2008 12:18pm
Quoting mtaboneweb
Here's where I'm not following you. Wouldn't the line above only set "Got=true" on Sunday? Because "DayOfWeek()==0" is Sunday and would not be true if you were currently on the Friday bar.
First you need to test ALL of the hours on friday before making a trade, to know which is the last hour on friday. Then, when it is sunday, and it tested which hour is last, it makes got=true, and then if got=true, and day is 5, and hour is HourHour(the tested hour), then it exits.
Warm regards,
Dan.
Request custom Expert Advisor or Indicator: dostapyuk "at" gmail . com
  • #13
  • Jul 24, 2008 12:20pm Jul 24, 2008 12:20pm
Quoting mtaboneweb
Let me clarify for a moment and maybe you can tell me where I'm looking at this wrong.


This line will only set "Got=true" if "DayOfWeek()==0" (Sunday)

if(DayOfWeek()==0 && HourHour>0)Got=true;


"Got" and "DayOfWeek==5" can't be true because it was "DayOfWeek()==0" (Sunday) that made "Got" true in the first place so when is check if "Got" is true (which it will be eventually), then DayOfWeek would also equal 0 now.

if(Got && DayOfWeek()==5 && Hour()==HourHour && Minute()>=55)CloseAll();

Am I reading this wrong? Maybe it would work for the following Friday having figured out when Friday ended from last week but anytime the user resets anything then it would have to figure it out again which would miss another Friday.
Your'e not paying attention to HourHour.
if(DayOfWeek()==0 && HourHour>0)Got=true;

I've coded this to be complicated, but not wordy.
I like coding something that takes up the least space, for less confusion.
That's my coding syle.
Dan.
Request custom Expert Advisor or Indicator: dostapyuk "at" gmail . com
  • #14
  • Jul 24, 2008 12:22pm Jul 24, 2008 12:22pm
The first friday it tests which hour is last on friday, and it trades the next friday and so on.
Just use Global Variables to remember which hour closes on friday.
Warm regards,
Dan.
Request custom Expert Advisor or Indicator: dostapyuk "at" gmail . com
  • #15
  • Jul 25, 2008 1:11am Jul 25, 2008 1:11am
Use Local time instead of broker time?
  • #16
  • Last Post: May 6, 2024 12:31pm May 6, 2024 12:31pm
I have expert strategy say close all position friday at 9 pm ..... Then i removed code friday close ... After that position not close at friday but i have big problem .. this problem .. all position close when market open at monday after one hour market open.. i don not know what the reasons and how i can solve this proplem ... Please any one can help me
0 traders viewing now