Fixing Code 1 line at a time

Have found a glitch in the Close command for an EA I'm developing. If this were an old math class I'ld outline it up something like this:

-------------------------------------

Given Items:
Variable A
Variable B

Opening Formula
When A > B then open trade LONG (TradeDirection=1 ?)
When B > A then open trade SHORT (TradeDirection=-1 ?)

Closing Formula
When Trade = Long / Close if B > A
When Trade = Short / Close if A > B

-------------------------------------

Note that the Close is not the same as simply "close if..." . Since the EA is designed to open in either direction, my current attempt has it wrestling with itself when A&B change directions / Not real healthy ...

Any thoughts for a couple of lines of code would be appreciated ...

Thank you ahead of time ,

Pip Parade

Sounds like you want code for a crossover open/close type thing?? How about this?

if (variable1 > variable2) //Sell Signal
ticket=OrderSend(Symbol(),OP_SELL,Lots,Bid,3,Bid+StopLoss*Point,Bid-TakeProfit*Point,"SellSignal",MagicNumber,0,Red);

// Should the Short Position be closed?

if(OrderType()==OP_SELL) // sell position is opened
{
if(variable1 < variable2)
OrderClose(OrderTicket(),OrderLots(),Bid,3,Violet); // close position
}



Obviously this is not tested, but i hope this gives you a hand.

Rephrase your logic...

if A > B
Close Short (if any)
Open Long
if B > A
Close Long (if any)
Open short

Tried to code a version of phy's logic. Didn't work ... I'm sure it is in my coding. Seemed simple & I do want to learn this code but it shows again that I've still got quite a way to go.

Will try to a)recode phy's approach and/or b)apply logiktraders code over the weekend. Thank you both for contributing.

Wouldn't break my ego if either of you (or someone else) would want to take a crack at coding phy's approach (logiktrader already coded his ... ). Until then, get lots of sleep as we'll be pip hunting all next week.

Thanks ya'all

This may give you some ideas...





int start(){

if(A > B){

CloseShorts();

OpenLong();

}

if(B > A){

CloseLongs();

OpenShort();

}

return(0);

}
//
//
// functions:
//
//



void CloseShorts(){

for(int i = ordersTotal()-1; i >= 0; i--){

OrderSelect(i, SELECT_BY_POS, MODE_TRADES);

if(OrderType() == OP_SELL){

OrderClose(OrderTicket(), OrderLots(), Ask, slippage, color);

}

}

}



void CloseLongs(){

for(int i = ordersTotal()-1; i >= 0; i--){

OrderSelect(i, SELECT_BY_POS, MODE_TRADES);

if(OrderType() == OP_BUY){

OrderClose(OrderTicket(), OrderLots(), Bid, slippage, color);

}

}

}



void OpenLong(){

OrderSend(Symbol(), Lots, Ask, slipage, stoploss, takeprofit, comment, magic, expiration, color);

}



void OpenShort(){

OrderSend(Symbol(), Lots, Bid, slipage, stoploss, takeprofit, comment, magic, expiration, color);

}

Thank you phy, very much appreciated.

I also took a different approach over the weekend. Reworked the EA so that the Long entry and the Short entry were identified with different magic numbers. That way (I hope) I am able to simplify the process and set "narrow focus" closing commands "A" for Long and "B" for Short.

Will report back with my success (or lack thereof).

Thanks again...

Phy, (and others)

Well, the report so far is that I'm not out of the woods yet.

To get some clarity I have broken the code into 2 parts, Long and Short. Will attach them manually until they're solid then try to combine them.

Currently, I attach them individually and they will enter a trade fine. Unfortunately, they will NOT Close a position. I've posted this part of the challenge with a chunk of the code I'm using in a new thread, here:

http://www.forexfactory.com/showthread.php?t=73500

If you have a minute to review it and comment I would appreciate your help.

Thank you...

PP

// check condition to close trade
int TradeClose=0;

if(magicnolong==2222 && Bid<SAR0)TradeClose=1;

// check if open trade should be closed
if (OrderFind(magicnolong))
if(ClosingConditions==1 && glbOrderType==OP_BUY && TradeClose==1)
OrderClose(magicnolong, Lots, Bid, 3, CLR_NONE);

return(0);
}


Ok, let's debug it:
Does magicnolong equal 2222 ? Don't know.
Is Bid less than SAR0 ? Don't know.
Does your custom call OrderFind() work? Don't know.
Does ClosingConditions equal 1? Don't know.
Does glbOrderType equal OP_BUY? Don't know.
Does TradeClose equal 1? Can't tell.

Ah! Here's a problem. OrderClose takes a ticket number, not magic number.

Thank you phy, nice catch.

Please correct me if I'm wrong but I believe the ticket # is random ... So, since the bool OrderClose(xoxoxoxo) tells me that ticket is an int would the replacement be the following?

OrderClose(ticketnumber(), Lots, Bid, 3, CLR_NONE);

PP