MT5 Basics

Quoting Mucky

Disliked

{quote} .. you may use "FileWriteString" - see example below (taken from TradeReport Indi) - Mucky void writeTradeInfo( TRADE_INFO &myTradeInfo[] ) { static const string logFile = StringFormat("TradeReport_%d.csv", AccountNumber() ); static const string excelDateMask = "Y-M-D H:I:S"; //yyyy-MM-dd HH:mm:ss static const string headerText = "Ticket,Symbol,Order Type,Lots,Open Price,Close Price,Stop Loss, Take Profit,PIP Factor,Open Date,Close Date,Profit,Swap,Commission,Expiration Date,Comment,MagicNumber"; ResetLastError(); // Delete previous logFile...

Ignored

Quoting Mucky

Disliked

{quote} .. you mayle); } }

Ignored

Quoting Macd-rsi

Disliked

avgPrice? is this a solution: get positionTicket, then look through history using the same orderTicket{image} - phu asked Mucky about this?

Ignored

Quoting phuclockbs

Disliked

{quote} yes, this is what i learned from his post Trade Tab: POSITON_IDENTIFIER History Tab: DEAL_POSITION_ID {image} {image}

Ignored

Quoting Macd-rsi

Disliked

{quote} we still have a problem . . how to link open position to the deal im history? im immediate way without using for loop for example open position with ticket 68994434 , , what is the fatest way to fetch its COMMISSSION

Ignored

void prepareHistoryProfitLoss()
{
   HistoryProfitLoss             =  0;
   HistoryProfitLossDate         =  TimeCurrent();
   HistoryProfitLossTrades       =  0;
   HistoryDailyProfitLoss        =  0;
   HistoryDailyProfitLossTrades  =  0;
   DailyProfitTargetReached      =  false;
  
  
   long  pos_id_array[];         // array for storing position IDs
   int   Numtotal;
  
   double HistoryProfitLossSum          =  0;
   double PreHistoryProfitLossSum       =  0;
   long   PrevPosition_id               =  0;
   int    PosNr                          = 1;
  
   ulong Ticket;
//--- request trade history
   if (!HistorySelect(0,TimeCurrent())) return;    
  
   uint total=HistoryOrdersTotal();
  
   for (uint cc = 0; cc < total; cc++)
   {
      ResetLastError();
      
      if(!m_history.SelectByIndex(cc)) continue;
    
      Ticket = m_history.Ticket();
    
      if(    Ticket  
         &&  m_history.Symbol()     == _Symbol
         &&( m_history.Magic()      == MagicNummer    || !UseMagicNummer                           )
         &&( m_history.OrderType()  == ORDER_TYPE_BUY || m_history.OrderType()  == ORDER_TYPE_SELL )
         &&( m_history.State()      == ORDER_STATE_FILLED )
        )    
      {
         if (findInArray(pos_id_array, m_history.PositionId()) >= 0 ) continue;
        
         int size=ArraySize(pos_id_array);
        
         if(ArrayResize(pos_id_array, size+1) == size+1)
            pos_id_array[size]=m_history.PositionId();
            
//       Alert("Ticket: ", Ticket," positionTicket: ",m_history.PositionId());
      }
   }            
  
   HistoryProfitLoss             =  0;
  
//--- by list of position IDs in the array
   Numtotal=ArraySize(pos_id_array);
  
// Alert("---- Numtotal: ",Numtotal);
  
   for(int i=0; i<Numtotal; i++)
   {
      long position_id = pos_id_array[i];
//    Alert("List of orders and deals for position with ID: ", position_id);
      HistoryProfitLossSum = 0;
      HistoryProfitLossSum = ProfitFromHistory(position_id); //, HistoryProfitLossDate, HistoryProfitLossTrades, HistoryDailyProfitLoss, HistoryDailyProfitLossTrades );
//    Alert("Sum Pos_ID: ", HistoryProfitLossSum);
      HistoryProfitLoss += HistoryProfitLossSum;
//    Alert("POS: ", PosNr++," PreHistoryProfitLossSum: ",PreHistoryProfitLossSum," +HistoryProfitLossSum: ",HistoryProfitLossSum," = Sum: ", HistoryProfitLoss);
      PreHistoryProfitLossSum = HistoryProfitLoss;
   }          
  
   if ( UseDailyProfitTarget && DailyProfitTarget > 0 )
   {
      DailyProfitTargetReached = HistoryDailyProfitLoss >= DailyProfitTarget ? true : false;
   }
}

//+------------------------------------------------------------------+
//| Select history of orders and deals by position ID                |
//+------------------------------------------------------------------+
double ProfitFromHistory(const long position_id)
{
   double ProfitLoss             =  0;
  
//--- request the history of deals and orders having the specified position ID
   if(!HistorySelectByPosition(position_id))
   {
      return(false);
   }
  
//--- list of position deals in the journal
   ProfitLoss = 0;
  
   int deals_total = HistoryDealsTotal();
  
   for(int i=0; i<deals_total; i++)
   {
      ulong dealTicket = HistoryDealGetTicket(i);
      
      if(dealTicket==0) continue;
      
      ENUM_DEAL_ENTRY deal_entry = (ENUM_DEAL_ENTRY)HistoryDealGetInteger(dealTicket, DEAL_ENTRY);
      ENUM_DEAL_TYPE  deal_type  = (ENUM_DEAL_TYPE) HistoryDealGetInteger(dealTicket, DEAL_TYPE);
      
      if(deal_type  != DEAL_TYPE_BUY && deal_type  != DEAL_TYPE_SELL) continue;
      if(deal_entry != DEAL_ENTRY_IN && deal_entry != DEAL_ENTRY_OUT) continue;      
//--- get the values of the properties affecting profit from the trade
      double profit    = HistoryDealGetDouble(dealTicket,DEAL_PROFIT);
      double comission = HistoryDealGetDouble(dealTicket,DEAL_COMMISSION);
      double swap      = HistoryDealGetDouble(dealTicket,DEAL_SWAP);
      double fee       = HistoryDealGetDouble(dealTicket,DEAL_FEE);
//    Alert("DEAL_ENTRY_OUT Ticket: ", dealTicket," position_id: ",position_id, " Profit: ",profit, " Commission: ", comission);
      
      ProfitLoss += profit  + comission + swap + fee;
      
      if(deal_entry == DEAL_ENTRY_OUT)
      {  
         CloseTime = (datetime)HistoryDealGetInteger(dealTicket, DEAL_TIME);
        
         if (HistoryProfitLossDate == 0 || HistoryProfitLossDate > CloseTime)
            HistoryProfitLossDate = CloseTime;
          
         HistoryProfitLossTrades++;
        
      }
            
      if ( TimeToString(TimeCurrent(), TIME_DATE) == TimeToString(CloseTime, TIME_DATE))
      {
         HistoryDailyProfitLoss += profit  + comission + swap + fee;
        
         if(deal_entry == DEAL_ENTRY_OUT)
            HistoryDailyProfitLossTrades++;
      }                        
   }
  
// Alert("Sum: ", ProfitLoss);
  
   return(ProfitLoss);
  }  
//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+
int findInArray(long &array[], long elem)
{
   int index = -1;
   for(int i=0; i < ArraySize(array); i++)
   {
      if ( array[i] == elem )
      {
         index = i;
         break;
      }
   }
   return(index);
}

Quoting Macd-rsi

Disliked

correction:{image} - remain DAX case .. . .to be added later . .

Ignored

Quoting Macd-rsi

Disliked

correction:{image} - remain DAX case .. . .to be added later . .

Ignored

Quoting phuclockbs

Disliked

{quote} {image} why don't we code like this? {image}

Ignored