Attachments: Indicator Not Updating/Repainting Automatically - Help

Indicator Not Updating/Repainting Automatically - Help

#1
First Post: Apr 29, 2025 3:13am Apr 29, 2025 3:13am

chimoong
| Joined May 2016 | Status: Trader | 353 Posts

Hi coders, I'm learning programming now to develop a simple Stochastic indicator. I don't know what codes are lack of resulting the indicator wasn't updated automatically. FYI, I'm using "indicator_separate_window" for my testing.

Upon a New Bar is launched, there are 2 issues :-

1) Stochastic "< 80" or "> 20", the DotLine and the line at sub-window won't be removed automatically

2) My settings are for(int i=0; i<=20; i++), i.e. up to Max Shift of 20, but from Shift 21 onwards, the DotLine and the line at sub-window won't be removed automatically

Kindly help to modify my indicator so that it can update the DotLines and the line at sub-window automatically without any human intervention. Thanks.

Attached Image (click to enlarge)

Click to Enlarge

Name: Test.png
Size: 17 KB

Attached File(s)

Test Indi.ex4 13 KB | 141 downloads

Test Indi.mq4 4 KB | 145 downloads

#2
Apr 29, 2025 5:03am Apr 29, 2025 5:03am

MwlRCT
| Commercial User | Joined Aug 2019 | 2,251 Posts

Not tested:
---

Inserted Code

//+------------------------------------------------------------------+
//|                                                    Test Indi.mq4 |
//|                                                    [email protected] |
//+------------------------------------------------------------------+
#property copyright "Copyright 2025"
#property link      "https://www.abc.com"
#property version   "1.00"
#property strict
#property indicator_separate_window
#property indicator_buffers 1
#property indicator_level1 20.0
#property indicator_level2 50.0
#property indicator_level3 80.0
#property indicator_levelcolor clrSilver
#property indicator_levelstyle STYLE_DOT
//+------------------------------------------------------------------+
// User Input Variables
int      strSf = 0;
int      endSf = 20;  // Note: The fixed endSf is retained but dynamic processing is applied.
ENUM_LINE_STYLE LineStyle = 0;
int      LineWid   = 2;
color    LineClr   = clrLime;
string   LineLabel = "Sto";
ENUM_LINE_STYLE VLStyle = 3;
bool     VLLabelDel = true;
string   VLLabel   = "VL_";
int      VLGrWid   = 1;
color    VLGrClr   = clrLime;
int      VLRdWid   = 1;
color    VLRdClr   = clrPink;
//+------------------------------------------------------------------+
string   sym = Symbol();
int      tTF = Period();
//+------------------------------------------------------------------+
// LINES BUFFERS
double buf1[];
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int OnInit()
  {
//+------------------------------------------------------------------+
   IndicatorDigits(3);
   SetIndexStyle(0, DRAW_LINE, LineStyle, LineWid, LineClr);
   SetIndexBuffer(0, buf1);
   SetIndexLabel(0, LineLabel + " ");
   return(INIT_SUCCEEDED);
  }
//+------------------------------------------------------------------+
//| Deinitialization function                                        |
//+------------------------------------------------------------------+
void OnDeinit(const int reason)
  {
   Comment("");
   for (int i = ObjectsTotal() - 1; i >= 0; i--)
     {
      string objName = ObjectName(i);
      if ((VLLabelDel && StringFind(objName, VLLabel) != -1) || StringFind(objName, LineLabel) != -1)
        {
         Print(IntegerToString(i) + ") " + objName);
         ObjectDelete(objName);
        }
     }
  }
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int OnCalculate(const int rates_total,
                const int prev_calculated,
                const datetime &time[],
                const double &open[],
                const double &high[],
                const double &low[],
                const double &close[],
                const long &tick_volume[],
                const long &volume[],
                const int &spread[])
  {
   // New Bar Detection: Execute cleanup once per new bar.
   static datetime lastBarTime = 0;
   if (lastBarTime != time[0])
     {
      lastBarTime = time[0];
      int totalObjects = ObjectsTotal();
      for (int j = totalObjects - 1; j >= 0; j--)
        {
         string objName = ObjectName(j);
         if ((VLLabelDel && StringFind(objName, VLLabel) != -1) || StringFind(objName, LineLabel) != -1)
           {
            if (!ObjectDelete(objName))
               Print("Error deleting object ", objName, " Error: ", GetLastError());
           }
        }
     }
   // Dynamic loop limit based on rates_total.
   int dynamicEnd = rates_total - 1;
   ArrayResize(buf1, dynamicEnd + 1);
   // Update the indicator buffer using stochastic values.
   for (int i = strSf; i <= dynamicEnd; i++)
     {
      buf1[i] = iStochastic(sym, tTF, 5, 3, 3, 0, 0, 0, i);
     }
   // Draw Vertical Lines on the Main Chart.
   for (int i = strSf; i <= dynamicEnd; i++)
     {
      double cSto0 = iStochastic(sym, tTF, 5, 3, 3, 0, 0, 0, i);
      if (cSto0 <= 20)
        {
         drawVL(i, VLLabel + "O/Sold(Up)", VLGrClr, VLGrWid, true);
        }
      else if (ObjectFind(0, VLLabel + "O/Sold(Up)" + IntegerToString(Time[i])) != -1)
        {
         ObjectDelete(VLLabel + "O/Sold(Up)" + IntegerToString(Time[i]));
        }
      if (cSto0 >= 80)
        {
         drawVL(i, VLLabel + "O/Bogt(Dw)", VLRdClr, VLRdWid, true);
        }
      else if (ObjectFind(0, VLLabel + "O/Bogt(Dw)" + IntegerToString(Time[i])) != -1)
        {
         ObjectDelete(VLLabel + "O/Bogt(Dw)" + IntegerToString(Time[i]));
        }
     }
   //+-------------------------------------------+
   return(rates_total);
  }
//+------------------------------------------------------------------+
//| Draw Vertical Lines on Selected Bar Chart                        |
//+------------------------------------------------------------------+
void drawVL(int i, string text, color colour, int width, bool draw)
  {
   string objName = text + IntegerToString(Time[i]);
   // Update existing object if it exists.
   if (ObjectFind(0, objName) != -1)
     {
      ObjectSet(objName, OBJPROP_COLOR, colour);
      ObjectSet(objName, OBJPROP_WIDTH, width);
      ObjectSet(objName, OBJPROP_STYLE, VLStyle);
      ObjectSet(objName, OBJPROP_BACK, true);
     }
   else if (draw)
     {
      if (!ObjectCreate(objName, OBJ_VLINE, 0, Time[i], 0))
         Print("Error creating object: ", objName, " Error: ", GetLastError());
      else
        {
         ObjectSet(objName, OBJPROP_STYLE, VLStyle);
         ObjectSet(objName, OBJPROP_BACK, true);
         ObjectSet(objName, OBJPROP_COLOR, colour);
         ObjectSet(objName, OBJPROP_WIDTH, width);
        }
     }
  }
//+------------------------------------------------------------------+

#3
Apr 29, 2025 11:52am Apr 29, 2025 11:52am

chimoong
| Joined May 2016 | Status: Trader | 353 Posts

Quoting MwlRCT

Disliked

Not tested:

Ignored

Hi MwlRCT, highly appreciated for your codes.

I just tested, it doesn't work to clean-up / hosekeep the lapsed lines. Kindly have a look at below pic for your better understanding.

Please help to modify your codes so that the indicator can do housekeeping automatically without human intervention. Thanks

Attached Image (click to enlarge)

Click to Enlarge

Name: aaa.png
Size: 15 KB

#4
Apr 30, 2025 3:05am Apr 30, 2025 3:05am

MwlRCT
| Commercial User | Joined Aug 2019 | 2,251 Posts

Quoting chimoong

Disliked

{quote} Please help to modify your codes so that the indicator can do housekeeping automatically without human intervention. Thanks {image}

Ignored

---

Inserted Code

 //+------------------------------------------------------------------+
//|                                                    Test Indi.mq4 |
//|                                                    [email protected] |
//+------------------------------------------------------------------+
#property copyright "Copyright 2025"
#property link      "https://www.abc.com"
#property version   "1.00"
#property strict
#property indicator_separate_window
#property indicator_buffers 1
#property indicator_level1 20.0
#property indicator_level2 50.0
#property indicator_level3 80.0
#property indicator_levelcolor clrSilver
#property indicator_levelstyle STYLE_DOT
 
//+------------------------------------------------------------------+
// User Input Variables
int      strSf = 0;
int      endSf = 20;  // Note: The fixed endSf is retained but dynamic processing is applied.
ENUM_LINE_STYLE LineStyle = 0;
int      LineWid   = 2;
color    LineClr   = clrLime;
string   LineLabel = "Sto";
ENUM_LINE_STYLE VLStyle = 3;
bool     VLLabelDel = true;
string   VLLabel   = "VL_";
int      VLGrWid   = 1;
color    VLGrClr   = clrLime;
int      VLRdWid   = 1;
color    VLRdClr   = clrPink;
//+------------------------------------------------------------------+
string   sym = Symbol();
int      tTF = Period();
//+------------------------------------------------------------------+
// LINES BUFFERS
double buf1[];
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int OnInit()
  {
//+------------------------------------------------------------------+
   IndicatorDigits(3);
   SetIndexStyle(0, DRAW_LINE, LineStyle, LineWid, LineClr);
   SetIndexBuffer(0, buf1);
   SetIndexLabel(0, LineLabel + " ");
   return(INIT_SUCCEEDED);
  }
//+------------------------------------------------------------------+
//| Deinitialization function                                        |
//+------------------------------------------------------------------+
void OnDeinit(const int reason)
  {
   Comment("");
   for (int i = ObjectsTotal() - 1; i >= 0; i--)
     {
      string objName = ObjectName(i);
      if (StringFind(objName, VLLabel) != -1 || StringFind(objName, LineLabel) != -1)
        {
         if (!ObjectDelete(objName))
            Print("Error deleting object ", objName, " Error: ", GetLastError());
        }
     }
  }
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int OnCalculate(const int rates_total,
                const int prev_calculated,
                const datetime &time[],
                const double &open[],
                const double &high[],
                const double &low[],
                const double &close[],
                const long &tick_volume[],
                const long &volume[],
                const int &spread[])
  {
   if (rates_total <= 0)
      return(0);
   // New Bar Detection: Execute cleanup once per new bar.
   static datetime lastBarTime = 0;
   if (lastBarTime != time[0])
     {
      lastBarTime = time[0];
      string prefix1 = VLLabel + "O/Sold(Up)";
      string prefix2 = VLLabel + "O/Bogt(Dw)";
      int totalObjects = ObjectsTotal();
      for (int j = totalObjects - 1; j >= 0; j--)
        {
         string objName = ObjectName(j);
         if (StringFind(objName, prefix1) == 0)
           {
            string timeStr = StringSubstr(objName, StringLen(prefix1));
            Print("Debug: objName=", objName, ", timeStr=", timeStr);
            long timeInt = StringToInteger(timeStr);
            datetime objTime = (datetime)timeInt;
            Print("Debug: objTime=", objTime);
            int barShift = iBarShift(sym, tTF, objTime);
            Print("Debug: barShift=", barShift);
            if (barShift >= 0)
              {
               double cSto0 = iStochastic(sym, tTF, 5, 3, 3, 0, 0, 0, barShift);
               Print("Debug: cSto0=", cSto0);
               if (cSto0 > 20)
                 {
                  Print("Debug: Deleting ", objName, " (cSto0 > 20)");
                  if (!ObjectDelete(objName))
                     Print("Error deleting object ", objName, " Error: ", GetLastError());
                 }
              }
            else
              {
               Print("Debug: Deleting ", objName, " (barShift < 0)");
               if (!ObjectDelete(objName))
                  Print("Error deleting object ", objName, " Error: ", GetLastError());
              }
           }
         else if (StringFind(objName, prefix2) == 0)
           {
            string timeStr = StringSubstr(objName, StringLen(prefix2));
            Print("Debug: objName=", objName, ", timeStr=", timeStr);
            long timeInt = StringToInteger(timeStr);
            datetime objTime = (datetime)timeInt;
            Print("Debug: objTime=", objTime);
            int barShift = iBarShift(sym, tTF, objTime);
            Print("Debug: barShift=", barShift);
            if (barShift >= 0)
              {
               double cSto0 = iStochastic(sym, tTF, 5, 3, 3, 0, 0, 0, barShift);
               Print("Debug: cSto0=", cSto0);
               if (cSto0 < 80)
                 {
                  Print("Debug: Deleting ", objName, " (cSto0 < 80)");
                  if (!ObjectDelete(objName))
                     Print("Error deleting object ", objName, " Error: ", GetLastError());
                 }
              }
            else
              {
               Print("Debug: Deleting ", objName, " (barShift < 0)");
               if (!ObjectDelete(objName))
                  Print("Error deleting object ", objName, " Error: ", GetLastError());
              }
           }
        }
     }
   // Dynamic loop limit based on rates_total.
   int dynamicEnd = rates_total - 1;
   ArrayResize(buf1, dynamicEnd + 1);
   // Update the indicator buffer using stochastic values.
   for (int i = strSf; i <= dynamicEnd; i++)
     {
      buf1[i] = iStochastic(sym, tTF, 5, 3, 3, 0, 0, 0, i);
      if (i % 100 == 0) // Log every 100 bars for brevity
         Print("Bar ", i, " Stochastic: ", buf1[i]);
     }
   // Draw Vertical Lines on the Main Chart.
   for (int i = strSf; i <= dynamicEnd; i++)
     {
      double cSto0 = iStochastic(sym, tTF, 5, 3, 3, 0, 0, 0, i);
      if (cSto0 <= 20)
        {
         drawVL(i, VLLabel + "O/Sold(Up)", VLGrClr, VLGrWid, true);
        }
      else
        {
         ObjectDelete(VLLabel + "O/Sold(Up)" + IntegerToString(Time[i]));
        }
      if (cSto0 >= 80)
        {
         drawVL(i, VLLabel + "O/Bogt(Dw)", VLRdClr, VLRdWid, true);
        }
      else if (ObjectFind(0, VLLabel + "O/Bogt(Dw)" + IntegerToString(Time[i])) != -1)
        {
         ObjectDelete(VLLabel + "O/Bogt(Dw)" + IntegerToString(Time[i]));
        }
     }
   //+-------------------------------------------+
   return(rates_total);
  }
//+------------------------------------------------------------------+
//| Draw Vertical Lines on Selected Bar Chart                        |
//+------------------------------------------------------------------+
void drawVL(int i, string text, color colour, int width, bool draw)
  {
   string objName = text + IntegerToString(Time[i]);
   // Update existing object if it exists.
   if (ObjectFind(0, objName) != -1)
     {
      ObjectSet(objName, OBJPROP_COLOR, colour);
      ObjectSet(objName, OBJPROP_WIDTH, width);
      ObjectSet(objName, OBJPROP_STYLE, VLStyle);
      ObjectSet(objName, OBJPROP_BACK, true);
     }
   else if (draw)
     {
      if (!ObjectCreate(objName, OBJ_VLINE, 0, Time[i], 0))
         Print("Error creating object: ", objName, " Error: ", GetLastError());
      else
        {
         ObjectSet(objName, OBJPROP_STYLE, VLStyle);
         ObjectSet(objName, OBJPROP_BACK, true);
         ObjectSet(objName, OBJPROP_COLOR, colour);
         ObjectSet(objName, OBJPROP_WIDTH, width);
        }
     }
   Print("Object Created/Updated: ", objName, " Total Objects: ", ObjectsTotal());
  }
//+------------------------------------------------------------------+

#5
Last Post: Edited 11:49am May 1, 2025 5:48am | Edited 11:49am

chimoong
| Joined May 2016 | Status: Trader | 353 Posts

Quoting MwlRCT

Disliked

{quote}//| Test Indi.mq4

Ignored

Hi MwlRCT, thanks.

I just tested. The way you coded is extended to the end of chart's last bar, but this is not what I want. Would you be able to code it with limited number of max bars, i.e.

endSf = 20; (the last shift to show the dotted lines and/or solid lime line)

From shift 21 onwards, all the dotted lines and solid lime line should be removed completely and automatically whenever a new bar is launched.

The reason that I want to limit the maximum shift and remove the 2 types of lines just because I'll slowly add more complicated other indicators, calculations and conditions, as a result, if working on till the end of chart's last bar will make the MT4 get hang easily.

Hope you can help, thanks

Platform Tech
/
Indicator Not Updating/Repainting Automatically - Help
Reply to Thread

0 traders viewing now

Options

Similar Threads

Indicator Not Updating/Repainting Automatically - Help