Move Stop Loss To Break Even EA

I'm trying to move my stop loss to break even in my EA with the following code:


The stop loss will move but the original take profit isn't being set. It modifies just the stop loss on the order and not the take profit. Any ideas would be greatly appreciated.

You aren't trying to change the TP, OrderTakeProfit() is the current TP and that is what you are setting when you move the SL to OrderOpenPrice(), by the way, why aren't you checking the return value of the OrderModify() to see if it has worked or not ? if it fails you can then log the error and any other useful information to help you diagnose the issue.

This may help: What are Function return values ? How do I use them ?

Sorry, I'm very new to programming. Checking the return value makes sense and I missed that. How do I do an order modify to change just the stop loss where the take profit stays the same as it was?

You seriously need to study the available material before asking.
http://docs.mql4.com/trading/OrderModify

If you don´t do that, you will come here hundreds of times asking similar questions which
are all answered in the documentation of mql.

Here is the book which you should read too:
http://book.mql4.com/

Whether or not you know this forums are a place for people to learn. I have studied the material, for someone new to programming it doesn't always make sense. If you don't have the answer don't reply to my threads. Some people are not only here to help but to learn. Unlike you, Raptor gave some helpful information by pointing out I didn't check the return value.

I gave you all you need, but you don´t understand it.
Learning doesn´t mean spoon feeding, but that is what you expect here.

The answer to your question is right in the first link I posted for you.

Again here the link for you to learn from it:
http://docs.mql4.com/trading/OrderModify

You can never ever modify the OrderOpenPrice of an already opened order.
And if you don´t want to modify the TakeProfit, you just tell the broker that the
already existing OrderTakeProfit value must be taken.

If you want a different TakeProfit, then you got to tell the broker what you want.
Define the new value, for example double new_tp = ...... your value
and then
OrderModify(OrderTicket(),OrderOpenPrice(),Bid-Point*TrailingStop,new_tp,0,Blue);

I don´t like your tone of voice when people are helping you.
Assuming that I don´t know the answer to your question is a bit strange, or should I say "arrogant" ?

That is what your code already does . . . but you said "The stop loss will move but the original take profit isn't being set. It modifies just the stop loss on the order and not the take profit. " suggesting that you wanted to modify the SL and TP.

Hi please I need some help. been at it since Christmas. trying to move sl to breakeven when take profit has been reached, and not to close all the lots but only 80%
of the lot size. But the expert just does nothing. It doesn't move to breakeven, neither does it take partial profits. I would really appreciate if someone could point
me in the right direction. here's the code;

// Call trade management
ManageTrade(ticket);
}

}
//+------------------------------------------------------------------+
//| Manage Trade |
//+------------------------------------------------------------------+
void ManageTrade(int ticket) {
double partialClosePercentage = PartialClosePercentage; // Default to 80%
double remainingPercentage = 1.0 - partialClosePercentage; // Remaining lots to keep
for (int i = OrdersTotal() - 1; i >= 0; i--) {
if (OrderSelect(i, SELECT_BY_POS, MODE_TRADES)) {
if (OrderSymbol() == Symbol() && OrderType() == OP_BUY) {
double currentPrice = Bid;
double tpLevel = OrderTakeProfit();
double lotSize = OrderLots();
int ticket = OrderTicket();
// Check if the take profit level has been reached
if (currentPrice >= tpLevel) {
double lotsToClose = NormalizeDouble(lotSize * partialClosePercentage, 2); // 80% of lot size
double lotsRemaining = NormalizeDouble(lotSize * remainingPercentage, 2); // 20% of lot size
// Move SL to breakeven
if (!OrderModify(ticket, OrderOpenPrice(), OrderOpenPrice(), tpLevel, 0, clrBlue)) {
Print("Failed to move SL to breakeven. Error: ", GetLastError());
} else {
Print("SL moved to Breakeven for Order: ", ticket);
}
// Partially close the trade
if (lotsToClose > 0) {
if (!OrderClose(ticket, lotsToClose, currentPrice, 3, clrRed)) {
Print("Error closing partial position. Error: ", GetLastError());
} else {
Print("Successfully closed ", lotsToClose, " lots for Order: ", ticket);
}
}
// If lotsRemaining is too small, close the entire order
if (lotsRemaining < MarketInfo(Symbol(), MODE_MINLOT)) {
if (!OrderClose(ticket, lotsRemaining, currentPrice, 3, clrRed)) {
Print("Error closing remaining position. Error: ", GetLastError());
} else {
Print("Successfully closed remaining position for Order: ", ticket);
}
}
break; // Stop processing further as the trade is managed
}
}
}
}
}

Have a look at the errors it prints when things fail which will show you what's going wrong. I think you will end up with some fractional lot sizes that will cause OrderClose() errors (they would need to be adjusted and rounded see MODE_MINLOT & MODE_LOTSTEP). The last attempt at closing the partial remains will never execute because you'll never have an order present with lots remaining less than the MODE_MINLOT value.
Regards, Paul.

Hi Paul, thanks for your response. the thing is the expert didnt print any error. It opens the trade with stop loss and take profit levels, and when price gets to the TP, it just closes the entire lot. No " failed to execute partial close" error printed and no ' failed to move sl error" either. It's almost as if it is not seeing what i have instructed it do, or worse, ignoring the instruction. Here is the place order and manage code snippets together.

//+------------------------------------------------------------------+
//| Place Buy Order |
//+------------------------------------------------------------------+
void PlaceBuyOrder() {
double askPrice = NormalizeDouble(Ask, Digits); // Current Ask price
double bidPrice = NormalizeDouble(Bid, Digits); // Current Bid price
double stopLevel = MarketInfo(Symbol(), MODE_STOPLEVEL) * Point; // Broker's minimum stop level
Print("Attempting to place a Buy Order at Ask Price: ", askPrice);
int ticket = OrderSend(Symbol(), OP_BUY, LotSize, askPrice, 3, 0, 0, "Buy Order", 0, 0, Green);
if (ticket < 0) {
Print("Error opening Buy Order: ", GetLastError());
return;
}
// Calculate SL and TP after successful order
double defaultSLBuffer = StopLossBuffer * Point; // Default SL buffer in pips
double sl = NormalizeDouble(bidPrice - defaultSLBuffer, Digits); // Use Bid price and buffer for SL
double tp = NormalizeDouble(askPrice + (askPrice - sl) * RiskRewardRatio, Digits); // Use Ask price for TP
// Validate SL
if ((askPrice - sl) < stopLevel || sl <= 0) {
sl = NormalizeDouble(askPrice - stopLevel, Digits); // Adjust SL to meet broker's minimum stop level
}
// Validate TP
if ((tp - askPrice) < stopLevel || tp <= 0) {
tp = NormalizeDouble(askPrice + stopLevel * RiskRewardRatio, Digits); // Adjust TP to meet broker's minimum stop level
}
bool modifyResult = OrderModify(ticket, askPrice, sl, tp, 0, clrGreen);
if (!modifyResult) {
Print("Error modifying SL/TP for Order: ", ticket, " Error: ", GetLastError());
} else {
Print("Order modified successfully. Ticket: ", ticket, " SL: ", sl, " TP: ", tp);

// Call trade management
ManageTrade();
}

}
//+------------------------------------------------------------------+
//| Manage Trade |
//+------------------------------------------------------------------+
void ManageTrade()
{
for (int i = OrdersTotal() - 1; i >= 0; i--)
{
if (OrderSelect(i, SELECT_BY_POS) && OrderSymbol() == Symbol() && OrderMagicNumber() == MagicNumber)
{
double openPrice = OrderOpenPrice();
double currentPrice = Bid; // For buy trades
double slPrice = OrderStopLoss();
double tpPrice = OrderTakeProfit();
double lotSize = OrderLots();
// 1. Check for manual adjustment
if (ManualAdjust)
{
Print("Manual SL/TP adjustment enabled.");
continue; // Skip automatic management
}
// 2. Automatic Stop Loss to Breakeven
double profit = (currentPrice - openPrice) * MathPow(10, Digits);
double risk = (openPrice - slPrice) * MathPow(10, Digits);
if (profit = RiskRewardRatio * risk && slPrice < openPrice)
{
// Move SL to Breakeven
double breakevenPrice = openPrice;
if (OrderModify(OrderTicket(), OrderOpenPrice(), breakevenPrice, tpPrice, 0, clrRed))
{
Print("Stop Loss moved to breakeven: ", breakevenPrice);
}
else
{
Print("Failed to move SL to breakeven: ", GetLastError());
}
// Partial Close at Breakeven
double closeLots = lotSize * (PartialClosePercentage / 100.0);
if (OrderClose(OrderTicket(), closeLots, Bid, 3, clrBlue))
{
Print("Partial close executed: ", closeLots, " lots at breakeven.");
}
else
{
Print("Failed to execute partial close: ", GetLastError());
}
}
}
}
}

You don't appear to be adding the magic number when placing the order. The management routine won't find anything... Are you sure the order isn't just being closed when it hits your SL or TP.

Yes, that's exactly what happens. Once price hits the take profit, the order is closed without moving the stop loss, or even printing anything.

And the magic number?

Included the magic number, like you said. I'm not sure i done it right cos, the expert is still doing the same thing during testing.

// Input Parameters
input double LotSize = 0.1; // Lot size for trades
input double RiskRewardRatio = 3.0; // Risk-Reward Ratio
input int StopLossBuffer = 20; // Stop Loss buffer in pips
input int WPR_Period = 14; // Williams Percent R period
input double WPR_Oversold = -70; // Oversold level for Williams %R
input ENUM_TIMEFRAMES SignalTimeframe = PERIOD_M5; // Signal timeframe
input ENUM_TIMEFRAMES EntryTimeframe = PERIOD_M1; // Entry timeframe
input double PartialClosePercentage = 80; // Percentage of lot size to close on TP hit
input int MagicNumber = 123456; // Default magic number
input bool ManualAdjust = false; // Enable manual SL/TP adjustment
// Global Variables
datetime lastHotCandleCloseTime = 0; // Tracks last hot candle close
datetime lastSOpAlertTime = 0; // Tracks last Sop alert
bool isHotCandleSequenceValid = false; // Tracks hot candle sequence
double cachedMA = 0; // Cached MA value
datetime lastMATime = 0; // Last MA calculation time
double lastHH = 0; // Last HH value
datetime lastZigZagUpdate = 0; // Last ZigZag update time


//+------------------------------------------------------------------+
//| Place Buy Order |
//+------------------------------------------------------------------+
void PlaceBuyOrder() {
double askPrice = NormalizeDouble(Ask, Digits); // Current Ask price
double bidPrice = NormalizeDouble(Bid, Digits); // Current Bid price
double stopLevel = MarketInfo(Symbol(), MODE_STOPLEVEL) * Point; // Broker's minimum stop level
Print("Attempting to place a Buy Order at Ask Price: ", askPrice);
int ticket = OrderSend(Symbol(), OP_BUY, LotSize, askPrice, 3, 0, 0, "Buy Order", MagicNumber, 0, Green);
if (ticket < 0) {
Print("Error opening Buy Order: ", GetLastError());
return;
}
// Calculate SL and TP after successful order
double defaultSLBuffer = StopLossBuffer * Point; // Default SL buffer in pips
double sl = NormalizeDouble(bidPrice - defaultSLBuffer, Digits); // Use Bid price and buffer for SL
double tp = NormalizeDouble(askPrice + (askPrice - sl) * RiskRewardRatio, Digits); // Use Ask price for TP
// Validate SL
if ((askPrice - sl) < stopLevel || sl <= 0) {
sl = NormalizeDouble(askPrice - stopLevel, Digits); // Adjust SL to meet broker's minimum stop level
}
// Validate TP
if ((tp - askPrice) < stopLevel || tp <= 0) {
tp = NormalizeDouble(askPrice + stopLevel * RiskRewardRatio, Digits); // Adjust TP to meet broker's minimum stop level
}
bool modifyResult = OrderModify(ticket, askPrice, sl, tp, 0, clrGreen);
if (!modifyResult) {
Print("Error modifying SL/TP for Order: ", ticket, " Error: ", GetLastError());
} else {
Print("Order modified successfully. Ticket: ", ticket, " SL: ", sl, " TP: ", tp);

// Call trade management
ManageTrade();
}

}
//+------------------------------------------------------------------+
//| Manage Trade |
//+------------------------------------------------------------------+
void ManageTrade()
{
for (int i = OrdersTotal() - 1; i >= 0; i--)
{
if (OrderSelect(i, SELECT_BY_POS) && OrderSymbol() == Symbol() && OrderMagicNumber() == MagicNumber)
{
double openPrice = OrderOpenPrice();
double currentPrice = Bid; // For buy trades
double slPrice = OrderStopLoss();
double tpPrice = OrderTakeProfit();
double lotSize = OrderLots();
// 1. Check for manual adjustment
if (ManualAdjust)
{
Print("Manual SL/TP adjustment enabled.");
continue; // Skip automatic management
}
// 2. Automatic Stop Loss to Breakeven
double profit = (currentPrice - openPrice) * MathPow(10, Digits);
double risk = (openPrice - slPrice) * MathPow(10, Digits);
if (profit >= RiskRewardRatio * risk && slPrice < openPrice)
{
// Move SL to Breakeven
double breakevenPrice = openPrice;
if (OrderModify(OrderTicket(), OrderOpenPrice(), breakevenPrice, tpPrice, 0, clrRed))
{
Print("Stop Loss moved to breakeven: ", breakevenPrice);
}
else
{
Print("Failed to move SL to breakeven: ", GetLastError());
}
// Partial Close at Breakeven
double closeLots = lotSize * (PartialClosePercentage / 100.0);
if (OrderClose(OrderTicket(), closeLots, Bid, 3, clrBlue))
{
Print("Partial close executed: ", closeLots, " lots at breakeven.");
}
else
{
Print("Failed to execute partial close: ", GetLastError());
}
}
}
}

Hello, Can anybody help me to see what it is I may be doing wrong or not doing right to get this expert working as it should?

The following line of code is a problem in the ManageTrade() section as it won't trigger the setting of BE until it reaches TP anyway (RR 1:3) but it does work if you check for profit > risk without multiplying by RRR.


I include a bit of code to fix up the partial close lot rounding, add it to your code:

Change the line calculating closeLots to:

And you should be good to go. Note that the logic in determining whether to set to BE is only suitable for BUY orders, you may need to cater for a SELL but I don't know what your EA design goals are...

Regards, Paul.