How to Make Use of GlobalVariable to Force Basket Close (MQL4) ? | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

BASKET TRADE Management: Using multiple trade management EA's on basket trades 11 replies

TMS basket: Dashboard for a basket of MA-Filtered RSI Signals 135 replies

GlobalVariable help.... 0 replies

MQL4 Language Most Recent Version is it updated beyond the tutorial on the mql4 websi 6 replies

How to Make Use of GlobalVariable to Force Basket Close (MQL4) ?

  • #1
  • First Post: Edited 4:21pm Dec 9, 2024 3:58pm | Edited 4:21pm
Hi codes, I have a technical problem to trigger a basket close action. Let's say I have the following conditions :-
1) Basket Close Target = 0.1 (10%)
2) Total Open Trades now = 20 Orders
3) Comparing the following :-

Inserted Code
   double balNow=AccountBalance();
   double eqtNow=AccountEquity();

My mission is :-

Inserted Code
if( (eqtNow-balNow) / balNow > 0.1) Basket Close Action (Close All 20 Open Trdaes)

- - - - - - - - -

The problem now is if there are 20 open trades, the moment my EA closes the 1st open trade (remaining 19 Open Trades), the values of eqtNow and balNow will start changing, resulting it may be less than 0.1 (10%) and finally my EA will stop basket close action, unable to proceed to basket close all the 20 Open Trades.

I'm thinking of how to make use of GlobalVariableGet / GlobalVariableSet / GlobalVariableDelete so that the moment the condition

Inserted Code
(eqtNow-balNow) / balNow > 0.1

is met, the EA will GlobalVariableSet and the EA will force / mandatory basket close all the 20 Open Trades completely ...

Kindly advise with your codes, thanks.
  • #2
  • Dec 9, 2024 6:35pm Dec 9, 2024 6:35pm
Quoting chimoong
The problem now is if there are 20 open trades, the moment my EA closes the 1st open trade (remaining 19 Open Trades), the values of eqtNow and balNow will start changing
It changes only if you recalculate between each closure.

Just close all your orders in a while loop until the orders count = 0.
MT4/MT5 EAs/Indicators/Alerts coder
  • #3
  • Dec 9, 2024 9:21pm Dec 9, 2024 9:21pm
Quoting chimoong
Hi codes, I have a technical problem to trigger a basket close action. Let's say I have the following conditions :- 1) Basket Close Target = 0.1 (10%) 2) Total Open Trades now = 20 Orders 3) Comparing the following :- double balNow=AccountBalance(); double eqtNow=AccountEquity(); My mission is :- if( (eqtNow-balNow) / balNow > 0.1) Basket Close Action (Close All 20 Open Trdaes) - - - - - - - - - The problem now is if there are 20 open trades, the moment my EA closes the 1st open trade (remaining 19 Open Trades), the values of eqtNow and balNow will...
void CloseAllTrades()
{
for (int i = OrdersTotal() - 1; i >= 0; i--)
{
if (OrderSelect(i, SELECT_BY_POS, MODE_TRADES))
{
// if(OrderMagicNumber()!=888 || OrderSymbol()!=ChartSymbol())continue; // use if only wanting select trades closed

bool result = OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), 3, clrYellow);
if (!result)
{
Print("Error closing order: ", ErrorDescription(GetLastError()));
}
}
}
}
  • #4
  • Edited Dec 10, 2024 4:42am Dec 9, 2024 11:58pm | Edited Dec 10, 2024 4:42am
Quoting FerruFx
{quote} It changes only if you recalculate between each closure. Just close all your orders in a while loop until the orders count = 0.
Thanks FerruFx. Could you please write down your codes how to use while loop to close all open trades at the moment the following condition is met :-

Inserted Code
   double balNow=AccountBalance();
   double eqtNow=AccountEquity();
 
   (eqtNow-balNow) / balNow > 0.1

FYI, I ever faced a situation if the open trades are sizeable, such as more than 80 open trades, due to the forex market fluctuation is great, my EA was unable to basket close all the 80 open trades, but only managed to close about 10 open trades, remaining about 70 open trades unclosed. This is because the forex market happened :-

Inserted Code
   (eqtNow-balNow) / balNow <= 0.1

You should know that to basket close 80 open trades completely, MT4 may take 1 to 2 minutes to close one trade by one trade to complete the whole process of basket close and it will never happen one-off closure action to basket close all 80 open trades completely in just 1 or 2 seconds.

During the process of basket closure, balNow increased but eqtNow dropped, leading to less than 10%.

Hope you can help to provide your codes, thanks.
  • #5
  • Last Post: Edited Dec 10, 2024 4:41am Dec 9, 2024 11:58pm | Edited Dec 10, 2024 4:41am
Quoting ffjbentz
{quote} void CloseAllTrades() { for (int i = OrdersTotal() - 1; i >= 0; i--) { if (OrderSelect(i, SELECT_BY_POS, MODE_TRADES)) { // if(OrderMagicNumber()!=888 || OrderSymbol()!=ChartSymbol())continue; // use if only wanting select trades closed bool result = OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), 3, clrYellow); if (!result) { Print("Error closing order: ", ErrorDescription(GetLastError())); } } } }
Thanks ffjbentz. Your function block is lack of the following condition :-

Inserted Code
   double balNow=AccountBalance();
   double eqtNow=AccountEquity();
 
   (eqtNow-balNow) / balNow > 0.1

FYI, I ever faced a situation if the open trades are sizeable, such as more than 80 open trades, due to the forex market fluctuation is great, my EA was unable to basket close all the 80 open trades, but only managed to close about 10 open trades, remaining about 70 open trades unclosed. This is because the forex market happened :-

Inserted Code
   (eqtNow-balNow) / balNow <= 0.1

You should know that to basket close 80 open trades completely, MT4 may take 1 to 2 minutes to close one trade by one trade to complete the whole process of basket close and it will never happen one-off closure action to basket close all 80 open trades completely in just 1 or 2 seconds.

During the process of basket closure, balNow increased but eqtNow dropped, leading to less than 10%.

Hope you can help, thanks.
0 traders viewing now