Loop to Count Symbols with Open Trades - Help | Forex Factory

Options

Permalinks
Print Thread

Related Instruments

EUR/USD, GBP/JPY, USD/CAD, Gold/USD

Similar Threads

Need Help: Sort Symbols with Representative Numbers 0 replies

Need Help from Coders: Get Open Order Info from a Loop 9 replies

Loop to get Desired Counts and its Shift, then Stop the Loop 2 replies

How to Write a Loop of a Loop for Different TF 8 replies

Help with drawing alert symbols 2 replies

Attachments: Loop to Count Symbols with Open Trades - Help
Exit Attachments

Loop to Count Symbols with Open Trades - Help

  • #1
  • First Post: Edited 2:51pm Mar 28, 2024 11:02am | Edited 2:51pm
Hi coder, kindly help on my open order loop symbols count, kindly point out where I wrote wrongly ...

I've a multi-symbols EA and it can run 30 pairs. Let's say I've the following 4 symbols with open trades now :-
1) EURUSD : 2 BUY trades + 1 SELL trade
2) GBPJPY : 4 SELL trades
3) USDCAD : 3 BUY trades + 4 SELL trade
4) XAUUSD : 5 BUY trades

I plan to run a loop to detect how many symbols with open trades automatically, out of total of 30 symbols, for example, the output for "symCn" below should expect an answer of "4". My loop is as follows :-

Inserted Code
   int symCn=0, bSymCn=0, sSymCn=0; // Count how many symbols with OpOrd
   for(int i=SymbolsTotal(true)-1; i>=0; i--) {
      int sum=0, bSum=0, sSum=0;
      for(int j=OrdersTotal()-1; j>=0; j--) {
      if(OrderSelect(j,SELECT_BY_POS,MODE_TRADES) && OrderSymbol()==sym) {
                                 sum++;
      if(OrderType()==OP_BUY)    bSum++;
      if(OrderType()==OP_SELL)   sSum++;}}
   if(SymbolName(i,true)==sym && sum>0)   symCn++;
   if(SymbolName(i,true)==sym && bSum>0)  bSymCn++;
   if(SymbolName(i,true)==sym && sSum>0)  sSymCn++;
   }
   Print("Sym# "+IntegerToString(symCn)+" / BUY Sym# "+IntegerToString(bSymCn)+
   " / SEL Sym# "+IntegerToString(sSymCn));

Based on the above loop, it cannot give me the correct answers, could you please correct my codes so that the outputs :-
symCn=4 (4 symbols with BUY / SELL open trades)
bSymCn=3 (3 symbols with only BUY open trades)
sSymCn=3 (3 symbols with only SELL open trades)

Thanks.
  • #2
  • Mar 29, 2024 6:33am Mar 29, 2024 6:33am
Hi,

Inserted Code
OrderSymbol()==sym

What does sym mean ie where is it defined?

Try changing sym to SymbolName(i, true)
  • #3
  • Last Post: Edited 2:59pm Mar 29, 2024 8:13am | Edited 2:59pm
Quoting kennyhubbard
Hi, OrderSymbol()==sym What does sym mean ie where is it defined? Try changing sym to SymbolName(i, true)
Hi Kenny, thanks for your kindness to help.

As I said, my EA is a multi-symbols system and currently is running 33 symbols that specified in the "string trSym".

My "sym" is referring to the 33 symbols (trSym) and the EA will do all the calculations and setting conditions. Currently, I'm trying to learn how to count the number of symbols that with open orders, but will exclude those symbols that without any open order. Hope you won't ask me how the EA was written as it is absolutely beyond my ability to understand (the EA was written by someone else).

The two attachments are for your better understanding how my Multi-sym EA works ... Thanks

FYI, if I change to :-

Inserted Code
OrderSymbol()==SymbolName(j,true)

The loop cannot detect any symbol count, all the outputs are = 0.
Attached Image (click to enlarge)
Click to Enlarge Name: Print iHigh+ExpertTab.png Size: 15 KB
Attached File(s)
File Type: mq4 EntrySig Function Extract.mq4   4 KB | 215 downloads
0 traders viewing now