Indicators with ON/OFF buttons

Quoting venkateshr56

Disliked

{quote} Done {file}

Ignored

Quoting iwudz

Disliked

{quote} hi mate, hope this meets your expectations for other files I'm working on, please be patient {image} {file}

Ignored

Quoting pipibrasci

Disliked

kvak, can you help me with this? Would like to have a toggle button to the hh-lh-ll_hl indicator. Secondly, can you adjust the hh, lh texts as they appear far away from the candles unlike the hl.ll text appearing close to the candles. Could not adjust it from settings. It needs some fix. Will appreciate. Thanks in advance. {file} {image}

Ignored

Quoting kvak

Disliked

{quote} try {image} {file} {file}

Ignored

Quoting Shabs19

Disliked

This classic indicator could do with having an On/Off Button. Be aware that the indicator is placed in multiple instances. {file}

Ignored

OnChartEvent(...) {
 
   //// Method 1: At the very least, skip the bulk of what are usually unwanted event id's.  NOTE that these
   //// events might have been enabled not by this indicator but by some OTHER indicator on the same chart!
   //// This appears to make this indy compatible with other programs that enabled CHART_EVENT_OBJECT_CREATE and/or CHART_EVENT_OBJECT_DELETE :
   //if(id==CHARTEVENT_OBJECT_CREATE || id==CHARTEVENT_OBJECT_DELETE) return;
   //// If this, or another program, enabled mouse-events, these are usually not needed, so skip unless actually needed.:
   //if(id==CHARTEVENT_MOUSE_MOVE    || id==CHARTEVENT_MOUSE_WHEEL)   return;
 
   // Method 2 (Preferred):  Check for a specific id and a specific sparam (object name) of interest, and ONLY act on that event!
   if (id==CHARTEVENT_OBJECT_CLICK && sparam == buttonId)
   {
      buttonStatus = ObjectGetInteger(0, buttonId, OBJPROP_STATE);
...

Quoting pips4life

Disliked

{quote} Here you go. I have coded the button using better (IMO) OnChartEvent() code which is *far* more efficient that many other Button implementations.

Ignored

#define obj "indi_name"
bool show_button;
 
int OnInit()
{
     if(ObjectFind(0,obj+"_OnOff")>=0){
     if(ObjectGetInteger(0,obj+"_OnOff",OBJPROP_COLOR) == btn_text_ON_color)
     show_button = true;}
//---
     else{
     ObjectCreate(0,obj+"_OnOff",OBJ_BUTTON,sub_window,0,0);
     //set button properties
     ...
     }
     ...
}
//---
void OnDeinit(const int reason)
  {
         if(reason==1 || reason==5 || reason==7 || reason==8){
         ObjectsDeleteAll(0,obj,-1,-1); ChartRedraw();} //everything including on/off button is removed from chart
//---
   else if(reason==2 || reason==3 || reason==9){
         ObjectsDeleteAll(0,obj+":",-1,-1); ChartRedraw();} //everything excluding on/off button is removed from chart
  }
//---
void OnChartEvent(...)
  {
   if(CHARTEVENT_OBJECT_CLICK && sparam==obj+"_OnOff"){
   if(ObjectGetInteger(0,obj+"_OnOff",OBJPROP_STATE))
      ObjectSetInteger(0,obj+"_OnOff",OBJPROP_STATE,false);
//---
   show_button = !show_button;
if(show_button) { ObjectSetInteger(0,obj+"_OnOff",OBJPROP_COLOR,btn_text_ON_color);
                  ...}
else            { ObjectSetInteger(0,obj+"_OnOff",OBJPROP_COLOR,btn_text_OFF_color);
                  ObjectsDeleteAll(0,obj+":",-1,-1);
                  ...}
   ChartRedraw();
   return;}
  }

Quoting Botan626

Disliked

{quote} I use another approach. 1. On/Off button state is always off, because it doesn't look good imo when its state is off (pressed). 2. On/Off button and other indicator's objects have different prefixes in their names. 3. On/Off button is removed from chart when it's necessary only, depending on user (coder) needs. Basically, it stays on chart, if symbol or chart period has been changed, saving its state, determined by its color. https://docs.mql4.com/constants/namedconstants/uninit #define obj "indi_name" bool show_button; int OnInit()...

Ignored

//+------------------------------------------------------------------+
void OnDeinit(const int reason) 
//+------------------------------------------------------------------+
{
   // If just changing a TF', the button need not be deleted, therefore the 'OBJPROP_STATE' is also preserved.
   if ( reason != REASON_CHARTCHANGE
     && reason != REASON_CLOSE
     // && reason != REASON_RECOMPILE  // Leave commented, if personal preference is to delete it when Re-Compiled.
      ) ObjectDelete(buttonId);
  del_obj();
  return;
}

Quoting pips4life

Disliked

{quote}I appreciate your feedback.

Ignored

Quoting pips4life

Disliked

{quote}I see that a button gets a little lighter color...

Ignored

Quoting pips4life

Disliked

{quote}OnDeinit()

Ignored

Quoting pips4life

Disliked

{quote}I do agree that 'ChartRedraw()' could be a good idea to use as in your example.

Ignored

Quoting Botan626

Disliked

{quote}On/Off button state is always off, because it doesn't look good imo when its state is off (pressed).

Ignored