Problem of Getting M1 1st Bar's Shift | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

How to get the Shift of 1st Group in a Loop 2 replies

3 Bar Fractal with mid-bar and bar on each side 11 replies

collect values on 1st tick of new bar 1 reply

judging direction for 1st 5-min bar of the day 1 reply

Pin bar, pin bar, pin bar 0 replies

Attachments: Problem of Getting M1 1st Bar's Shift
Exit Attachments

Problem of Getting M1 1st Bar's Shift

  • #1
  • First Post: Edited 4:48am Dec 18, 2021 2:19am | Edited 4:48am
Hi Coders, could you please advise me on these coding issues.

I'm testing with 3 scenario of crypto prices as below and I'm using the M30 current Bar0's M1 shift to get the breakout bars that Close price below the destinated prices (PxLevelA/B/C), i.e my signal will only fall into the M1 bars of M30 current Bar0.

Inserted Code
   double PxLevelA=46450;
   double PxLevelB=46390;
   double PxLevelC=46375;
 
   int b0M30Sf=iBarShift(symbol,PERIOD_M1,iTime(symbol,PERIOD_M30,0),true);
 
   int BreakOutM1SfA=0; for(int i=b0M30Sf; i>=1; i--) {double cCs0=iClose(symbol,1,i);
   if(cCs0<PxLevelA) break; BreakOutM1SfA=i-1;}
 
   int BreakOutM1SfB=0; for(int i=b0M30Sf; i>=1; i--) {double cCs0=iClose(symbol,1,i);
   if(cCs0<PxLevelB) break; BreakOutM1SfB=i-1;}
 
   int BreakOutM1SfC=0; for(int i=b0M30Sf; i>=1; i--) {double cCs0=iClose(symbol,1,i);
   if(cCs0<PxLevelC) break; BreakOutM1SfC=i-1;}
 
   //{Alert(symbol+" M1 B/Out Shift BarStartShift || A || B || C : "+
   //IntegerToString(b0M30Sf)+" || "+IntegerToString(BreakOutM1SfA)+" || "+
   //IntegerToString(BreakOutM1SfB)+" || "+IntegerToString(BreakOutM1SfC));}

Now, I CANNOT get the M1 1st bar's shift if the signal conditions are met, i.e cCs0 < PxLevelA/B.

If the M1 bar's shift is NOT the 1st shift, I can get the bar's shift if the conditions are met.

Kindly look at my picture, I'm expecting the output result should be " 8 || 8 || 8 || 5 " but do not know why the codes cannot get the M1 1st bar's shift.

Could you please advise where my codes go wrong and what would be the coding solution ? Thanks

My mission is to get the M1 bar's breakout shift. If the breakout happens on the M1 1st bar's shift, I need the shift number, but if the breakout falls on other M1 bar, I need to get the shift too.

Why I need to ensure that the codes can get the M1 1st bar's shift info ? This is because I need the "shift" for other calculation purposes. If the "shift" is NOT cCs0<PxLevelA/B/C, there is no issue at all, but if the "1st bar's shift" is cCs0<PxLevelA/B/C (onditions are met) and the output = 0, means I cannot proceed with other calculations.

** If you want to test the codes above by yourself, you may sign up a demo account at ACY Securities, AdmiralMarkets, Axiory, Swissquote, CMTrading, Easy Markets, Forex.com, FxOpen, FxPrimus, Hugo's Way, ICMarkets, IG, InstaForex, RoboForex, TenkoFx, EagleFx ... from my understanding, these brokers have cryptocurrency 24/7.
Attached Image (click to enlarge)
Click to Enlarge Name: BarShift.png Size: 62 KB
  • #2
  • Dec 18, 2021 2:45am Dec 18, 2021 2:45am
looks like the place where you put the break statement is not where it should be and missing encapsulate brackets....,

Example, should be like this:

Inserted Code
 int BreakOutM1SfA=0;
          for(int i=b0M30Sf; i>=1; i--)
          {
             double cCs0=iClose(symbol,1,i);
             if(cCs0<PxLevelA){
                 BreakOutM1SfA=i-1;
                  break;
             }
         }

May I suggest if you are new to programming, try to build a strong foundation in C++ by doing some free tutorials online systematically, it will strengthen more in this kind of stuff...Otherwise it's pretty tiring to keep running into issues like this...
  • #3
  • Dec 18, 2021 3:01am Dec 18, 2021 3:01am
This set of C++ tutorials look pretty systematic to me and covers many topics, anyway there are plenty of such stuff on youtube, you can search and see what you like

https://www.youtube.com/playlist?lis...-u4SyQmMhFeC1C
  • #4
  • Edited 4:01am Dec 18, 2021 3:13am | Edited 4:01am
Quoting eess
looks like the place where you put the break statement is not where it should be and missing encapsulate brackets...., Example, should be like this: int BreakOutM1SfA=0; for(int i=b0M30Sf; i>=1; i--) { double cCs0=iClose(symbol,1,i); if(cCs0<PxLevelA){ BreakOutM1SfA=i-1; break; } } May I suggest if you are new to programming, try to build a strong foundation in C++ by doing some free tutorials online systematically, it will strengthen more in this kind of stuff...Otherwise it's pretty tiring to keep running into issues like this...
Thanks Eess, will consider to learn C++ language later.

For the break; to put at the rear, another problem created. Kindly have a look at below codes and picture :-

Inserted Code
   double PxLevelA=46500;
   double PxLevelB=46447;
   double PxLevelC=46375;
 
   int b0M30Sf=iBarShift(symbol,PERIOD_M1,iTime(symbol,PERIOD_M30,0),true);
 
   int BreakOutM1SfA=0; for(int i=b0M30Sf; i>=1; i--) {double cCs0=iClose(symbol,1,i);
   if(cCs0<PxLevelA) BreakOutM1SfA=i; break;}
 
   int BreakOutM1SfB=0; for(int i=b0M30Sf; i>=1; i--) {double cCs0=iClose(symbol,1,i);
   if(cCs0<PxLevelB) BreakOutM1SfB=i; break;}
 
   int BreakOutM1SfC=0; for(int i=b0M30Sf; i>=1; i--) {double cCs0=iClose(symbol,1,i);
   if(cCs0<PxLevelC) BreakOutM1SfC=i; break;}

I can get the M1 1st bar's shift now as per above mod, but I CANNOT get subsequent M1 bars' shifts, FYI, I'm expecting the output result should be " 24 || 24 || 24 || 16 ", please advise where I went wrong, thanks.
Attached Image (click to enlarge)
Click to Enlarge Name: BarShift2.png Size: 66 KB
  • #5
  • Dec 18, 2021 3:26am Dec 18, 2021 3:26am
Quoting eess
This set of C++ tutorials look pretty systematic to me and covers many topics, anyway there are plenty of such stuff on youtube, you can search and see what you like https://www.youtube.com/playlist?lis...-u4SyQmMhFeC1C
Noted with thanks
  • #6
  • Dec 18, 2021 3:34am Dec 18, 2021 3:34am
I thought you wanted to get first barshift as you said here "Why I need to ensure that the codes can get the M1 1st bar's shift info ? "

If not, what is your objective?
  • #7
  • Edited 4:47am Dec 18, 2021 3:42am | Edited 4:47am
Quoting eess
I thought you wanted to get first barshift as you said here "Why I need to ensure that the codes can get the M1 1st bar's shift info ? " If not, what is your objective?
My mission is to get the M1 bar's breakout shift. Forex market does not always happen can breakout in the M1 1st bar of M30 current bar0, do you agree ?

If the breakout happens on the M1 1st bar's shift, I need the shift number, but if the breakout falls on other M1 bar, I need to get the shift too. As mentioned above, "Why I need to ensure that the codes can get the M1 1st bar's shift info ? This is because I need the "shift" for other calculation purposes. If the "shift" is NOT cCs0<PxLevelA/B/C, there is no issue at all, but if the "1st bar's shift" is cCs0<PxLevelA/B/C (onditions are met) and the output = 0, means I cannot proceed with other calculations.", I need the shift for other calculation purposes. Thanks
  • #8
  • Dec 18, 2021 3:45am Dec 18, 2021 3:45am
Why you need to be so aggressive to someone who is trying to help you and obviously not able to read into your mind? Anyway I'm hands off this issue, maybe someone else might be keen to help.
  • #9
  • Dec 18, 2021 3:47am Dec 18, 2021 3:47am
Quoting eess
Why you need to be so aggressive to someone who is trying to help you? Anyway I'm hands off this issue, maybe someone else might be keen to help.
My apology for my words if you're not feeling well. Please help if you can, thanks again.
  • #10
  • Last Post: Edited 1:08pm Dec 18, 2021 6:20am | Edited 1:08pm
Hi Coders, I desperately need your comments on my mod codes, kindly correct it into a proper coding style.

Due to I do not have programming background at all, my mind is not restricted to any rules / formality of coding style, i.e. my mind is unleased.

The following codes give me the correct output, LOL ... just an accident banging me for getting the right answer, a little bit of crazy.

Former Chairman of China Mr Deng Xiaoping ever quoted "no matter whether is black cat or white cat, as long as a cat can catch mouse, it is a good cat"

For my original issues, the only problem is the M1 1st bar, but if it is firstly tackled, the rest of the codes should be correct. Kindly help to check the codes whether there is any shortfall (in my opinion, it should have the shortfall). Thanks

Inserted Code
   double PxLevelA=47290;
   double PxLevelB=47210;
   double PxLevelC=46950;
 
   int b0M30Sf=iBarShift(symbol,PERIOD_M1,iTime(symbol,PERIOD_M30,0),true);
 
   int BreakOutM1SfA=0; {
   if(b0M30Sf>=1 && iClose(symbol,1,b0M30Sf)<PxLevelA) BreakOutM1SfA=b0M30Sf;
      else if (b0M30Sf>=1 && iClose(symbol,1,b0M30Sf)>=PxLevelA)
      for(int i=b0M30Sf; i>=1; i--) {double cCs0=iClose(symbol,1,i);
      if(cCs0<PxLevelA) break; BreakOutM1SfA=i-1;}}
 
   int BreakOutM1SfB=0; {
   if(b0M30Sf>=1 && iClose(symbol,1,b0M30Sf)<PxLevelB) BreakOutM1SfB=b0M30Sf;
      else if (b0M30Sf>=1 && iClose(symbol,1,b0M30Sf)>=PxLevelB)
      for(int i=b0M30Sf; i>=1; i--) {double cCs0=iClose(symbol,1,i);
      if(cCs0<PxLevelB) break; BreakOutM1SfB=i-1;}}
 
   int BreakOutM1SfC=0; {
   if(b0M30Sf>=1 && iClose(symbol,1,b0M30Sf)<PxLevelC) BreakOutM1SfC=b0M30Sf;
      else if (b0M30Sf>=1 && iClose(symbol,1,b0M30Sf)>=PxLevelC)
      for(int i=b0M30Sf; i>=1; i--) {double cCs0=iClose(symbol,1,i);
      if(cCs0<PxLevelC) break; BreakOutM1SfC=i-1;}}
0 traders viewing now