How to Build your EA | Page 9 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Why your broker is your friend and your enemy 8 replies

MT4 build 1220 EA running OK, build 1260 not OK 1 reply

MT4 Compiler Build prior to Build 6xxx 7 replies

Making your Indicators work with MT4 Build 600+; Simple! 1 reply

Build 201 has new function names that can mess up your EA 0 replies

Attachments: How to Build your EA
Exit Attachments

How to Build your EA

  • #161
  • Sep 2, 2020 2:30pm Sep 2, 2020 2:30pm
Quoting D.s
{quote} I can help you with your doubts while you create the EA yourself. If you expect me to do everything for you, then I am sorry.
please can you help with fixing errors in this EA and making it fast to refresh
Attached Image (click to enlarge)
Click to Enlarge Name: ERROR CODE.png Size: 225 KB
  • #162
  • Sep 3, 2020 3:09am Sep 3, 2020 3:09am
Quoting Samalin
{quote} please can you help with fixing errors in this EA and making it fast to refresh {image}
The error may be due to all the variable that you are using such as PriceOpen_BuyLimit, PriceOpen_SellStop, PriceOpen_SellLimit, etc have some error with their declaration.
For Example: One of the error says that in line no:23 the declaration of the variable is having error. Even if in the snapshot i could not see line no 23, from my experience i think you are trying to declare variables wit same name twice.
It mean you need to check that if "double PriceOpen_BuyLimit" is declared once, you should not add the keyword "double" again while writing "PriceOpen_BuyLimit".

If you are generating the script using EA Builder, then you need to see that "PriceOpen_BuyLimit" name is not repeated at multiple places while assigning name to your variables.
  • #163
  • Sep 3, 2020 6:08am Sep 3, 2020 6:08am
Quoting D.s
{quote} The error may be due to all the variable that you are using such as PriceOpen_BuyLimit, PriceOpen_SellStop, PriceOpen_SellLimit, etc have some error with their declaration. For Example: One of the error says that in line no:23 the declaration of the variable is having error. Even if in the snapshot i could not see line no 23, from my experience i think you are trying to declare variables wit same name twice. It mean you need to check that if "double PriceOpen_BuyLimit" is declared once, you should not add the keyword "double" again while...

thanks so much for your reply,
am not using a builder i saw the EA online and am trying to increase the options
ok i will change the name of the variable

once again thanks
  • #164
  • Sep 6, 2020 3:56pm Sep 6, 2020 3:56pm
Quoting D.s
{quote} The error may be due to all the variable that you are using such as PriceOpen_BuyLimit, PriceOpen_SellStop, PriceOpen_SellLimit, etc have some error with their declaration. For Example: One of the error says that in line no:23 the declaration of the variable is having error. Even if in the snapshot i could not see line no 23, from my experience i think you are trying to declare variables wit same name twice. It mean you need to check that if "double PriceOpen_BuyLimit" is declared once, you should not add the keyword "double" again while...

THANKS SO MUCH FOR YOUR ADVICE I HAVE BEEN ABLE TO COMPILE WITHOUT AN ERROR, BUT PLEASE I STILL NEED YOUR HELP THE EA DOES NOT REFRESH ON EVERY TICK I DON'T KNOW WHY, AFTER AN ORDER IS CLOSED IT TAKES MORE THAN A ONE-MINUTE CANDLE TO COMPLETE BEFORE IT COMES BACK AGAIN TO REPLACE THE PENDING ORDER, I ATTACH HERE THE FIRST PART OF THE CODE SINCE THE REMAINING IS THE SAME PLEASE KINDLY ADVICE

if(CntTicks<27)
CntTicks++;
if(CntTicks<27)
return;
//---------------------------------------------------------------------
//Open orders
//---Open pending stop
if((PriceOpen_BuyStop>0.0)||(PriceOpen_SellStop>0.0))
{
//---Open buy stop
if((PriceOpen_BuyStop>0.0)&&(isMgNum(MagicNumber,OP_BUYSTOP)==0)&&(SendBS==true))
{
FreeMargin=AccountFreeMargin()+AccountFreeMarginCheck(Symbol(),OP_BUY,LotSize);
//---
while(FreeMargin>=0)
{
TP=0;
SL=0;
//---
DistAsk=MathMax(NormalizeDouble(Ask+StopLevel,Digits),NormalizeDouble(PriceOpen_BuyStop,Digits));
DistBid=MathMax(NormalizeDouble(Bid+StopLevel,Digits),NormalizeDouble(PriceOpen_BuyStop-SpreadPair,Digits));
//---
if(TakeProfit>0)
TP=NormalizeDouble(DistAsk+OrderTP,Digits);
if(StopLoss>0)
SL=NormalizeDouble(DistBid-OrderSL,Digits);
//---
OpenOrderTicket=OrderSend(Symbol(),OP_BUYSTOP,NormalizeLot(LotSize),DistAsk,3,SL,TP,ExpertName,MagicNumber,Expire,clrBlue);
//---
if(OpenOrderTicket>0)
{
SendBS=false;
Print(ExpertName+" M"+IntegerToString(Period())+" "+"open buystop order");
break;
}
else
{
Print(ExpertName+": receives new data and try again open order");
Sleep(100);
RefreshRates();
}
}
}
//---Open sell stop
if((PriceOpen_SellStop>0.0)&&(isMgNum(MagicNumber,OP_SELLSTOP)==0)&&(SendSS==true))
{
FreeMargin=AccountFreeMargin()+AccountFreeMarginCheck(Symbol(),OP_SELL,LotSize);
//---
while(FreeMargin>=0)
{
TP=0;
SL=0;
//---
DistAsk=MathMin(NormalizeDouble(Ask-StopLevel,Digits),NormalizeDouble(PriceOpen_SellStop+SpreadPair,Digits));
DistBid=MathMin(NormalizeDouble(Bid-StopLevel,Digits),NormalizeDouble(PriceOpen_SellStop,Digits));
//---
if(TakeProfit>0)
TP=NormalizeDouble(DistBid-OrderTP,Digits);
if(StopLoss>0)
SL=NormalizeDouble(DistAsk+OrderSL,Digits);
//---
OpenOrderTicket=OrderSend(Symbol(),OP_SELLSTOP,NormalizeLot(LotSize),DistBid,3,SL,TP,ExpertName,MagicNumber,Expire,clrRed);
//---
if(OpenOrderTicket>0)
{
SendSS=false;
Print(ExpertName+" M"+IntegerToString(Period())+" "+"open sellstop order");
break;
}
else
{
Print(ExpertName+": receives new data and try again open order");
Sleep(100);
RefreshRates();
}
}
}
Sleep(1000);
}
//---Open pending limit
if((PriceOpen_BuyLimit>0.0)||(PriceOpen_SellLimit>0.0))
{
//---Open buy limit
if((PriceOpen_BuyLimit>0.0)&&(isMgNum(MagicNumber,OP_BUYLIMIT)==0)&&(SendBL==true))
{
FreeMargin=AccountFreeMargin()+AccountFreeMarginCheck(Symbol(),OP_BUY,LotSize);
//---
while(FreeMargin>=0)
{
TP=0;
SL=0;
//---
DistAsk=MathMin(NormalizeDouble(Ask-StopLevel,Digits),NormalizeDouble(PriceOpen_BuyLimit+SpreadPair,Digits));
DistBid=MathMin(NormalizeDouble(Bid-StopLevel,Digits),NormalizeDouble(PriceOpen_BuyLimit,Digits));
//---
if(TakeProfit>0)
TP=NormalizeDouble(DistAsk+OrderTP,Digits);
if(StopLoss>0)
SL=NormalizeDouble(DistBid-OrderSL,Digits);
//---
OpenOrderTicket=OrderSend(Symbol(),OP_BUYLIMIT,NormalizeLot(LotSize),DistBid,3,SL,TP,ExpertName,MagicNumber,Expire,clrBlue);
//---
if(OpenOrderTicket>0)
{
SendBL=false;
Print(ExpertName+" M"+IntegerToString(Period())+" "+"open buylimit order");
break;
}
else
{
Print(ExpertName+": receives new data and try again open order");
Sleep(100);
RefreshRates();
}
}
}
//---Open sell limit
if((PriceOpen_SellLimit>0.0)&&(isMgNum(MagicNumber,OP_SELLLIMIT)==0)&&(SendSL==true))
{
FreeMargin=AccountFreeMargin()+AccountFreeMarginCheck(Symbol(),OP_SELL,LotSize);
//---
while(FreeMargin>=0)
{
TP=0;
SL=0;
//---
DistAsk=MathMax(NormalizeDouble(Ask+StopLevel,Digits),NormalizeDouble(PriceOpen_SellLimit,Digits));
DistBid=MathMax(NormalizeDouble(Bid+StopLevel,Digits),NormalizeDouble(PriceOpen_SellLimit-SpreadPair,Digits));
//---
if(TakeProfit>0)
TP=NormalizeDouble(DistBid-OrderTP,Digits);
if(StopLoss>0)
SL=NormalizeDouble(DistAsk+OrderSL,Digits);
//---
OpenOrderTicket=OrderSend(Symbol(),OP_SELLLIMIT,NormalizeLot(LotSize),DistAsk,3,SL,TP,ExpertName,MagicNumber,Expire,clrRed);
//---
if(OpenOrderTicket>0)
{
SendSL=false;
Print(ExpertName+" M"+IntegerToString(Period())+" "+"open selllimit order");
break;
}
else
{
Print(ExpertName+": receives new data and try again open order");
Sleep(100);
RefreshRates();
}
}
}
Sleep(1000);
}
//---------------------------------------------------------------------
  • #165
  • Sep 6, 2020 5:18pm Sep 6, 2020 5:18pm
Please do you have any idea why more than 4 pending orders will not work in the ea or platform?

I ask because i multiply the pending orders in the ea, and it compile without error, but is not working?
Only the previous 4 that is working
  • #166
  • Sep 6, 2020 10:29pm Sep 6, 2020 10:29pm
Quoting Samalin
Please do you have any idea why more than 4 pending orders will not work in the ea or platform? I ask because i multiply the pending orders in the ea, and it compile without error, but is not working? Only the previous 4 that is working

For your first problem where the EA is not refreshing on every tick, you need to check that under which function you are writing the whole code. I use to face the same problem before.
use this:
void OnTick()
{
}

Write your essential code inside "void OnTick" method (you can see its details in help section) and on every tick this method will be recalled again and again thus giving you a refresh data. For extra precaution use also RefreshRates(); inside it so that the rates will be refreshed before making any calculations.

For your second problem where you are not able to trigger pending orders when pending orders are more than 4, then i don't think its a problem. May be the total lot size exceeds where free margin is not available for the trade to take place. Either decrease the lot size or increase the available balance and the problem may disappear. I have personally seen EA where it has 8 pending order open at the same time and it works fine.
  • #167
  • Sep 7, 2020 3:24am Sep 7, 2020 3:24am
Quoting D.s
{quote} For your first problem where the EA is not refreshing on every tick, you need to check that under which function you are writing the whole code. I use to face the same problem before. use this: void OnTick() { } Write your essential code inside "void OnTick" method (you can see its details in help section) and on every tick this method will be recalled again and again thus giving you a refresh data. For extra precaution use also RefreshRates(); inside it so that the rates will be refreshed before making any calculations. For your second...
Thanks so much for your time your effort and reply,

please for the RefreshRates(); must i write numbers between the brackets?,
can i remove sleep (100);and sleep(1000):of the code, am thinking its making the code to sleep

for second problem i have $27,437.80 on the account am using to test the EA and i use 0.01 for each order, thats why am surprised why its not opening,
exactly the same code i multiplied change variable name as you advised, it compiled without error
  • #168
  • Sep 7, 2020 1:03pm Sep 7, 2020 1:03pm
Quoting Samalin
{quote} Thanks so much for your time your effort and reply, please for the RefreshRates(); must i write numbers between the brackets?, can i remove sleep (100);and sleep(1000):of the code, am thinking its making the code to sleep for second problem i have $27,437.80 on the account am using to test the EA and i use 0.01 for each order, thats why am surprised why its not opening, exactly the same code i multiplied change variable name as you advised, it compiled without error
For RefreshRates(), you do not need to put any value inside.
Delete the sleep() function as it is slowing you down and it may be the reason why the prices are not getting update at every tick.

For the problem with pending order, the balance should not pose any problem, the only reason which is causing problem is the "if()" conditions you are providing before executing the pending order function. as the if conditions are correct in syntax, you are not seeing any error, but the conditions itself causing it to fail. recreate your conditions in a better way and print the values using printf() for the conditions variables so that you can manually verify if the conditions have any issue or not.
while compiling you must be checking the errors tab only, do check the other tabs like "code base" and "journal" while running the EA. the things you print and other type of errors which occur while the EA is running is displayed in those tabs.
  • #169
  • Sep 9, 2020 7:32pm Sep 9, 2020 7:32pm
Quoting D.s
{quote} For RefreshRates(), you do not need to put any value inside. Delete the sleep() function as it is slowing you down and it may be the reason why the prices are not getting update at every tick. For the problem with pending order, the balance should not pose any problem, the only reason which is causing problem is the "if()" conditions you are providing before executing the pending order function. as the if conditions are correct in syntax, you are not seeing any error, but the conditions itself causing it to fail. recreate your conditions...

i have tried all i can for this to work but no way out, i comment out the sleep part and the EA no longer work normal, i dont have experience to re-write the EA, i have searched even no paid version doing what i want to use it for, i am down financially just wanted to start somewhere, even if is only two active pending orders am able to see i can manage but nowhere all the ones online are not with specified price entry and they are all faulty, a lot of them will not compile

i hope to find help
  • #170
  • Edited 12:41am Sep 10, 2020 12:23am | Edited 12:41am
@D.S please Sir i must try to re-write this code, but please you will help me ny guiding me how to do it, because i dont understand the meaning and functions of some codes inside
the idea behind this EA it is that in case of volatility price must pick any of the stops for movement, so ea remain stagnant and price picks it at certain levels

so i will start with extern variables for price input,
do i have to put the declaration of working with 4 and 5 digit brokers in Void On Tick?
  • #171
  • Sep 10, 2020 6:54am Sep 10, 2020 6:54am
Quoting Samalin
{quote} i have tried all i can for this to work but no way out, i comment out the sleep part and the EA no longer work normal, i dont have experience to re-write the EA, i have searched even no paid version doing what i want to use it for, i am down financially just wanted to start somewhere, even if is only two active pending orders am able to see i can manage but nowhere all the ones online are not with specified price entry and they are all faulty, a lot of them will not compile i hope to find help
If you have financial issue and trying to build an EA hoping that you will succeed and change everything, then its better to stop trading completely and find a different career which will first stabilize your finances. EA only works, if you can do the same thing manually and generate profit. Do not misunderstand Ea as something extraordinary. First build your trading plan, than convert that plan to an EA if possible.
  • #172
  • Sep 10, 2020 7:02am Sep 10, 2020 7:02am
Quoting Samalin
@D.S please Sir i must try to re-write this code, but please you will help me ny guiding me how to do it, because i dont understand the meaning and functions of some codes inside the idea behind this EA it is that in case of volatility price must pick any of the stops for movement, so ea remain stagnant and price picks it at certain levels so i will start with extern variables for price input, do i have to put the declaration of working with 4 and 5 digit brokers in Void On Tick?
For different broker you need to provide price differently. Provide the price in the same manner as it is displayed in the right side of your chart.
For example "double price = 1.23456"
  • #173
  • Dec 26, 2020 5:24pm Dec 26, 2020 5:24pm
Hi,

I want a small job from anybody. Could write code for me?

Open trade every single candle
Open buy order if previous candle was bullish.
Open sell order if previous candle was bearish.
  • #174
  • Jan 28, 2021 4:56am Jan 28, 2021 4:56am
recently created an EA which uses GRID trading. The back test is good. can be used with account as small as $250, but having a small account is not recommended, as most trader will randomly put the EA on random charts with random settings.
The currency pairs with low daily volatility like USDJPY are best suited for the EA. It make more money inside ranges then when price just runs away.

I tested and had a decent gain of 47% in two months. Further test are required with different settings.
Details about the EA with the EA attached is posted in the thread below(link).

Grid trading EA
  • #175
  • Feb 27, 2021 1:30am Feb 27, 2021 1:30am
Quoting D.s
Disclaimer: Please note that this thread has nothing to do with any particular EA nor it will provide any valuable trading knowledge. I could not find any thread where people are taught to build their own EA, so I started this thread. Who m I ? Just a simple trader who thinks designing our own system will give us more free time. Technically I am a designer too, and have designed multiple EA for large number of peoples including myself. What this thread will offer: We will discuss all possibilities available for a trader to design their personal...

Hello, can you code correlation EA for me using only one indicator ?
  • #176
  • Feb 27, 2021 6:15am Feb 27, 2021 6:15am
Quoting RazLimpo
{quote} Hello, can you code correlation EA for me using only one indicator ?
Sorry I will not.

I only help them who are trying to code. I advice on their mistakes. But if you want me to do everything, i am not interested.
  • #177
  • Mar 2, 2021 12:31pm Mar 2, 2021 12:31pm
Hi D.s I am trying to develop an EA to test a strategy using MT4 strategy tester, basically involving trading round numbers. I have been able to put together a working EA (through trial and error and copy and pasting snippets of codes here and there from other EAs. I am not a proficient mql coder by any means) that can trade at round numbers at every 100 pips. However, I want to make it to trade at every 200 pips and I have been finding it difficult to come up with a workable EA. Anyways, I decided to try a very crude method (basically hard-coding the round numbers at 200 pips as all I want to to do right now is just to test the EA/strategy on one pair for a short period just to see whether it has any legs). So, below is the bit of the code I have knocked up which unfortunately is not working properly. For example, at a price of 1.2275 for GBPUSD back in Sep 2019, instead of the EA opening a buy stop at 1.24 and a sell stop at 1.22, it instead opened a buy stop at 1.24 (correct) but then a sell stop at 1.16!! What is wrong with the code please, or even if you have a better suggestion/code to achieve what I am after (trading at 200 pips round numbers), I will be most grateful. Thanks!

Inserted Code
void OnTick()
  {
  
  int NrOfDigits = MarketInfo(Symbol(),MODE_DIGITS);   // Nr. of decimals used by Symbol
   int PipAdjust;                                       // Pips multiplier for value adjustment
      if(NrOfDigits == 5 || NrOfDigits == 3)            // If decimals = 5 or 3
         PipAdjust = 10;                                // Multiply pips by 10
         else
      if(NrOfDigits == 4 || NrOfDigits == 2)            // If digits = 4 or 3 (normal)
         PipAdjust = 1;            
//----  
   
   double nTickValue=MarketInfo(Symbol(),MODE_TICKVALUE);   //value of a tick
   if(Digits==3 || Digits==5){       //If the digits are 3 or 5 we normalize multiplying by 10
      nTickValue=nTickValue*10;
      }
   
   int slippage = Slippage * PipAdjust; 
   
 
   double buy_price;
   double sell_price;
   double mid_price = (Ask + Bid) / 2;
   
  
   if(mid_price < 1.38 && mid_price > 1.36)buy_price = 1.38; sell_price = 1.36;
   if(mid_price < 1.36 && mid_price > 1.34) buy_price = 1.36; sell_price = 1.34;
   if(mid_price < 1.34 && mid_price > 1.32) buy_price = 1.34; sell_price = 1.32;
   if(mid_price < 1.32 && mid_price > 1.30) buy_price = 1.32; sell_price = 1.30;
   if(mid_price < 1.30 && mid_price > 1.28) buy_price = 1.30; sell_price = 1.28;
   if(mid_price < 1.28 && mid_price > 1.26) buy_price = 1.28; sell_price = 1.26;
   if(mid_price < 1.26 && mid_price > 1.24) buy_price = 1.26; sell_price = 1.24;
   if(mid_price < 1.24 && mid_price > 1.22) buy_price = 1.24; sell_price = 1.22;
   if(mid_price < 1.22 && mid_price > 1.20) buy_price = 1.22; sell_price = 1.20;
   if(mid_price < 1.20 && mid_price > 1.18) buy_price = 1.20; sell_price = 1.18;
   if(mid_price < 1.18 && mid_price > 1.16) buy_price = 1.18; sell_price = 1.16;
  • #178
  • Mar 2, 2021 8:31pm Mar 2, 2021 8:31pm
Quoting danjuma
Hi D.s I am trying to develop an EA to test a strategy using MT4 strategy tester, basically involving trading round numbers. I have been able to put together a working EA (through trial and error and copy and pasting snippets of codes here and there from other EAs. I am not a proficient mql coder by any means) that can trade at round numbers at every 100 pips. However, I want to make it to trade at every 200 pips and I have been finding it difficult to come up with a workable EA. Anyways, I decided to try a very crude method (basically hard-coding...


Hi... I think the error is in your if() writing style
when the condition satisfy it will only execute thee next line, so put all the lines you want to execute after the condition satisfy, inside braces { }.
Semicolon means change in line. It does not matter if you write it in a single line.
For example:

Inserted Code
  if(mid_price < 1.36 && mid_price > 1.34)
{  buy_price = 1.36;
sell_price = 1.34;
}

Repeat this with all the if conditions. This will fix the issue
  • #179
  • Mar 3, 2021 11:36am Mar 3, 2021 11:36am
Quoting D.s
{quote} Hi... I think the error is in your if() writing style when the condition satisfy it will only execute thee next line, so put all the lines you want to execute after the condition satisfy, inside braces { }. Semicolon means change in line. It does not matter if you write it in a single line. For example: if(mid_price < 1.36 && mid_price > 1.34) { buy_price = 1.36; sell_price = 1.34; } Repeat this with all the if conditions. This will fix the issue
His D.s. Thanks for your response. Yes you are right about enclosing the code to execute in { }. Someone else pointed this out to me in another thread. Many thanks!
  • #180
  • Mar 6, 2021 7:12am Mar 6, 2021 7:12am
Is it possible to build my own EA that can be profitable, or is it risky?
0 traders viewing now