Draw a vline at the first trading day of the month

 
#property copyright ""
#property link      ""
#property indicator_chart_window
 
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int init()
{
 
return(0);
}
//+------------------------------------------------------------------+
//| Custor indicator deinitialization function                       |
//+------------------------------------------------------------------+
int deinit()
{
   ObjectsDeleteAll();
return(0);
}
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int start()
{
   int Day1Exist, Day2Exist, Day3Exist = 0;
   int LookBack = 1000; // no of days you wanna look back
   for(int i=0;i<=LookBack;i++)
     {
      datetime dailyTime=iTime(Symbol(),1440,i);
      string name="Time_Vertical_Line"+i;
      
      if(TimeDay(dailyTime)==1)
        {
         if(!ObjectCreate(0,name,OBJ_VLINE,0,dailyTime,0))
            Print("Fail to draw the line ERROR CODE : ",GetLastError());
         ObjectSet(name,OBJPROP_WIDTH,3);
         ObjectSet(name,OBJPROP_COLOR,Red);
         ObjectSet(name,OBJPROP_BACK,true);
         Day1Exist = Day1Exist + 1;
        }
        else if(TimeDay(dailyTime)==2 && Day1Exist < 1)
            {
               if(!ObjectCreate(0,name,OBJ_VLINE,0,dailyTime,0))
                  Print("Fail to draw the line ERROR CODE : ",GetLastError());
               ObjectSet(name,OBJPROP_WIDTH,3);
               ObjectSet(name,OBJPROP_COLOR,Green);
               ObjectSet(name,OBJPROP_BACK,true);
               Day2Exist = Day2Exist + 1;
            }
            else if(TimeDay(dailyTime)==3 && (Day1Exist < 1) || (Day2Exist < 1))
               {
                  if(!ObjectCreate(0,name,OBJ_VLINE,0,dailyTime,0))
                     Print("Fail to draw the line ERROR CODE : ",GetLastError());
                  ObjectSet(name,OBJPROP_WIDTH,3);
                  ObjectSet(name,OBJPROP_COLOR,Blue);
                  ObjectSet(name,OBJPROP_BACK,true);
                  Day1Exist = 0;
                  Day2Exist = 0;
               }
               
 
     
     } // For
} // Start

Quoting Georgebaker

Disliked

I'm trying to code an indicator that can show a vline at the first trading day of the month (in some month the first tradingday is the 1. other month the first trading day is the 2. or 3.) Here is what i have tried #property copyright "" #property link "" #property indicator_chart_window //+------------------------------------------------------------------+ //| Custom indicator initialization function | //+------------------------------------------------------------------+ int init() { return(0); } //+------------------------------------------------------------------+...

Ignored

Quoting Loftboy

Disliked

{quote} Do it manually.

Ignored

int j=TimeMonth(Time[Bars-1]); string name; datetime d;
   for (int i=Bars-1;i>0;i--){
         d = Time[i];
         if (TimeMonth(d) !=j) {  
               j=TimeMonth(d);
               name="vline"+IntegerToString(i);
               ObjectDelete(name);
               ObjectCreate(name,OBJ_VLINE,0,d,0);
         }
   }

#define PREFIX "__vline_month_start_"
#include <arrays/list.mqh>
#include <chartobjects/chartobjectslines.mqh>
int OnInit(){
   return(INIT_SUCCEEDED);
}
int OnCalculate(const int rates_total,
                const int prev_calculated,
                const datetime &time[],
                const double &open[],
                const double &high[],
                const double &low[],
                const double &close[],
                const long &tick_volume[],
                const long &volume[],
                const int &spread[])
{
   static CList gc;
   static datetime recent_calc = 0;
   datetime check_delta = recent_calc + PeriodSeconds(PERIOD_MN1);
   if (TimeCurrent() > check_delta) {
      datetime times[];
      ArraySetAsSeries(times, true);
      int num_bars = 0;
      do {
         num_bars = Bars(_Symbol, PERIOD_MN1);
      } while(num_bars <= 0);
      int x = CopyTime(_Symbol, PERIOD_MN1,0, gc.Total() ? 1 : num_bars, times);
      for (int i=0; i<x; i++) {
         CChartObjectVLine *line = new CChartObjectVLine();
         gc.Add(line);
         string name = PREFIX + string(times[i]);
         line.Create(ChartID(), name, 0, times[i]);
      }
      recent_calc = times[0];
   }
   return(rates_total);
}

Quoting paulselvan

Disliked

there should be many ways to do this.Here is one : int j=TimeMonth(Time[Bars-1]); string name; datetime d; for (int i=Bars-1;i>0;i--){ d = Time[i]; if (TimeMonth(d) !=j) { j=TimeMonth(d); name="vline"+IntegerToString(i); ObjectDelete(name); ObjectCreate(name,OBJ_VLINE,0,d,0); } }

Ignored

Quoting Nicholishen

Disliked

You just need to draw a vLine at the time corresponding to the open of the month bar. #define PREFIX "__vline_month_start_" #include <arrays/list.mqh> #include <chartobjects/chartobjectslines.mqh> int OnInit(){ return(INIT_SUCCEEDED); } int OnCalculate(const int rates_total, const int prev_calculated, const datetime &time[], const double &open[], const double &high[], const double &low[], const double &close[], const long &tick_volume[], const long &volume[], const int &spread[]) { static CList gc; static datetime recent_calc = 0; datetime check_delta...

Ignored