MT4/MQL Custom Coded Buttons Must Be Pressed Twice to Work

Quoting FtNTrader

Disliked

Hi, I have a trading panel EA I've created. It's full of wonderful buttons that I programmed. By and large, it works great. I realize that the issue I'm about to describe does not include code or specifics -- this is because there is too much code to share it all, and I'm not sure how to even start to isolate where the issue might be, to the point where sharing code makes sense -- so thank you in advance for any guidance you can suggest. The issues is that oftentimes: -'Occasionally' (when MT4 was opened recently, or off busiest market hours) -or...

Ignored

Quoting FtNTrader

Disliked

In an attempt to provide more info, please see simple buttons in attached screenshot. I put Print() statements in each button's OnClick functions. As expected, when the buttons perform correctly, the Print statements print correctly. In this last case, I was on the "Alert" tab, and then when I pressed the "Other" button and it did not work -- you can see, the "Other" button appears to be "stuck" in the depressed position (while "Alert" remains the same). The UI took the click, but the underlying code of the click did not get executed. No print statement...

Ignored

 
// THIS SETS UP A MAPPING OF BUTTON CLICKS TO ACTIONS
#define EVENT_MAP_BEGIN(class_name)              bool class_name::OnEvent(const int id,const long& lparam,const double& dparam,const string& sparam) {
#define EVENT_MAP_END(parent_class_name)         return(parent_class_name::OnEvent(id,lparam,dparam,sparam)); }
 
// EXCERPT OF BUTTON OBJECTS
CButton    m_BtnTabAlerts, m_BtnTabOther;
 
// ESTABLISH THAT WHEN EVENTS OCCUR, TRIGGER ONEVENT() FUNCTION BASED ON THE EVENT MAP
void OnChartEvent(const int id,
                  const long &lparam,
                  const double &dparam,
                  const string &sparam)
  {  if (id != CHARTEVENT_CHART_CHANGE) OnEvent(id, lparam, dparam, sparam); }
 
// THESE FUNCTIONS ARE NOT USED AT ALL
void OnTick() { }
void OnTimer() { }
 
// EVENT MAP THAT ALIGNS SPECIFIC BUTTON CLICKS TO SPECIFIC FUNCTIONS
EVENT_MAP_BEGIN(CFtNTradePanel)
   ON_EVENT(ON_CLICK, m_BtnTabAlerts, OnClickBtnTabAlerts)
   ON_EVENT(ON_CLICK, m_BtnTabOther, OnClickBtnTabOther)
   ON_EVENT(ON_CLICK, m_BtnTabTrade, OnClickBtnTabTrade)
   ON_EVENT(ON_CLICK, m_BtnTabChart, OnClickBtnTabChart)
   ...
EVENT_MAP_END(CAppDialog)
 
 
// Hides elements of TabButton "Alerts"
void CFtNTradePanel::HideConditions()
{    m_BtnTabAlerts.ColorBackground(CONTROLS_BUTTON_COLOR_DISABLE); }
 
// Shows elements of TabButton "Alerts"
void CFtNTradePanel::ShowConditions()
{   m_BtnTabAlerts.ColorBackground(CONTROLS_BUTTON_COLOR_ENABLE); }
 
// THIS FUNCTION IS DIRECTLY CALLED FROM THE EVENT MAP
void CFtNTradePanel::OnClickBtnTabAlerts() {
Print("ALERTS TAB Registered click");
   if (sets.SelectedTab == AlertsTab) return;  //
m_BtnTabTrade.ColorBackground(CONTROLS_BUTTON_COLOR_DISABLE);
m_BtnTabChart.ColorBackground(CONTROLS_BUTTON_COLOR_DISABLE);
m_BtnTabOther.ColorBackground(CONTROLS_BUTTON_COLOR_DISABLE);
m_BtnTabAlerts.ColorBackground(CONTROLS_BUTTON_COLOR_ENABLE);
sets.SelectedTab = AlertsTab;
ShowConditions();
HideMain();
HideFilters();
HideActions();
}
 
struct Settings
{
   TABS SelectedTab;
} sets;
 
enum TABS
{
TradeTab,
ChartTab,
AlertsTab,
OtherTab
};

Quoting doktorcak

Disliked

I think you should try to call the functions from void OnTick()

Ignored

Quoting FtNTrader

Disliked

Often, the button will visually show that it was pressed, but instead of a quick toggle, it just sits there until it is pressed (at least) one more time.

Ignored

void OnChartEvent(const int id, const long &lparam, const double &dparam, const string &sparam)
{
  if(id==CHARTEVENT_OBJECT_CLICK)
  {
    if(sparam==buttonName)
    {
      bool selected = ObjectGetInteger(0,buttonName,OBJPROP_STATE);
      // log a debug message
      Print("Button pressed = ", selected);
      if(selected)
      {
        Sleep(60); // wait
        ObjectSetInteger(0,buttonName,OBJPROP_STATE,false); // deselect button
        ChartRedraw(); // redraw all chart objects
      }
    }
  }
}