handling error code 3 "invalid trade parameter" | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

MT4 No Connection, Common Error, Invalid Account 14 replies

Dealing with "Invalid Price", "Requote", "Server Busy" in MT4 3 replies

invalid integer number as parameter 1 for TimeToNumber function 13 replies

"Optimized Parameter" feature in EA? 0 replies

Grid EA bug: missing orders due to invalid stops (error 130) 8 replies

Attachments: handling error code 3 "invalid trade parameter"
Exit Attachments

handling error code 3 "invalid trade parameter"

  • #1
  • First Post: Jan 13, 2020 9:55pm Jan 13, 2020 9:55pm
hlw

i m facing error 3 " invalid trade parameter" during pending order modify in almost all brokers in ECN and VIP acc
My EA request to modify pending orders but brokers server always failed to modify as requirement of EA and shoing error libe below

Quote
2020.01.12 18:56:50.105 '2090550030': modification of pending order #486177218 buy stop 0.30 XAUUSD at 1556.29 sl: 1555.99 tp: 0.00 -> price: 1556.29 sl: 1555.99 tp: 0.00 failed [Invalid parameters]

any suggestion tp avoid this error code
  • #2
  • Edited 7:45am Jan 14, 2020 7:14am | Edited 7:45am
Quoting munna00
hlw i m facing error 3 " invalid trade parameter" during pending order modify in almost all brokers in ECN and VIP acc My EA request to modify pending orders but brokers server always failed to modify as requirement of EA and shoing error libe below {quote} any suggestion tp avoid this error code
Before you send the request you have to check that the new settings differ from the old ones. The error you observe comes from the fact that beforer/after settings are the same and there is nothing to do for the trade server.

See here: checking of previous trade parameters before OrderModify()

ps: Don't forget to use proper comparator functions for comparing doubles. An "if ((double) a == (double) b)..." will not work. You may copy yourself just the following comparison helpers, no need to use everything from there.
It takes blood, sweat and enough tears to wash away the blood.
  • #3
  • Jan 17, 2020 9:18pm Jan 17, 2020 9:18pm
Quoting emmzett
{quote} Before you send the request you have to check that the new settings differ from the old ones. The error you observe comes from the fact that beforer/after settings are the same and there is nothing to do for the trade server. See here: checking of previous trade parameters before OrderModify() ps: Don't forget to use proper comparator functions for comparing doubles. An "if ((double) a == (double) b)..." will not work. You may copy yourself just...
i m using order modify like below
Inserted Code
 
double Spread=MarketInfo(Symbol(),MODE_SPREAD);
 
extern double gap1 = 10; // pending Distance
double gap = gap1 + Spread ;
 
for(int b=OrdersTotal()-1;b>=0;b--)
              {
         if(OrderSelect(b,SELECT_BY_POS,MODE_TRADES))
 
if (OrderType()==OP_BUYSTOP  && OrderMagicNumber()== magic1 && OrderSymbol()==Symbol())
{
if ( OrderOpenPrice()- Bid >gap*Point)
{                                    
double priceNew=(Bid+gap*Point);
int tk3 = OrderModify(OrderTicket(),priceNew ,priceNew-30*Point,0,CLR_NONE);
}
}
if (OrderType()==OP_SELLSTOP  && OrderMagicNumber()== magic1 && OrderSymbol()==Symbol())
{
if (Bid-OrderOpenPrice()>gap*Point)
{                                  
double priceNew1=(Bid-gap*Point);
int tk4 = OrderModify(OrderTicket(),priceNew1,priceNew1+30*Point,0,CLR_NONE);
}
}
 
}

but its showing always invalid parameter
  • #4
  • Edited 1:33am Jan 18, 2020 1:21am | Edited 1:33am
Quoting munna00
{quote} i m using order modify like below...but its showing always invalid parameter
First, you need to get used to write and format code more carefully. Your way code is not readable, and you immediately get the feedback: it produces errors which you can't explain. Properly formatted:
Attached Image (click to enlarge)
Click to Enlarge Name: error-3.png Size: 56 KB


What we see here is a missing pair of curly brackets in line 7, your second conditional test in line 15 is always executed even if line 7 would trigger an error. With proper formatting those errors would not happen. But that's not the reason for the trade error you observe.

The reason for the trade error is - as stated before - the lack of proper comparator functions in line 9 and 16. You can't compare doubles with standard operators "==", "!=", ">" or "<" as the result will amost always be wrong. I will not go into too much details here now (there are countless threads and posts at mql5.com regarding "comparing doubles"). The quick solution is - as stated before - copy the comparator functions from my project and always use those when working with doubles. There are variants for each possible case:

EQ() - equal
NE() - not equal
GT() - greater than
GE() - greater or equal
LT() - lower than
LE() - lower or equal

And your error will be gone.
It takes blood, sweat and enough tears to wash away the blood.
  • #5
  • Edited 5:50am Jan 18, 2020 5:36am | Edited 5:50am
Quoting emmzett
{quote} First, you need to get used to write and format code more carefully. Your way code is not readable, and you immediately get the feedback: it produces errors which you can't explain. Properly formatted: {image} What we see here is a missing pair of curly brackets in line 7, your second conditional test in line 15 is always executed even if line 7 would trigger an error. With proper formatting those errors would not happen. But that's not the reason for the trade error you observe. The reason for the trade error is - as stated before - the...

thanks for help

but little confused in compare double values...

use NormalizeDouble or Mathabs

or

Inserted Code
bool CompareDoubles(double number1,double number2) {
if(NormalizeDouble(number1-number2,8)<0) {..........};
}

little confused in using, how to use, as diff function call?

EQ() - equal
NE() - not equal
GT() - greater than
GE() - greater or equal
LT() - lower than
LE() - lower or equal
  • #6
  • Edited 8:56am Jan 18, 2020 8:37am | Edited 8:56am
Quoting munna00
...but little confused in compare double values... use NormalizeDouble or Mathabs or bool CompareDoubles......little confused ...
Did you read the PS and the link in my first reply? Nobody said anything regarding NormalizeDouble(), MathAbs() or CompareDoubles().

Inserted Code
/**
 * Correct comparison of two doubles for "Greater-Than".
 *
 * @param double double1 - first value
 * @param double double2 - second value
 * @param int digits - number of decimal digits to consider (default: 8)
 *
 * @return bool
 */
bool GT(double double1, double double2, int digits=8) {
   if (EQ(double1, double2, digits))
      return(false);
   return(double1 > double2);
}
 
 
 
if (OrderOpenPrice()-Bid > gap*Point) {...}        // a "greater than" comparison
// becomes...
if (GT(OrderOpenPrice()-Bid, gap*Point)) {...}
 
 
if (Bid-OrderOpenPrice() > gap*Point) {...}        // another one
// becomes...
if (GT(Bid-OrderOpenPrice(), gap*Point)) {...}
Attached File(s)
File Type: mqh comparators.mqh   3 KB | 407 downloads
It takes blood, sweat and enough tears to wash away the blood.
  • #7
  • Jan 19, 2020 9:07pm Jan 19, 2020 9:07pm
Quoting emmzett
{quote} Did you read the PS and the link in my first reply? Nobody said anything regarding NormalizeDouble(), MathAbs() or CompareDoubles(). /** * Correct comparison of two doubles for "Greater-Than". * * @param double double1 - first value * @param double double2 - second value * @param int digits - number of decimal digits to consider (default: 8) * * @return bool */ bool GT(double double1, double double2, int digits=8) { if (EQ(double1, double2, digits)) return(false); return(double1 > double2); } if (OrderOpenPrice()-Bid > gap*Point) {...} //...
Sir,

after modification as per ur suggestion , same error is comming AGAIN BROKER SIDE, but in testing it is ok
Attached Image (click to enlarge)
Click to Enlarge Name: Untitled.png Size: 28 KB


i m attaching my modified code here:

Inserted Code
for(int b=OrdersTotal()-1;b>=0;b--)
              {
         if(OrderSelect(b,SELECT_BY_POS,MODE_TRADES) == true){
    
if (OrderType()==OP_BUYSTOP  && OrderMagicNumber()== magic1 && OrderSymbol()==Symbol())
{
if (GT(OrderOpenPrice()-Bid, gap*Point))
{                                    
double priceNew=(Bid+gap*Point);
int tk3 = OrderModify(OrderTicket(),priceNew ,priceNew-30*Point,0,CLR_NONE);
}
}
if (OrderType()==OP_SELLSTOP  && OrderMagicNumber()== magic1 && OrderSymbol()==Symbol())
{
if (GT(Bid-OrderOpenPrice(), gap*Point))
{                                  
double priceNew1=(Bid-gap*Point);
int tk4 = OrderModify(OrderTicket(),priceNew1,priceNew1+30*Point,0,CLR_NONE);
}
}
}}
  • #8
  • Edited 4:33am Jan 20, 2020 4:11am | Edited 4:33am
Quoting munna00
{quote} Sir, after modification as per ur suggestion , same error is comming AGAIN BROKER SIDE, but in testing it is ok {image} i m attaching my modified code here: for(int b=OrdersTotal()-1;b>=0;b--) { if(OrderSelect(b,SELECT_BY_POS,MODE_TRADES) == true){ if (OrderType()==OP_BUYSTOP && OrderMagicNumber()== magic1 && OrderSymbol()==Symbol()) { if (GT(OrderOpenPrice()-Bid, gap*Point)) { double priceNew=(Bid+gap*Point); int tk3 = OrderModify(OrderTicket(),priceNew ,priceNew-30*Point,0,CLR_NONE); } } if (OrderType()==OP_SELLSTOP && OrderMagicNumber()==...
Munna, I'm not a "Sir" to you. I can tell you there a no "Sir"s here :-)

Your current error is a bit different than the first one. If you look closely in your first post you sent identical trade parameters to the server. Now you send different parameters - which tells us that your price comparison finally works correctly: You only send the modification request when price has indeed changed. That's a progress.

If you still get ERR_INVALID_TRADE_PARAMETERS then the price you send is illegal. You have to make sure that for a stop order the new price is not inside the spread (between Bid and Ask) and that you comply with your broker's stop level and freeze level conditions. To me it looks like a MODE_STOPLEVEL issue of your broker. A broker enforcing a stop level or freeze level restriction on his clients is always a bucketshop. In this case you should change the broker asap as he will never allow you to earn money from Forex.

Look at the symbols dialog (Ctrl-U) for the symbol in question. If "StopsLevel" is not zero you should take your money and run...

Attached Image (click to enlarge)
Click to Enlarge Name: stoplevel.png Size: 47 KB
It takes blood, sweat and enough tears to wash away the blood.
  • #9
  • Jan 22, 2020 2:15am Jan 22, 2020 2:15am
Quoting emmzett
{quote} Munna, I'm not a "Sir" to you. I can tell you there a no "Sir"s here :-) Your current error is a bit different than the first one. If you look closely in your first post you sent identical trade parameters to the server. Now you send different parameters - which tells us that your price comparison finally works correctly: You only send the modification request when price has indeed changed. That's a progress. If you still get ERR_INVALID_TRADE_PARAMETERS then the price you send is illegal. You have to make sure that for a stop order the...
Attached Image


its showing 0 for my broker

also i set stop loss 0 for check the error code...but its still coming, though it is pending stop in fixed distance gap. i think its not placing between ask and bid

i cant understand whats the error code coming from broker side? ERR_INVALID_TRADE_PARAMETERS

any suggestion...i also check indiff broker ecn acc , all time same problem and same error and pending modify is not working and showing same error
  • #10
  • Jan 22, 2020 3:58am Jan 22, 2020 3:58am
Quoting munna00
{quote} {image} its showing 0 for my broker also i set stop loss 0 for check the error code...but its still coming, though it is pending stop in fixed distance gap. i think its not placing between ask and bid i cant understand whats the error code coming from broker side? ERR_INVALID_TRADE_PARAMETERS any suggestion...i also check indiff broker ecn acc , all time same problem and same error and pending modify is not working and showing same error
In this case something in your price calculation logic is wrong (which I don't check). For a fact you are sending illegal (i.e. not allowed) price parameters to the trade server. Add two log statements before and after each call of OrderModify() like so:

Inserted Code
// first OrderModify()
Print("Tick="+ Volume[0] +"  trying to modify BuyStop, price="+ priceNew +" sl="+ (priceNew-30*Point) +" (market: "+ Bid +"/"+ Ask +")");
int tk3 = OrderModify(OrderTicket(), priceNew, priceNew-30*Point, 0, CLR_NONE);
if (!tk3) Print("Tick="+ Volume[0] +"  modification of BuyStop failed: error="+ GetLastError() +"  stopLevel="+ MarketInfo(Symbol(), MODE_STOPLEVEL) +"  freezeLevel="+ MarketInfo(Symbol(), MODE_FREEZELEVEL));

Inserted Code
// second OrderModify()
Print("Tick="+ Volume[0] +"  trying to modify SellStop, price="+ priceNew1 +" sl="+ (priceNew1+30*Point) +" (market: "+ Bid +"/"+ Ask +")");
int tk4 = OrderModify(OrderTicket(), priceNew1, priceNew1+30*Point, 0, CLR_NONE);
if (!tk4) Print("Tick="+ Volume[0] +"  modification of SellStop failed: error="+ GetLastError() +"  stopLevel="+ MarketInfo(Symbol(), MODE_STOPLEVEL) +"  freezeLevel="+ MarketInfo(Symbol(), MODE_FREEZELEVEL));

Run it on the broker where the error occurres and post the log output.
It takes blood, sweat and enough tears to wash away the blood.
  • #11
  • Jan 23, 2020 3:21am Jan 23, 2020 3:21am
EA placed a sell stop and cant modify cause showing error in journal ..ERR_INVALID_TRADE_PARAMETERS

modify coe and expert log attached , error 3 and 4109

Inserted Code
for(int b=OrdersTotal()-1;b>=0;b--)
              {
         if (OrderSelect(b, SELECT_BY_POS, MODE_TRADES)) {
                    
if (OrderType()==OP_BUYSTOP  && OrderMagicNumber()== magic1 && OrderSymbol()==Symbol())
{
if (GT(OrderOpenPrice()-Bid, gap*Point))
{                                    
double priceNew=(Bid+gap*Point);
Print("Tick="+ Volume[0] +"  trying to modify BuyStop, price="+ priceNew +" sl="+ (priceNew-30*Point) +" (market: "+ Bid +"/"+ Ask +")");
int tk3 = OrderModify(OrderTicket(), priceNew, priceNew-30*Point, 0, CLR_NONE);
if (!tk3) Print("Tick="+ Volume[0] +"  modification of BuyStop failed: error="+ GetLastError() +"  stopLevel="+ MarketInfo(Symbol(), MODE_STOPLEVEL) +"  freezeLevel="+ MarketInfo(Symbol(), MODE_FREEZELEVEL));

}
}
if (OrderType()==OP_SELLSTOP  && OrderMagicNumber()== magic1 && OrderSymbol()==Symbol())
{
if (GT(Bid-OrderOpenPrice(), gap*Point))
{                                   
double priceNew1=(Bid-gap*Point);
Print("Tick="+ Volume[0] +"  trying to modify SellStop, price="+ priceNew1 +" sl="+ (priceNew1+30*Point) +" (market: "+ Bid +"/"+ Ask +")");
int tk4 = OrderModify(OrderTicket(), priceNew1, priceNew1+30*Point, 0, CLR_NONE);
if (!tk4) Print("Tick="+ Volume[0] +"  modification of SellStop failed: error="+ GetLastError() +"  stopLevel="+ MarketInfo(Symbol(), MODE_STOPLEVEL) +"  freezeLevel="+ MarketInfo(Symbol(), MODE_FREEZELEVEL));

}
}
}
 }

Attached Image (click to enlarge)
Click to Enlarge Name: Untitled.png Size: 66 KB

Attached Image (click to enlarge)
Click to Enlarge Name: Untitled1.png Size: 48 KB
  • #12
  • Jan 23, 2020 4:20am Jan 23, 2020 4:20am
Quoting munna00
EA placed a sell stop and cant modify cause showing error in journal ..ERR_INVALID_TRADE_PARAMETERS modify coe and expert log attached , error 3 and 4109 for(int b=OrdersTotal()-1;b>=0;b--) { if (OrderSelect(b, SELECT_BY_POS, MODE_TRADES)) { if (OrderType()==OP_BUYSTOP && OrderMagicNumber()== magic1 && OrderSymbol()==Symbol()) { if (GT(OrderOpenPrice()-Bid, gap*Point)) { double priceNew=(Bid+gap*Point); Print("Tick="+ Volume[0] +" trying to modify BuyStop, price="+ priceNew +" sl="+ (priceNew-30*Point) +" (market: "+ Bid +"/"+ Ask +")"); int tk3...
My first reply was to fast. Please also add the output lines from the terminal log, where MetaTrader reports the error.
It takes blood, sweat and enough tears to wash away the blood.
  • #13
  • Edited 4:51am Jan 23, 2020 4:40am | Edited 4:51am
Quoting emmzett
{quote} My first reply was to fast. Please also add the output lines from the terminal log, where MetaTrader reports the error.
Attached Image (click to enlarge)
Click to Enlarge Name: Untitled.png Size: 27 KB


Attached Image (click to enlarge)
Click to Enlarge Name: Untitled1.png Size: 55 KB


i manually disable automated trade for save the log
  • #14
  • Jan 23, 2020 4:56am Jan 23, 2020 4:56am
Quoting munna00
{quote} {image} {image} i manually disable automated trade for save the log
Exactly. This is what my IDE shows me for 4109
Attached Image (click to enlarge)
Click to Enlarge Name: ordermodify-error.png Size: 3 KB


Always add error handling and print the error to the log. And use
Inserted Code
bool IsTradeAllowed()
to detect those cases before you send the request.
It takes blood, sweat and enough tears to wash away the blood.
  • #15
  • Jan 23, 2020 5:37am Jan 23, 2020 5:37am
Quoting munna00
{quote} {image} {image} i manually disable automated trade for save the log
btw: This also shows that traders cannot trust the terminal's log messages and must always implement their own error handling. The error shown in MetaTrader's log window was misleading and just plain wrong. The result of GetLastError() is correct.
It takes blood, sweat and enough tears to wash away the blood.
  • #16
  • Edited 5:50am Jan 23, 2020 5:38am | Edited 5:50am
Quoting emmzett
{quote} Exactly. This is what my IDE shows me for 4109 {image} Always add error handling and print the error to the log. And use bool IsTradeAllowed() to detect those cases before you send the request.
4109 is after stop autmated trading,

but i m dealing with error 3 which before stop auto trade manually

i used the code and same error 3 comming

Inserted Code
if (IsTradeAllowed() && OrderType()==OP_SELLSTOP  && OrderMagicNumber()== magic1 && OrderSymbol()==Symbol())
{
if (GT(Bid-OrderOpenPrice(), gap*Point))
{                                  
double priceNew1=(Bid-gap*Point);
Print("Tick="+ Volume[0] +"  trying to modify SellStop, price="+ priceNew1 +" sl="+ (priceNew1+30*Point) +" (market: "+ Bid +"/"+ Ask +")");
int tk4 = OrderModify(OrderTicket(), priceNew1, priceNew1+30*Point, 0, CLR_NONE);
if (!tk4) Print("Tick="+ Volume[0] +"  modification of SellStop failed: error="+ GetLastError() +"  stopLevel="+ MarketInfo(Symbol(), MODE_STOPLEVEL) +"  freezeLevel="+ MarketInfo(Symbol(), MODE_FREEZELEVEL));
 
}
}
thats i made one error handling code

if(GetLastError() == 3 || GetLastError() == 4109){ ...delete pending orders...}

its deleting but result is not coming in EA performance when Ea again place same stop pending in specific distance from input setting than what was required in modify pending place price
  • #17
  • Edited 8:15am Jan 23, 2020 5:55am | Edited 8:15am
Quoting munna00
{quote} 4109 is after stop autmated trading, but i m dealing with error 3 which before stop auto trade manually i used the code and same error 3 comming if (IsTradeAllowed() && OrderType()==OP_SELLSTOP && OrderMagicNumber()== magic1 && OrderSymbol()==Symbol()) { if (GT(Bid-OrderOpenPrice(), gap*Point)) { double priceNew1=(Bid-gap*Point); Print("Tick="+ Volume[0] +" trying to modify SellStop, price="+ priceNew1 +" sl="+ (priceNew1+30*Point) +" (market: "+ Bid +"/"+ Ask +")"); int tk4 = OrderModify(OrderTicket(), priceNew1, priceNew1+30*Point, 0,...
To see what really happens I loaded your first code snippet into my framework and run it there. This is the outcome:
Attached Image (click to enlarge)
Click to Enlarge Name: ordermodify-error.png Size: 35 KB

You have to check whether or not the order was already executed before you try to modify it again. You continue trying to modify it even if the stop limit is already executed.
It takes blood, sweat and enough tears to wash away the blood.
  • #18
  • Jan 23, 2020 7:10am Jan 23, 2020 7:10am
Quoting emmzett
{quote} To see what really happens I loaded your first code snippet into my framework and run it there. This is the outcome: {image} You have to check whether or not the order was already executed before you try to modify it again. You continue trying to modify it even if the stop limit is already executed. ps: A notice to other FF members who think about helping others. There hasn't been a "Thank you" or anything like that from munna00. Instead - after I found and pointed out the causes of his errors - 5 minutes later he put me on his "Ignore list"....
Actually I m from Android browser and I press wrongly the icon... It's mistake
  • #19
  • Last Post: Jan 27, 2020 11:49pm Jan 27, 2020 11:49pm
Finally i found the solution of modify pending order to avoid error 3 "invalid trade parameter"

its works well


Inserted Code
   RefreshRates();
   double ppoint=MarketInfo(OrderSymbol(), MODE_POINT);
   double pBid=MarketInfo(OrderSymbol(), MODE_BID);
   
   double pAsk=MarketInfo(OrderSymbol(), MODE_ASK);
   
   for(int i=0; i<total; i++)
   {
      if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES))
      {
         if (OrderType()==OP_BUYSTOP)
         {
               //if(OrderOpenPrice()-pBid>20*Point)
                 if (GT(OrderOpenPrice()-pBid, gap*ppoint)){
                     priceNew=(pBid+10*ppoint);
                     OrderModify(OrderTicket(),priceNew,0,OrderStopLoss(),OrderTakeProfit());
                    // Print("Modified Order");
               }
         }        
         else if (OrderType()==OP_SELLSTOP)
         {
              // if (pBid-OrderOpenPrice()>20*Point)
                if (GT(pBid-OrderOpenPrice(), gap*ppoint)){
                     priceNew=(pBid-10*ppoint);
                     OrderModify(OrderTicket(),priceNew,0,OrderStopLoss(),OrderTakeProfit());
                     //Print("Modified Order");
               }
         }
      }
   }
0 traders viewing now