BoxFibo indicator acting weird, can anyone help? | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

can anyone help me to add alert to this indicator 20 replies

Can anyone help me to add an email alert to this indicator 0 replies

need help with a simple MA crossover EA. anyone can help? 7 replies

Indicator is acting weird 5 replies

Need a retracement indicator, anyone can help please? 1 reply

Attachments: BoxFibo indicator acting weird, can anyone help?
Exit Attachments

BoxFibo indicator acting weird, can anyone help?

  • #1
  • First Post: Feb 16, 2010 10:29pm Feb 16, 2010 10:29pm
My BoxFibo indicator is acting weird, can anyone help? If it sits on the chart for a while the box will disappear and it look like it redraws the lines a second time right over the first one. Any coders out see anything funky in the code? Any help is appreciate since I'm a coding noob.
Attached File(s)
File Type: mq4 BoxFibo 2.mq4   4 KB | 544 downloads
  • #2
  • Feb 17, 2010 9:47pm Feb 17, 2010 9:47pm
Is there no one to even look at it? C'mon now, I thought we had coding wizards all over the place here?
  • #3
  • Feb 19, 2010 8:08pm Feb 19, 2010 8:08pm
Wow, responses to almost every other thread except this one? C'mon guys, You can't tell me there isn't a competent coder on this whole site that can figure out the problem here, really?
  • #4
  • Feb 19, 2010 11:44pm Feb 19, 2010 11:44pm
hi mer,

it's quite hard to figure out what you want to achive with your fibs, i assume you want to draw fib based on the highest/lowest form time 05.00 - 08.15 every day

after make some correction to your fibs indicator, i get result shown at screenshot below.
Attached Image (click to enlarge)
Click to Enlarge Name: fib_ind.gif Size: 20 KB
  • #5
  • Feb 20, 2010 11:07am Feb 20, 2010 11:07am
Sangmane, what corrections did you make? The only issue I'm having is that the indicator draws everything perfect when placed on the chart, but after a few minutes it looks like the indicator draws the lines again right over the top of the original lines (it almost looks blurry) and also the box will disappear. That is the only problem I'm having, but I'm no coder by any means and don't know how or what needs to be fixed. The lines are set at certain fib levels and do not need changing.
  • #6
  • Feb 20, 2010 11:14pm Feb 20, 2010 11:14pm
take a look at the fibs indy below. it's based on your fibs with some minor corrections.
Attached File(s)
File Type: mq4 BoxFibo 2_1.mq4   4 KB | 515 downloads
  • #7
  • Feb 21, 2010 8:26pm Feb 21, 2010 8:26pm
Thanks, I'll test it out this week.
  • #8
  • Feb 22, 2010 7:22pm Feb 22, 2010 7:22pm
Hey sangmane, the indicator works great except for one small problem. If I use it on a broker with Sunday candles, it draws the levels even though it's not in the time range like it normally is, any ideas? (see pic)
Attached Image (click to enlarge)
Click to Enlarge Name: pic2.jpg Size: 108 KB
  • #9
  • Feb 23, 2010 7:46am Feb 23, 2010 7:46am
Inserted Code
    datetime thistime = Time[i];  
    datetime dt2 = StrToTime(TimeToStr(Time[i],TIME_DATE) + " "  + EndTime);
    datetime dt1 = StrToTime(TimeToStr(Time[i],TIME_DATE) + " "  + StartTime);    
    if(thistime < dt2) continue;
    //add the single line below/////////////
    [b]if(TimeDayOfWeek(dt1)==0) continue;[/b] //TimeDayOfWeek of Sunday = 0, Monday = 1, etc.
    //////////////////////////////////////////
    string objname = "BF-Box-"+dt2;
    if(ObjectFind(objname)!=-1) continue;
Let me know if it solved that small problems.
  • #10
  • Feb 23, 2010 4:37pm Feb 23, 2010 4:37pm
Yeah that worked, thanks. Another question, is there any way to make length of the lines the same for each day? Right now, if the high/low of the box is within a couple of candles, the lines are real short, and vice-versa, if the high/low of the box is farther apart the line are longer. Can we make where the lines are drawn based on the box size and not where the high and lows are made?
  • #11
  • Feb 24, 2010 5:28am Feb 24, 2010 5:28am
hi mer,

to make Fib lines drawn based on box length, change this
PHP Code
ObjectCreate(objname,OBJ_FIBO,0,MathMin(Time[tlow],Time[thigh]),pt1,MathMax(Time[tlow],Time[thigh]),pt2);
to
PHP Code
ObjectCreate(objname,OBJ_FIBO,0,dt1,pt1,dt2,pt2);
or if you want an adjustable length of lines, use this instead:
PHP Code
ObjectCreate(objname,OBJ_FIBO,0,dt1,pt1,Time[ib1-FibLength],pt2);
and define additional external params:
PHP Code
extern int FibLength=2; //Fib swing will be drawn from left box to 2 bars after that
this last tweak give us the ability to display Fib level lines as short as possible without alter the level of those lines themself

Oh yes, modding this indy has become more and more interesting...
  • #12
  • Feb 25, 2010 2:37am Feb 25, 2010 2:37am
I'm glad you you're having fun with it! I do appreciate the help. I've attached a pic showing the final modifications that I've made. That last piece of code to adjust the lines length was just what I needed. Now I can back the lines right up to the next day's box, awesome!

Now the question is, are you up for doing an EA for this?
Attached Image (click to enlarge)
Click to Enlarge Name: pic2.jpg Size: 111 KB
Attached File(s)
File Type: mq4 BoxFibo 2_1.mq4   5 KB | 743 downloads
  • #13
  • Last Post: Jul 3, 2019 3:03pm Jul 3, 2019 3:03pm
Quoting sangmane
hi mer, to make Fib lines drawn based on box length, change this ObjectCreate(objname,OBJ_FIBO,0,MathMin(Time[tlow],Time[thigh]),pt1,MathMax(Time[tlow],Time[thigh]),pt2); to ObjectCreate(objname,OBJ_FIBO,0,dt1,pt1,dt2,pt2); or if you want an adjustable length of lines, use this instead: ObjectCreate(objname,OBJ_FIBO,0,dt1,pt1,Time[ib1-FibLength],pt2);and define additional external params: extern int FibLength=2; //Fib swing will be drawn from left box to 2 bars after thatthis last tweak give us the ability to display Fib level lines as short as...
Hi Sangmane, are you still here?
0 traders viewing now