Help, find biggest and second biggest order lot

   double biggest_lot=0;   // biggest order Lot
   double second_biggest_lot=0; // second biggest order Lot
// Find the biggest and second biggest order Lot
double biggest_vol(){
   for(int i=0; i <= OrdersTotal(); i++)
  {
      if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)){
      string ordSym=OrderSymbol();
      double ordLot=OrderLots();
      int ordMag=OrderMagicNumber();
         Sleep(300);
         if(ordSym==Symbol())
         {
              if(biggest_lot <ordLot)
            //  second_biggest_lot= biggest_lot;
              biggest_lot = ordLot;
              biggest_lot = NormalizeDouble(biggest_lot,2);
              RefreshRates();
             /* second_biggest_lot=NormalizeDouble(second_biggest_lot,2);
              biggest_lot=NormalizeDouble(biggest_lot,2); */
         }
 
     }
  }
return(biggest_lot);
}
 
 
// Find the biggest and second biggest order Lot
double second_biggest_vol(){
   for(int i=0; i <= OrdersTotal(); i++)
  {
      if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)){
      string ordSym=OrderSymbol();
      double ordLot=OrderLots();
      int ordMag=OrderMagicNumber();
         Sleep(300);
         if(ordSym==Symbol())
         {
              if(second_biggest_lot <ordLot)
              if(ordLot != biggest_lot)
 
              second_biggest_lot = ordLot;
              second_biggest_lot = NormalizeDouble(second_biggest_lot,2);
              RefreshRates();
             /* second_biggest_lot=NormalizeDouble(second_biggest_lot,2);
              biggest_lot=NormalizeDouble(biggest_lot,2); */
         }
          
     }
  }
return(second_biggest_lot);
 
}

void OnTick()
  {
//---
 
      biggest_vol();
      second_biggest_vol();
      Print(" second_biggest_lot: ",second_biggest_lot);
                Print(" biggest_lot: ",biggest_lot);
  }

Quoting will.cyan259

Disliked

Hi everyone, I am a beginner coder. I have no programming background. Everything I try to self-study. I want to pick up the order that have biggest and second biggest volume to keep track its profit. Can anyone help me? double biggest_lot=0; // biggest order Lot double second_biggest_lot=0; // second biggest order Lot // Find the biggest and second biggest order Lot double biggest_vol(){ for(int i=0; i <= OrdersTotal(); i++) { if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)){ string ordSym=OrderSymbol(); double ordLot=OrderLots(); int ordMag=OrderMagicNumber();...

Ignored

void LotSizes(){
  double biggest=0,second=0;
  for(int ord=OrdersTotal()-1;ord>=0;ord--){
   if(OrderSelect(ord,SELECT_BY_POS,MODE_TRADES))
    if(OrderSymbol()==Symbol()){
     if(OrderLots()>biggest){
      biggest=OrderLots();
      continue;}
     if(OrderLots()>second)second=OrderLots();}}
  Print("biggest "+DoubleToString(biggest,2));
  Print("second biggest "+DoubleToString(second,2));}

Quoting Beerrun

Disliked

{quote} You could try this, it might do what you want void LotSizes(){ double biggest=0,second=0; for(int ord=OrdersTotal();ord>=0;ord--){ if(OrderSelect(ord,SELECT_BY_POS,MODE_TRADES)) if(OrderSymbol()==Symbol()){ if(OrderLots()>biggest){ biggest=OrderLots(); continue;} if(OrderLots()>second)second=OrderLots();}} Print("biggest "+DoubleToString(biggest,2)); Print("second biggest "+DoubleToString(second,2));}

Ignored

Quoting will.cyan259

Disliked

{quote} Hi Beerrun, It works perfectly. Appreciated. However, I see it lagg update when I insert the order between the sequence, sometimes. For example, I have sequence of 0.01 - 0.02 -0.03 -0.04 - 0.05: biggest = 0.05/second = 0.04 - if I delete 0.04 => 0.01 -0.02 -0.03 -0.05: biggest = 0.05, second = 0.03 (work immediately, perfect) - then I insert 0.04 => 0.01 - 0.02 -0.03 -0.04 - 0.05: but it keeps 0.05/0.03 for awhile even tick data changed, then it updates the result biggest = 0.05/second = 0.04. Do you know what make it lagg update? How can...

Ignored

Quoting Beerrun

Disliked

{quote} Sorry there is a small error in the loop, it is stuck in the loop. Add a "-1" after orders total. for(int ord=OrdersTotal()-1;ord>=0;ord--)

Ignored

Quoting Beerrun

Disliked

{quote} Sorry there is a small error in the loop, it is stuck in the loop. Add a "-1" after orders total. for(int ord=OrdersTotal()-1;ord>=0;ord--)

Ignored

Quoting will.cyan259

Disliked

{quote} Hi Beerrun, this code is also counting the pending order. How can we make it count only the open trade order only? and I do not understand what different between int ord=OrdersTotal()-1 and without "-1". Thank you

Ignored

if(OrderSymbol()==Symbol() && OrderType() <= 1)

int ord=OrdersTotal()-1 and without "-1

Quoting will.cyan259

Disliked

{quote} Hi, for counting open trade order only, I add if(OrderSymbol()==Symbol() && OrderType() <= 1)

Ignored

Quote

Disliked

Still confuse about your int ord=OrdersTotal()-1 and without "-1 Cheers,

Quoting Beerrun

Disliked

{quote} Yes add that line for only counting open market orders {quote} Counting orders starts at 1 but the order positions begin at 0. We are looping through their positions with "SELECT_BY_POS". Example: if you had 5 orders, they would fill positions 0,1,2,3,4. If you did not include the "-1" then the last position it checks wouldn't exist, so it would be stuck in the loop and mt4 would timeout it after a while; that is why you see lag.

Ignored

void OnTick()
  {
//---
   if(IsTesting()){RefreshRates();

Quoting will.cyan259

Disliked

{quote} Hi Beerrun, My EA almost done. when I study in the reference code, I see the coder put the function void OnTick() { //--- if(IsTesting()){RefreshRates(); Do you know what is the purpose of the function IsTesting(), does it work only on tester or something like this, or I misunderstood this function, the explaination in MQL4 is not clear. {image}

Ignored

Quoting Beerrun

Disliked

{quote} The function IsTesting() is used to signal a program is being used in the strategy tester. I cannot see the rest of the code inside the {}, but if your entire OnTick code is enclosed in that if statement {}, then it will not work on live charts.

Ignored

void OnTick()
  {
//---
   if(IsTesting()){
      RefreshRates();
      
      if(IsNewCandle()){trade=1;}
      if(WorkingHour())FindSignal();
      if(StopLoss>0 && allProfit()<0 && MathAbs(allProfit())>StopLoss){
         CLOSEALL();
      }
      if(TotalOpenOrders() <= Max_order_Martingale)
      {
         hedge();
      }
      closeProfit();
      //Moving_BE(); v4 test sau
      if(OpenOrders()>0 && OpenTrades()==0){CLOSEALL();}
      
      double totProfit=NormalizeDouble(totalProfitPct(),2);
      Comment("Total Profit: ",totProfit);
   }
  }
  
double allProfit(){
   double ftotal=0;
   for(int i=OrdersTotal()-1; i >= 0; i--)
  {
      if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)){
      int ordMag=OrderMagicNumber();
         if(OrderSymbol()==Symbol()){
            //if(BasketClose==Fixed_TP){
            ftotal+=OrderProfit();  
            
            }
         }
     }
ftotal=NormalizeDouble(ftotal,Digits);
return(ftotal);
}
//+------------------------------------------------------------------+
void OnTimer()
  {
 
   if(!IsTesting()){
   RefreshRates();
   if(IsNewCandle()){trade=1;}
   if(WorkingHour())FindSignal();
   if(OpenOrders()>0 && OpenTrades()==0){CLOSEALL();}
   if(OpenTrades() <= Max_order_Martingale)
   {
      hedge();
   }  
   closeProfit();
   if(StopLoss>0 && allProfit()<0 && MathAbs(allProfit())>StopLoss){
         CLOSEALL();
      }
  
   double totProfit=NormalizeDouble(totalProfitPct(),2);
   Comment("Total Profit: ",totProfit);
    }
}

Quoting will.cyan259

Disliked

{quote} OMG, this is the entire OnTick code, void OnTick() { //--- if(IsTesting()){ RefreshRates(); if(IsNewCandle()){trade=1;} if(WorkingHour())FindSignal(); if(StopLoss>0 && allProfit()<0 && MathAbs(allProfit())>StopLoss){ CLOSEALL(); } if(TotalOpenOrders() <= Max_order_Martingale) { hedge(); } closeProfit(); //Moving_BE(); v4 test sau if(OpenOrders()>0 && OpenTrades()==0){CLOSEALL();} double totProfit=NormalizeDouble(totalProfitPct(),2); Comment("Total Profit: ",totProfit); } } double allProfit(){ double ftotal=0; for(int i=OrdersTotal()-1; i...

Ignored

Quoting Beerrun

Disliked

{quote} I don't think he was tricking you. Both code sections are very similar. if(IsTesting()) means if testing is true if(!IsTesting()) means if testing is false So it looks like it is setup to run the OnTimer() section when using live charts and the OnTick() in the tester. Which is good since OnTimer() does not always work properly in the tester.

Ignored

Quoting will.cyan259

Disliked

{quote} Good to hear that, also 1 more useful experience for me. Thank you, Beerrun ^^

Ignored