Boolean help, getting wrong outcome | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Anyone getting cashback from XTB? How much are you getting? 1 reply

Flow of Boolean Logic (for MT4) 5 replies

help, help, help (templates) 5 replies

Can arrays be boolean variables? 2 replies

Attachments: Boolean help, getting wrong outcome
Exit Attachments

Boolean help, getting wrong outcome

  • #1
  • First Post: Dec 25, 2018 10:08pm Dec 25, 2018 10:08pm
Hello Everyone,

I have been trying to write an EA but keep getting a false on a boolean when it should be giving me a true. Could someone please help me out with finding the problem. Ive tried everything and even doing it manually but haven't been able to find the problem.

Channel_Period is an external value which at the moment im using 20 for this test.

This is for shorting. Im using the exact same code (only with "<=", and buffer "1") for the long part and it works fine.

The code:
Inserted Code
bool DC_Low_Ascending     =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,1) >=
                             iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,2) >=
                             iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,3) >=
                             iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,4) >=
                             iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,5) >=
                             iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,6) >=
                             iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,7) >=
                             iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,8) >=
                             iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,9) >=
                             iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,10) >=
                             iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,11) >=
                             iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,12) >=
                             iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,13) >=
                             iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,14) >=
                             iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,15) >=
                             iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,16) >=
                             iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,17) >=
                             iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,18) >=
                             iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,19);

Thank you!
Attached File(s)
File Type: mq4 Donchian Channels - Generalized version.mq4   7 KB | 462 downloads
  • #2
  • Dec 26, 2018 12:45am Dec 26, 2018 12:45am
wrong threat!
But, the buffer return a price level, to convert it to boolean:
if(iCustom (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,1) >=iCustom (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,5)) return (true);

it means if the 5th buffer is lower like the 1th buffer return true value.
  • #3
  • Dec 26, 2018 3:47am Dec 26, 2018 3:47am
Quoting Beertje
wrong threat! But, the buffer return a price level, to convert it to boolean: if(iCustom (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,1) >=iCustom (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,5)) return (true); it means if the 5th buffer is lower like the 1th buffer return true value.
With all due respect, you are wrong ... A boolean can perfectly be written like this:

Inserted Code
bool valid = 1 > 2;
return(valid);

In the example above, the returned is false.
MT4/MT5 EAs/Indicators/Alerts coder
  • #4
  • Dec 26, 2018 5:18am Dec 26, 2018 5:18am
Quoting Ernie11
Hello Everyone,
//-----

hey ernie..... that code returns true for me.....h
to trade and code, keep both simple... no call to impress....h
  • #5
  • Dec 26, 2018 12:35pm Dec 26, 2018 12:35pm
Quoting Ernie11
...Could someone please help me out with finding the problem...
Your code can not work because the compiler doesn't know your operator precedence intentions.
While you can write something like this:
Inserted Code
bool result = a < b;
you cannot write something like this:
Inserted Code
bool result = a < b < c < d;
In both cases the compiler will accept the code but the second case will give wrong results depending on the current values of the operands. If you use more than two operands like that you need to use brackets to tell the compiler your precedence rules like so:
Inserted Code
bool result = (a < b) < (c < d);
It takes blood, sweat and enough tears to wash away the blood.
  • #6
  • Dec 26, 2018 2:49pm Dec 26, 2018 2:49pm
This logic can be broken down using functions and loops...

Inserted Code
bool dc_low_ascending()
{
   for(int i=1; i<19; i++) 
      if(donchian(i) < donchian(i + 1))
         return false;
   return true;
}
double donchian(int index)
{
   return iCustom(Symbol(), timeframe,
      "Donchian Channels - Generalized version", 
      channel_period, 1, 0, 0, 700, 0, index
   );
}
  • #7
  • Dec 26, 2018 4:13pm Dec 26, 2018 4:13pm
Inserted Code
bool result = 5 > 4 > 3;
The value of result will be false.

The first part is evaluated: 5 > 4.
The result is true (a value of 1)
Then it evaluates the second part: 1 > 3.
The result is false.

Inserted Code
   result = 5 > 4 > 3;
   result = (5 > 4) > 3;    
   result = (true) > 3;
   result = (1) > 3;
The correct way to write it:
Inserted Code
bool result = 5 > 4 && 4 > 3;
  • #8
  • Edited 1:55am Jan 6, 2019 1:38am | Edited 1:55am
Hello,

Sorry for the late reply.

Im trying to go down the loop route but I get 6 errors and 2 warnings when I tried to compile. What am I doing wrong?

Errors:
'DC_High_Descending' - function can be declared only in the global scope
'Donchian_High' - function can be declared only in the global scope
'DC_Low_Ascending' - function can be declared only in the global scope
'Donchian_Low' - function can be declared only in the global scope
'DC_High_Descending' - function call missing, open parenthesis expected
'DC_Low_Ascending' - function call missing, open parenthesis expected

Warnings:
expression not boolean (two times)

Inserted Code
bool DC_High_Descending() {
   for(int i=1; i<(Channel_Period-1); i++)
      if(Donchian_High(i) > Donchian_High(i + 1))
         return false;
   return true;
}
double Donchian_High(int index) {
   return iCustom(Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,1,index);
}
 
bool DC_Low_Ascending() {
   for(int i=1; i<(Channel_Period-1); i++)
      if(Donchian_Low(i) < Donchian_Low(i + 1))
         return false;
   return true;
}
double Donchian_Low(int index) {
   return iCustom(Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,index);
}
  • #9
  • Jan 6, 2019 8:15am Jan 6, 2019 8:15am
Quoting Ernie11
Hello, Sorry for the late reply.
//------

hey ernie...... it's likely cascading errors..... often the error reported is not the true error...... there are several errors in the code you provided this time.....

"return false" should be return(false) ..... really need to see the entire mq4 other wise we just keep guessing..... we have no idea what your trying to do......

//-----

in regards to your original post, your code returned true for me..... and that should not be all to surprising.....

while it's not something i would do under any circumstance, (a >= b >= c >= d >= e >= f) can return the correct answer..... it's easy to envision ideas where it would always return the correct answer......

but as a rule, it's bad code form...h
to trade and code, keep both simple... no call to impress....h
  • #10
  • Jan 6, 2019 4:36pm Jan 6, 2019 4:36pm
Hello,

Below is my code. I tried to add the () around the false and true but still doesnt compile.

Inserted Code
extern double Risk_Percent = 0.02;
input ENUM_TIMEFRAMES TimeFrame = PERIOD_M15;
extern int Channel_Period = 20;
extern double Scale_Ratio = 1;
extern double Start_Trailing_Stop_Percent = 0.03;
extern double Trailing_Stop = 0.03;
extern int Magic_Number = 1000;
 
int Buy_Order,Sell_Order,getOpenOrders,Buy_Order_2,Sell_Order_2,Buy_Order_3,Sell_Order_3;
datetime bartime=0;
color LineClr=Orange;
bool DrawLine=FALSE;
string action,sObjName;
double Stop_Loss_Long_Transfer;
double Stop_Loss_Short_Transfer;
//global
double Poin;
//+------------------------------------------------------------------+
//| Expert initialization function                                   |
//+------------------------------------------------------------------+
int OnInit()
  {
//---
if (Point == 0.00001) Poin = 0.0001;
else if (Point == 0.001) Poin = 0.01;
else Poin = Point;
//---
   return(INIT_SUCCEEDED);
  }
int getOpenOrders(){
   int liOrders = 0;
   for (int i = 0; i < OrdersTotal(); i++){
     if (OrderSelect(i, SELECT_BY_POS, MODE_TRADES) == false){
       continue;
     }
     if (OrderSymbol() != Symbol() || OrderMagicNumber() != Magic_Number){
       continue;
     }
     liOrders++;
   }
   return(liOrders);
}
//+------------------------------------------------------------------+
//| Expert tick function                                             |
//+------------------------------------------------------------------+
void OnTick() {
//---
//Donchian Channel Entry//
bool DC_High_Descending() {
   for(int i=1; i<(Channel_Period-1); i++)
      if(Donchian_High(i) > Donchian_High(i + 1))
         return(false);
   return(true);
}
double Donchian_High(int index) {
   return iCustom(Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,1,index);
}
bool DC_Low_Ascending() {
   for(int i=1; i<(Channel_Period-1); i++)
      if(Donchian_Low(i) < Donchian_Low(i + 1))
         return(false);
   return(true);
}
double Donchian_Low(int index) {
   return iCustom(Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,index);
}
 
 
double DC_High_Current    =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,1,0);
/*
double DC_High_1_Shift    =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,1,1);
double DC_High_2_Shift    =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,1,2);
double DC_High_3_Shift    =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,1,3);
double DC_High_4_Shift    =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,1,4);
double DC_High_5_Shift    =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,1,5);
double DC_High_6_Shift    =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,1,6);
double DC_High_7_Shift    =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,1,7);
double DC_High_8_Shift    =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,1,8);
double DC_High_9_Shift    =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,1,9);
double DC_High_10_Shift   =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,1,10);
double DC_High_11_Shift   =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,1,11);
double DC_High_12_Shift   =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,1,12);
double DC_High_13_Shift   =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,1,13);
double DC_High_14_Shift   =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,1,14);
double DC_High_15_Shift   =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,1,15);
double DC_High_16_Shift   =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,1,16);
double DC_High_17_Shift   =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,1,17);
double DC_High_18_Shift   =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,1,18);
double DC_High_19_Shift   =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,1,19);
*/
double DC_Low_Current     =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,0);
/*
double DC_Low_1_Shift     =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,1);
double DC_Low_2_Shift     =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,2);
double DC_Low_3_Shift     =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,3);
double DC_Low_4_Shift     =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,4);
double DC_Low_5_Shift     =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,5);
double DC_Low_6_Shift     =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,6);
double DC_Low_7_Shift     =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,7);
double DC_Low_8_Shift     =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,8);
double DC_Low_9_Shift     =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,9);
double DC_Low_10_Shift    =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,10);
double DC_Low_11_Shift    =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,11);
double DC_Low_12_Shift    =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,12);
double DC_Low_13_Shift    =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,13);
double DC_Low_14_Shift    =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,14);
double DC_Low_15_Shift    =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,15);
double DC_Low_16_Shift    =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,16);
double DC_Low_17_Shift    =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,17);
double DC_Low_18_Shift    =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,18);
double DC_Low_19_Shift    =  iCustom   (Symbol(),TimeFrame,"Donchian Channels - Generalized version",Channel_Period,1,0,0,700,0,19);                    
*/
 
//Money Management//
double Stop_Loss_Long     =  (Ask - DC_Low_Current);
double Stop_Loss_Short    =  (DC_High_Current - Bid);
 
//Buy Logic 1//
if (bartime!=Time[0]) {
   if (getOpenOrders() == 0) {
      if ((DC_High_Descending) && (DC_High_Current < Bid)) {
         Buy_Order = OrderSend(Symbol(),OP_BUY,NormalizeDouble(((AccountEquity()*(Risk_Percent))/((Stop_Loss_Long*100000)*(MarketInfo(Symbol(),MODE_TICKVALUE)))),2),Ask,30,DC_Low_Current,(Ask+(Stop_Loss_Long*10)),"Long - "+TimeFrame,Magic_Number,0,clrGreen);
         sObjName="buyline"+IntegerToString(Time[0]);
            ObjectCreate(sObjName,OBJ_VLINE,0,Time[0],0);
               ObjectSet(sObjName,OBJPROP_WIDTH,1);
               ObjectSet(sObjName,OBJPROP_STYLE,STYLE_DOT);
               ObjectSet(sObjName,OBJPROP_BACK,TRUE);
               ObjectSet(sObjName,OBJPROP_COLOR,clrGreen);
         bartime=Time[0];
         Stop_Loss_Long_Transfer = Stop_Loss_Long;
      }
   }
}
//Buy Logic 2//
if (getOpenOrders() == 1) {
   if (OrderSelect(Buy_Order,SELECT_BY_TICKET,MODE_TRADES)) {
      if ((OrderType() == OP_BUY) && ((OrderOpenPrice()+(Stop_Loss_Long_Transfer*Scale_Ratio)) < Ask)) {
         Buy_Order_2 = OrderSend(Symbol(),OP_BUY,NormalizeDouble(((AccountEquity()*(Risk_Percent))/((Stop_Loss_Long*100000)*(MarketInfo(Symbol(),MODE_TICKVALUE)))),2),Ask,30,DC_Low_Current,0,"Long - "+TimeFrame,Magic_Number,0,clrGreen);
         sObjName="buyline"+IntegerToString(Time[0]);
            ObjectCreate(sObjName,OBJ_VLINE,0,Time[0],0);
               ObjectSet(sObjName,OBJPROP_WIDTH,1);
               ObjectSet(sObjName,OBJPROP_STYLE,STYLE_DOT);
               ObjectSet(sObjName,OBJPROP_BACK,TRUE);
               ObjectSet(sObjName,OBJPROP_COLOR,clrGreen);
      }
   }
}
//Buy Logic 3//
if (getOpenOrders() == 2) {
   if (OrderSelect(Buy_Order_2,SELECT_BY_TICKET,MODE_TRADES)) {
      if ((OrderType() == OP_BUY) && ((OrderOpenPrice()+(Stop_Loss_Long_Transfer*Scale_Ratio)) < Ask)) {
         Buy_Order_3 = OrderSend(Symbol(),OP_BUY,NormalizeDouble(((AccountEquity()*(Risk_Percent))/((Stop_Loss_Long*100000)*(MarketInfo(Symbol(),MODE_TICKVALUE)))),2),Ask,30,DC_Low_Current,0,"Long - "+TimeFrame,Magic_Number,0,clrGreen);
         sObjName="buyline"+IntegerToString(Time[0]);
            ObjectCreate(sObjName,OBJ_VLINE,0,Time[0],0);
               ObjectSet(sObjName,OBJPROP_WIDTH,1);
               ObjectSet(sObjName,OBJPROP_STYLE,STYLE_DOT);
               ObjectSet(sObjName,OBJPROP_BACK,TRUE);
               ObjectSet(sObjName,OBJPROP_COLOR,clrGreen);
      }
   }
}
/*
//Modify Buy Logic//
if (getOpenOrders() > 0) {
   if (OrderSelect(Buy_Order,SELECT_BY_TICKET,MODE_TRADES)) {
      if ((OrderOpenPrice() + (Stop_Loss_Long_Transfer*3)) > Ask) {
         if (DC_Low_Current > DC_Low_1_Shift) {OrderModify(Buy_Order,OrderOpenPrice(),DC_Low_Current,OrderTakeProfit(),0,clrYellow);
            if (getOpenOrders() >= 2) {OrderModify(Buy_Order_2,OrderOpenPrice(),DC_Low_Current,OrderTakeProfit(),0,clrYellow);}
            if (getOpenOrders() >= 3) {OrderModify(Buy_Order_3,OrderOpenPrice(),DC_Low_Current,OrderTakeProfit(),0,clrYellow);}
         }
      }
      if (((OrderOpenPrice() + (Stop_Loss_Long_Transfer*3)) < Ask) && ((OrderOpenPrice() + (Stop_Loss_Long_Transfer*5)) > Ask)) {
         if ((((DC_High_2_Shift - DC_Low_2_Shift)/2) + DC_Low_2_Shift) < (((DC_High_1_Shift - DC_Low_1_Shift)/2) + DC_Low_1_Shift)) {
            OrderModify(Buy_Order,OrderOpenPrice(),((DC_High_1_Shift - DC_Low_1_Shift)/2) + DC_Low_1_Shift,OrderTakeProfit(),0,clrYellow);
            OrderModify(Buy_Order_2,OrderOpenPrice(),((DC_High_1_Shift - DC_Low_1_Shift)/2) + DC_Low_1_Shift,OrderTakeProfit(),0,clrYellow);            
            OrderModify(Buy_Order_3,OrderOpenPrice(),((DC_High_1_Shift - DC_Low_1_Shift)/2) + DC_Low_1_Shift,OrderTakeProfit(),0,clrYellow);
         }
      }
      
      if (((OrderOpenPrice() + (Stop_Loss_Long_Transfer*5)) < Ask)) {
         if ((((DC_High_2_Shift - DC_Low_2_Shift)*0.75) + DC_Low_2_Shift) < (((DC_High_1_Shift - DC_Low_1_Shift)*0.75) + DC_Low_1_Shift)) {
            OrderModify(Buy_Order,OrderOpenPrice(),((DC_High_1_Shift - DC_Low_1_Shift)*0.75) + DC_Low_1_Shift,OrderTakeProfit(),0,clrYellow);
            OrderModify(Buy_Order_2,OrderOpenPrice(),((DC_High_1_Shift - DC_Low_1_Shift)*0.75) + DC_Low_1_Shift,OrderTakeProfit(),0,clrYellow);
            OrderModify(Buy_Order_3,OrderOpenPrice(),((DC_High_1_Shift - DC_Low_1_Shift)*0.75) + DC_Low_1_Shift,OrderTakeProfit(),0,clrYellow);
         }
      }
   }
}
*/
 
//Sell Logic//
if (bartime!=Time[0]) {
   if (getOpenOrders() == 0) {
      if ((DC_Low_Ascending) && (DC_Low_Current > Bid)) {
         Sell_Order = OrderSend(Symbol(),OP_SELL,NormalizeDouble(((AccountEquity()*(Risk_Percent))/((Stop_Loss_Short*100000)*(MarketInfo(Symbol(),MODE_TICKVALUE)))),2),Bid,30,DC_High_Current,(Bid-(Stop_Loss_Short*10)),"Short - "+TimeFrame,Magic_Number,0,clrRed);
         sObjName="buyline"+IntegerToString(Time[0]);
            ObjectCreate(sObjName,OBJ_VLINE,0,Time[0],0);
               ObjectSet(sObjName,OBJPROP_WIDTH,1);
               ObjectSet(sObjName,OBJPROP_STYLE,STYLE_DOT);
               ObjectSet(sObjName,OBJPROP_BACK,TRUE);
               ObjectSet(sObjName,OBJPROP_COLOR,clrRed);
         bartime=Time[0];
         Stop_Loss_Short_Transfer = Stop_Loss_Short;
      }
   }
}
//Sell Logic 2//
if (getOpenOrders() == 1) {
   if (OrderSelect(Sell_Order,SELECT_BY_TICKET,MODE_TRADES)) {
      if ((OrderType() == OP_SELL) && ((OrderOpenPrice()-(Stop_Loss_Short_Transfer*Scale_Ratio)) > Bid)) {
         Sell_Order_2 = OrderSend(Symbol(),OP_SELL,NormalizeDouble(((AccountEquity()*(Risk_Percent))/((Stop_Loss_Short*100000)*(MarketInfo(Symbol(),MODE_TICKVALUE)))),2),Bid,30,DC_High_Current,0,"Short - "+TimeFrame,Magic_Number,0,clrRed);
         sObjName="buyline"+IntegerToString(Time[0]);
            ObjectCreate(sObjName,OBJ_VLINE,0,Time[0],0);
               ObjectSet(sObjName,OBJPROP_WIDTH,1);
               ObjectSet(sObjName,OBJPROP_STYLE,STYLE_DOT);
               ObjectSet(sObjName,OBJPROP_BACK,TRUE);
               ObjectSet(sObjName,OBJPROP_COLOR,clrRed);
      }
   }
}
//Sell Logic 3//
if (getOpenOrders() == 2) {
   if (OrderSelect(Sell_Order_2,SELECT_BY_TICKET,MODE_TRADES)) {
      if ((OrderType() == OP_SELL) && ((OrderOpenPrice()+(Stop_Loss_Short_Transfer*Scale_Ratio)) < Ask)) {
         Sell_Order_3 = OrderSend(Symbol(),OP_SELL,NormalizeDouble(((AccountEquity()*(Risk_Percent))/((Stop_Loss_Short*100000)*(MarketInfo(Symbol(),MODE_TICKVALUE)))),2),Bid,30,DC_High_Current,0,"Short - "+TimeFrame,Magic_Number,0,clrRed);
         sObjName="buyline"+IntegerToString(Time[0]);
            ObjectCreate(sObjName,OBJ_VLINE,0,Time[0],0);
               ObjectSet(sObjName,OBJPROP_WIDTH,1);
               ObjectSet(sObjName,OBJPROP_STYLE,STYLE_DOT);
               ObjectSet(sObjName,OBJPROP_BACK,TRUE);
               ObjectSet(sObjName,OBJPROP_COLOR,clrRed);
      }
   }
}
/*
//Modify Sell Logic//
if (getOpenOrders() > 0) {
   if (OrderSelect(Sell_Order,SELECT_BY_TICKET,MODE_TRADES)) {
      if ((OrderOpenPrice() - (Stop_Loss_Short_Transfer*3)) < Bid) {
         if (DC_Low_Current > DC_Low_1_Shift) {OrderModify(Sell_Order,OrderOpenPrice(),DC_High_Current,OrderTakeProfit(),0,clrYellow);
            if (getOpenOrders() >= 2) {OrderModify(Sell_Order_2,OrderOpenPrice(),DC_High_Current,OrderTakeProfit(),0,clrYellow);}
            if (getOpenOrders() >= 3) {OrderModify(Sell_Order_3,OrderOpenPrice(),DC_High_Current,OrderTakeProfit(),0,clrYellow);}
         }
      }
      if (((OrderOpenPrice() - (Stop_Loss_Long_Transfer*3)) > Bid) && ((OrderOpenPrice() - (Stop_Loss_Long_Transfer*5)) < Bid)) {
         if ((DC_High_2_Shift - ((DC_High_2_Shift - DC_Low_2_Shift)/2)) > (DC_High_1_Shift - ((DC_High_1_Shift - DC_Low_1_Shift)/2))) {
            OrderModify(Sell_Order,OrderOpenPrice(),DC_High_1_Shift - ((DC_High_1_Shift - DC_Low_1_Shift)/2),OrderTakeProfit(),0,clrYellow);
            OrderModify(Sell_Order_2,OrderOpenPrice(),DC_High_1_Shift - ((DC_High_1_Shift - DC_Low_1_Shift)/2),OrderTakeProfit(),0,clrYellow);            
            OrderModify(Sell_Order_3,OrderOpenPrice(),DC_High_1_Shift - ((DC_High_1_Shift - DC_Low_1_Shift)/2),OrderTakeProfit(),0,clrYellow);
         }
      }
      
      if (((OrderOpenPrice() - (Stop_Loss_Long_Transfer*5)) > Bid)) {
         if ((DC_High_2_Shift - ((DC_High_2_Shift - DC_Low_2_Shift)*0.25)) < (DC_High_1_Shift - ((DC_High_1_Shift - DC_Low_1_Shift)*0.25))) {
            OrderModify(Sell_Order,OrderOpenPrice(),DC_High_1_Shift - ((DC_High_1_Shift - DC_Low_1_Shift)*0.25),OrderTakeProfit(),0,clrYellow);
            OrderModify(Sell_Order_2,OrderOpenPrice(),DC_High_1_Shift - ((DC_High_1_Shift - DC_Low_1_Shift)*0.25),OrderTakeProfit(),0,clrYellow);
            OrderModify(Sell_Order_3,OrderOpenPrice(),DC_High_1_Shift - ((DC_High_1_Shift - DC_Low_1_Shift)*0.25),OrderTakeProfit(),0,clrYellow);
         }
      }
   }
}
*/
//Trailing Stop Trigger//
if (OrdersTotal() > 0) {
   if (Trailing_Stop != 0) {
      TrailingControl();
   }
}
 
}
 
void TrailingControl(){
 
//string TimeNow=TimeToStr(Time[1],TIME_DATE|TIME_SECONDS);
 int cnt,result=0;
 int total=OrdersTotal();
 double BEPrice;
for(cnt=0;cnt<total;cnt++){    
 if(OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES)==TRUE){
 if(OrderMagicNumber() && OrderSymbol()==Symbol()){
 double OOP=OrderOpenPrice();
 double OTP=OrderTakeProfit();
 double OSL=OrderStopLoss();
 
//buy
if(OrderType()==OP_BUY){
   BEPrice=(OOP+(OTP-OOP)*Start_Trailing_Stop_Percent);
   if(Bid >= BEPrice){
      if(OrderStopLoss()<Bid-((OTP-OOP)*Trailing_Stop) || (OrderStopLoss()==0)){
         result = OrderModify(OrderTicket(),OOP,(Bid-((OTP-OOP)*Trailing_Stop)),OTP,0,Yellow);
      }
   }
}
 
//sell
else{
   BEPrice=(OOP-(OOP-OTP)*Start_Trailing_Stop_Percent);
   if(Ask <= BEPrice){
      if((OrderStopLoss()>Ask+((OOP-OTP)*Trailing_Stop)) || (OrderStopLoss()==0)){
         result=OrderModify(OrderTicket(),OOP,(Ask+((OOP-OTP)*Trailing_Stop)),OTP,0,Yellow);
      }
   }
}
}
}
}
}
  • #11
  • Jan 7, 2019 7:10am Jan 7, 2019 7:10am
Quoting Ernie11
Hello, Below is my code. I tried to add the () around the false and true but still doesnt compile. extern double Risk_Percent = 0.02; input ENUM_TIMEFRAMES TimeFrame = PERIOD_M15; extern int Channel_Period = 20; extern double Scale_Ratio = 1; extern double Start_Trailing_Stop_Percent = 0.03; extern double Trailing_Stop = 0.03; extern int Magic_Number = 1000; int Buy_Order,Sell_Order,getOpenOrders,Buy_Order_2,Sell_Order_2,Buy_Order_3,Sell_Order_3; datetime bartime=0; color LineClr=Orange; bool DrawLine=FALSE; string action,sObjName; double Stop_Loss_Long_Transfer;...
When you call a function, the caller() goes after the function name not around it. Also, the reason your code won't compile is because you are trying to define a function within a function which is an illegal syntax, and you need to move the functions to the global scope. In a production EA you would also need to limit your use of global variables. As it is you are storing ticket numbers directly in some global variables, but what happens when you accidentally change your chart, or your platform restarts, or computer crashes? Your EA needs to be able to "recover". A final piece of advice -- you might have a look at some C style guides. I know this sounds pedantic, but it's important to develop good coding habits early, and as you get better at programming you will realize the importance of good stylistic hygiene.

Inserted Code
extern double Risk_Percent = 0.02;
input ENUM_TIMEFRAMES TimeFrame = PERIOD_M15;
extern int Channel_Period = 20;
extern double Scale_Ratio = 1;
extern double Start_Trailing_Stop_Percent = 0.03;
extern double Trailing_Stop = 0.03;
extern int Magic_Number = 1000;
int Buy_Order, Sell_Order, getOpenOrders, Buy_Order_2, Sell_Order_2, Buy_Order_3, Sell_Order_3;
datetime bartime = 0;
color LineClr = Orange;
bool DrawLine = FALSE;
string action, sObjName;
double Stop_Loss_Long_Transfer;
double Stop_Loss_Short_Transfer;
//global
double _pip;
 
bool DC_High_Descending()
{
    for (int i = 1; i < (Channel_Period - 1); i++)
        if (Donchian_High(i) > Donchian_High(i + 1))
            return (false);
    return (true);
}
double Donchian_High(int index)
{
    return iCustom(Symbol(), TimeFrame, "Donchian Channels - Generalized version", Channel_Period, 1, 0, 0, 700, 1, index);
}
bool DC_Low_Ascending()
{
    for (int i = 1; i < (Channel_Period - 1); i++)
        if (Donchian_Low(i) < Donchian_Low(i + 1))
            return (false);
    return (true);
}
double Donchian_Low(int index)
{
    return iCustom(Symbol(), TimeFrame, "Donchian Channels - Generalized version", Channel_Period, 1, 0, 0, 700, 0, index);
}
//+------------------------------------------------------------------+
//| Expert initialization function                                   |
//+------------------------------------------------------------------+
int OnInit()
{
    //---
    if (Point == 0.00001)
        _pip = 0.0001;
    else if (Point == 0.001)
        _pip = 0.01;
    else
        _pip = Point;
    //---
    return (INIT_SUCCEEDED);
}
int getOpenOrders()
{
    int liOrders = 0;
    for (int i = 0; i < OrdersTotal(); i++)
    {
        if (OrderSelect(i, SELECT_BY_POS, MODE_TRADES) == false)
        {
            continue;
        }
        if (OrderSymbol() != Symbol() || OrderMagicNumber() != Magic_Number)
        {
            continue;
        }
        liOrders++;
    }
    return (liOrders);
}
//+------------------------------------------------------------------+
//| Expert tick function                                             |
//+------------------------------------------------------------------+
void OnTick()
{
    double DC_High_Current = Donchian_High(0);
    double DC_Low_Current = Donchian_Low(0);
    //Money Management//
    double Stop_Loss_Long = (Ask - DC_Low_Current);
    double Stop_Loss_Short = (DC_High_Current - Bid);
    //Buy Logic 1//
    int open_orders = getOpenOrders();
    if (bartime != Time[0])
    {
        if (open_orders == 0)
        {
            if (DC_High_Descending() && (DC_High_Current < Bid))
            {
                Buy_Order = OrderSend(Symbol(), OP_BUY, NormalizeDouble(((AccountEquity() * (Risk_Percent)) / ((Stop_Loss_Long * 100000) * (MarketInfo(Symbol(), MODE_TICKVALUE)))), 2), Ask, 30, DC_Low_Current, (Ask + (Stop_Loss_Long * 10)), "Long - " + TimeFrame, Magic_Number, 0, clrGreen);
                sObjName = "buyline" + IntegerToString(Time[0]);
                ObjectCreate(sObjName, OBJ_VLINE, 0, Time[0], 0);
                ObjectSet(sObjName, OBJPROP_WIDTH, 1);
                ObjectSet(sObjName, OBJPROP_STYLE, STYLE_DOT);
                ObjectSet(sObjName, OBJPROP_BACK, TRUE);
                ObjectSet(sObjName, OBJPROP_COLOR, clrGreen);
                bartime = Time[0];
                Stop_Loss_Long_Transfer = Stop_Loss_Long;
            }
        }
    }
    //Buy Logic 2//
    if (open_orders == 1)
    {
        if (OrderSelect(Buy_Order, SELECT_BY_TICKET, MODE_TRADES))
        {
            if ((OrderType() == OP_BUY) && ((OrderOpenPrice() + (Stop_Loss_Long_Transfer * Scale_Ratio)) < Ask))
            {
                Buy_Order_2 = OrderSend(Symbol(), OP_BUY, NormalizeDouble(((AccountEquity() * (Risk_Percent)) / ((Stop_Loss_Long * 100000) * (MarketInfo(Symbol(), MODE_TICKVALUE)))), 2), Ask, 30, DC_Low_Current, 0, "Long - " + TimeFrame, Magic_Number, 0, clrGreen);
                sObjName = "buyline" + IntegerToString(Time[0]);
                ObjectCreate(sObjName, OBJ_VLINE, 0, Time[0], 0);
                ObjectSet(sObjName, OBJPROP_WIDTH, 1);
                ObjectSet(sObjName, OBJPROP_STYLE, STYLE_DOT);
                ObjectSet(sObjName, OBJPROP_BACK, TRUE);
                ObjectSet(sObjName, OBJPROP_COLOR, clrGreen);
            }
        }
    }
    //Buy Logic 3//
    if (open_orders == 2)
    {
        if (OrderSelect(Buy_Order_2, SELECT_BY_TICKET, MODE_TRADES))
        {
            if ((OrderType() == OP_BUY) && ((OrderOpenPrice() + (Stop_Loss_Long_Transfer * Scale_Ratio)) < Ask))
            {
                Buy_Order_3 = OrderSend(Symbol(), OP_BUY, NormalizeDouble(((AccountEquity() * (Risk_Percent)) / ((Stop_Loss_Long * 100000) * (MarketInfo(Symbol(), MODE_TICKVALUE)))), 2), Ask, 30, DC_Low_Current, 0, "Long - " + TimeFrame, Magic_Number, 0, clrGreen);
                sObjName = "buyline" + IntegerToString(Time[0]);
                ObjectCreate(sObjName, OBJ_VLINE, 0, Time[0], 0);
                ObjectSet(sObjName, OBJPROP_WIDTH, 1);
                ObjectSet(sObjName, OBJPROP_STYLE, STYLE_DOT);
                ObjectSet(sObjName, OBJPROP_BACK, TRUE);
                ObjectSet(sObjName, OBJPROP_COLOR, clrGreen);
            }
        }
    }
    if (bartime != Time[0])
    {
        if (getOpenOrders() == 0)
        {
            if (DC_Low_Ascending() && (DC_Low_Current > Bid))
            {
                Sell_Order = OrderSend(Symbol(), OP_SELL, NormalizeDouble(((AccountEquity() * (Risk_Percent)) / ((Stop_Loss_Short * 100000) * (MarketInfo(Symbol(), MODE_TICKVALUE)))), 2), Bid, 30, DC_High_Current, (Bid - (Stop_Loss_Short * 10)), "Short - " + TimeFrame, Magic_Number, 0, clrRed);
                sObjName = "buyline" + IntegerToString(Time[0]);
                ObjectCreate(sObjName, OBJ_VLINE, 0, Time[0], 0);
                ObjectSet(sObjName, OBJPROP_WIDTH, 1);
                ObjectSet(sObjName, OBJPROP_STYLE, STYLE_DOT);
                ObjectSet(sObjName, OBJPROP_BACK, TRUE);
                ObjectSet(sObjName, OBJPROP_COLOR, clrRed);
                bartime = Time[0];
                Stop_Loss_Short_Transfer = Stop_Loss_Short;
            }
        }
    }
    //Sell Logic 2//
    if (getOpenOrders() == 1)
    {
        if (OrderSelect(Sell_Order, SELECT_BY_TICKET, MODE_TRADES))
        {
            if ((OrderType() == OP_SELL) && ((OrderOpenPrice() - (Stop_Loss_Short_Transfer * Scale_Ratio)) > Bid))
            {
                Sell_Order_2 = OrderSend(Symbol(), OP_SELL, NormalizeDouble(((AccountEquity() * (Risk_Percent)) / ((Stop_Loss_Short * 100000) * (MarketInfo(Symbol(), MODE_TICKVALUE)))), 2), Bid, 30, DC_High_Current, 0, "Short - " + TimeFrame, Magic_Number, 0, clrRed);
                sObjName = "buyline" + IntegerToString(Time[0]);
                ObjectCreate(sObjName, OBJ_VLINE, 0, Time[0], 0);
                ObjectSet(sObjName, OBJPROP_WIDTH, 1);
                ObjectSet(sObjName, OBJPROP_STYLE, STYLE_DOT);
                ObjectSet(sObjName, OBJPROP_BACK, TRUE);
                ObjectSet(sObjName, OBJPROP_COLOR, clrRed);
            }
        }
    }
    //Sell Logic 3//
    if (getOpenOrders() == 2)
    {
        if (OrderSelect(Sell_Order_2, SELECT_BY_TICKET, MODE_TRADES))
        {
            if ((OrderType() == OP_SELL) && ((OrderOpenPrice() + (Stop_Loss_Short_Transfer * Scale_Ratio)) < Ask))
            {
                Sell_Order_3 = OrderSend(Symbol(), OP_SELL, NormalizeDouble(((AccountEquity() * (Risk_Percent)) / ((Stop_Loss_Short * 100000) * (MarketInfo(Symbol(), MODE_TICKVALUE)))), 2), Bid, 30, DC_High_Current, 0, "Short - " + TimeFrame, Magic_Number, 0, clrRed);
                sObjName = "buyline" + IntegerToString(Time[0]);
                ObjectCreate(sObjName, OBJ_VLINE, 0, Time[0], 0);
                ObjectSet(sObjName, OBJPROP_WIDTH, 1);
                ObjectSet(sObjName, OBJPROP_STYLE, STYLE_DOT);
                ObjectSet(sObjName, OBJPROP_BACK, TRUE);
                ObjectSet(sObjName, OBJPROP_COLOR, clrRed);
            }
        }
    }
    //Trailing Stop Trigger//
    if (OrdersTotal() > 0)
    {
        if (Trailing_Stop != 0)
        {
            TrailingControl();
        }
    }
}
void TrailingControl()
{
    //string TimeNow=TimeToStr(Time[1],TIME_DATE|TIME_SECONDS);
    int cnt, result = 0;
    int total = OrdersTotal();
    double BEPrice;
    for (cnt = 0; cnt < total; cnt++)
    {
        if (OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES) == TRUE)
        {
            if (OrderMagicNumber() && OrderSymbol() == Symbol())
            {
                double OOP = OrderOpenPrice();
                double OTP = OrderTakeProfit();
                double OSL = OrderStopLoss();
                //buy
                if (OrderType() == OP_BUY)
                {
                    BEPrice = (OOP + (OTP - OOP) * Start_Trailing_Stop_Percent);
                    if (Bid >= BEPrice)
                    {
                        if (OrderStopLoss() < Bid - ((OTP - OOP) * Trailing_Stop) || (OrderStopLoss() == 0))
                        {
                            result = OrderModify(OrderTicket(), OOP, (Bid - ((OTP - OOP) * Trailing_Stop)), OTP, 0, Yellow);
                        }
                    }
                }
                //sell
                else
                {
                    BEPrice = (OOP - (OOP - OTP) * Start_Trailing_Stop_Percent);
                    if (Ask <= BEPrice)
                    {
                        if ((OrderStopLoss() > Ask + ((OOP - OTP) * Trailing_Stop)) || (OrderStopLoss() == 0))
                        {
                            result = OrderModify(OrderTicket(), OOP, (Ask + ((OOP - OTP) * Trailing_Stop)), OTP, 0, Yellow);
                        }
                    }
                }
            }
        }
    }
}
  • #12
  • Jan 13, 2019 6:25pm Jan 13, 2019 6:25pm
Quoting Nicholishen
{quote} When you call a function, the caller() goes after the function name not around it. Also, the reason your code won't compile is because you are trying to define a function within a function which is an illegal syntax, and you need to move the functions to the global scope. In a production EA you would also need to limit your use of global variables. As it is you are storing ticket numbers directly in some global variables, but what happens when you accidentally change your chart, or your platform restarts, or computer crashes? Your EA needs...
Hello Nicholishen,

Thank you for the reply. I have gone over the code you sent and notice a completely different style of writing code haha. Thank you for the information.

I ran your code and modified it a little but I only get about 20-30 orders a year. This is decently not correct. Also if there's a long open a short shouldn't be able to open buy it does and vice versa is also happening. Any idea why this is? I ran it on the simulator, not forward testing. Thanks for the help.

Quote
extern double Risk_Percent = 0.02;
input ENUM_TIMEFRAMES TimeFrame = PERIOD_M15;
extern int Channel_Period = 20;
extern double Scale_Ratio = 1;
extern double Start_Trailing_Stop_Percent = 0.03;
extern double Trailing_Stop = 0.03;
extern int Magic_Number = 1000;
int Buy_Order, Sell_Order, getOpenOrders, Buy_Order_2, Sell_Order_2, Buy_Order_3, Sell_Order_3;
datetime bartime = 0;
color LineClr = Orange;
bool DrawLine = FALSE;
string action, sObjName;
double Stop_Loss_Long_Transfer;
double Stop_Loss_Short_Transfer;
//--Global//
double _pip;

bool DC_High_Descending()
{...
  • #13
  • Jan 13, 2019 9:55pm Jan 13, 2019 9:55pm
Quoting Ernie11
{quote} I ran your code {quote}
It's not my code. I don't know the details of it.
  • #14
  • Last Post: Oct 22, 2020 5:52pm Oct 22, 2020 5:52pm
hello- sorry to post in hear

long story short i was lucky enough to discover honestnieves mad c dash

and gone on abit of a purge whilst having the ultimate ahah moment

i came across these these two indicators re shared -originaly shared by Boolean

but i cant get them to work - i have a header file do i need to place this some where as i don't understand where it should go if this is the problem

thankyou for your time .
Attached Image (click to enlarge)
Click to Enlarge Name: f04332a2f90489de5e435917c3fe197d.png Size: 26 KB
Attached Image
0 traders viewing now