Help with EA buttons, please

#1
First Post: May 23, 2018 8:41am May 23, 2018 8:41am

Reamasesa
Joined Jan 2015 | Status: Trader | 1,005 Posts

Hi All,

I have a problem I'm not sure how to address or describe well, sorry, but I'll try.

I've written an EA with on chart buttons to assist me in my manual trading, when the EA first loads on the chart, everything is fine, I can click the buttons and expect to get the results I want, however, after some time (random), the buttons that use the false/true OBJPROP_STATE return to their default, which is "false" even if they look "true" (clicked) on the chart itself.

I took the buttons code from an EA someone was paid to code for me, maybe it wasn't written well, maybe I don't know how to use it well, I don't know but this is driving me crazy while debugging it, everything works as long as I look at it, I go away for an hour (some times longer or shorter than that), I look at the chart and while everything looks fine, nothing works until I re-click all the clickable sunk/unsunk (sorry, not sure how it is called) buttons.

Here's the code for the buttons

Thanks.

Inserted Code

//+------------------------------------------------------------------+
//| Expert initialization function                                   |
//+------------------------------------------------------------------+
int OnInit() {
  ObjectCreate(ChartID(),"Longs Disabled",OBJ_BUTTON,0,0,0);
  ObjectSet("Longs Disabled",OBJPROP_BGCOLOR,clrRed);
  ObjectSet("Longs Disabled",OBJPROP_CORNER,1);
  ObjectSet("Longs Disabled",OBJPROP_YDISTANCE,60);
  ObjectSet("Longs Disabled",OBJPROP_XDISTANCE,120);
  ObjectSet("Longs Disabled",OBJPROP_XSIZE,120);
  ObjectSet("Longs Disabled",OBJPROP_YSIZE,30);   
  ObjectSetString(ChartID(),"Longs Disabled",OBJPROP_TEXT,"Longs Disabled");
  ObjectSet("Longs Disabled",OBJPROP_COLOR,White);
  
  ObjectCreate(ChartID(),"Shorts Disabled",OBJ_BUTTON,0,0,0);
  ObjectSet("Shorts Disabled",OBJPROP_BGCOLOR,clrRed);
  ObjectSet("Shorts Disabled",OBJPROP_CORNER,1);
  ObjectSet("Shorts Disabled",OBJPROP_YDISTANCE,90);
  ObjectSet("Shorts Disabled",OBJPROP_XDISTANCE,120);
  ObjectSet("Shorts Disabled",OBJPROP_XSIZE,120);
  ObjectSet("Shorts Disabled",OBJPROP_YSIZE,30);   
  ObjectSetString(ChartID(),"Shorts Disabled",OBJPROP_TEXT,"Shorts Disabled");
  ObjectSet("Shorts Disabled",OBJPROP_COLOR,White);
  ObjectCreate(ChartID(),"Close All",OBJ_BUTTON,0,0,0);
  ObjectSet("Close All",OBJPROP_BGCOLOR,clrRed);
  ObjectSet("Close All",OBJPROP_CORNER,1);
  ObjectSet("Close All",OBJPROP_YDISTANCE,120);
  ObjectSet("Close All",OBJPROP_XDISTANCE,120);
  ObjectSet("Close All",OBJPROP_XSIZE,120);
  ObjectSet("Close All",OBJPROP_YSIZE,30);   
  ObjectSetString(ChartID(),"Close All",OBJPROP_TEXT,"Close All");
  ObjectSet("Close All",OBJPROP_COLOR,White);
  ObjectCreate(ChartID(),"Disabled",OBJ_BUTTON,0,0,0);
  ObjectSet("Disabled",OBJPROP_BGCOLOR,clrRed);
  ObjectSet("Disabled",OBJPROP_CORNER,1);
  ObjectSet("Disabled",OBJPROP_YDISTANCE,150);
  ObjectSet("Disabled",OBJPROP_XDISTANCE,120);
  ObjectSet("Disabled",OBJPROP_XSIZE,120);
  ObjectSet("Disabled",OBJPROP_YSIZE,30);   
  ObjectSetString(ChartID(),"Disabled",OBJPROP_TEXT,"Disabled");
  ObjectSet("Disabled",OBJPROP_COLOR,White);
  
  ObjectCreate(ChartID(),"Buy",OBJ_BUTTON,0,0,0);
  ObjectSet("Buy",OBJPROP_BGCOLOR,clrGreen);
  ObjectSet("Buy",OBJPROP_CORNER,1);
  ObjectSet("Buy",OBJPROP_YDISTANCE,180);
  ObjectSet("Buy",OBJPROP_XDISTANCE,120);
  ObjectSet("Buy",OBJPROP_XSIZE,120);
  ObjectSet("Buy",OBJPROP_YSIZE,30);   
  ObjectSetString(ChartID(),"Buy",OBJPROP_TEXT,"Buy");
  ObjectSet("Buy",OBJPROP_COLOR,White);
  
  ObjectCreate(ChartID(),"Sell",OBJ_BUTTON,0,0,0);
  ObjectSet("Sell",OBJPROP_BGCOLOR,clrGreen);
  ObjectSet("Sell",OBJPROP_CORNER,1);
  ObjectSet("Sell",OBJPROP_YDISTANCE,210);
  ObjectSet("Sell",OBJPROP_XDISTANCE,120);
  ObjectSet("Sell",OBJPROP_XSIZE,120);
  ObjectSet("Sell",OBJPROP_YSIZE,30);   
  ObjectSetString(ChartID(),"Sell",OBJPROP_TEXT,"Sell");
  ObjectSet("Sell",OBJPROP_COLOR,White);
  
  return(INIT_SUCCEEDED);
}
//+------------------------------------------------------------------+

//+------------------------------------------------------------------+
//| ChartEvent function                                              |
//+------------------------------------------------------------------+
void OnChartEvent(const int id,
                  const long &lparam,
                  const double &dparam,
                  const string &sparam)
{
  if (id==CHARTEVENT_OBJECT_CLICK)
  {
    if (sparam=="Longs Disabled")
    {
      if (AllowLongs)
      {
        AllowLongs=false;
        ObjectSetInteger(ChartID(), "Longs Disabled",OBJPROP_STATE,false);
        ObjectSetInteger(ChartID(), "Longs Disabled", OBJPROP_BGCOLOR, clrRed);
        ObjectSetString(ChartID(), "Longs Disabled", OBJPROP_TEXT, "Longs Disabled");
      }
      else
      {
        AllowLongs=true;
        ObjectSetInteger(ChartID(), "Longs Disabled",OBJPROP_STATE,true);
        ObjectSetInteger(ChartID(), "Longs Disabled", OBJPROP_BGCOLOR, clrGreen);
        ObjectSetString(ChartID(), "Longs Disabled", OBJPROP_TEXT, "Longs Enabled");
      }
   }
   if (sparam=="Shorts Disabled")
   {
     if (AllowShorts)
     {
       AllowShorts=false;
       ObjectSetInteger(ChartID(), "Shorts Disabled",OBJPROP_STATE,false);
       ObjectSetInteger(ChartID(), "Shorts Disabled", OBJPROP_BGCOLOR, clrRed);
       ObjectSetString(ChartID(), "Shorts Disabled", OBJPROP_TEXT, "Shorts Disabled");
     }
     else
     {
       AllowShorts=true;
       ObjectSetInteger(ChartID(), "Shorts Disabled",OBJPROP_STATE,true);
       ObjectSetInteger(ChartID(), "Shorts Disabled", OBJPROP_BGCOLOR, clrGreen);
       ObjectSetString(ChartID(), "Shorts Disabled", OBJPROP_TEXT, "Shorts Enabled");
     }
   }
    if (sparam=="Close All")
    {
      CloseAll();
      ObjectSetInteger(ChartID(), "Close All", OBJPROP_STATE,false);
    }
    if (sparam=="Disabled")
    {
      if (NotDisabled)
      {
        NotDisabled=false;
        ObjectSetInteger(ChartID(), "Disabled",OBJPROP_STATE,false);
        ObjectSetInteger(ChartID(), "Disabled", OBJPROP_BGCOLOR, clrRed);
        ObjectSetString(ChartID(), "Disabled", OBJPROP_TEXT, "Disabled");
      } else {
        NotDisabled=true;
        ObjectSetInteger(ChartID(), "Disabled",OBJPROP_STATE,true);
        ObjectSetInteger(ChartID(), "Disabled", OBJPROP_BGCOLOR, clrGreen);
        ObjectSetString(ChartID(), "Disabled", OBJPROP_TEXT, "Enabled");
      }
    }
    if (sparam=="Buy")
    {
      if (NotDisabled)
      {
        UpCycle();
      }
      ObjectSetInteger(ChartID(), "Buy", OBJPROP_STATE,false);
    }
    if (sparam=="Sell")
    {
      if (NotDisabled)
      {
        DownCycle();
      }
      ObjectSetInteger(ChartID(), "Sell", OBJPROP_STATE,false);
    }
  }
}
//+------------------------------------------------------------------+

#2
May 23, 2018 1:50pm May 23, 2018 1:50pm

mladen
Joined Apr 2007 | Status: ... | 817 Posts

Check the state of the object - do not assume the state and then it will work

#3
May 24, 2018 2:28am May 24, 2018 2:28am

Reamasesa
Joined Jan 2015 | Status: Trader | 1,005 Posts

Quoting mladen

Disliked

Check the state of the object - do not assume the state and then it will work

Ignored

Thanks for replying.
Not sure what you mean by that. It's a button, either it is clicked or not, no? Am I missing something here?

#4
May 24, 2018 5:36am May 24, 2018 5:36am

Nicholishen
Joined Jul 2005 | Status: zzzzzzzzzzzzzzzzzzzzzzzzz zzzzzzzzzz | 1,261 Posts

Quoting Reamasesa

Disliked

{quote} Thanks for replying. Not sure what you mean by that. It's a button, either it is clicked or not, no? Am I missing something here?

Ignored

Yes. You are not checking the state of the button, but instead you're only checking that an event has registered with the name of the button. You need something like...

Inserted Code

...
   if(sparam==button.Name() && button.State())
      ...

#5
May 24, 2018 8:20am May 24, 2018 8:20am

Reamasesa
Joined Jan 2015 | Status: Trader | 1,005 Posts

Quoting Nicholishen

Disliked

{quote} Yes. You are not checking the state of the button, but instead you're only checking that an event has registered with the name of the button. You need something like... ... if(sparam==button.Name() && button.State()) ...

Ignored

Thanks for the example, I'll look it up and add it to my code.

But how is that related to the fact that I click the button, something happens (allowing automated long trades opening, f.e.) and after a while, I see the button is still clicked but the function tied to it isn't executing. Re-clicking the button on and off restarts the cycle.
What I would like solved is that if it's clicked it should stay clicked and not just show itself as clicked.

#6
May 24, 2018 1:12pm May 24, 2018 1:12pm

Nicholishen
Joined Jul 2005 | Status: zzzzzzzzzzzzzzzzzzzzzzzzz zzzzzzzzzz | 1,261 Posts

Quoting Reamasesa

Disliked

{quote} Thanks for the example, I'll look it up and add it to my code. But how is that related to the fact that I click the button, something happens (allowing automated long trades opening, f.e.) and after a while, I see the button is still clicked but the function tied to it isn't executing. Re-clicking the button on and off restarts the cycle. What I would like solved is that if it's clicked it should stay clicked and not just show itself as clicked.

Ignored

Follow the advice of your elders and check the damn button state!

Also you need to set the button state back to false after your function finishes.

Inserted Code

if(sparam==button.Name() && button.State())
{
    some_func();
    button.State(false);
}

#7
May 25, 2018 8:11am May 25, 2018 8:11am

Reamasesa
Joined Jan 2015 | Status: Trader | 1,005 Posts

Quoting Nicholishen

Disliked

{quote} Follow the advice of your elders and check the damn button state! Also you need to set the button state back to false after your function finishes. if(sparam==button.Name() && button.State()) { some_func(); button.State(false); }

Ignored

I am

So the code now looks something like this, I'm already setting the state in the code so I just added the ButtonState() function which returns true or false according to the button state, I must have done something wrong or didn't understand because now I have to click 2-3 times until the button has the correct wording and state.

Why is it so hard? I checked my original code and it returns True/False accordingly when clicked, what can possibly make the state of a button be different than the one shown on screen?

Thanks

Inserted Code

bool ButtonState(string ButtonName) {
  if(ObjectGetInteger(0,ButtonName,OBJPROP_STATE)==true)
  {
    return true;
  }
  else
  {
    return false;
  }
}
 
 
void OnChartEvent(const int id,
                  const long &lparam,
                  const double &dparam,
                  const string &sparam)
{
  if (id==CHARTEVENT_OBJECT_CLICK)
  {
    if (sparam=="Longs" && ButtonState("Longs"))
    {
      if (AllowLongs)
      {
        AllowLongs=false;
        ObjectSetInteger(ChartID(), "Longs",OBJPROP_STATE,false);
        ObjectSetInteger(ChartID(), "Longs", OBJPROP_BGCOLOR, clrRed);
        ObjectSetString(ChartID(), "Longs", OBJPROP_TEXT, "Longs Disabled");
      }
      else
      {
        AllowLongs=true;
        ObjectSetInteger(ChartID(), "Longs",OBJPROP_STATE,true);
        ObjectSetInteger(ChartID(), "Longs", OBJPROP_BGCOLOR, clrGreen);
        ObjectSetString(ChartID(), "Longs", OBJPROP_TEXT, "Longs Enabled");
      }..........

#8
Last Post: May 26, 2018 1:04pm May 26, 2018 1:04pm

Nicholishen
Joined Jul 2005 | Status: zzzzzzzzzzzzzzzzzzzzzzzzz zzzzzzzzzz | 1,261 Posts

If that's the case then you definitely have an issue upstream with whatever logic is setting the AllowLongs bool. Also you can simplify your state check func to just:

Inserted Code

bool buttonState(string button_name)
{
    return ObjectGetInteger(0,button_name,OBJPROP_STATE);
}

Platform Tech
/
Help with EA buttons, please
Reply to Thread

0 traders viewing now

Options

Similar Threads

Help with EA buttons, please