Having Trouble with Cross Logic for Indicator. | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Rsi cross indicator? (NOT cross 50, etc) 44 replies

How does this EMA cross filter? (help with decoding logic) 2 replies

Having MT4 on two computer and having to REDO stuff 16 replies

MA Cross Indicator trouble 2 replies

Having Trouble with my Charting Program... 2 replies

Attachments: Having Trouble with Cross Logic for Indicator.
Exit Attachments

Having Trouble with Cross Logic for Indicator.

  • #1
  • First Post: Oct 19, 2006 12:26pm Oct 19, 2006 12:26pm
I thought I was getting this..but somehow I messed up.

I have an SMA55. I only want it to track H4(other time frames get scaled SMA). When a bar Closes above it I want a signal to buy. When a bar Closes below it I want a signal to sell. If I already have received a signal I should not receive another unless the SMA is crossed. The current bar should not be tracked.

This is my CheckBuy Function:

Inserted Code
 
bool CheckForBuy(int idx)
{
if (Close[idx]>SMA55[idx])
 {
 if (Close[idx]>Close[idx-1])
 {
if (Close[idx-1]<=SMA55[idx-1])
{
 return(true);
}
 }
 } 
else return(false);
}

Check Sell the logic is reversed.

I am not sure how to hold the data for the indicators since I can't figure out the Global Scoped variables.

What am I missing or doing wrong?
Attached Image
  • #2
  • Last Post: Oct 19, 2006 3:20pm Oct 19, 2006 3:20pm
OK I figured this one out too. Here is the solution so that it may help someone someother time...


My initial loop was wrong. I had it going like so:

for(i=0;i<counted_bars;i++)
because the first bar is 0 it is writing out the indicator from right to left.

the correct way is a 'reverse' iteration
for (i=counted_bars;i>0;i--)
this causes the iteration to occur in the expected direction of left to right and places the arrows correctly.

I also have defined constants to control the placement of arrows.

if (Close[i]<SMA55[i]&& status !=LINE_UNDER && SMA55[i]>0)
{
CreateDOWNArrow(i);
status=LINE_UNDER;
}

this appears to be working as intended for the moment....
0 traders viewing now