Adding Orderprofit()

Hi

This is the first time I have had to ask a question on the forum, but I am having huge problems.
I have previously coded some rather complex indicators but this one has me stumped. I am sure it is something I am doing wrong but I can't see it.
I am accumulating all the Positive and Negative closed orders in the history. The positives work correctly - I have checked. But the negatives are not right.

The code is;

if(OrdProfit > 0.0)
{
OrdProf ++ ;
TotalProf += OrdProfit;
}
else
{
OrdLoss ++ ;
TotalLoss += OrdProfit;
Alert("Cnt "+string(OrdLoss)+" Prof "+DoubleToString(OrdProfit,2)+" Tot "+DoubleToString(TotalLoss,2));
}

The results from the Alert (which is temporary) are, for example;

Cnt 4 ----
Cnt 3 Prof -773.55 Tot -93.80
Cnt 2 Prof -237.66 Tot 867.55
Cnt 1 ----

You can see that sometimes it adds, and then sometimes it subtracts.

I have tried adding, subtracting, testing for negative, Squaring then taking Sqrt etc - all with no success. I have even re-installed the platform to a new folder.

I would appreciate any help if it is possible. Many Thanks

shouldn't it be :

Hi

Thanks for coming back to me - yes it is OrdProfit. Just my fat fingers editing the code.

Also, I have tried using OrderProfit() instead on another variable (with all the variations) but it makes no difference.

Just out of curiosity - I have an indicator (this problem one) that calculates the MAE and MFE for all closed orders. When I get it working, I will post it.

Also, you should put the Alert() outside the loop ... Once the whole count is finished.

Hi FerruFX - thanks, but no as I want to see each order as it was processed. If I put it outside the loop I would only see the total. By being inside the loop I can see the maths per order - which is wrong. Thanks

Are you only wanting the alert to show when it reports losses? It seems the alert sits inside the else statement for the loss portion.

Hi Vlad - thanks. I have the following code just below it;

TotalComm += OrdCommis;
TotalSwap += OrdSwap;

which is doing what you suggest. Which by the way works!

Hi Vlad. The Alert is only there to try and sort this out - I will remove it when this works. When all orders are processed, I display the various lines using Objects, which is later down the code.

Ok cool, is your problem solved? Or is something still not working correctly?

Hi - Just to clear the confusion, I have pasted a snapshot of the output - with the Alert, which as I say will go when I get this working.

Hi Vlad - Nope, the OrderProfit is still adding or subtracting when it wants to . The only thing I can say is that it is always the same orders. This leads me to believe that there is something embedded in the order that is doing this.

Maybe showing the whole loop will help finding what is wrong. You are only showing part of the loop.

Ok something I don't quite understand...

OrdProfit is a negative number in the else{} statement

You then TotalLoss+=OrdProfit , but your "Tot" shows a positive number, how is this possible?

Hi Vlad. Unfortunately, I cannot show the whole indicator - it is 900+ lines. However, the only parts missing are;

TotalProf = 0.0;
TotalLoss = 0.0;

.....

for(x = HistTotal-1; x > 0; x--)
{
if(OrderSelect(x,SELECT_BY_POS,MODE_HISTORY) == false)
{
Alert("Access to history failed with error (",GetLastError(),")");
break;
}
.......
OrdProfit = OrderProfit();

.......

//---- Calculate Profit and Loss Total, Numbers and Total Commission and Swap

if(OrdProfit > 0.0)
{
OrdProf ++ ;
TotalProf += OrdProfit;
}
else
{
OrdLoss ++ ;
TotalLoss += OrdProfit;
Alert("Cnt "+string(OrdLoss)+" Prof "+DoubleToString(OrderProfit(),2)+" Tot "+DoubleToString(TotalLoss,2);
}

TotalComm += OrdCommis;
TotalSwap += OrdSwap;

If you see from this the only time OrdProfit is used is above. It is calculated for negative orders only and I have an Alert just after the calculation which sahows it is not working properly. All the other code is worki9ng correctly. It is only negative orders.

Not seeing the whole code, it is difficult to make sense of it

We don't know if OrdProfit is reset to zero at any point, we don't even know where OrdProfit gets its value from. Why not just use OrderProfit()?
How it stands, if OrdProfit is a positive number, you then add 1 to it. Then you add the cumulative value of OrdProfit to TotalProf.
That makes no sense at all

Hi Vlad. The count is simply an accumulation of the number of orders - it will always be positive.

Hi Gumrai

If you read my earlier mail, you will see I have tried OrderProfit() with no change at all. I do not add 1 to OrdProfit - only to OrdProf - the number of orders. Also, it is not the Profit section that doesn't work - it is the Negative - the bit after the else.