coders please fix an EA bug - trading hours

Goof day,I have an EA which apparently has a bug in the trading hours algorithms,as I've set it 9-17,broker offset +2(which actually is my broker's GMT offset),but it opens trades outside the set trading time.Unfortunately,the coder who coded it for me doesn't answer my mails.Can somebody take a look at the code?Thanks for any suggestion.

Merlin,
Sure is a Goofy day ;-)

Not sure but I think the following should work.....

Remove/overwrite the existing bool TradingTime() function with....
(keep a copy in case I am wrong)



bool TradingTime()
{
datetime start, stop;

start = StrToTime(StringConcatenate(Year(),".",Month(),".",Day()," ",StartTime))+GMT_Offset*3600;
stop = StrToTime(StringConcatenate(Year(),".",Month(),".",Day()," ",StopTime))+GMT_Offset*3600;

if(stop <= start)
stop += 86400;

if((TimeCurrent() >= start && TimeCurrent() < stop))
return(true);

return(false);
}

Thanks a lot futurespec,I'll try immediately.Unfortunately,since the EA doesn't trade very often,I don't know when I'll be able to let you know wheter your modification works or not.Thanks again.

For that there is the strategy tester in Mt4.

I know,but my pc is under technical maintenance and my spare laptop is old and very poor of ram,so I can't run a backtest until the weekend.