Nicotina GJ Breakout strategy: an auto-trader by SteveHopwood

Quoting Dixpat

Disliked

...The EA which has been running for over 24 hours now redrew the box at the appropriate time and in the correct place but has failed to place the pending orders.

Sorry Paul but the cork is being placed back on the champers bottle

Dave

Ignored

Quoting batemap

Disliked

Y, I show the same, take the EA off the chart and reapply and the pending trades will be sent.
The issue is to do with some of the protection I've put in.

It looks like I used iTime, instead of Time. This has been fixed in the attached, Shelley EA, please try this.

Thanks

Paul

Ignored

Quoting Dixpat

Disliked

Loaded Shelley

No go

Just says "looking for trades"

Dave

Ignored

Quoting batemap

Disliked

Hi Dave, can you post a portion of the log?

Thanks

Paul

Ignored

Quoting Dixpat

Disliked

Hope this helps

Ignored

Quoting batemap

Disliked

Dave

Looks like your times are wrong because you are not getting past this code: -

if (h >= CloseHour || h < RangeCalculationHour) return(false);

This means that either: -

1. Your local hour is greater than your CloseHour (i.e. 1800 British), or
2. Your local hour is before the RangeCalculationHour (i.e. 0200 British)

Can you check the above variables and post the values?

Thanks

Paul

Ignored

Quoting Dixpat

Disliked

My variables re times are:

CloseHour 5
RangeCalculationHour 13

My local time is GMT+12

Dave

Ignored

Quoting Dixpat

Disliked

My variables re times are:

CloseHour 5
RangeCalculationHour 13

My local time is GMT+12

Dave

Ignored

Quoting Dixpat

Disliked

My understanding was that the variables were to be in Local time not GMT

If that is the case then both the equations will give false.

Dave

Ignored

Quoting jimmynoodles

Disliked

This trade was stopped for -50. The EA then entered long @ 132.25 which, as far as my understanding of the strategy goes, is correct behavoir.

Ignored

Quoting batemap

Disliked

OK, here's my theory and I think this is Shelley's issues as well!

Your current local time is 16:28, so your hour is 16, h = 16. CloseHour = 5, is h greater than or equal to CloseHour , with numbers, is 16 >= 5, yes it is, so we return false, which means trading is not allowed because you are outside of the time window!

We need to tell the EA that your CloseHour is in the future, tomorrow, not in the past, today. I'll need to think about this for a while before fixing, but I've just made a cup of tea, so

Thanks

Paul

Ignored

Quoting fxozgirl

Disliked

Hi Paul,

No champagne on this end just yet...
running your updated de-bug ea from yesterday, box drawn correctly, still no trades.
Checked the logs and it's a bit weird as there's nothing in there, but on checking the experts tab on the platform it is constantly scrolling through with comments.

I have taken a screen shot to try and give you an idea of what it's doing.
Hopefully it will provide some help??

Shelley

Ignored

Quoting Dixpat

Disliked

Hi cobber Paul

Loaded Aussie.EA

20:12:17 Nicotana - AussieNZ GBPJPY,H1: loaded successfully
20:12:33 Nicotana - AussieNZ GBPJPY,H1 inputs: gen="----General inputs----"; Lot=0.01; TakeProfit=100; StopLoss=50; MagicNumber=755; TradeComment="Nicotina"; CriminalIsECN=false; RangeLineColour=(255,255,0); StopTrading=false; TradeLong=true; TradeShort=true; tt="----Trading hour inputs----"; rch="Range calculation hour"; RangeCalculationHour=13; LookBackCandles=8; tcc="Trade closure hour"; CloseHour=5; ptd="PendingTradeExpiryHour"; PendingExpiryTime=5;...

Ignored

Quoting batemap

Disliked

Hi Dave and all

Can you post the logs please? I really need these to make any sense of what is going on

But, after checking the code I think all is still good, but you will not get any trades until the box is redrawn tomorrow at 2 a.m British time, yes I got it wrong in my previous post

Thanks

Paul

Ignored

Quoting batemap

Disliked

while (TimeHour(TimeCurrent()) != TimeHour(Time[0])) {

Ignored

Quoting skoda2008

Disliked

I don't have access to MT4 right now to check, but I think you need to use iTime[0] for the bar time?

Ignored