Programming Smart Tips | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

programming 6 replies

API programming 5 replies

MT Information (Programming, Backtesting, Tips ...) 9 replies

MetaTrader 4 Programming guide? 2 replies

Neuro Linguistic Programming Book 24 replies

Attachments: Programming Smart Tips
Exit Attachments

Programming Smart Tips

  • #1
  • First Post: Edited 5:09pm Dec 8, 2022 3:43pm | Edited 5:09pm
hint: my subscribers can post here . .
. .
assume you want to calculate profit in pips for closed positions . . some of them are BUY and others are SELL . .
Instead of using two functions (one for BUY and other for SELL) what is the best/smart alternative?

I am eagerly waiting your answer/solution which would be better than my suggestion . .
Inserted Code
pips = ( OrderType() - ( OrderType() ^ 1 ) ) * ( OrderOpenPrice() - OrderClosePrice() )

look at it!! is it very smart? only one line that is valid for both BUY or SELL type . .

let us check: assume order type: BUY = 0

pips = (OrderType()-(OrderType()^1)) * (OrderOpenPrice()-OrderClosePrice())

You have to study this "^" symbol . . to understand what we are talking about . . in MQL4 it is not "THE POWER OF"
or just simply check the result which will be -1 for BUY and +1 for SELL
Attached Image (click to enlarge)
Click to Enlarge Name: Untitled.png Size: 18 KB

^ is the bitwise exclusive operation XOR of binary representations of x and y. The value of the expression contains a 1 in all digits where x and y have different binary values, and it contains 0 in all other digits.

Therefore:
it makes 0 (which is BUY) 1
and
makes 1 (which is SELL) 0
each day 10%,,,, https://www.forexfactory.com/thread/1371538
  • #2
  • Edited 5:07pm Dec 8, 2022 4:10pm | Edited 5:07pm
2nd Tip:

int digits = Digits & (~1);

think deeply and find some of its advantages . .
each day 10%,,,, https://www.forexfactory.com/thread/1371538
  • #3
  • Dec 8, 2022 4:55pm Dec 8, 2022 4:55pm
very very smart tip. Thank you for sharing, Al-Otaibi !!!
  • #4
  • Edited Dec 9, 2022 5:24am Dec 8, 2022 8:32pm | Edited Dec 9, 2022 5:24am
Quoting Macd-rsi
2nd Tip:

int digits = Digits & (~1);

think deeply and find some of its advantages
this one of the smartest methods that solve problems of different DIGITS
Yen pairs 3 digits
other pairs 4 digits . .
instead of many coding lines to differentiate b/w Yen and non-Yen pairs digits + if you hate 5 digits or 3 digits and you need to make calculations based on 4 or 2 digits . .
above code helps (generalized for both)

proof:
assume you attach your expert to EURUSD chart with 5 digits . .
5 binary representation is 101 (4+0+1=5)

and we know that ~1 = 0 ----> add ones to the left . . . . since you will ANDed it with another 3 digits binary
then:
5&(~1) = 101& 110 = 100 = 4

in this case you change digits from 5 to 4 . . .

the same is applied for any YEN pair > > > lets us check it . .


USDJPY --- 3 digits = 11 (binary)

3&(~1) = 11& 10 = 10 = 2

you change digit value of 3 to 2 using the same rule !!! look how it is smart compared to their traditional ways using if condition!!
Attached Image (click to enlarge)
Click to Enlarge Name: Untitled.png Size: 6 KB
g
each day 10%,,,, https://www.forexfactory.com/thread/1371538
  • #5
  • Dec 8, 2022 8:42pm Dec 8, 2022 8:42pm
NASDAC is 2 digits!!
what will happen (we prefer to stay 2 digits)

2&(~1) = 10& 10 = 10 = 2
each day 10%,,,, https://www.forexfactory.com/thread/1371538
  • #6
  • Edited 5:22am Dec 9, 2022 5:04am | Edited 5:22am
any smart tips?
each day 10%,,,, https://www.forexfactory.com/thread/1371538
  • #7
  • Dec 10, 2022 9:49am Dec 10, 2022 9:49am
Quoting Macd-rsi
{quote} this one of the smartest methods that solve problems of different DIGITS Yen pairs 3 digits other pairs 4 digits . . instead of many coding lines to differentiate b/w Yen and non-Yen pairs digits + if you hate 5 digits or 3 digits and you need to make calculations based on 4 or 2 digits . . above code helps (generalized for both) proof: assume you attach your expert to EURUSD chart with 5 digits . . 5 binary representation is 101 (4+0+1=5) and we know that ~1 = 0 ----> add ones to the left . . . . since you will ANDed it with another 3 digits...
Seems like I have been coding stupidly lol.
Thanks for this, mate!
  • #8
  • Dec 11, 2022 9:42am Dec 11, 2022 9:42am
Quoting gcancino
{quote} Seems like I have been coding stupidly lol. Thanks for this, mate!
it is a trial to spruce up our programming thought . .
each day 10%,,,, https://www.forexfactory.com/thread/1371538
  • #9
  • Dec 26, 2022 1:14pm Dec 26, 2022 1:14pm
any smart idea?
each day 10%,,,, https://www.forexfactory.com/thread/1371538
  • #10
  • Dec 28, 2022 10:43pm Dec 28, 2022 10:43pm
Tick();
if(m_p_digits==5)
m_pointbase=SYMBOL_POINTBASE_10000;
else if(m_p_digits==6)
m_pointbase=SYMBOL_POINTBASE_100000;
else if(m_p_digits==7)
m_pointbase=SYMBOL_POINTBASE_1000000;
else if(m_p_digits==4)
m_pointbase=SYMBOL_POINTBASE_10000;
else if(m_p_digits==3)
m_pointbase=SYMBOL_POINTBASE_100;
else if(m_p_digits==2)
{
m_pointbase=SYMBOL_POINTBASE_100;
if(SpreadAbs()>=0.25)
m_pointbase=SYMBOL_POINTBASE_1;
}
else if(m_p_digits==1)
m_pointbase=SYMBOL_POINTBASE_1;
else
m_pointbase=SYMBOL_POINTBASE_1;
}
else
m_pointbase=base;
m_pointsteps=m_p_ticksize*m_pointbase;
  • #11
  • Jan 31, 2023 4:09am Jan 31, 2023 4:09am
Quoting Macd-rsi
hint: my subscribers can post here . . . . assume you want to calculate profit in pips for closed positions . . some of them are BUY and others are SELL . . Instead of using two functions (one for BUY and other for SELL) what is the best/smart alternative? I am eagerly waiting your answer/solution which would be better than my suggestion . . pips = ( OrderType() - ( OrderType() ^ 1 ) ) * ( OrderOpenPrice() - OrderClosePrice() ) look at it!! is it very smart? only one line that is valid for both BUY or SELL type . . let us check: assume order type:...
Just noticed your smart solution... Not bad, but your attempt is similar to using your fork to slice your steak instead of a knife.. It is the practical way, but inappropriate...

Best practice is to always write "clear code", so that after a certain time has passed, you or others easily understand the reasoning behind it. To do that and since you always want a positive value whether the case is a SELL OR BUY, we would simply use the classic "Ternary Operator":

Usage:
"expression1 ? expression2 : expression3"

The code (still one line):
pips = if(OrderOpenPrice() - OrderClosePrice()) < 0 ? -(OrderOpenPrice() - OrderClosePrice()) : OrderOpenPrice() - OrderClosePrice();

Just advice though... Do what fits you best.. I hope it helps...

Best wishes and more strength to your success brother...
Focus only on what truly matters!
  • #12
  • Jan 31, 2023 4:28am Jan 31, 2023 4:28am
Quoting Macd-rsi
2nd Tip: int digits = Digits & (~1); think deeply and find some of its advantages . .
You Are So Smart, GO ON ...
I'm not a programmer and i don't like ! , but only I try to catch my view !
  • #13
  • Jan 31, 2023 11:56am Jan 31, 2023 11:56am
Quoting Ata-Turkoglu
{quote} Just noticed your smart solution... Not bad, but your attempt is similar to using your fork to slice your steak instead of a knife.. It is the practical way, but inappropriate... Best practice is to always write "clear code", so that after a certain time has passed, you or others easily understand the reasoning behind it. To do that and since you always want a positive value whether the case is a SELL OR BUY, we would simply use the classic "Ternary Operator": Usage: "expression1 ? expression2 : expression3" The code (still one line): pips...
i need to read your post again , "Ternary Operator"
each day 10%,,,, https://www.forexfactory.com/thread/1371538
  • #14
  • Jan 31, 2023 11:57am Jan 31, 2023 11:57am
Quoting xreytrading
Tick(); if(m_p_digits==5) m_pointbase=SYMBOL_POINTBASE_10000; else if(m_p_digits==6) m_pointbase=SYMBOL_POINTBASE_100000; else if(m_p_digits==7) m_pointbase=SYMBOL_POINTBASE_1000000; else if(m_p_digits==4) m_pointbase=SYMBOL_POINTBASE_10000; else if(m_p_digits==3) m_pointbase=SYMBOL_POINTBASE_100; else if(m_p_digits==2) { m_pointbase=SYMBOL_POINTBASE_100; if(SpreadAbs()>=0.25) m_pointbase=SYMBOL_POINTBASE_1; } else if(m_p_digits==1) m_pointbase=SYMBOL_POINTBASE_1; else m_pointbase=SYMBOL_POINTBASE_1; } else m_pointbase=base; m_pointsteps=m_p_ticksize*m_pointbase;...
weclome brother
but i think thier tradironal way, is smarter than this suggestion
too many coding lines ..

when we say smart = one coding line that encompass many coding lines . .
each day 10%,,,, https://www.forexfactory.com/thread/1371538
  • #15
  • Feb 4, 2023 3:18am Feb 4, 2023 3:18am
Quoting Macd-rsi
2nd Tip: int digits = Digits & (~1); think deeply and find some of its advantages . .
Also, we can write this code
Inserted Code
int digits = Digits & -2;
I'm not a programmer and i don't like ! , but only I try to catch my view !
  • #16
  • Feb 5, 2023 7:04am Feb 5, 2023 7:04am
Quoting Sasco_me
{quote} Also, we can write this code int digits = Digits & -2;
Sure
complement of 1 = -2
each day 10%,,,, https://www.forexfactory.com/thread/1371538
  • #17
  • Feb 7, 2023 6:49am Feb 7, 2023 6:49am
Always count down in your loops
  • #18
  • Last Post: Jun 6, 2023 3:01pm Jun 6, 2023 3:01pm
Quoting Kefada
Always count down in your loops
yes
especially with counting/deleting open orders . .
if you count up, will delete order then jump the next and so on . .

another advantage ,,
if your first loop is a function like ArraySize(&var), then it will be passed one time by the processor , ,
Attached Image (click to enlarge)
Click to Enlarge Name: _0000000.png Size: 6 KB

j
each day 10%,,,, https://www.forexfactory.com/thread/1371538
0 traders viewing now