Help drawing a fibo in a script

//+------------------------------------------------------------------+
//|                                                     FiboDraw.mq4 |
//|                                                      nicholishen |
//|                                   www.reddit.com/u/nicholishenFX |
//+------------------------------------------------------------------+
#property copyright "nicholishen"
#property link      "www.reddit.com/u/nicholishenFX"
#property version   "1.00"
#property strict
#include <ChartObjects\ChartObjectsFibo.mqh>
//+------------------------------------------------------------------+
//| Script program start function                                    |
//+------------------------------------------------------------------+
void OnStart()
{
//---
   ObjectDelete(0,"myFibo");
   //--- getting fibo anchor points from zigzag
   struct myAnchors 
   { 
      double price; 
      datetime time; 
      myAnchors():price(0.0),time(NULL){} 
   }  anchors[2];
   int index = -1;
   for(int i=0;i<Bars(Symbol(),Period());i++)
   {
      double val = iCustom(Symbol(),Period(),"ZigZag",15,5,3,0,i);
      if((val != 0.0 || val != EMPTY_VALUE) && val > 0.0)
      {
         if(index >=0)
         {
            anchors[index].price = val;
            anchors[index].time  = iTime(Symbol(),Period(),i);
         }
         index++;
         if(index >=2)
            break;
      }
   }
   //--- declare and create an object of fibo class
   CChartObjectFibo fibo;
   fibo.Create(0,                //chartID
               "myFibo",         //chart object name
               0,                //subwindow
               anchors[1].time,  //time 1
               anchors[1].price, //price 1
               anchors[0].time,  //time 2
               anchors[0].price  //price 2
               );
   
   //--- setting new levels because we want 76.4 and no extensions, otherwise this step is not necessary 
   double levels[7] = { 0.000, 0.236, 0.382, 0.500, 0.618, 0.764, 1.000} ;
   fibo.LevelsCount(7);   
   for(int i=0;i<ArraySize(levels);i++)
   {
      fibo.LevelValue(i,levels[i]);
      fibo.LevelDescription(i,DoubleToStr(levels[i]*100,1));
   }    
  
   //leave object on chart after object is destroyed
   fibo.Detach();
}
//+------------------------------------------------------------------+

Quoting Nicholishen

Disliked

This one is actually quite simple if you use the standard library. https://www.mql5.com/en/docs/standar...hartobjectfibo //+------------------------------------------------------------------+ //| FiboDraw.mq4 | //| nicholishen | //| www.reddit.com/u/nicholishenFX | //+------------------------------------------------------------------+ #property copyright "nicholishen" #property link "www.reddit.com/u/nicholishenFX" #property version "1.00" #property strict #include <ChartObjects\ChartObjectsFibo.mqh>...

Ignored

Quoting TheMaxx

Disliked

This script is great if you want to draw a fibo from the highest candle to the lowest candle, which is the usual use of the fibo tool. I'd like to place the fibo over the most recent candle only. How would I do this please? Remove the for loop, and use something like "High[0]" for price?

Ignored

Quoting Nicholishen

Disliked

{quote} Try it and tell me what happens

Ignored

Quoting Nicholishen

Disliked

{quote} Try it and tell me what happens

Ignored

Quoting TheMaxx

Disliked

{quote} It worked! I'm sure the code isn't very elegant but it works! Thank you so much for all your advice. I've gotten everything working how I want it except for 1 thing.... I can only run it once on a chart. What do I do so that I could call the script every bar, and it would keep adding a new fibo? I suspect it has something to do with destroying the object, but am not sure? {file}

Ignored

Quoting Nicholishen

Disliked

{quote} Well that all depends on how you want to implement it... Are you trying to leave the drawings on the chart?

Ignored

Quoting Nicholishen

Disliked

{quote}Are you attempting to update the current drawing?

Ignored

Quoting Nicholishen

Disliked

{quote} What happens when you call fibo.Detach()? Have you set a breakpoint and stepped through the code in the debugger?

Ignored

Quoting Nicholishen

Disliked

{quote} Hint: You can't Create(...) the same "object name" more than once.

Ignored

Quote

Disliked

When I debug, it seems to call a ObjectDelete() in ChartObject.mqh...? The funny thing is, when I comment it out, nothing gets drawn. If I leave it in, it draws the fibo, but the fibo doesn't show up in the Objects list for the chart. I can live without that now, but it would be nice to be able to manually delete different fibos in the future.

Quote

Disliked

It's doing everything I want, other than leaving the chart in the objects list. I need "Detach()", but what else do I need to do to put it in there? I can't see anything here:

//+------------------------------------------------------------------+
//|                                                     FiboDraw.mq4 |
//|                                                      nicholishen |
//|                                   www.reddit.com/u/nicholishenFX |
//+------------------------------------------------------------------+
#property copyright "nicholishen"
#property link      "www.reddit.com/u/nicholishenFX"
#property version   "1.00"
#property strict
#include <ChartObjects\ChartObjectsFibo.mqh>
#include <Arrays\ArrayObj.mqh>
//+------------------------------------------------------------------+
//| Script program start function                                    |
//+------------------------------------------------------------------+
void OnStart()
{
//---
   //--- deletes all chart objects left over from a previous run. This is just for the script
   ObjectsDeleteAll(0,"myFibo");
  
   //--- getting fibo anchor points from zigzag
   struct myAnchors
   {
      double price;
      datetime time;
      myAnchors():price(0.0),time(NULL){}
   }  anchors[2];
  
   //automatically manage memory
   CArrayObj objArray;
  
   for(int i=0;i<10;i++)
   {
      anchors[1].price = High[i];
      anchors[1].time  = Time[i];
      anchors[0].price = High[i]-((High[i]-Low[i])/2);
      anchors[0].time  = Time[i];
    
      string fibo_name = "myFibo_"+IntegerToString(i);
      //--- declare and create an object of fibo class
      CChartObjectFibo *fibo = new CChartObjectFibo;
      fibo.Create(0,                //chartID
                  fibo_name,         //chart object name
                  0,                //subwindow
                  anchors[1].time,  //time 1
                  anchors[1].price, //price 1
                  anchors[0].time,  //time 2
                  anchors[0].price  //price 2
                  );
      
      //--- setting new levels because we want 76.4 and no extensions, otherwise this step is not necessary
      double levels[10] = {-9, -7, -5, -3, -1, 1, 3, 5, 7, 9} ;
      string levelname[10] = {"4R","3R","2R","1R","S","L","1R","2R","3R","4R"};
      fibo.LevelsCount(10);  
      for(int j=0;j<ArraySize(levels);j++)
      {
         fibo.LevelValue(j,levels[j]);
         fibo.LevelDescription(j,levelname[j]);
         fibo.LevelColor(j,clrBlack);
      }    
      // turn off ray
      fibo.RayRight(false);
      //leave object on chart after object is destroyed
      fibo.Detach();
      objArray.Add(fibo);
   }
}
//+------------------------------------------------------------------+

Quoting Nicholishen

Disliked

Hi Maxx, {quote} I'm not sure if you edited the standard lib files, but if you did that can be a huge issue and you should restore them back to the way they came. If you need to alter the standard library, you'll need to create a child class instead... if you didn't then disregard this comment. {quote} Yes...if you don't call Detach() then the chart drawing gets removed by the objects destructor. You shouldn't use the same object to create multiple chart drawings. Each chart drawing should have its own object. Here is an example of creating a new...

Ignored

Quoting Nicholishen

Disliked

Hi Maxx, {quote} I'm not sure if you edited the standard lib files, but if you did that can be a huge issue and you should restore them back to the way they came. If you need to alter the standard library, you'll need to create a child class instead... if you didn't then disregard this comment. {quote} Yes...if you don't call Detach() then the chart drawing gets removed by the objects destructor. You shouldn't use the same object to create multiple chart drawings. Each chart drawing should have its own object. Here is an example of creating a new...

Ignored