Help fix promising EA with close trade error | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Help needed to fix 'Divide by zero' error 5 replies

EA error message (0) no error 6 replies

MT4 EA error- when placing trade getting error 0 rate on ask 3 replies

Urgent Help needed with Order Close Error Handling! 2 replies

Please Help with this Code, loooks promising 0 replies

Attachments: Help fix promising EA with close trade error
Exit Attachments

Help fix promising EA with close trade error

  • #1
  • First Post: Sep 5, 2016 3:29pm Sep 5, 2016 3:29pm
Hello Guys,

Bollinger breakout strategy have been around for some time. In an attempt to create a variation of a bollinger breakout strategy I have been able to code the EA attached below. However the following lines of Code just wont work. ALL ATTEMPTS TO SPOT THE ERROR in the code has proved futile .

Inserted Code
 double MA_Prev=iMA(NULL,0,MaTrendPeriod,MaTrendShift,MODE_LWMA,PRICE_CLOSE,1);
    
      if (TradeBar!= iTime(0,0,0)&&CloseB4TradeBar!=Close[1]) //dont closetrade while price is on trade bar neither use close of bar before trade bar to close
         {
            if (ExistPositions()==true)
            {
               if (Close[1]>MA_Prev)
                  {
                     CloseSell();
                     Print(Close[1]," > ",MA_Prev);
                  }
                  
              
               if (Close[1]<MA_Prev)
                  {
                    CloseBuy();
                     Print(Close[1]," < ",MA_Prev);
                  }  
            }  
            
         }


I will be really grateful if someone could help fix this and tell me where I made the error so that I and others who may make the mistake can learn.

Attached is screen shots and the Faulty Expert Advisor

MANY MANY THANKS
Attached Image(s) (click to enlarge)
Click to Enlarge Name: 0close if condition not met but buy is closed.PNG Size: 39 KB
Click to Enlarge Name: 1Trades are closed with close greater or less than condition being met.png Size: 112 KB
Attached File(s)
File Type: mq4 RemakeGoaway.mq4   9 KB | 277 downloads
  • #2
  • Sep 5, 2016 3:49pm Sep 5, 2016 3:49pm
Check if this modification solves the problem....
Attached File(s)
File Type: mq4 RemakeGoaway_mod1.mq4   10 KB | 532 downloads
Trading is the hardest way to make easy money...
  • #3
  • Sep 5, 2016 4:36pm Sep 5, 2016 4:36pm
It worked, I owe you immensely. I am really grateful. I noticed you changed

Inserted Code
bool fc;
 
fc=OrderClose(OrderTicket(), OrderLots(), Bid, Slippage*multiplier,clrNONE);

was changed to

Inserted Code
  int ticket = -1;
   int totalorders = OrdersTotal();
   for(int i=totalorders-1;i>=0;i--)
   {
      OrderSelect(i, SELECT_BY_POS);      
      if ( OrderSymbol()==Symbol() && OrderType()==OP_SELL)
      {
         OrderClose(OrderTicket(), OrderLots(), Ask, Slippage*multiplier, clrNONE);
      }
   }


But I still cant understand how Mt4 was able to reach Closebuy() and CloseSell() functions since the PREREQUISITE IF CONDITIONS were not met. I would be grateful if someone really explain to help me understand mql4 better. I hope i am not asking too much
  • #4
  • Sep 5, 2016 4:41pm Sep 5, 2016 4:41pm
Quoting Adewumi
It worked, I owe you immensely. I am really grateful. I noticed you changed bool fc; fc=OrderClose(OrderTicket(), OrderLots(), Bid, Slippage*multiplier,clrNONE); was changed to int ticket = -1; int totalorders = OrdersTotal(); for(int i=totalorders-1;i>=0;i--) { OrderSelect(i, SELECT_BY_POS); if ( OrderSymbol()==Symbol() && OrderType()==OP_SELL) { OrderClose(OrderTicket(), OrderLots(), Ask, Slippage*multiplier, clrNONE); } } But I still cant understand how Mt4 was able to reach Closebuy() and CloseSell() functions since the PREREQUISITE...

Which conditions do you think were not met?
I still need a trading break soon!!! "Loose some to win more" --Baher A.
  • #5
  • Sep 6, 2016 3:30am Sep 6, 2016 3:30am
The close of the previous bar was not greater than the moving average of the previous bar for all to be closed

Neither was the close of previous bar less than the moving average of the Previous bar for buy to be closed

From my little knowledge of programming when the conditions of an "if statement" is not met the sub module under it will not be read at all when running.

For example
" "If x. >5 print 10 "
Even if the the programmer intended to write print 1.

Just because X was not greater than 5 that print 10 statement is not supposed to run.

This is the glitch I just can't seem to understand
  • #6
  • Sep 7, 2016 4:44am Sep 7, 2016 4:44am
Is this how mql4 operates or is it a glitch? Thanks
  • #7
  • Feb 5, 2017 1:24pm Feb 5, 2017 1:24pm
Hello,

Please I need you guys help on this ea (A Para). I am trying to close it with a currency strength indicator(10.7_CSS) but it keeps bring out "out of memory error". It also draws a lot of lines when viewed with back test.

Can someone Please really help. thanks


Inserted Code
double Cur_1Prev,Cur_1, Cur_2,Cur_2Prev;
Cur_1=iCustom(NULL,0,"10.7 CSS.v3.5_withAlertsCross_ withoutCHF.ex4", autoSymbols ,symbolsToWeigh , maxBars ,weighOnlySymbolOnChart,nonPropFont ,addSundayToMonday,showOnlySymbolOnChart, autoTimeFrame ,ind_tf ,timeFrame ,extraTimeFrame ,ignoreFuture,showCrossAlerts,differenceThreshold,showLevelCross,levelCrossValue,PopupAlert,EmailAlert,PushAlert,USD, EUR ,GBP ,JPY ,AUD , CAD, NZD, CssBuffer1,1);
Cur_1Prev=iCustom(NULL,0,"10.7 CSS.v3.5_withAlertsCross_ withoutCHF.ex4", autoSymbols ,symbolsToWeigh , maxBars ,weighOnlySymbolOnChart,nonPropFont ,addSundayToMonday,showOnlySymbolOnChart, autoTimeFrame ,ind_tf ,timeFrame ,extraTimeFrame ,ignoreFuture,showCrossAlerts,differenceThreshold,showLevelCross,levelCrossValue,PopupAlert,EmailAlert,PushAlert,USD, EUR ,GBP ,JPY ,AUD , CAD, NZD, CssBuffer1,2);
Cur_2=iCustom(NULL,0,"10.7 CSS.v3.5_withAlertsCross_ withoutCHF.ex4", autoSymbols ,symbolsToWeigh , maxBars ,weighOnlySymbolOnChart,nonPropFont ,addSundayToMonday,showOnlySymbolOnChart, autoTimeFrame ,ind_tf ,timeFrame ,extraTimeFrame ,ignoreFuture,showCrossAlerts,differenceThreshold,showLevelCross,levelCrossValue,PopupAlert,EmailAlert,PushAlert,USD, EUR ,GBP ,JPY ,AUD , CAD, NZD,CssBuffer2,1);
Cur_2Prev=iCustom(NULL,0,"10.7 CSS.v3.5_withAlertsCross_ withoutCHF.ex4", autoSymbols ,symbolsToWeigh , maxBars ,weighOnlySymbolOnChart,nonPropFont ,addSundayToMonday,showOnlySymbolOnChart, autoTimeFrame ,ind_tf ,timeFrame ,extraTimeFrame ,ignoreFuture,showCrossAlerts,differenceThreshold,showLevelCross,levelCrossValue,PopupAlert,EmailAlert,PushAlert,USD, EUR ,GBP ,JPY ,AUD , CAD, NZD, CssBuffer1,2);
 
 
if (Cur_1 > Cur_1Prev && Cur_2<Cur_2Prev) CloseSell();
if (Cur_1 < Cur_1Prev && Cur_2>Cur_2Prev) CloseBuy();
Attached Image (click to enlarge)
Click to Enlarge Name: Image1.png Size: 60 KB
Attached File(s)
File Type: mq4 10.7 CSS.v3.5_withAlertsCross_ withoutCHF.mq4   42 KB | 242 downloads
File Type: mqh Majesty_Order_Functions.mqh   27 KB | 203 downloads
File Type: mqh Majesty_TrendingMarket.mqh   13 KB | 183 downloads
File Type: mq4 A_PARA.mq4   18 KB | 232 downloads
  • #8
  • Jun 2, 2017 3:56am Jun 2, 2017 3:56am
How is it that Mql4 keeps calling and opening a new instance of this indicator but doesnt do the same for other indicators?
Attached Image (click to enlarge)
Click to Enlarge Name: mql4 calling indicator on each tick resulting to multiple windows.png Size: 106 KB
  • #9
  • Last Post: Jun 2, 2017 7:24am Jun 2, 2017 7:24am
Quoting Adewumi
How is it that Mql4 keeps calling and opening a new instance of this indicator but doesnt do the same for other indicators? {image}
Your problem is usually caused by a bad iCustom call, it can be caused by an incorrect indicator name or the wrong number of inputs referenced.

You have the indicator name as
"10.7 CSS.v3.5_withAlertsCross_ withoutCHF.ex4"
it should be
"10.7 CSS.v3.5_withAlertsCross_ withoutCHF"

Try this link it should help you get on the right track.
https://docs.mql4.com/indicators/icustom
Trade what you see not what you hope
0 traders viewing now