EA to read CSV file and plot values in indicator window | Page 2 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Import data excel/csv file in MT4 separate window 0 replies

Need little help to modify indicator to read csv file 3 replies

getting value from CSV file to mql indi and plot it 5 replies

How to convert expert advisor values into CSV file? 2 replies

Splitting values in a CSV file into individual cells 2 replies

Attachments: EA to read CSV file and plot values in indicator window
Exit Attachments

EA to read CSV file and plot values in indicator window

  • #21
  • Edited May 12, 2017 12:18pm May 11, 2017 4:44pm | Edited May 12, 2017 12:18pm
Quoting alesridl
Please do you have some unbugged version or .mq4 source code file to find problem and correct it?
It runs fine on my computer, provided that the data file it's reading is in the correct format. If you post your data file, I'll have a look at it.

I've attached the latest version of the MQ4 source. It needs the MQH libraries and MetaEditor/compiler build 509 to compile correctly (these are included in the ZIP file).
___________________________

[EDIT]
I've added a build 600+ version of the indicator in the ZIP file, also a sample data.csv file that I created using Excel (values plotted are random numbers generated, between 1 and 100), that was used to create the screenshot below. You will still need the MQH library files, but not the MetaEditor/compiler build 509 if you use the b600+ version of the indicator. Everything you need is in the correct folders in the ZIP.

The plot in the screenshot uses 2,338 data points going back to 2008, and appears instantly on my computer without any problem, when I attach the indicator. Hence I don't believe that the indicator is buggy; the problem you're experiencing is more likely caused by something else. (I'm running Pepperstone MT4 build 1065 on Windows 7 Home Premium SP 1). I repeat my earlier offer: if you post your data file, I'll have a look at it.
Attached Image (click to enlarge)
Click to Enlarge Name: PPI 313.png Size: 193 KB
Attached File(s)
File Type: zip Plot external data.zip   2.8 MB | 865 downloads
  • #22
  • May 11, 2017 5:25pm May 11, 2017 5:25pm
Quoting hanover
...I've attached the latest version of the MQ4 source. It needs the MQH libraries and MetaEditor/compiler build 509 to compile correctly (these are included in the ZIP file).
Hi @hanover, you wanted to post the EA, or only the .mqh files?
In "Experts" there is no .mq4 file!
  • #23
  • May 11, 2017 6:11pm May 11, 2017 6:11pm
Quoting SwingMan
you wanted to post the EA, or only the .mqh files? In "Experts" there is no .mq4 file!
It's an indicator not an EA, check the /MQL4/Indicators folder.
  • #24
  • May 12, 2017 1:32am May 12, 2017 1:32am
Quoting hanover
... It's an indicator not an EA, check the /MQL4/Indicators folder.
Is OK, thank you!
  • #25
  • May 12, 2017 1:41am May 12, 2017 1:41am
Quoting hanover
{quote} It runs fine on my computer, provided that the data file it's reading is in the correct format. If you post your data file, I'll have a look at it. I've attached the latest version of the MQ4 source. It needs the MQH libraries and MetaEditor/compiler build 509 to compile correctly (these are included in the ZIP file). {file}
Thanks for .zip file

But i am using MT4, build 600+ (1065), as you see at the picture.

How can i use it correctly with my build? Only copy folders from .zip file to my MT4? Or something else?

Thanks for advice

A.
Attached Image
  • #26
  • May 12, 2017 2:44am May 12, 2017 2:44am
Quoting alesridl
How can i use it correctly with my build?
See the comments that I've added in blue typeface to post #21.
  • #27
  • May 12, 2017 5:03am May 12, 2017 5:03am
Quoting hanover
{quote} See the comments that I've added in blue typeface to post #21.
Hi Hannover,

Thanks for update.
I copied folders from .zip file to my MT4 folders all at once.

Unfortunately Metatrader still freezing after using Plot External Data B600+.
I tried on Different Metatraders, works same bad.

Don't know how to solve that.......
  • #28
  • May 12, 2017 5:15am May 12, 2017 5:15am
Quoting alesridl
Don't know how to solve that.......
Neither do I. Indicator works fine on my computer, I can't reproduce your problem. Hence I can't help any further.
  • #29
  • May 12, 2017 5:22am May 12, 2017 5:22am
Quoting hanover
{quote} Neither do I. Indicator works fine on my computer, I can't reproduce your problem. Hence I can't help any further.
Thanks for help anyway.....
  • #30
  • Jul 4, 2017 5:56pm Jul 4, 2017 5:56pm
Hi hanover,

Thanks for this indicator. I think it'll help me a lot, but I've run into a problem. As you can see on the attached image that I've got two separate data sets loaded into the indicator. So far so good. I've marked two points on the indicator - 67 and 100. Level 67 on the chart is on 21.06.17 and level 100 on the chart is on 27.06.17.

These two correspond with the data which is loaded from separate files. The issue is that 67 and 100 show on the same level and 67 should be lower than 100. The data flows between -100 and 100 on either extreme. There are other points on the indicator that suffer the same issue.

I've attached the .csv files used here. The blue line on the indicator relates to eurostr csv and the orange to usdstr. The data really starts at the end of the data range so you need to scroll to the bottom of the spreadsheet.

Can you please help with it? Should I have done something differently when loading up the data? Or will the scaling fall into place once both data sets hit -100 and +100?

Many thanks again.

Rob

Attached Image (click to enlarge)
Click to Enlarge Name: EURUSDSBDaily.png Size: 37 KB
Attached File(s)
File Type: csv eurostr.csv   6 KB | 331 downloads
File Type: csv usdstr.csv   6 KB | 317 downloads
  • #31
  • Edited 2:22am Jul 5, 2017 2:02am | Edited 2:22am
Rob,
Quoting Robski
Or will the scaling fall into place once both data sets hit -100 and +100?
Yes, I believe that it will. But did you try fixing the scaling (for both instances of the indicator) as shown in the screenshot below?

Thanks for providing data files, it makes troubleshooting a realistic possibility. The screenshot was produced using the data files that you uploaded, without any changes. Hence I believe that your data files, and indicator settings, are fine.

Chart below is EURUSD,D1. Sorry, I got the colors the opposite way around (blue=usdstr, red=eurostr).

Also, the screenshot was generated using the build 509 version of the indicator. As far as I know, the build 600+ version has an intermittent problem with the array subscripting, causing the final data point not to plot.

David
Attached Image (click to enlarge)
Click to Enlarge Name: PPI 309.png Size: 87 KB
  • #32
  • Jul 5, 2017 3:40am Jul 5, 2017 3:40am
Quoting hanover
Rob, {quote} Yes, I believe that it will. But did you try fixing the scaling (for both instances of the indicator) as shown in the screenshot below? Thanks for providing data files, it makes troubleshooting a realistic possibility. The screenshot was produced using the data files that you uploaded, without any changes...
Thanks hanover! I'll deduct myself points for this oversight. All is working well now.
  • #33
  • Jul 5, 2017 5:53am Jul 5, 2017 5:53am
Hey hanover. Thanks for this indicator. I've used it.
Can you also provide me a version where the indicator is not in a seperate window but onto the main chart? Thanks.
Multiple SMA Trader
  • #34
  • Jul 5, 2017 7:41am Jul 5, 2017 7:41am
Quoting lechugas
Can you also provide me a version where the indicator is not in a seperate window but onto the main chart?
The scale in the main chart depends on the price range of the instrument, which might not be suitable for the scale of the external data being plotted.

Take Robski's example in post #30, where the values of his external plots range between -100 and +100. If (for example) you were to plot this on a EURUSD,D1 chart, the price ranges between approx 1.0470 and 1.1500. Hence any values outside of this range, which would probably represent more than 99% of them, would plot off the chart and could not be seen, making the whole exercise futile.

It would be possible to re-scale the values from [-100,100] so that they fitted within the price range, and thus effectively having multiple Y-axes, but this price range is constantly re-scaling itself to fit the candles in the main chart window. It could potentially be done but would require a significant amount of complex coding, and running this could also slow computer performance. Hence in my view it's simpler to plot the external values in subwindows, where each subwindow can have its own Y-axis range that's suitable for the data set being plotted; i.e. the way it currently operates.
  • #35
  • Jul 5, 2017 7:50am Jul 5, 2017 7:50am
Quoting hanover
{quote} The scale in the main chart depends on the price range of the instrument, which might not be suitable for the scale of the external data being plotted. Take Robski's example in post #30, where the values of his external plots range between -100 and +100. If (for example) you were to plot this on a EURUSD,D1 chart, the price ranges between approx 1.0470 and 1.1500. Hence any values outside of this range, which would probably represent more than 99% of them, would plot off the chart and could not be seen, making the whole exercise futile....
Thanks for your explanation and recommendation. I was planning to plot predicted price points for selected instruments in the future with a line like the seperate window. Anyways, since it's going to take a lot more computing. I'll stick with the seperate window indicators. Thanks!
Multiple SMA Trader
  • #36
  • Jul 5, 2017 2:26pm Jul 5, 2017 2:26pm
Quoting lechugas
{quote} Thanks for your explanation and recommendation. I was planning to plot predicted price points for selected instruments in the future with a line like the seperate window. Anyways, since it's going to take a lot more computing. I'll stick with the seperate window indicators. Thanks!
Here's how I'm doing it by manipulating the template file.

https://www.forexfactory.com/showthr...57#post9722557
  • #37
  • Edited 11:17pm Jul 5, 2017 8:24pm | Edited 11:17pm
Quoting lechugas
I'll stick with the seperate window indicators.
Changed my mind and was persuaded to accept the challenge.

The indicator has to re-scale the plot with each new price tick, so it could affect computer performance; use at your own risk. (You can also toggle between chart timeframes to force a re-plot).

See screenshots below for explanations.
Attached Image(s) (click to enlarge)
Click to Enlarge Name: PPI 073.png Size: 64 KB
Click to Enlarge Name: PPI 012.png Size: 49 KB
Attached File(s)
File Type: ex4 Plot External Data (main chart).ex4   34 KB | 387 downloads
  • #38
  • Jul 6, 2017 5:56am Jul 6, 2017 5:56am
Quoting hanover
{quote} Changed my mind and was persuaded to accept the challenge. The indicator has to re-scale the plot with each new price tick, so it could affect computer performance; use at your own risk. (You can also toggle between chart timeframes to force a re-plot). See screenshots below for explanations. {file} {image} {image}
Thanks a lot for your hard work! I really do appreciate it. I'm going to try and use it.
Multiple SMA Trader
  • #39
  • Jul 7, 2017 3:21pm Jul 7, 2017 3:21pm
Hello hanover.
How do you make the indicators plot past the current bar?
I have a .csv file that i want to be projected in the future.
The values in the .csv only appear in the indicator after bar closing.

Here is an example of what I mean.
Attached Image (click to enlarge)
Click to Enlarge Name: audcad-d1-fbs-inc-2.png Size: 21 KB


Also, here is the indicator in case it helps you with the coding.
Attached File(s)
File Type: mq4 seasonal.mq4   8 KB | 534 downloads
Multiple SMA Trader
  • #40
  • Edited 3:49pm Jul 7, 2017 3:39pm | Edited 3:49pm
Quoting lechugas
Also, here is the indicator in case it helps you with the coding.
In the code you provided, it looks like the programmer is populating Buffer1[i] in the 'conventional' way, and then shifting the whole plot to the right using SetIndexShift(). Just my best guess without spending a long time reverse engineering the code:
Attached Image


You can achieve a similar effect using a shifted MA, for example:
Attached Image (click to enlarge)
Click to Enlarge Name: PPI 110.png Size: 71 KB


_____________________
[EDIT]
Looks like my guess was good, this is what happens if you remove the SetIndexShift() command from his code:
Attached Image (click to enlarge)
Click to Enlarge Name: PPI 116.png Size: 30 KB
0 traders viewing now