Commodity Channel Index with added input

Quoting metta87

Disliked

hello i would like to know if it is possible to add an option on the default mt4 commodity channel index. Basically lets say, on a 14 period of the commodity channel index, if i add a value of 100.50 for example, the indicator will highlight all the bars which have exact value of 100.50 and -100.50. Thank you. P.s : The commodity channel index is different than cci.

Ignored

Quoting metta87

Disliked

hello i would like to know if it is possible to add an option on the default mt4 commodity channel index. Basically lets say, on a 14 period of the commodity channel index, if i add a value of 100.50 for example, the indicator will highlight all the bars which have exact value of 100.50 and -100.50. Thank you. P.s : The commodity channel index is different than cci.

Ignored

Quoting fxanalysis

Disliked

{quote} channel index indi will highlight all candles that have reached certain level. Put them all in one place or channel indi wont work. {file} {file} {file} {file}

Ignored

Quoting metta87

Disliked

hello i would like to know if it is possible to add an option on the default mt4 commodity channel index. Basically lets say, on a 14 period of the commodity channel index, if i add a value of 100.50 for example, the indicator will highlight all the bars which have exact value of 100.50 and -100.50. Thank you. P.s : The commodity channel index is different than cci.

Ignored

Quoting fxanalysis

Disliked

{quote} here is one who highlights exact value like you asked {file} {file}

Ignored

Quoting metta87

Disliked

{quote} fxanalysis the indicator doesnt show on a chart, can you please take a look. Also it makes the mt4 crash.

Ignored

Quoting metta87

Disliked

hello i would like to know if it is possible to add an option on the default mt4 commodity channel index. Basically lets say, on a 14 period of the commodity channel index, if i add a value of 100.50 for example, the indicator will highlight all the bars which have exact value of 100.50 and -100.50. Thank you. P.s : The commodity channel index is different than cci.

Ignored

Quoting mladen

Disliked

{quote} Why do you think that "commodity channel index" is different from CCI? They are the same ... https://en.wikipedia.org/wiki/Commodity_channel_index

Ignored

Quoting metta87

Disliked

{quote} hello mladen maybe they have the same name but when you put both on a chart with the exact same settings, the values are differents. Take a look at this chart, cci 10, commodity channel index 10 lol.png;2163018 No matter which candles, the value on both indicators differ. Try it yourself, and you will see what i mean. I even found another forum where a guy also mentions about it, dating from 2007. {image}

Ignored

Quoting mladen

Disliked

{quote} Attach the thing you are testing ... The "commodity channel index" (CCI) was invented in 1980 (by Donald Lambert) and whatever is using that same name and does not have the same values for same settings, is wrongly coded

Ignored

Quoting metta87

Disliked

{quote} i dont know how to attach it, but if you go on mt4>indicators>oscillators> you will find the commodity channel index. And if you go on mt4>indicators>under examples you will see cci. Both are default mt4 indicators.pot.png;2163065 Take a look at the picture, to the left, under "oscillators" there you will find commodity channel index. And completely below, you will see "cci". Try to put both a chart. {image}

Ignored

Quoting metta87

Disliked

{quote} i dont know how to attach it, but if you go on mt4>indicators>oscillators> you will find the commodity channel index. And if you go on mt4>indicators>under examples you will see cci. Both are default mt4 indicators.pot.png;2163065 Take a look at the picture, to the left, under "oscillators" there you will find commodity channel index. And completely below, you will see "cci". Try to put both a chart. {image}

Ignored

Quoting fxanalysis

Disliked

{quote} They shouldn't crash anything but here is a better Highlighter , just made it. This one works solo, so you don't need any other indicator with this one to work. You can set inputs yourself now. Screenshot1.png;2162290 {file} {file} {image}

Ignored

Quoting mladen

Disliked

{quote} As I told already : post the thing you are testing. Otherwise it is comparing whatever with whatever for whatever settings ... not much sense in doing so. And, judging from your picture, you are comparing some custom coded indicator with the built in indicator. So, please post the custom coded indicator that you are trying to compare to the built in cci indicator so that we all can see what is it all about and why. PS: in the lower left corner of the post when you are editing it, you have the attach files text. Use that and attach the thing...

Ignored

---------------------------------------------+
//|                                                          CCI.mq4 |
//|                   Copyright 2005-2014, MetaQuotes Software Corp. |
//|                                              http://www.mql4.com |
//+------------------------------------------------------------------+
#property copyright   "2005-2014, MetaQuotes Software Corp."
#property link        "http://www.mql4.com"
#property description "Commodity Channel Index"
#property strict
#include <MovingAverages.mqh>
#property indicator_separate_window
#property indicator_buffers    1
#property indicator_color1     LightSeaGreen
#property indicator_level1    -100.0
#property indicator_level2     100.0
#property indicator_levelcolor clrSilver
#property indicator_levelstyle STYLE_DOT
//--- input parameter
input int InpCCIPeriod=14; // CCI Period
//--- buffers
double ExtCCIBuffer[];
double ExtPriceBuffer[];
double ExtMovBuffer[];
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int OnInit(void)
  {
   string short_name;
//--- 2 additional buffers are used for counting.
   IndicatorBuffers(3);
   SetIndexBuffer(1,ExtPriceBuffer);
   SetIndexBuffer(2,ExtMovBuffer);
//--- indicator line
   SetIndexStyle(0,DRAW_LINE);
   SetIndexBuffer(0,ExtCCIBuffer);
//--- check for input parameter
   if(InpCCIPeriod<=1)
     {
      Print("Wrong input parameter CCI Period=",InpCCIPeriod);
      return(INIT_FAILED);
     }
//---
   SetIndexDrawBegin(0,InpCCIPeriod);
//--- name for DataWindow and indicator subwindow label
   short_name="CCI("+IntegerToString(InpCCIPeriod)+")";
   IndicatorShortName(short_name);
   SetIndexLabel(0,short_name);
//--- initialization done
   return(INIT_SUCCEEDED);
  }
//+------------------------------------------------------------------+
//| Commodity Channel Index                                          |
//+------------------------------------------------------------------+
int OnCalculate(const int rates_total,
                const int prev_calculated,
                const datetime &time[],
                const double &open[],
                const double &high[],
                const double &low[],
                const double &close[],
                const long &tick_volume[],
                const long &volume[],
                const int &spread[])
  {
   int    i,k,pos;
   double dSum,dMul;
//---
   if(rates_total<=InpCCIPeriod || InpCCIPeriod<=1)
      return(0);
//--- counting from 0 to rates_total
   ArraySetAsSeries(ExtCCIBuffer,false);
   ArraySetAsSeries(ExtPriceBuffer,false);
   ArraySetAsSeries(ExtMovBuffer,false);
   ArraySetAsSeries(high,false);
   ArraySetAsSeries(low,false);
   ArraySetAsSeries(close,false);
//--- initial zero
   if(prev_calculated<1)
     {
      for(i=0; i<InpCCIPeriod; i++)
        {
         ExtCCIBuffer[i]=0.0;
         ExtPriceBuffer[i]=(high[i]+low[i]+close[i])/3;
         ExtMovBuffer[i]=0.0;
        }
     }
//--- calculate position
   pos=prev_calculated-1;
   if(pos<InpCCIPeriod)
      pos=InpCCIPeriod;
//--- typical price and its moving average
   for(i=pos; i<rates_total; i++)
     {
      ExtPriceBuffer[i]=(high[i]+low[i]+close[i])/3;
      ExtMovBuffer[i]=SimpleMA(i,InpCCIPeriod,ExtPriceBuffer);
     }
//--- standard deviations and cci counting
   dMul=0.015/InpCCIPeriod;
   pos=InpCCIPeriod-1;
   if(pos<prev_calculated-1)
      pos=prev_calculated-2;
   i=pos;
   while(i<rates_total)
     {
      dSum=0.0;
      k=i+1-InpCCIPeriod;
      while(k<=i)
        {
         dSum+=MathAbs(ExtPriceBuffer[k]-ExtMovBuffer[i]);
         k++;
        }
      dSum*=dMul;
      if(dSum==0.0)
         ExtCCIBuffer[i]=0.0;
      else
         ExtCCIBuffer[i]=(ExtPriceBuffer[i]-ExtMovBuffer[i])/dSum;
      i++;
     }
//---
   return(rates_total);
  }
//+------------------------------------------------------------------+

Quoting mladen

Disliked

{quote} As I told already : post the thing you are testing. Otherwise it is comparing whatever with whatever for whatever settings ... not much sense in doing so. And, judging from your picture, you are comparing some custom coded indicator with the built in indicator. So, please post the custom coded indicator that you are trying to compare to the built in cci indicator so that we all can see what is it all about and why. PS: in the lower left corner of the post when you are editing it, you have the attach files text. Use that and attach the thing...

Ignored

Quoting metta87

Disliked

{quote} ok mladen but i dont know how to attach the code. tell me if thats what you talking about. here is the cci ---------------------------------------------+ //| CCI.mq4 | //| Copyright 2005-2014, MetaQuotes Software Corp. | //| http://www.mql4.com | //+------------------------------------------------------------------+ #property copyright "2005-2014, MetaQuotes Software Corp." #property link "http://www.mql4.com" #property description "Commodity Channel Index" #property strict #include <MovingAverages.mqh> #property indicator_separate_window...

Ignored

Quoting mladen

Disliked

{quote} That same code compared to built in cci cci.png;2163202 They are exactly the same (if you use the typical price in the built in cci). Used the "_test" file (that is the code pasted from your post) {file} {image}

Ignored

Quoting metta87

Disliked

{quote} hello fxanalysis, first of all thanks for the effort i really appreciate it, and this time it finally works. The only problem is that the indicator used isnt the commodity channel index but the cci and the second is that when i enter a value in the settings the indicator doesnt find candles with the exact same value, but find all candles with the same value and above. For example if i put a value of 150.80, the indicator should find all candles with value 150.80 only, not 150.80 and above. I dont have the code for the commodity channel indicator,...

Ignored