how EA collect last indicator buffer? | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

How to get the value from indicator which doesn't use buffer? 9 replies

Last buffer with value 2 replies

Multiple lines in a indicator, but how to select the second buffer? 1 reply

Buffer indicator 3 replies

Calculate Stochastic Formula on a array (non indicator buffer array) 2 replies

Attachments: how EA collect last indicator buffer?
Exit Attachments

how EA collect last indicator buffer?

  • #1
  • First Post: Jan 10, 2017 11:05am Jan 10, 2017 11:05am
dear coders,

in my EA, i need to collect last buffer value for attach indicator where there are 6 buffers value but they are not come in all time in every bar. among those buffers value Number 5 & 6 come alternatively, so i need to collect last printed value of 5 or 6 and select which one

for collecting indicator buffer value i m using icustom, but i m not getting last printed 5 or 6 value.

i m adding my indicator here and also attaching buffer 5 and 6 data window value in two screenshot here

Attached File(s)
File Type: ex4 RenkoScalp_SMF.ex4   8 KB | 282 downloads


Attached Image (click to enlarge)
Click to Enlarge Name: buffer 5.png Size: 34 KB


Attached Image (click to enlarge)
Click to Enlarge Name: buffer 6.png Size: 34 KB


thanks
  • #2
  • Jan 10, 2017 2:52pm Jan 10, 2017 2:52pm
Perhaps your iCustom command is not set up correctly. More info here (http://www.forexfactory.com/showthread.php?p=9393926#post9393926).

Beyond that, you will need to post your .mq4 file, if you want a programmer to investigate what is wrong with your code.
But it will have to be somebody else, I have other work to get on with.
  • #3
  • Jan 10, 2017 6:52pm Jan 10, 2017 6:52pm
Quoting hanover
Perhaps your iCustom command is not set up correctly. More info here (http://www.forexfactory.com/showthread.php?p=9393926#post9393926). Beyond that, you will need to post your .mq4 file, if you want a programmer to investigate what is wrong with your code. But it will have to be somebody else, I have other work to get on with.
thanks for reply

double smfup = iCustom(NULL,0,"RenkoScalp_SMF",0.0,0.0,24.0,0.0,0.0,3.8,0,0,177,5,0);
double smfdown = iCustom(NULL,0,"RenkoScalp_SMF",0.0,0.0,24.0,0.0,0.0,3.8,0,0,177,6,0);

i already code it where buffer 5 is up signal and 6 is down signal, but the both up and down signal came and show buffer value once where it is own bar. my problem is in next and next bar where no 5 and 6 buffer value available, how my EA understand that still up or down signal is there until next signal came.

is there any memory option to save it until next signal come or search previous some bars to detect what is last signal? for this what code will need...

thanks
  • #4
  • Edited 4:09pm Jan 11, 2017 3:46pm | Edited 4:09pm
Quoting sajib0189
thanks for reply......
Your iCustom statements crashed my MT4. Then I noticed that you have periods in your parameter list where you should probably have commas -- see screenshot below.
Try something like:

double smfup = iCustom(NULL,0,"RenkoScalp_SMF",0.0,0.0,24.0,"0,0","0,0","3,8",0,0,177,5,0);
double smfdown = iCustom(NULL,0,"RenkoScalp_SMF",0.0,0.0,24.0,"0,0","0,0","3,8",0,0,177,6,0);

Also, if there is no data in buffer 5 or 6, this will have an empty value, hence you need to ensure that you have the last parameter (datapoint#) correct.

Quote
is there any memory option to save it until next signal come or search previous some bars to detect what is last signal? for this what code will need...
You could try something like:
Inserted Code
  double smfup = 0, smfdown = 0;
  for (int z=0; z<Bars; z++)  {
    double x_up = iCustom(NULL,0,"RenkoScalp_SMF",0.0,0.0,24.0,"0,0","0,0","3,8",0,0,177,5,z);
    double x_dn = iCustom(NULL,0,"RenkoScalp_SMF",0.0,0.0,24.0,"0,0","0,0","3,8",0,0,177,6,z);
    if (x_up == EMPTY || x_up == EMPTY_VALUE)    x_up = 0;
    if (x_dn == EMPTY || x_dn == EMPTY_VALUE)    x_dn = 0;
    if (x_up > 0 && smfup == 0)     smfup   = x_up;
    if (x_dn > 0 && smfdown == 0)   smfdown = x_dn;
    if (smfup > 0 && smfdown > 0)   break;
  }

Will let you test all of this as I don't want to crash my MT4 again.
Attached Image (click to enlarge)
Click to Enlarge Name: PPI 120.png Size: 35 KB
  • #5
  • Jan 12, 2017 9:44am Jan 12, 2017 9:44am
Quoting hanover
{quote} Your iCustom statements crashed my MT4. Then I noticed that you have periods in your parameter list where you should probably have commas -- see screenshot below. Try something like: double smfup = iCustom(NULL,0,"RenkoScalp_SMF",0.0,0.0,24.0,"0,0","0,0","3,8",0,0,177,5,0); double smfdown = iCustom(NULL,0,"RenkoScalp_SMF",0.0,0.0,24.0,"0,0","0,0","3,8",0,0,177,6,0); Also, if there is no data in buffer 5 or 6, this will have an empty value, hence you need to ensure that you have the last parameter (datapoint#) correct. {quote} You could try...
boss, what is the possible cause of terminal hang?
if i use icustom in EA, normaly terminal hang?
  • #6
  • Edited 4:20pm Jan 12, 2017 2:58pm | Edited 4:20pm
Quoting sajib0189
what is the possible cause of terminal hang? if i use icustom in EA, normaly terminal hang?
I wrote a test script (not indicator) using the code below, you can see the end result in the screenshot.

Note how you have to use buffer# 4 and 5 in the iCustom() command, because buffer numbers start from 0, not 1.

The code below seems to deliver the correct solution without hanging the terminal. Hence the problem must be somewhere else in your EA. You will need to get another programmer to help you, I have other work to get on with.
Inserted Code
void OnStart()  {
  double smfup = 0, smfdown = 0;
  for (int z=0; z<Bars; z++)  {
    double x_up = iCustom(NULL,0,"RenkoScalp_SMF",0.0,0.0,24.0,"0,0","0,0","3,8",0,0,177,4,z);
    double x_dn = iCustom(NULL,0,"RenkoScalp_SMF",0.0,0.0,24.0,"0,0","0,0","3,8",0,0,177,5,z);
    if (x_up == EMPTY || x_up == EMPTY_VALUE)    x_up = 0;
    if (x_dn == EMPTY || x_dn == EMPTY_VALUE)    x_dn = 0;
    if (x_up > 0 && smfup == 0)     smfup   = x_up;
    if (x_dn > 0 && smfdown == 0)   smfdown = x_dn;
    if (smfup > 0 && smfdown > 0)   break;
  }
  MessageBox("smfup = "+DoubleToStr(smfup,5)+"\nsmfdown = "+DoubleToStr(smfdown,5));  
}
Attached Image (click to enlarge)
Click to Enlarge Name: PPI 038.png Size: 33 KB

____________________________________

Below is a screenshot taken an hour or so later. Note that the red signal (which was previously in the location shown by the question marked arrow) has disappeared, and now a new signal occurs as a new low forms. In other words, the indicator repaints, i.e. there were historical signals on the chart that are no longer displayed.

Just pointing this out, in case you haven't already noticed it.
Attached Image (click to enlarge)
Click to Enlarge Name: PPI 144.png Size: 25 KB
  • #7
  • Jan 12, 2017 11:11pm Jan 12, 2017 11:11pm
Quoting hanover
{quote} I wrote a test script (not indicator) using the code below, you can see the end result in the screenshot. Note how you have to use buffer# 4 and 5 in the iCustom() command, because buffer numbers start from 0, not 1. The code below seems to deliver the correct solution without hanging the terminal. Hence the problem must be somewhere else in your EA. You will need to get another programmer to help you, I have other work to get on with. void OnStart() { double smfup = 0, smfdown = 0; for (int z=0; z<Bars; z++) { double x_up = iCustom(NULL,0,"RenkoScalp_SMF",0.0,0.0,24.0,"0,0","0,0","3,8",0,0,177,4,z);...
yes boss, i know it is repaint...if u use higher time frame M30 or H1 or higher, repaint not done normally.

another thing is, in ur script its showing both upsmf and downsmf, i think its detecting last 2 spot, but i want only last spot either it is upsmf or downsmf, so if one value came others one must be emmty value so that my ea can understand it is up spot or down spot...thanks for coding help again

i m attaching my EA here, also add all indicator and template use there, in manually trade with these all indi i can make money, but i m doing job ..that why i m trying to make this ea with 3 main indicator among all this system.

Attached File(s)
File Type: mq4 saj renko scalp ea.mq4   8 KB | 259 downloads

Attached File(s)
File Type: zip Indicator.zip   75 KB | 265 downloads

Attached File(s)
File Type: tpl Renko scalp system.tpl   39 KB | 263 downloads


thanks
  • #8
  • Last Post: Jan 13, 2017 3:08pm Jan 13, 2017 3:08pm
Quoting sajib0189
another thing is, in ur script its showing both upsmf and downsmf, i think its detecting last 2 spot, but i want only last spot either it is upsmf or downsmf, so if one value came others one must be emmty value so that my ea can understand it is up spot or down spot...
Code below produces result in screenshot. This is my last post here. Sorry, but I have other work to do.
Inserted Code
void OnStart()  {
  double smfup = 0, smfdown = 0;
  for (int z=0; z<Bars; z++)  {
    double x_up = iCustom(NULL,0,"RenkoScalp_SMF",0.0,0.0,24.0,"0,0","0,0","3,8",0,0,177,4,z);
    double x_dn = iCustom(NULL,0,"RenkoScalp_SMF",0.0,0.0,24.0,"0,0","0,0","3,8",0,0,177,5,z);
    if (x_up == EMPTY || x_up == EMPTY_VALUE)    x_up = 0;
    if (x_dn == EMPTY || x_dn == EMPTY_VALUE)    x_dn = 0;
    if (x_up > 0 && smfup == 0)     smfup   = x_up;
    if (x_dn > 0 && smfdown == 0)   smfdown = x_dn;
    if (smfup > 0 || smfdown > 0)   break;
  }
  double smf = MathMax(smfup,smfdown);
  MessageBox("smfup = "+DoubleToStr(smfup,5)+"\nsmfdown = "+DoubleToStr(smfdown,5)+"\nsmf = "+DoubleToStr(smf,5));  
}
Attached Image (click to enlarge)
Click to Enlarge Name: PPI 145.png Size: 37 KB
0 traders viewing now