Some help on debugging my code please :) | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Need help debugging EA to move SL twice 4 replies

Need help debugging SFX TOR indicator 2 replies

EA debugging help Please - SevenChi 7 replies

Need help debugging 0 replies

Help debugging my EA I feel like the solution is too simple. 1 reply

Attachments: Some help on debugging my code please :)
Exit Attachments

Some help on debugging my code please :)

  • #1
  • First Post: Edited Jul 30, 2021 7:13am Nov 29, 2016 5:05am | Edited Jul 30, 2021 7:13am
Hi there coders!

I've been working on an alternative rework of my last EA lately.
For a reason I don't understand it works like a charm when activated one-way (Long Only or Short Only) but despite my efforts to have divided the code into 2 separate parts, one for longs and one for shorts, the EA won't behave the way it should when both directions are activated.

You'll find attached a lightweight version of my EA, thanks for your help, be sure I'll share the strategy as a whole once it works fine!

Attached File(s)
File Type: mq4 Keops.mq4   13 KB | 524 downloads
You'll always miss 100% of the shots you don't take.
  • #2
  • Nov 29, 2016 2:49pm Nov 29, 2016 2:49pm
It work on five digits broker !

It stop putting takeprofit at some moment :
Attached Image (click to enlarge)
Click to Enlarge Name: Screenshot1.png Size: 355 KB
  • #3
  • Nov 29, 2016 3:27pm Nov 29, 2016 3:27pm
There is an error here :

Inserted Code
if (nb_longs>0 && nb_longs<max_trades){
   if (BUY == true){
      if (RSI_0>RSI_1 && last<= NormalizeDouble(buy_min-(step_long),Digits)){
         OrderSend(Symbol(),OP_BUY,mlots_1,
                Ask,0,0,0,
                "Robot Test "+DoubleToStr(mlots_1,2)+" on "+Symbol(),
                magic_1,0,Turquoise);
        
       [b] for(i=0;i<OrdersTotal();i++)[/b]{
            if((OrderMagicNumber()==magic_1) && OrderSymbol()==Symbol() && OrderType() == OP_BUY){
               OrderSelect(i, SELECT_BY_POS, MODE_TRADES);
               OrderModify(OrderTicket(),OrderOpenPrice(),0,NormalizeDouble((buy_min+tp),Digits),0,Turquoise);
            }
         }
      }
   }
}

for all the buy order the tp will be at : buy_min + tp,
this mean lower than the oop of the order buy when there is several order
  • #4
  • Nov 30, 2016 4:14am Nov 30, 2016 4:14am
Quoting machine25
It work on five digits broker ! It stop putting takeprofit at some moment : {image}

It clearly doesn't work fine ahahah,
But how comes that the TP level is right when only the shorts or longs are enabled??? I can't understand!
You'll always miss 100% of the shots you don't take.
  • #5
  • Dec 1, 2016 2:00pm Dec 1, 2016 2:00pm
Anyone? Did the coders flee MT4 or what ahah
You'll always miss 100% of the shots you don't take.
  • #6
  • Edited 6:07am Dec 3, 2016 5:55am | Edited 6:07am
Quoting Edorenta
{quote} It clearly doesn't work fine ahahah, But how comes that the TP level is right when only the shorts or longs are enabled??? I can't understand!
Excuse me, but I don't see anything in the EA to enable or disable onlybuy or onlysell.
I don't see the EA being separatate in two part.
If the magic number is set to zero, it will open buy and sell with no magic number.


The problem is :
if a takeprofit buy is put below oop it send error 131 (invalid stop), this is what the code posted above do;
otherwise it should be stoploss, (or trailingstop.) not takeprofit,

solution :

Inserted Code
if (nb_shorts==0){
   SELL = false;
   sl2_set = false;
  
   if (RSI_0<RSI_1) {
    int ticket_sell =  OrderSend(Symbol(),OP_SELL,mlots_2,
                Bid,0,0,Bid-tp,
                "Robot Test "+DoubleToStr(mlots_2,2)+" on "+Symbol(),
                magic_2,0,Magenta);
      SELL = true;
 
    if( ticket_sell > 0 )     Put_stoploss_wherever_it_has_to_be();
      }
   }
 }
  • #7
  • Dec 3, 2016 6:38am Dec 3, 2016 6:38am
Quoting Edorenta
Anyone? Did the coders flee MT4 or what ahah
If you want somebody to help you, use descriptive names of variables in your EA
Inserted Code
extern double blots = 0.01;            //Base lot size
extern double xtor = 1.6;              //Martingale multiplicator
extern double increment = 0.01;        //Scaler increment
extern int atr_p = 50;                 //ATR TP period
extern double atr_x = 0.5;             //ATR TP multiplier
extern double step_x = 0.5;            //Step (TP multiplier)
extern bool inc_step = true;           //Increasing step
extern int rsi_p = 5;                  //RSI period
extern int max_trades = 6;             //Max number of trades in Cycle
extern bool use_war_stop = true;       //Use Emergency Stop  
extern double war_stop_pct = 25;       //Emergency Stop K%

Do you really expect coders to keep scrolling up and down to find what these variables are?
Inserted Code
extern double xtor = 1.6;              //Martingale multiplicator

xtor is meaningless, why not just name it in a descriptive way?

Inserted Code
extern double MartingaleMultiplicator= 1.6;              //Martingale multiplicator

With autocomplete it is very easy to use descriptive names for variables, it makes it much easier for others to follow your code and believe me in 2,3,4 weeks when you come back to work on your code after a break, you won't be able to follow it either.
Please Do Not PM Me With Coding Enquiries
  • #8
  • Dec 3, 2016 8:03am Dec 3, 2016 8:03am
My last word : just added be
Attached File(s)
File Type: mq4 Keops_1_01.mq4   17 KB | 590 downloads
  • #9
  • Last Post: Dec 5, 2016 4:39am Dec 5, 2016 4:39am
Quoting Gumrai
{quote} If you want somebody to help you, use descriptive names of variables in your EA extern double blots = 0.01; //Base lot size extern double xtor = 1.6; //Martingale multiplicator extern double increment = 0.01; //Scaler increment extern int atr_p = 50; //ATR TP period extern double atr_x = 0.5; //ATR TP multiplier extern double step_x = 0.5; //Step (TP multiplier) extern bool inc_step = true; //Increasing step extern int rsi_p = 5; //RSI period extern int max_trades = 6; //Max number of trades in Cycle extern bool use_war_stop = true; //Use...
Thanks for the input. I figured out what was going wrong.
It it descriptive to me but not to other coders I should have thought about it excuse me
You'll always miss 100% of the shots you don't take.
0 traders viewing now