my LockInProfit() and CloseAll() fail to close everything | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Everything to Nothing to get Everything? 7 replies

CloseAll Scritp!!! Some modifications needed!!! 0 replies

Need help!! Close order on this bar close 5 replies

Question on closeAll function 5 replies

Seeking Correct Open/Close - It's Close but ... 0 replies

my LockInProfit() and CloseAll() fail to close everything

  • #1
  • First Post: Sep 13, 2016 10:00pm Sep 13, 2016 10:00pm
Inserted Code
void LockInProfit()
{
   double Balance = AccountBalance();
   double Equity = AccountEquity();  
  
   if ((Equity) > (Balance*1.01))
   {          
         CloseAll();                
   }    return;
}
void CloseAll()
{
  // for (int i=OrdersTotal()-1;i>=0; i--)
   for (int i = 0; i < OrdersTotal(); i++)    // FIFO rule
   {
      if (OrderSelect(i, SELECT_BY_POS, MODE_TRADES))
      {
         RefreshRates();            
         if(!OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),slippage,clrNONE))
         Print("Error closing (CloseAll) #",IntegerToString(OrderTicket())," Error code ",GetLastError());
      }  
   }
}


I have multiple opened positions in multiple currencies. When LockInProfit() is triggered, it does not close everything.

Is the problem with LockInProfit() or/and CloseAll()?
I suspect that
1) The functions only close the currency pair that the EA is attached to and not all the other currency pairs.
2) At some point, it stop closing when (Equity) is no longer > (Balance*1.01).
How do I close everything? (All opened positions in multiple currencies )

How to close everything without attaching the EA to multiple charts of different pairs.
How do I close everything (including currencies of different pairs) when attaching the EA to only one chart?
  • #2
  • Sep 13, 2016 10:44pm Sep 13, 2016 10:44pm
You should use the Ask and Bid prices in the OrderClose() function. And separate the function according to the order type (buy or sell) ... as their closure price isn't the same.

Inserted Code
MarketInfo(_Symbol,MODE_ASK)
MarketInfo(_Symbol,MODE_BID)
MT4/MT5 EAs/Indicators/Alerts coder
  • #3
  • Sep 13, 2016 11:01pm Sep 13, 2016 11:01pm
Inserted Code
void CloseAll2()
{
 // int total = OrdersTotal();
 // for(int i=total-1;i>=0;i--)
  for (int i = 0; i < OrdersTotal(); i++)    // FIFO rule
  {
   // OrderSelect(i, SELECT_BY_POS);
    if (OrderSelect(i, SELECT_BY_POS, MODE_TRADES))
    {
    int type   = OrderType();
    bool result = false;
    
    switch(type)
    {
      //Close opened long positions
      case OP_BUY       : result = OrderClose( OrderTicket(), OrderLots(), MarketInfo(Symbol_1, MODE_BID), slippage, Red );
                          break;
      
      //Close opened short positions
      case OP_SELL      : result = OrderClose( OrderTicket(), OrderLots(), MarketInfo(Symbol_2, MODE_ASK), slippage, Red );
                          
    }
    
    if(result == false)
    {
      Alert("Order " , OrderTicket() , " failed to close. Error:" , GetLastError() );
      Sleep(3000);
    }
    }  
  }
  
  return;
}

I tried something like this before and have the same problem
  • #4
  • Sep 13, 2016 11:13pm Sep 13, 2016 11:13pm
I made a small mistake in my last answer ... Below is the right one:

Inserted Code
MarketInfo(OrderSymbol(),MODE_ASK)
MarketInfo(OrderSymbol(),MODE_BID)
MT4/MT5 EAs/Indicators/Alerts coder
  • #5
  • Sep 14, 2016 4:07am Sep 14, 2016 4:07am
I suggest you check the number of orders. I have the same function in a script and it never close all orders at once.

Try this in your LockInProfit():

Inserted Code
int c=0;
while(OrdersTotal()>0) && c<20)
{
    CloseAll();
    c++;
}

Variable c makes sure it does not go in an infinite loop.
  • #6
  • Sep 14, 2016 5:45am Sep 14, 2016 5:45am
You are getting orphaned orders because your close loop counts up not down. I know you are trying to comply with FIFO rules, but it will not work the way you have it coded.

Imagine you have 4 orders to close:

First loop (i=0)
At the start of the loop, the positions are:
Position 0 = Ticket 990
Position 1 = Ticket 991
Position 2 = Ticket 992
Position 3 = Ticket 993
Ticket 990 (in Position 0) gets closed

Second loop (i=1)
At the start of the loop, the new positions are:
Position 0 = Ticket 991
Position 1 = Ticket 992
Position 2 = Ticket 993
Ticket 992 (in Position 1) gets closed

Third loop (i=2)
At the start of the loop, the new positions are:
Position 0 = Ticket 991
Position 1 = Ticket 993
There is no Position 2, so the order select fails. The loop moves on without closing anything.

Fourth loop (i=3)
At the start of the loop, the positions are still:
Position 0 = Ticket 991
Position 1 = Ticket 993
There is no Position 3, so the order select fails. The loop moves on without closing anything.

The loop has now come to an end.
But it missed 2 tickets (991 and 993).
The more orders you have to close, the more tickets get missed when you count up not down.

Personally, I would always use OrderClosePrice(). Less logic required and less chance of a coding mistake.

HTH
  • #7
  • Last Post: Sep 15, 2016 1:56am Sep 15, 2016 1:56am
Quoting fredix
I suggest you check the number of orders. I have the same function in a script and it never close all orders at once. Try this in your LockInProfit(): int c=0; while(OrdersTotal()>0) && c<20) { CloseAll(); c++; } Variable c makes sure it does not go in an infinite loop.
This works!
TY
0 traders viewing now