Problem With EA | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Compiler problem or code problem ? 3 replies

problem, problem, is it MT4 platform or EA, Please help................ 1 reply

Oanda Spread Problem 15 replies

MT4 Connection Problem?? HELP!! 7 replies

Charting problem 1 reply

Attachments: Problem With EA
Exit Attachments

Problem With EA

  • #1
  • First Post: Edited 8:49am Jun 18, 2016 3:56am | Edited 8:49am
Hi guys, I've made an entering & exiting Indicator and now I want to make them work in an EA.. I used moving average EA codes to make my own EA; but it does not seem to work. I have one Buffer in Exit indicator & three Buffers in Enter indicator... I don't have that knowledge to understand all the coding, but it seems that the EA doesn't use indicators... so I'm here. i know its too much to ask, but I would greatly appreciate it if somebody help me with this. Thanks..
Attached File(s)
File Type: mq4 EA-MEE.mq4   8 KB | 316 downloads
  • #2
  • Jun 18, 2016 9:54am Jun 18, 2016 9:54am
From a quick look ...

on line 106/7/8 you set CEB[2] to a value

then...

on line 110 you only ask to open an order if && CEB[2]==EMPTY_VALUE
cannot be empty as I understand it as just set to value.

(Don't know what "Currencies_Enter Origin" indi is ??)

J.
If it was easy then I would do it !!
  • #3
  • Jun 18, 2016 4:47pm Jun 18, 2016 4:47pm
Hi j11... sorry, I should explain this before, my indicator (Currencies_Enter Origin) show the wrong signals. when color of Heiken Ashi changes & the indicator show nothing under the first changed color candle, I should buy/sell... I should fix this lunatic method, but I needed this method to see wrong signals easily..
I have another buffer in Currencies_Enter Origin indicator except (No buy/No sell) buffers and it sometimes happens under the second changed color heiken ashi candle, and it shows me that i should stay in buy/sell signal longer..
now I've written my conditions in this EA, but it doesn't work...
Attached Image (click to enlarge)
Click to Enlarge Name: Untitled.png Size: 23 KB
  • #4
  • Jun 19, 2016 6:04am Jun 19, 2016 6:04am
With the info provided it is not possible to help further.
If you provide the mq4 files that you are working with maybe somebody could help.

Sorry no time now.

J.
If it was easy then I would do it !!
  • #5
  • Jun 19, 2016 7:17am Jun 19, 2016 7:17am
Ok, Suppose we have an indicator names "Currencies_Enter Origin" that shows the wrong signals..
Attached File(s)
File Type: mq4 Currencies_Enter Origin.mq4   4 KB | 272 downloads
  • #6
  • Jun 19, 2016 3:40pm Jun 19, 2016 3:40pm
...
  • #7
  • Jun 20, 2016 1:23am Jun 20, 2016 1:23am
Yo have an indi that gives you wrong signals!!!!

May I respectfully suggest that you work with indi, or change it, so that it gives correct signals.

OR ... show correct conditions for entry and that would be easier to code.

J.
If it was easy then I would do it !!
  • #8
  • Jun 20, 2016 3:00am Jun 20, 2016 3:00am
Ok. I changed it...
now it shows the right signals..
we have two buffers for buy and sell and there is extra buffer (yellow one) to show that we should stay in trade longer (for example 25pip instead of 12pip)
Attached File(s)
File Type: mq4 Currencies_Enter Origin.mq4   4 KB | 287 downloads
  • #9
  • Jun 20, 2016 8:42am Jun 20, 2016 8:42am
Sorry but really is a mess!

I changed a little so might work now if conditions are met ....

BUT .... Ext3Buffer[];never returns a value I think so you need to check logic.
Therefore .... any parts of EA that look for CEY to return a value will NOT work !

Up to you now to work through it and check your logic (I do not have the time for it!).

Both attachments have been changed

J.
Attached File(s)
File Type: mq4 Currencies_Enter Origin.mq4   5 KB | 231 downloads
File Type: mq4 EA-MEE J11.mq4   8 KB | 237 downloads
If it was easy then I would do it !!
  • #10
  • Jun 20, 2016 12:39pm Jun 20, 2016 12:39pm
Had time to take another quick look ......

1. EA now places the trades.
2. Indi conditions need checking as highlighted in attached on lines 78 & 84
3. Yellow signals of indi do show up in higher TF's so may need to adjust values in the conditions (I tried it on EURGBP)
4. Added PrPeriod in EA so that different TF's can be used.


Hope this helps

J.
Attached File(s)
File Type: mq4 Currencies_Enter Origin.mq4   5 KB | 258 downloads
File Type: mq4 EA-MEE J11.mq4   8 KB | 252 downloads
If it was easy then I would do it !!
  • #11
  • Jun 20, 2016 5:00pm Jun 20, 2016 5:00pm
Hi j... Thank you man, I just needed something to work and now its working,...
now I have to place my conditions, thank you very much
  • #12
  • Jun 23, 2016 8:29am Jun 23, 2016 8:29am
Hi J. sorry bother you again... ea is working, but close action doesn't work. this is the code... it should close the order if heiken ashi changes its color on the third candle open or Exit indicator send signal (Exit indicator doesn't matter now), no matter that we have profit or loss. Thanks

Inserted Code
//+------------------------------------------------------------------+
//| Check for open order conditions                                  |
//+------------------------------------------------------------------+  
void CheckForOpen()
  {
   int    res;
   double Poin = Point;
   if ((Point == 0.00001) || (Point == 0.001)) Poin *= 10;
//--- go trading only for first tiks of new bar
   if(Volume[0]>1) return;
   CEB =iCustom(NULL,TimeFrame,"Currencies_Enter Origin",0,2);
   CER =iCustom(NULL,TimeFrame,"Currencies_Enter Origin",1,2);
   CEY =iCustom(NULL,TimeFrame,"Currencies_Enter Origin",2,1);
//--- buy conditions
   if (((O4>C4 && O3>C3 && O2<C2 && O1<C1) || (O5>C5 && O4<C4 && O3>C3 && O2<C2 && O1<C1)) && CER==EMPTY_VALUE && CEB==EMPTY_VALUE && CEY==EMPTY_VALUE)
     {
      res=OrderSend(Symbol(),OP_BUY,LotsOptimized(),Ask,1,0,NormalizeDouble(Ask+12*Poin,Digits),"",MagicNum,0,clrBlue);
      return;
     }
   if (((O4>C4 && O3>C3 && O2<C2 && O1<C1) || (O5>C5 && O4<C4 && O3>C3 && O2<C2 && O1<C1)) && CER==EMPTY_VALUE && CEB==EMPTY_VALUE && CEY!=EMPTY_VALUE)
     {
      res=OrderSend(Symbol(),OP_BUY,LotsOptimized(),Ask,1,0,NormalizeDouble(Ask+25*Poin,Digits),"",MagicNum,0,clrBlue);
      return;
     }
//--- sell conditions
   if (((O4<C4 && O3<C3 && O2>C2 && O1>C1) || (O5<C5 && O4>C4 && O3<C3 && O2>C2 && O1>C1)) && CEB==EMPTY_VALUE && CER==EMPTY_VALUE && CEY==EMPTY_VALUE)
     {
      res=OrderSend(Symbol(),OP_SELL,LotsOptimized(),Bid,1,0,NormalizeDouble(Bid-12*Poin,Digits),"",MagicNum,0,clrRed);
      return;
     }
   if (((O4<C4 && O3<C3 && O2>C2 && O1>C1) || (O5<C5 && O4>C4 && O3<C3 && O2>C2 && O1>C1)) && CEB==EMPTY_VALUE && CER==EMPTY_VALUE && CEY!=EMPTY_VALUE)
     {
      res=OrderSend(Symbol(),OP_SELL,LotsOptimized(),Bid,1,0,NormalizeDouble(Bid-25*Poin,Digits),"",MagicNum,0,clrRed);
      return;
     }
  }
//+------------------------------------------------------------------+
//| Check for close order conditions                                 |
//+------------------------------------------------------------------+
void CheckForClose()
  {
   bool ClosedF=false;
//--- go trading only for first tiks of new bar
   if(Volume[0]>1) return;
//--- get Moving Average
   CEX = iCustom(NULL,TimeFrame,"Currencies_Exit Origin",0,0,0,0,0);
//---
   for(int i=0;i<OrdersTotal();i++)
     {
      if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==false) break;
      if(OrderMagicNumber()!=MagicNum || OrderSymbol()!=Symbol()) continue;
      //--- check order type
      if(OrderType()==OP_BUY)
        {
         if (((OE4<CE4 && OE3<CE3 && OE2>CE2 && OE1>CE1) || (OE5<CE5 && OE4>CE4 && OE3<CE3 && OE2>CE2 && OE1>CE1)) || CEX!=EMPTY_VALUE)
           {
            ClosedF=OrderClose(OrderTicket(), OrderLots(), Bid, 2, clrWhite);
              if(!OrderClose(OrderTicket(),OrderLots(),Bid,2,clrWhite))
                 Print("OrderClose error ",GetLastError());
           }
         break;
        }
      if(OrderType()==OP_SELL)
        {
         if (((OE4>CE4 && OE3>CE3 && OE2<CE2 && OE1<CE1) || (OE5>CE5 && OE4<CE4 && OE3>CE3 && OE2<CE2 && OE1<CE1)) || CEX!=EMPTY_VALUE)
           {
            ClosedF=OrderClose(OrderTicket(), OrderLots(), Ask, 2, clrWhite);
              if(!OrderClose(OrderTicket(),OrderLots(),Ask,2,clrWhite))
                 Print("OrderClose error ",GetLastError());
           }
         break;
        }
     }
}
  • #13
  • Jun 23, 2016 11:09am Jun 23, 2016 11:09am
when you take trade you should be in that trade until the color changes and then it is closed on the third bar of the opposite color;but somehow it misses the first color change and keeps the trade till the second time color change,something that should not happen.
Attached Image (click to enlarge)
Click to Enlarge Name: Untitled.png Size: 20 KB
  • #14
  • Jun 23, 2016 11:54am Jun 23, 2016 11:54am
anybody?
  • #15
  • Jun 23, 2016 2:00pm Jun 23, 2016 2:00pm
Print("OrderClose error ",GetLastError());

put getlasterror code or message from MT4 journal.

ClosedF=OrderClose(OrderTicket(), OrderLots(), Ask, 2, clrWhite); if(!OrderClose(OrderTicket(),OrderLots(),Ask,2,clrWhite)) Print("OrderClose error ",GetLastError());

you are trying to close order twice, what you do?
  • #16
  • Jun 23, 2016 2:59pm Jun 23, 2016 2:59pm
hi hanzov...
it seems my loop was wrong:
http://www.forexfactory.com/showthread.php?t=511029
i changed it and its worok hanzov, you mean i should delete this line too?? :
" if(!OrderClose(OrderTicket(),OrderL ots(),Ask,2,clrWhite)) Print("OrderClose error ",GetLastError()); "
  • #17
  • Jun 23, 2016 4:14pm Jun 23, 2016 4:14pm
For example, you can do it

ClosedF=OrderClose(OrderTicket(), OrderLots(), Ask, 2, clrWhite);
if (!ClosedF) Print("OrderClose error ",GetLastError());

but better find example of the script. MT4 has the same script as example.
  • #18
  • Jun 24, 2016 5:44am Jun 24, 2016 5:44am
Thanks man.
  • #19
  • Edited 11:10am Jun 24, 2016 10:43am | Edited 11:10am
sorry guys, im here again, if someone with coding experience could help me with that...
this is my latest ea, after i changed closed condition loop to "for(int i = OrdersTotal()-1; i >= 0; i--)", ea just trade the first order and closing it (with profit or loss), it does not work anymore.. the smily on and auto trade is on, allow live trade ticks.. idk what the problem might be in this ea..
Attached File(s)
File Type: mq4 EA-MEE.mq4   9 KB | 288 downloads
  • #20
  • Jun 24, 2016 1:52pm Jun 24, 2016 1:52pm
ye,
you are out of loop after break;
if(OrderType()==OP_BUY)
{
if (((OE4<CE4 && OE3<CE3 && OE2>CE2 && OE1>CE1) || (OE5<CE5 && OE4>CE4 && OE3<CE3 && OE2>CE2 && OE1>CE1)) || CEX!=EMPTY_VALUE)
{
ClosedF=OrderClose(OrderTicket(), OrderLots(), Bid, 2, clrWhite);
if(!ClosedF) Print("OrderClose error ",GetLastError());
}
break; // exit from loop. Put continue; or nothing..
}


also change
if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==false) break;
for if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==false) continue;

"break" means immediate exit from loop
0 traders viewing now