Problem with close all function | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

required to function call function 2 replies

Unknown problem with iCustom() function 1 reply

MT4 ArrayBsearch function problem 2 replies

stop loss function and edit time function for Breakout EA 1 reply

Problem with Function + its call 1 reply

Problem with close all function

  • #1
  • First Post: Jun 2, 2016 5:23pm Jun 2, 2016 5:23pm
Hello ,
I have a problem with the close all function add to my ea .
I want the function to close all when i have open more then >1 trade with certain profit for each symbol chart.
When i back test is work correctly , but i run it for few symbol chart together it will close when the profit is reach and i only have open 1 position for each chart .

Please any one can help me find out the problem .

Thanks in advance .

Inserted Code
 // close all
 if (OrdersTotal()>1 && Profit_>0 && NetProfit()>=Profit_){
    CloseAll(0);
    Sleep(1000);
    if (OrdersTotal()>1) CloseAll(0);
    }
    
 if (OrdersTotal()>1 && Loss_>0 && NetProfit()<=-Loss_){
    CloseAll(0);
    Sleep(1000);
    if (OrdersTotal()>1) CloseAll(0);
    }

Inserted Code
int CloseAll(int OrdrType)
{
bool ClTicket=false;
   for (int cnt = OrdersTotal()-1 ; cnt >= 0; cnt--)
   {
      if(OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES))
      {
      if (OrderSymbol() == Symbol() && (OrderMagicNumber() == MagicNumberBuy || OrderMagicNumber() == MagicNumberSell)  && OrderCloseTime()==0)
      {
            if((OrderType()==OP_BUY)&&((OrdrType==0)||(OrdrType==1)))  ClTicket=OrderClose(OrderTicket(),OrderLots(),Bid,2*Spread,Blue);
            if((OrderType()==OP_SELL)&&((OrdrType==0)||(OrdrType==-1))) ClTicket=OrderClose(OrderTicket(),OrderLots(),Ask,2*Spread,Red);
      }
   }
   }
   return(0);
}
  • #2
  • Jun 2, 2016 10:03pm Jun 2, 2016 10:03pm
You need to ensure your code includes and sorts by Symbol() in its calculations, at the moment you are looking at all history across all currencies, hence your problem.
The reason it works in backtest is that its only looking at a single pair and so the code appears to work, but as soon as you go to live with more than a single currency you are looking at all currencies.
" check out The Traders Outpost "
  • #3
  • Edited 3:41am Jun 3, 2016 2:52am | Edited 3:41am
Quoting RedLineFred
You need to ensure your code includes and sorts by Symbol() in its calculations, at the moment you are looking at all history across all currencies, hence your problem. The reason it works in backtest is that its only looking at a single pair and so the code appears to work, but as soon as you go to live with more than a single currency you are looking at all currencies.
Hi RedLineFred , first thanks for your reply .
Can you point out how to sort by the symbol ?
I though this line already find the symbol at the chart ?
Inserted Code
if(OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES)) { if (OrderSymbol() == Symbol()
I not a coder , i just read some pdf file and search on the internet to study .
can you give some example ?

One more question , some time i have saw this code write by this
Inserted Code
if(OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES)==true)
What that means the true / false?
  • #4
  • Jun 3, 2016 4:54am Jun 3, 2016 4:54am
Quoting stevenfx
{quote} Hi RedLineFred , first thanks for your reply . Can you point out how to sort by the symbol ? I though this line already find the symbol at the chart ? if(OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES)) { if (OrderSymbol() == Symbol() I not a coder , i just read some pdf file and search on the internet to study . can you give some example ? One more question , some time i have saw this code write by this if(OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES)==true) What that means the true / false?
Try check this script, Brother Stevenfx.... http://www.forexfactory.com/showthre...38#post8500738
Regard, Ding Dong
  • #5
  • Last Post: Jun 3, 2016 5:50am Jun 3, 2016 5:50am
Quoting dingdong99
{quote} Try check this script, Brother Stevenfx.... http://www.forexfactory.com/showthre...38#post8500738
Hi dingdong , thanks for the link .
It very useful for me

Now i have change the call from MarketInfo , also add the swap and commission for calculation .
But still dont know how does it work , have no error when compile .
Have to double confirm with expert

Inserted Code
if((OrderType()==OP_BUY)&&((OrdrType==0==OrderProfit()+OrderSwap()+OrderCommission())||(OrdrType==1==OrderProfit()+OrderSwap()+OrderCommission())))  
 ClTicket=OrderClose(OrderTicket(),OrderLots(), MarketInfo(OrderSymbol(),Bid),2*Spread,Blue);
 if((OrderType()==OP_SELL)&&((OrdrType==0==OrderProfit()+OrderSwap()+OrderCommission())||(OrdrType==-1==OrderProfit()+OrderSwap()+OrderCommission())))
 ClTicket=OrderClose(OrderTicket(),OrderLots(), MarketInfo(OrderSymbol(),Ask),2*Spread,Red);
0 traders viewing now