a little help with code | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Little code help from the experts :) 17 replies

Little help needed with EA code 3 replies

Need a little help. Can anyone code this EA? 0 replies

Little help with Code 5 replies

T3 Cross Ea - Need A Little Code Help 0 replies

Attachments: a little help with code
Exit Attachments

a little help with code

  • #1
  • First Post: Apr 10, 2016 1:53am Apr 10, 2016 1:53am
ea that counts the number of the wining trades from the initial.
if (win) {Winers++;}

now I want it to count just from the last fifty trades.
and afer evry trade, it will updated to the new last fifty (like MA).

IS THERE AN EASY WAY??
  • #2
  • Apr 10, 2016 2:35am Apr 10, 2016 2:35am
If you want any help with coding then this is thread you should be writing on.

http://www.forexfactory.com/showthread.php?t=166758

You may get help.

There is another very professional coder here .

FerruFX- You may get in touch with him

http://www.forexfactory.com/ferrufx
When the going gets tough , the tough get going
  • #3
  • Apr 10, 2016 2:58pm Apr 10, 2016 2:58pm
Say you have an array that contains all your Net profits over 100 trades, call that your Net_profit_Array,

If you want just the last 50 trades from that array , then you can create a new array, let's call it New_array, by using ArrayCopy and specifying where you want to start copying from the original array by setting the "src_start" parameter to 50 as follows:

ArrayCopy(New_array,Net_profit_Array,0,50,WHOLE_ARRAY);

This will store the last 50 trades of the original array into New_array, then you can do your computations as usual on this copied array.

Naturally, you would want to set the "src_start" parameter to a variable if the size of the original Net_profit_Array keeps on changing.

Good luck!
  • #4
  • Apr 11, 2016 3:27am Apr 11, 2016 3:27am
Quoting MoneyD
Say you have an array that contains all your Net profits over 100 trades, call that your Net_profit_Array, If you want just the last 50 trades from that array , then you can create a new array, let's call it New_array, by using ArrayCopy and specifying where you want to start copying from the original array by setting the "src_start" parameter to 50 as follows: ArrayCopy(New_array,Net_profit_Array,0,50,WHOLE_ARRAY); This will store the last 50 trades of the original array into New_array, then you...
but how to create this Net_profit_Array, automaticly?
  • #5
  • Apr 11, 2016 9:18am Apr 11, 2016 9:18am
Quoting quiet
{quote} but how to create this Net_profit_Array, automaticly?
Where are you counting your winning trades from in the first place ? that's your Net_profit_Array . Paste all your code, and I'll try and clarify.

good luck!
  • #6
  • Apr 12, 2016 2:05am Apr 12, 2016 2:05am
Quoting MoneyD
{quote} Where are you counting your winning trades from in the first place ? that's your Net_profit_Array . Paste all your code, and I'll try and clarify. good luck!
when the ea closes a trade:
("profit" is the profit/loss of this trade, in $)

if (profit>0) // winner trade
{Number_of_winners ++;}
if (profit<0) // loss
{number_of_losses ++;}
  • #7
  • Edited 3:09am Apr 12, 2016 2:31am | Edited 3:09am
Last_50_trades_result();


//+------------------------------------------------------------------+
//Last 50 trades result
//+------------------------------------------------------------------+
void Last_50_trades_result()
{
wins = 0;
loses = 0;
int depth_trades = 50;
int total_trades = OrdersHistoryTotal();
int limit;
if(total_trades > depth_trades)
limit = total_trades - depth_trades;
else limit = 0;


for(int i=total_trades; i>=limit; i--)
{
OrderSelect(i,SELECT_BY_POS,MODE_HISTORY);
if(OrderProfit() > 0)
wins++;
if(OrderProfit() < 0)
loses++;
}
}

**** MODE_HISTORY "Close the gap between HI and STORY "
  • #8
  • Apr 12, 2016 5:17am Apr 12, 2016 5:17am
Quoting anax
Last_50_trades_result(); //+------------------------------------------------------------------+ //Last 50 trades result //+------------------------------------------------------------------+ void Last_50_trades_result() { wins = 0; loses = 0; int depth_trades = 50; int total_trades = OrdersHistoryTotal(); int limit; if(total_trades > depth_trades) limit = total_trades - depth_trades; else limit = 0; for(int i=total_trades; i>=limit; i--) { OrderSelect(i,SELECT_BY_POS,MODE_HISTORY); if(OrderProfit() > 0) wins++; if(OrderProfit() < 0) loses++; } }...
THANK YOU VERY MUCH
(and welcome to ff)

if (Last_50_trades_result() ==true) { quiet+anax = ; }
  • #9
  • May 3, 2016 4:51am May 3, 2016 4:51am
Quoting anax
Last_50_trades_result(); //+------------------------------------------------------------------+ //Last 50 trades result //+------------------------------------------------------------------+ void Last_50_trades_result() { wins = 0; loses = 0; int depth_trades = 50; int total_trades = OrdersHistoryTotal(); int limit; if(total_trades > depth_trades) limit = total_trades - depth_trades; else limit = 0; for(int i=total_trades; i>=limit; i--) { OrderSelect(i,SELECT_BY_POS,MODE_HISTORY); if(OrderProfit() > 0) wins++; if(OrderProfit() < 0) loses++; } }...
thank you, it works fine.
but the OrdersHistoryTotal() counts also expired pending orders.
how can I prevent it from include them?
  • #10
  • May 3, 2016 5:03am May 3, 2016 5:03am
Quoting quiet
{quote} thank you, it works fine. but the OrdersHistoryTotal() counts also expired pending orders. how can I prevent it from include them?
Try this

Inserted Code
 
//+------------------------------------ ------------------------------+
//Last N trades result
//+------------------------------------ ------------------------------+
int Last_N_trades_result(int depth_trades)
{
int wins = 0;
int counted_trades=0;
int total_trades = OrdersHistoryTotal();
for(int i=total_trades; i>=0; i--)
{
 if(!OrderSelect(i,SELECT_BY_POS,MODE_HISTORY) || counted_trades=depth_trades) break;
 if(OrderType()<2)
 {
   counted_trades++;
   if(OrderProfit()+OrderCommission()+OrderSwap() > 0)    wins++;
 }
 return(wins);
}
No guts, no glory
  • #11
  • May 3, 2016 5:40am May 3, 2016 5:40am
Quoting abokwaik
{quote} Try this //+------------------------------------ ------------------------------+ //Last N trades result //+------------------------------------ ------------------------------+ int Last_N_trades_result(int depth_trades) { int wins = 0; int counted_trades=0; int total_trades = OrdersHistoryTotal(); for(int i=total_trades; i>=0; i--) { if(!OrderSelect(i,SELECT_BY_POS,MODE_HISTORY) || counted_trades=depth_trades) break; if(OrderType()<2) { counted_trades++; if(OrderProfit()+OrderCommission()+OrderSwap() > 0) wins++; } return(wins); }
thank you
but it doesnt works for me
Attached File(s)
File Type: mq4 count.mq4   2 KB | 364 downloads
  • #12
  • May 3, 2016 5:53am May 3, 2016 5:53am
Quoting quiet
{quote} thank you but it doesnt works for me {file}
Right. my mistake. didn't test it.

int total_trades = OrdersHistoryTotal();
should be
int total_trades = OrdersHistoryTotal()-1;

Here the corrected one ...
Attached File(s)
File Type: mq4 count.mq4   2 KB | 376 downloads
No guts, no glory
  • #13
  • Last Post: May 3, 2016 6:01am May 3, 2016 6:01am
Quoting abokwaik
{quote} Right. my mistake. didn't test it. int total_trades = OrdersHistoryTotal(); should be int total_trades = OrdersHistoryTotal()-1; Here the corrected one ... {file}
great
very proffetional
thank you very much
0 traders viewing now