Free EA - Piggy n The Middle | Page 16 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

No Free Lunch but all the Free Coffee you can drink 736 replies

SWAP free, rollover free Broker? 15 replies

Orders triggered in the middle of nowhere! 1 reply

Crisis in the middle east 2 replies

Attachments: Free EA - Piggy n The Middle
Exit Attachments

Free EA - Piggy n The Middle

  • #301
  • Apr 22, 2016 8:36am Apr 22, 2016 8:36am
Quoting jpyp99
{quote} Just so there is no confusion your CloseAll() function closes only the trades with that magic number right?
Yes, this SHOULD be the case.
  • #302
  • Apr 22, 2016 8:44am Apr 22, 2016 8:44am
Quoting jpyp99
{quote} Just so there is no confusion your CloseAll() function closes only the trades with that magic number right?

Close function close all trades, I did not use magic number because I don't have mq4 of @daniel v4 code. Presently, I write another EA that will close all open trades.
  • #303
  • Apr 22, 2016 8:45am Apr 22, 2016 8:45am
Quoting guilherme
I dont think you can restart the EA after terminating it. Unless you reload. Try using the function Sleep. Do the Math Time to Restart - Current Time (when started sleeping) = amount of time to sleep
Thanks. i will try the sleep function now.

cheers
  • #304
  • Apr 22, 2016 8:47am Apr 22, 2016 8:47am
" If Profit (Equity-Balance) is > than Balance *1.01 "

if((Equity-Balance)> (Balance* "1.01"))

left operand is greater than the value of right operand. You are trying to compare a numerical value to a string of characters.

try using

if((Equity-Balance)> (Balance*StrToDouble(StopEquityProfitFactor));
So many in the Commercial section want to make me rich! :o
  • #305
  • Apr 22, 2016 8:50am Apr 22, 2016 8:50am
Quoting tundex
{quote} Close function close all trades, I did not use magic number because I don't have mq4 of @daniel v4 code. Presently, I write another EA that will close all open trades.
AFTER CONSIDERATION, I THINK I WILL RELEASE THE MQ4 FILE SOON.

I don't see any more value in keeping the file. If coders want to be greedy and not share their ideas and modifications, so be it on their conscience.

I was hoping to get a more positive response from my motives for keeping the file but have not gotten any.

I'm sorry if I have offended anybody with my issues with the mq4 file, it was not intended. All I have to say is when I release it good luck, because fxdreema code amongst all their template stuff in the middle and all over the place is not easy to read.

I should release v4 and v4-1 mq4s shortly in hope that others will find improvement in them and share with the rest.

Happy Pipping!

Daniel
  • #306
  • Apr 22, 2016 9:08am Apr 22, 2016 9:08am
Quoting keydcuk
{quote} AFTER CONSIDERATION, I THINK I WILL RELEASE THE MQ4 FILE SOON. I don't see any more value in keeping the file. If coders want to be greedy and not share their ideas and modifications, so be it on their conscience. I was hoping to get a more positive response from my motives for keeping the file but have not gotten any. I'm sorry if I have offended anybody with my issues with the mq4 file, it was not intended. All I have to say is when I release it good luck, because fxdreema code amongst all their template stuff in the middle and all over...

No offense taken @daniel, I was planning to finish the bit of code and send to you to add to your code. I'm not much of a coder too still new to mql. lol
  • #307
  • Apr 22, 2016 9:19am Apr 22, 2016 9:19am
MQ4 FILES ARE IN POST 1.

I hope that anybody who further develops on my EA will have the decency to share with the rest of us so we can all benefit.

I appeal on your dignity to do the right thing.

Happy Pipping!

Many Thanks & Best Regards,

Daniel
  • #308
  • Apr 22, 2016 9:24am Apr 22, 2016 9:24am
How did you come by this code?

It's much easier for people to help when they can follow the logic through.
So many in the Commercial section want to make me rich! :o
  • #309
  • Apr 22, 2016 9:45am Apr 22, 2016 9:45am
Quoting FX-Flux
How did you come by this code? It's much easier for people to help when they can follow the logic through.
As I have mentioned all along. I am not a coder. The code that you see in the mq4 is generated by software called fxdreema.

I don't know what else to say on this?

It is a very good piece of software for those who don't know how to code. If anybody wants to recode it into something more coder friendly, I am more than happy to explain the strategy step by step behind this and then we can have a coder friendly EA and take it from there.

Anybody just let me know and I will go through the steps in which the EA performs if someone wants to recode a coder friendly version.

I would do it myself but I have very little knowledge in coding. I am taking lessons from a generous person who is offering it to me for free but he is in Australia and the lessons are slow.

Many Thanks & Best Regards,

Daniel
  • #310
  • Apr 22, 2016 12:04pm Apr 22, 2016 12:04pm
Daniel,
one good thing would be : you take a screen picture of the fxdreema structures. write above it explaining each block. and add to the picture the futures you want to add.
so people like that know the software will understand easier. and people who dont know the software can know wich block to search for in the code.
Just an ideia....
  • #311
  • Apr 22, 2016 3:25pm Apr 22, 2016 3:25pm
Quoting guilherme
Daniel, one good thing would be : you take a screen picture of the fxdreema structures. write above it explaining each block. and add to the picture the futures you want to add. so people like that know the software will understand easier. and people who dont know the software can know wich block to search for in the code. Just an ideia....
Pretty simple stuff really. I would think that this would be pretty easy for a coder to do a much simpler mq4 file.
Attached Image (click to enlarge)
Click to Enlarge Name: Screenshot_1.png Size: 88 KB
  • #312
  • Apr 22, 2016 10:06pm Apr 22, 2016 10:06pm
Quoting keydcuk
{quote} Pretty simple stuff really. I would think that this would be pretty easy for a coder to do a much simpler mq4 file. {image}
Hi Daniel,

check this version please. You can import the mq4 to your fxdreema. Go to Project menu / Import Project. Will be easier to see the change I have made.
But here they are:
1. Added a close all trades if x amount of money is achieved. (the input must be a negative number)
2. Changed the parameter of the round number block. Now 30 pips will be 30 pips no mather the currency pair.
3. Took out the #Groups 1 and 2. Now the closing block filter by buy/sell
4. Added external variables to make the input tab look better
5. I dont see a point in using a time filter in a EA like this but I changed that one to a single one from 0 to 24 hours as default.

now if you want you can add to the block 17 (after it closes all trades when the loss is achieved) the Block Terminate (will stop the EA and will work just I reattached).

This version is working different from the other one as now it really just open the trades at the round number. If the performance of the other is better just change again the block round number to price fraction.

If you need anything...just ask
Attached Image (click to enlarge)
Click to Enlarge Name: Piggy n The Middle v4-1.jpg Size: 168 KB
Attached File(s)
File Type: mq4 Piggy n The Middle v4-1 (test).mq4   286 KB | 486 downloads
  • #313
  • Apr 22, 2016 10:47pm Apr 22, 2016 10:47pm
Quoting guilherme
{quote} Hi Daniel, check this version please. You can import the mq4 to your fxdreema. Go to Project menu / Import Project. Will be easier to see the change I have made. But here they are: 1. Added a close all trades if x amount of money is achieved. (the input must be a negative number) 2. Changed the parameter of the round number block. Now 30 pips will be 30 pips no mather the currency pair. 3. Took out the #Groups 1 and 2. Now the closing block filter by buy/sell 4. Added external variables to make the input tab look better 5. I dont see a point...
I am working I can not sleep here in Brazil ...

This EA was the same system 1st EA piggy?

Fantastic
  • #314
  • Apr 23, 2016 2:25am Apr 23, 2016 2:25am
HI
I am using candestick when i moved my mouse to the candelstic i can't view the price , any setting require?
thanks
  • #315
  • Apr 23, 2016 3:12am Apr 23, 2016 3:12am
Quoting guilherme
{quote} Hi Daniel, check this version please. You can import the mq4 to your fxdreema. Go to Project menu / Import Project. Will be easier to see the change I have made. But here they are: 1. Added a close all trades if x amount of money is achieved. (the input must be a negative number) 2. Changed the parameter of the round number block. Now 30 pips will be 30 pips no mather the currency pair. 3. Took out the #Groups 1 and 2. Now the closing block filter by buy/sell 4. Added external variables to make the input tab look better 5. I dont see a point...
guilherme

Add a trailer stop (TP)
Add a function that close a losing order that exceed a certain amount of pips

1. TrailerStop
void MoveToBE()
{
RefreshRates();
//double vbid = MarketInfo("EURUSD",MODE_BID);
//double vask = MarketInfo("EURUSD",MODE_ASK);
//double vpoint = MarketInfo("EURUSD",MODE_POINT);
//int vdigits = (int)MarketInfo("EURUSD",MODE_DIGITS);
//int vspread = (int)MarketInfo("EURUSD",MODE_SPREAD);

double StopLevel = MarketInfo(Symbol(), MODE_STOPLEVEL) + MarketInfo(Symbol(), MODE_SPREAD);
if(TrailingStop < StopLevel) TrailingStop = StopLevel;
for(int order=OrdersTotal()-1; order>=0; order--)
{
if(!OrderSelect(order,SELECT_BY_POS))continue;
if(OrderMagicNumber()!=MagicNumber)continue;
if(OrderProfit()<=0)continue;
if(OrderType() == OP_BUY)
{
// check for trailing stop
if(TrailingStop>0)
{
if(Bid-OrderOpenPrice()>Point*TrailingStop)
{
if(OrderStopLoss()<Bid-Point*TrailingStop)
{
OrderModify(OrderTicket(),OrderOpenPrice(),Bid-Point*TrailingStop,OrderTakeProfit(),0,CLR_NONE);
}
}
}
}
}
for(int order=OrdersTotal()-1; order>=0; order--)
{
if(!OrderSelect(order,SELECT_BY_POS))continue;
if(OrderMagicNumber()!=MagicNumber)continue;
if(OrderProfit()<=0)continue;
//if(OrderType() == OP_SELL);
{
if((OrderOpenPrice()-Ask)>(Point*TrailingStop))
{
if((OrderStopLoss()>(Ask+Point*TrailingStop)) || (OrderStopLoss()==0))
{
OrderModify(OrderTicket(),OrderOpenPrice(),Ask+Point*TrailingStop,OrderTakeProfit(),0,CLR_NONE);
}
}
}
}
}

2. //Amount to close losing orders
for(int i = 0;i <= OrdersTotal() - 1;i++)
{
bool select = OrderSelect(i, SELECT_BY_POS, MODE_TRADES); // select one after another
if (OrderSymbol() == "EURCADmicro" && OrderMagicNumber() == 147258) // order check
{
if (OrderProfit() <= LossToClose) // check losing more or equal to
{
select = OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(),Slippage, Red); // close nagitive order
}
}
}
  • #316
  • Apr 23, 2016 5:14am Apr 23, 2016 5:14am
Quoting guilherme
{quote} Hi Daniel, check this version please. You can import the mq4 to your fxdreema. Go to Project menu / Import Project. Will be easier to see the change I have made. But here they are: 1. Added a close all trades if x amount of money is achieved. (the input must be a negative number) 2. Changed the parameter of the round number block. Now 30 pips will be 30 pips no mather the currency pair. 3. Took out the #Groups 1 and 2. Now the closing block filter by buy/sell 4. Added external variables to make the input tab look better 5. I dont see a point...
Hi Guilherme,

Thanks for your modifications. I've had a quick test and it seems to be doing the exact same as the original except it has more user friendly inputs. I only realized afterwards that I could change the round numbers to pips on the web version of fxdreema and didn't do this while tinkering and waiting for a new release of the EA.

The only thing that I would point out and then again it might not be useful for most people is to give the independence of lot sizes on trade as some might want to put more weighted positions to the buys that go up step and the sells that go down step.

I appreciate your participation in this as there is something that you are doing different with the blocks that has got me thinking around a problem that I had in the original which your configuration may solve the problem. I won't say what yet as I don't know if this improved method in my head is going to be an improvement at all. I will test this first.

I only started to learn about changing the inputs with different names so if I get another version out, I will modify stuff to be more user friendly.

All and all, I am very happy with this and I thank you again for your help!

Best Regards,

Daniel
  • #317
  • Apr 23, 2016 5:18am Apr 23, 2016 5:18am
Quoting Tekkies
{quote} guilherme Add a trailer stop (TP) Add a function that close a losing order that exceed a certain amount of pips 1. TrailerStop void MoveToBE() { RefreshRates(); //double vbid = MarketInfo("EURUSD",MODE_BID); //double vask = MarketInfo("EURUSD",MODE_ASK); //double vpoint = MarketInfo("EURUSD",MODE_POINT); //int vdigits = (int)MarketInfo("EURUSD",MODE_DIGITS); //int vspread = (int)MarketInfo("EURUSD",MODE_SPREAD); double StopLevel = MarketInfo(Symbol(), MODE_STOPLEVEL) + MarketInfo(Symbol(), MODE_SPREAD); if(TrailingStop < StopLevel) TrailingStop...
Hello Tekkies,

Adding actual code to this kind of EA proves to be difficult as the mq4 file is not user friendly. That is why I am appealing to coders to do a coders version of this EA as this has only been done through GUI fxdreema. Having said this, I am looking at trailing profits and BE. I was only thinking about this last night but am struggling to implement it in fxdreema. If I was a coder, I would have easily added this as I think it is a great idea.

I guess we'll just have to wait and see if we have a volunteer to make a coders version of this EA.

Many Thanks & Best Regards,

Daniel
  • #318
  • Apr 23, 2016 6:03am Apr 23, 2016 6:03am
Quoting keydcuk
{quote} Hello Tekkies, Adding actual code to this kind of EA proves to be difficult as the mq4 file is not user friendly. That is why I am appealing to coders to do a coders version of this EA as this has only been done through GUI fxdreema. Having said this, I am looking at trailing profits and BE. I was only thinking about this last night but am struggling to implement it in fxdreema. If I was a coder, I would have easily added this as I think it is a great idea. I guess we'll just have to wait and see if we have a volunteer to make a coders version...
As of typing busy converting to mq4 coders friendly
main reason is current version is cpu intensive
  • #319
  • Apr 23, 2016 6:18am Apr 23, 2016 6:18am
Quoting keydcuk
{quote} Pretty simple stuff really. I would think that this would be pretty easy for a coder to do a much simpler mq4 file. {image}
keydcuk
This is your ea and your idea.
Would you have a problem if change some code by adding
1. stoploss
2. trailer stop
3. increase lot as deposit increase or visa vica
4. close losing order that exceed x-amount of pips
5. open order according to trend

would really to code ea not trade as below
Attached Image (click to enlarge)
Click to Enlarge Name: GBPUSDmicroH1.png Size: 66 KB
  • #320
  • Apr 23, 2016 6:21am Apr 23, 2016 6:21am
Quoting Tekkies
{quote} keydcuk This is your ea and your idea. Would you have a problem if change some code by adding 1. stoploss 2. trailer stop 3. increase lot as deposit increase or visa vica 4. close losing order that exceed x-amount of pips 5. open order according to trend would really to code ea not trade as below {image}
sorry for poor grammar is in programming mode
1 trader viewing now