Saving user defined Functions within a mql file? | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

looking for a Grid EA with user defined scale 1 reply

File handle functions 5 replies

Using MQL Print and Comment Functions? 11 replies

File Functions help 0 replies

Uploading a File desde Metatrader: Wininet API functions 0 replies

Saving user defined Functions within a mql file?

  • #1
  • First Post: Mar 11, 2016 7:15pm Mar 11, 2016 7:15pm
Hi All,

I have a number of EAs, all of which contain a large number of separate user defined functions. These functions are regularly used by each EA. However, if I need to make a code change to one of the functions I then have to go into each EA containing the same function and make the same change.

In order to avoid this hassle and to keep my EA code short and to save duplication, I wanted to include these functions within one mqh file and then call them in each EA using the #include <....> command.

Unfortunately, each of my functions contains variables which are normally defined at the start of my EAs. This then means when I try and compile the mqh file I receive an error as these variables don't exist in that particular file (as they are contained within my actual EA).

How would i get around this?

As I am not an experienced programmer, any easy to understand advice would be most welcome.

Thanks in advance....

CCH
  • #2
  • Mar 12, 2016 3:35pm Mar 12, 2016 3:35pm
Hi All,

Just thought I'd bump this up in case anyone might be able to assist.


Cheers.
  • #3
  • Mar 12, 2016 4:16pm Mar 12, 2016 4:16pm
Quoting Chorlton
Hi All, Just thought I'd bump this up in case anyone might be able to assist. Cheers.
Chorlton-
You don't need to compile the .mqh file as such. If you do it will return all the errors you are speaking of.
Instead, compile the EA file and if there are errors they will show up as the .mqh file gets compiled first.
  • #4
  • Mar 13, 2016 1:55am Mar 13, 2016 1:55am
Quoting cyber1
{quote} Chorlton- You don't need to compile the .mqh file as such. If you do it will return all the errors you are speaking of. Instead, compile the EA file and if there are errors they will show up as the .mqh file gets compiled first.
Interesting approach... I've been trying to write clean code but this would work. Thanks for the reply. Much appreciated :-)
  • #5
  • Mar 13, 2016 8:00am Mar 13, 2016 8:00am
Quoting Chorlton
Hi All, I have a number of EAs, all of which contain a large number of separate user defined functions. These functions are regularly used by each EA. However, if I need to make a code change to one of the functions I then have to go into each EA containing the same function and make the same change. In order to avoid this hassle and to keep my EA code short and to save duplication, I wanted to include these functions within one mqh file and then call them in each EA using the #include <....> command. Unfortunately, each of my functions contains...
The correct thing to do is ensure that the functions are self-sufficient and do not need variables declared elsewhere, sooner or later you will end up in a pickle with remembering what goes where. All you need to do is declare all the required variables for the function within it, and pass the required values to the function as you call it and return the output values from it. This way your code is easier to understand and maintain
  • #6
  • Mar 16, 2016 4:59am Mar 16, 2016 4:59am
Quoting MaxDoom
{quote} The correct thing to do is ensure that the functions are self-sufficient and do not need variables declared elsewhere, sooner or later you will end up in a pickle with remembering what goes where. All you need to do is declare all the required variables for the function within it, and pass the required values to the function as you call it and return the output values from it. This way your code is easier to understand and maintain
Have decided to take your advice and re-code my EAs to cater for this. Lot of work but I can appreciate the longer term benefit.
  • #7
  • Last Post: Mar 16, 2016 5:58am Mar 16, 2016 5:58am
Quoting Chorlton
{quote} Have decided to take your advice and re-code my EAs to cater for this. Lot of work but I can appreciate the longer term benefit.
It's the right thing to do and it will give you an independent library as a result
regards
0 traders viewing now