Question on OrderModify and OrderClose | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

MT4 OrderClose Question 5 replies

OrderClose() issue on EA 4 replies

OrderClose wont work 2 replies

OrderClose error 4107 1 reply

Question about OrderModify() 2 replies

Question on OrderModify and OrderClose

  • #1
  • First Post: Mar 9, 2016 12:38pm Mar 9, 2016 12:38pm
Hello
I'm in the task of automatize some trades but what I've got interfere with manual opened trades, I hope someone can point what's missing
my OrderModify:
RefreshRates();
// Calculate Trailing Stop.
if ( Ask <= OrderOpenPrice() - TrailingStart * Point && OrderStopLoss() > Ask + ( TrailingStop * Point ) ) {
Ticket = OrderModify ( OrderTicket(), OrderOpenPrice(), Ask + ( TrailingStop * Point ), OrderTakeProfit(), 0 );
}
---------------
My CloseOrder:
Ticket = OrderClose ( Ticket, OrderLots(), OrderClosePrice(), Slippage, Red );
----------------
I think it's related to magic number, this is my OrderSend:

Ticket = OrderSend ( Symbol(), OP_SELL, Lots, Bid, Slippage, Bid + ( StopLoss * Point ), Bid - ( TakeProfit * Point ), NULL, mymagic, 0, Red);
LastOrder = 0;

How can I avoid the bot to jump on previous opened trades?
Thanks for any help
  • #2
  • Mar 9, 2016 6:22pm Mar 9, 2016 6:22pm
Quoting FxCba
Hello I'm in the task of automatize some trades but what I've got interfere with manual opened trades, I hope someone can point what's missing my OrderModify: RefreshRates(); // Calculate Trailing Stop. if ( Ask <= OrderOpenPrice() - TrailingStart * Point && OrderStopLoss() > Ask + ( TrailingStop * Point ) ) { Ticket = OrderModify ( OrderTicket(), OrderOpenPrice(), Ask + ( TrailingStop * Point ), OrderTakeProfit(), 0 ); } --------------- My CloseOrder: Ticket = OrderClose ( Ticket, OrderLots(), OrderClosePrice(), Slippage, Red ); ----------------...
FxCba
Somewhere you should be trapping for your MagicNumber and OrderSymbol()
manually placed orders don't have a MagicNumber. That should solve that problem.
Inserted Code
for(cnt=0;cnt<total;cnt++){    
 if(OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES)==TRUE){
 if(OrderMagicNumber() == MagicNumber && OrderSymbol()==Symbol()){
  • #3
  • Last Post: Mar 10, 2016 8:24am Mar 10, 2016 8:24am
Thank you very much cyber
0 traders viewing now