Help With Understanding Error Code(s) in MT4 | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Need help understanding ZigZag code 2 replies

MT4 error code 3 Invalid_trade Parameters on EA - help! 2 replies

MT4 EA error- when placing trade getting error 0 rate on ask 3 replies

Cannot login [no connection] - MT4 Error code #6 5 replies

Help needed understanding this code 2 replies

Help With Understanding Error Code(s) in MT4

  • #1
  • First Post: Edited 6:33am Mar 6, 2016 5:48am | Edited 6:33am
In the tester, I am getting an "Error Code 0 internal error" on BUY side orders ONLY and not sell side orders.

2 questions:

1. What is an "internal error" tied to Error code 0 which I thought was no error?

2. Why am I getting this error only on buy side orders?

The specific result printed is: "Error During Modifying Stop and TP of Buy Order !!! Error code: 0 internal error"
which corresponds to the first modification. As far as I can tell the buy side code is correct.
Here is the code used for the function below...the code may seem to have redundancy, however it is designed to make sure hard stops and hard tps are sent and posted after the order has been filled for ecn / stp type brokers.


Inserted Code
void set_stop_tp()
{
  int totalorders = OrdersTotal();
  for(int i=totalorders-1;i>=0;i--)
 {
  if(!OrderSelect(i, SELECT_BY_POS)) {
  Print(TimeToStr(TimeCurrent(),TIME_SECONDS), " CHECK Function > ", __FUNCTION__," !!!!! ", " Error code = ", GetLastError()); }
  int result;
  int check;
{
  
// Modify Stop and TP on Server if not during Order Entry
if (((OrderStopLoss() == 0) || (OrderTakeProfit() == 0)) && (OrdersTotal() > 0) && (UseHardStop == true)) { RefreshRates();
  // Modify both SL and TP if both not set yet
  if ((OrderType() == OP_BUY) && (OrdersTotal() > 0) && (OrderSymbol() == Trade) && ((OrderStopLoss() == 0) && (OrderTakeProfit() == 0)))
  result = OrderModify(OrderTicket(),OrderOpenPrice(),OrderOpenPrice()-HardStop,OrderOpenPrice()+HardTP,0,0);
  check = GetLastError();
  if(check != 0) { Print("Error During Modifying Stop and TP of Buy Order !!! Error code: ", GetLastError(), "  ", ErrorDescription(check)); }
 
  if ((OrderType() == OP_SELL) && (OrdersTotal() > 0) && (OrderSymbol() == Trade) && ((OrderStopLoss() == 0) && (OrderTakeProfit() == 0)))
  result = OrderModify(OrderTicket(),OrderOpenPrice(),OrderOpenPrice()+HardStop,OrderOpenPrice()-HardTP,0,0);
  check = GetLastError();
  if(check != 0) { Print("Error During Modifying Stop and TP of Sell Order !!! Error code: ", GetLastError(), "  ", ErrorDescription(check)); }
 
  // Modify TP only if not set yet
  if ((OrderType() == OP_BUY) && (OrdersTotal() > 0) && (OrderSymbol() == Trade) && ((OrderStopLoss() != 0) && (OrderTakeProfit() == 0)))
  result = OrderModify(OrderTicket(),OrderOpenPrice(),OrderStopLoss(),OrderOpenPrice()+HardTP,0,0);
  check = GetLastError();
  if(check != 0) { Print("Error During Modifying TP of Buy Order !!! Error code: ", GetLastError(), "  ", ErrorDescription(check)); }
 
  if ((OrderType() == OP_SELL) && (OrdersTotal() > 0) && (OrderSymbol() == Trade) && ((OrderStopLoss() != 0) && (OrderTakeProfit() == 0)))
  result = OrderModify(OrderTicket(),OrderOpenPrice(),OrderStopLoss(),OrderOpenPrice()-HardTP,0,0);
  check = GetLastError();
  if(check != 0) { Print("Error During Modifying TP of Sell Order !!! Error code: ", GetLastError(), "  ", ErrorDescription(check)); }
 
  // Modify SL only if not set yet
  if ((OrderType() == OP_BUY) && (OrdersTotal() > 0) && (OrderSymbol() == Trade) && ((OrderStopLoss() == 0) && (OrderTakeProfit() != 0)))
  result = OrderModify(OrderTicket(),OrderOpenPrice(),OrderOpenPrice()-HardStop,OrderTakeProfit(),0,0);
  check = GetLastError();
  if(check != 0) { Print("Error During Modifying Stop of Buy Order !!! Error code: ", GetLastError(), "  ", ErrorDescription(check)); }
 
  if ((OrderType() == OP_SELL) && (OrdersTotal() > 0) && (OrderSymbol() == Trade) && ((OrderStopLoss() == 0) && (OrderTakeProfit() != 0)))
  result = OrderModify(OrderTicket(),OrderOpenPrice(),OrderOpenPrice()+HardStop,OrderTakeProfit(),0,0);
  check = GetLastError();
  if(check != 0) { Print("Error During Modifying Stop of Sell Order !!! Error code: ", GetLastError(), "  ", ErrorDescription(check)); }
}


Code Reposted Outside of FF Code Box:
*******************************

void set_stop_tp()
{
int totalorders = OrdersTotal();
for(int i=totalorders-1;i>=0;i--)
{
if(!OrderSelect(i, SELECT_BY_POS)) {
Print(TimeToStr(TimeCurrent(),TIME_SECONDS), " CHECK Function > ", __FUNCTION__," !!!!! ", " Error code = ", GetLastError()); }
int result;
int check;
{

// Modify Stop and TP on Server if not during Order Entry
if (((OrderStopLoss() == 0) || (OrderTakeProfit() == 0)) && (OrdersTotal() > 0) && (UseHardStop == true)) { RefreshRates();
// Modify both SL and TP if both not set yet
if ((OrderType() == OP_BUY) && (OrdersTotal() > 0) && (OrderSymbol() == Trade) && ((OrderStopLoss() == 0) && (OrderTakeProfit() == 0)))
result = OrderModify(OrderTicket(),OrderOpenPrice(),OrderOpenPrice()-HardStop,OrderOpenPrice()+HardTP,0,0);
check = GetLastError();
if(check != 0) { Print("Error During Modifying Stop and TP of Buy Order !!! Error code: ", GetLastError(), " ", ErrorDescription(check)); }

if ((OrderType() == OP_SELL) && (OrdersTotal() > 0) && (OrderSymbol() == Trade) && ((OrderStopLoss() == 0) && (OrderTakeProfit() == 0)))
result = OrderModify(OrderTicket(),OrderOpenPrice(),OrderOpenPrice()+HardStop,OrderOpenPrice()-HardTP,0,0);
check = GetLastError();
if(check != 0) { Print("Error During Modifying Stop and TP of Sell Order !!! Error code: ", GetLastError(), " ", ErrorDescription(check)); }

// Modify TP only if not set yet
if ((OrderType() == OP_BUY) && (OrdersTotal() > 0) && (OrderSymbol() == Trade) && ((OrderStopLoss() != 0) && (OrderTakeProfit() == 0)))
result = OrderModify(OrderTicket(),OrderOpenPrice(),OrderStopLoss(),OrderOpenPrice()+HardTP,0,0);
check = GetLastError();
if(check != 0) { Print("Error During Modifying TP of Buy Order !!! Error code: ", GetLastError(), " ", ErrorDescription(check)); }

if ((OrderType() == OP_SELL) && (OrdersTotal() > 0) && (OrderSymbol() == Trade) && ((OrderStopLoss() != 0) && (OrderTakeProfit() == 0)))
result = OrderModify(OrderTicket(),OrderOpenPrice(),OrderStopLoss(),OrderOpenPrice()-HardTP,0,0);
check = GetLastError();
if(check != 0) { Print("Error During Modifying TP of Sell Order !!! Error code: ", GetLastError(), " ", ErrorDescription(check)); }

// Modify SL only if not set yet
if ((OrderType() == OP_BUY) && (OrdersTotal() > 0) && (OrderSymbol() == Trade) && ((OrderStopLoss() == 0) && (OrderTakeProfit() != 0)))
result = OrderModify(OrderTicket(),OrderOpenPrice(),OrderOpenPrice()-HardStop,OrderTakeProfit(),0,0);
check = GetLastError();
if(check != 0) { Print("Error During Modifying Stop of Buy Order !!! Error code: ", GetLastError(), " ", ErrorDescription(check)); }

if ((OrderType() == OP_SELL) && (OrdersTotal() > 0) && (OrderSymbol() == Trade) && ((OrderStopLoss() == 0) && (OrderTakeProfit() != 0)))
result = OrderModify(OrderTicket(),OrderOpenPrice(),OrderOpenPrice()+HardStop,OrderTakeProfit(),0,0);
check = GetLastError();
if(check != 0) { Print("Error During Modifying Stop of Sell Order !!! Error code: ", GetLastError(), " ", ErrorDescription(check)); }
}
  • #2
  • Mar 6, 2016 5:59am Mar 6, 2016 5:59am
I can't speak for everyone else, maybe it is because I have a small computer screen.
But for me, trying to read your code requires a lot of scrolling from left to right and back again. With having to scroll, I can't follow the code.
Does anyone else have this problem?
Please Do Not PM Me With Coding Enquiries
  • #3
  • Mar 6, 2016 6:31am Mar 6, 2016 6:31am
Quoting Gumrai
I can't speak for everyone else, maybe it is because I have a small computer screen. But for me, trying to read your code requires a lot of scrolling from left to right and back again. With having to scroll, I can't follow the code. Does anyone else have this problem?
I think it's a problem with FF's code box. I have the same problem. Will post again above.
  • #4
  • Mar 6, 2016 6:48am Mar 6, 2016 6:48am
sometimes code logic is weird...MT4 is really weird sometimes...

I changed one line of code and eliminated redundant lines and it generated the error more times...

I changed the same line of code and KEPT the redundant lines and the buy side error disappeared.

void set_stop_tp()
{
int totalorders = OrdersTotal();
for(int i=totalorders-1;i>=0;i--)
{
if(!OrderSelect(i, SELECT_BY_POS)) {
Print(TimeToStr(TimeCurrent(),TIME_ SECONDS), " CHECK Function > ", __FUNCTION__," !!!!! ", " Error code = ", GetLastError()); }
int result;
int check = GetLastError(); ------->>>>> changed and added the = to GetLastError()
{
// Modify Stop and TP on Server if not during Order Entry
if (((OrderStopLoss() == 0) || (OrderTakeProfit() == 0)) && (OrdersTotal() > 0) && (UseHardStop == true)) { RefreshRates();
// Modify both SL and TP if both not set yet
if ((OrderType() == OP_BUY) && (OrdersTotal() > 0) && (OrderSymbol() == Trade) && ((OrderStopLoss() == 0) && (OrderTakeProfit() == 0)))
result = OrderModify(OrderTicket(),OrderOpen Price(),OrderOpenPrice()-HardStop,OrderOpenPrice()+HardTP,0, 0);
check = GetLastError(); -------->>>>> Kept the redundant = to GetLastErrors() on all modifications
if(check != 0) { Print("Error During Modifying Stop and TP of Buy Order !!! Error code: ", GetLastError(), " ", ErrorDescription(check)); }

error code on buy side only disappeared, not sure why the redundancy is required but it works cleanly now.
  • #5
  • Edited 7:46am Mar 6, 2016 7:35am | Edited 7:46am
Quoting Pipologist
sometimes code logic is weird...MT4 is really weird sometimes... I changed one line of code and eliminated redundant lines and it generated the error more times... I changed the same line of code and KEPT the redundant lines and the buy side error disappeared. void set_stop_tp() { int totalorders = OrdersTotal(); for(int i=totalorders-1;i>=0;i--) { if(!OrderSelect(i, SELECT_BY_POS)) { Print(TimeToStr(TimeCurrent(),TIME_ SECONDS), " CHECK Function > ", __FUNCTION__," !!!!! ", " Error code = ", GetLastError()); } int result; int check = GetLastError();...
Pipologist-
Unfortunately you did not post the entire function so I'm not quite sure why you have this open curly bracket here:
if(!OrderSelect(i, SELECT_BY_POS)) {
Print(TimeToStr(TimeCurrent(),TIME_SECONDS), " CHECK Function > ", __FUNCTION__," !!!!! ", " Error code = ", GetLastError()); }
int result;
int check;
{

aside from some of the redundancy with using this block multiple times:
OrdersTotal() > 0) && (OrderSymbol() == Trade)

you did not specify whether the stops are being set, I suspect they're not. I would add additional information to the Print() statement
not only which of the different conditions the error is occurring but what is the result of the stops you have calculated:
for example, what is the result of OrderOpenPrice()+HardTP
if HardTP equals 50 for example and OrderOpenPrice() = 1.536 the result would be 51.536
  • #6
  • Mar 6, 2016 3:58pm Mar 6, 2016 3:58pm
I have edited your code to make it easier to read (for me, at least)
Inserted Code
void set_stop_tp()
  {
   int check;
   int totalorders=OrdersTotal();
   for(int i=totalorders-1;i>=0;i--)
     {
      if(!OrderSelect(i,SELECT_BY_POS))
        {
         Print(TimeToStr(TimeCurrent(),TIME_SECONDS)," CHECK Function > ",__FUNCTION__," !!!!! "," Error code = ",GetLastError());
        }
      else
      if(OrderSymbol()==Trade)
        {
         // Modify Stop and TP on Server if not during Order Entry
         if((OrderStopLoss()==0 || OrderTakeProfit()==0) && UseHardStop)
           {
            // Modify both SL and TP if both not set yet
            if(OrderType()==OP_BUY && OrderStopLoss()==0 && OrderTakeProfit()==0)
               if(!OrderModify(OrderTicket(),OrderOpenPrice(),OrderOpenPrice()-HardStop,OrderOpenPrice()+HardTP,0,0))
                 {
                  check=GetLastError();
                  Print("Error During Modifying Stop and TP of Buy Order !!! Error code: ",check,"  ",ErrorDescription(check));
                 }
            if(OrderType()==OP_SELL && OrderStopLoss()==0 && OrderTakeProfit()==0)
               if(!OrderModify(OrderTicket(),OrderOpenPrice(),OrderOpenPrice()+HardStop,OrderOpenPrice()-HardTP,0,0))
                 {
                  check=GetLastError();
                  Print("Error During Modifying Stop and TP of Sell Order !!! Error code: ",check,"  ",ErrorDescription(check));
                 }
            // Modify TP only if not set yet
            if(OrderType()==OP_BUY && OrderStopLoss()!=0 && OrderTakeProfit()==0)
               if(!OrderModify(OrderTicket(),OrderOpenPrice(),OrderStopLoss(),OrderOpenPrice()+HardTP,0,0))
                 {
                  check=GetLastError();
                  Print("Error During Modifying TP of Buy Order !!! Error code: ",check,"  ",ErrorDescription(check));
                 }
            if(OrderType()==OP_SELL && OrderStopLoss()!=0 && OrderTakeProfit()==0)
               if(!OrderModify(OrderTicket(),OrderOpenPrice(),OrderStopLoss(),OrderOpenPrice()-HardTP,0,0))
                 {
                  check=GetLastError();
                  Print("Error During Modifying TP of Sell Order !!! Error code: ",check,"  ",ErrorDescription(check));
                 }
            // Modify SL only if not set yet
            if(OrderType()==OP_BUY && OrderStopLoss()==0 && OrderTakeProfit()!=0)
               if(!OrderModify(OrderTicket(),OrderOpenPrice(),OrderOpenPrice()-HardStop,OrderTakeProfit(),0,0))
                 {
                  check=GetLastError();
                  Print("Error During Modifying Stop of Buy Order !!! Error code: ",check,"  ",ErrorDescription(check));
                 }
            if(OrderType()==OP_SELL && OrderStopLoss()==0 && OrderTakeProfit()!=0)
               if(!OrderModify(OrderTicket(),OrderOpenPrice(),OrderOpenPrice()+HardStop,OrderTakeProfit(),0,0))
                 {
                  check=GetLastError();
                  Print("Error During Modifying Stop of Sell Order !!! Error code: ",check,"  ",ErrorDescription(check));
                 }
           }
        }
     }
  }

As cyber1 mentioned there is no need for the repeated checks of OrdersTotal>0 as the loop will not execute if there are no open orders.
I have moved OrderSymbol()==Trade as it only needs to be checked once.
You use
result = OrderModify(OrderTicket(),OrderOpenPrice(),OrderOpenPrice()-HardStop,OrderOpenPrice()+HardTP,0,0);
but you don't actually check the value. The last error could be from elswhere in your code as it is not dependant on whether the modify fails or not.
Also in your print, you use GetLastError(). When check=GetLastError(); is executed, GetLastError() is reset to 0. This means that the error code will be printed as 0, no matter what the error was. I have modified the print to use check instead of GetLastError()
Note that I have modified the code to check for the error only if the OrderModify Fails
Please Do Not PM Me With Coding Enquiries
  • #7
  • Mar 6, 2016 6:20pm Mar 6, 2016 6:20pm
Quoting cyber1
{quote} Pipologist- Unfortunately you did not post the entire function so I'm not quite sure why you have this open curly bracket here: if(!OrderSelect(i, SELECT_BY_POS)) { Print(TimeToStr(TimeCurrent(),TIME_SECONDS), " CHECK Function > ", __FUNCTION__," !!!!! ", " Error code = ", GetLastError()); } int result; int check; { aside from some of the redundancy with using this block multiple times: OrdersTotal() > 0) && (OrderSymbol() == Trade) you did not specify whether the stops are being set, I suspect they're not. I would add additional information...
Thank you...the open bracket closes later, I didn't show the rest of the risk mgmt function because some of the other algos associated with it are proprietary.

I didn't test by removing the redundant OrdersTotal() > 0) && (OrderSymbol() == Trade) as you and Gumrai have suggested, however, as I last stated it's testing perfectly right now even with the redundant OrdersTotal() > 0) && (OrderSymbol() == Trade)

As far as the values for HardTP, HardSL, they are fine.

Thank you.
  • #8
  • Mar 6, 2016 6:21pm Mar 6, 2016 6:21pm
Quoting Gumrai
I have edited your code to make it easier to read (for me, at least)
I didn't test by removing the redundant OrdersTotal() > 0) && (OrderSymbol() == Trade) as you and Cyber1 have suggested, however, as I last stated it's testing perfectly right now even with the redundant OrdersTotal() > 0) && (OrderSymbol() == Trade)

As far as the values for HardTP, HardSL, they are fine.

Thank you.
  • #9
  • Last Post: Mar 6, 2016 7:51pm Mar 6, 2016 7:51pm
Quoting Gumrai
Also in your print, you use GetLastError(). When check=GetLastError(); is executed, GetLastError() is reset to 0. This means that the error code will be printed as 0, no matter what the error was. I have modified the print to use check instead of GetLastError() Note that I have modified the code to check for the error only if the OrderModify Fails
That was probably part of the original problem. Thank you.
0 traders viewing now