How to close by order sequence? | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Script to place multiple pending orders in succession/sequence 34 replies

Fibonacci sequence automatic adjustment 1 reply

SWING Trades using the FXTradepro "LUCKY 7" Progression Sequence 4 replies

Sequence of Order Creation - which one was first? 2 replies

How to close by order sequence?

  • #1
  • First Post: Feb 19, 2016 9:33pm Feb 19, 2016 9:33pm
Closing by order sequence.
How to create a loop to check?
if
i.e.
order 1 + order 2 has profited - close
order 3 + order 4 has profited - close

5 + 6
7 + 8
9 + 10
and so on ...
Order 1 being having the smallest order number and was opened at the earliest time.
  • #2
  • Feb 20, 2016 12:13am Feb 20, 2016 12:13am
Not tested.
Something like this should work
Inserted Code
  int slippage=10;
  double minimum_profit=5.00;
  int x;
  double trades[][4];
  int total=OrdersTotal();
  ArrayResize(trades,total);
  for(x=total-1;x>=0;x--)
     {
     if(OrderSelect(x,SELECT_BY_POS,MODE_TRADES))
        {
        trades[x][0]=OrderTicket();
        trades[x][1]=OrderProfit()+OrderCommission()+OrderSwap();
        trades[x][2]=OrderLots();
        trades[x][3]=OrderType();
        }
     }
 
  ArraySort(trades,WHOLE_ARRAY,0,MODE_ASCEND);
  x=0;
  while(x<total)
     {
     double profit=trades[x][1]+trades[x+1][1];
     if(profit>=minimum_profit)
        {
        RefreshRates();
        double close_price=Ask;
        if(trades[x][3]==OP_BUY)
           close_price=Bid;
        if(!OrderClose((int)trades[x][0],trades[x][2],close_price,slippage,clrNONE))
           Print("Error closing #",DoubleToStr(trades[x][0],0)," Error code ",GetLastError());
        
        x++;
        RefreshRates();
        close_price=Ask;
        if(trades[x][3]==OP_BUY)
           close_price=Bid;
        if(!OrderClose((int)trades[x][0],trades[x][2],close_price,slippage,clrNONE))
           Print("Error closing #",DoubleToStr(trades[x][0],0)," Error code ",GetLastError());
        x++;
        }
     }

minimum_profit can be set to whatever you want as aggregate profit.
Please Do Not PM Me With Coding Enquiries
  • #3
  • Edited 5:14pm Feb 20, 2016 12:35pm | Edited 5:14pm
How do I rectify this error?
Error: incorrect start position 0 for ArraySort function


Thanks!
  • #4
  • Feb 21, 2016 12:19am Feb 21, 2016 12:19am
As I said, I had not tested the code. I had quickly put it together to give you an example of looping through the orders.
I have looked at the code again and revised it as I made a couple of sloppy mistakes.
Inserted Code
  int slippage=10;
  double minimum_profit=100.00;
  int x;
  double trades[][4];
  int total=OrdersTotal();
  if(total>1)
  {
  ArrayResize(trades,total);
  for(x=total-1;x>=0;x--)
     {
     if(OrderSelect(x,SELECT_BY_POS,MODE_TRADES))
        {
        trades[x][0]=OrderTicket();
        trades[x][1]=OrderProfit()+OrderCommission()+OrderSwap();
        trades[x][2]=OrderLots();
        trades[x][3]=OrderType();
        }
     }
 
  ArraySort(trades,WHOLE_ARRAY,0,MODE_ASCEND);
  x=0;
  while(x<total-1)
     {
     double profit=trades[x][1]+trades[x+1][1];
     if(profit>=minimum_profit)
        {
        RefreshRates();
        double close_price=Ask;
        if(trades[x][3]==OP_BUY)
           close_price=Bid;
        if(!OrderClose((int)trades[x][0],trades[x][2],close_price,slippage,clrNONE))
           Print("Error closing #",DoubleToStr(trades[x][0],0)," Error code ",GetLastError());
        RefreshRates();
        close_price=Ask;
        if(trades[x+1][3]==OP_BUY)
           close_price=Bid;
        if(!OrderClose((int)trades[x+1][0],trades[x+1][2],close_price,slippage,clrNONE))
           Print("Error closing #",DoubleToStr(trades[x][0],0)," Error code ",GetLastError());
        }
        x+=2;
     }
     }

Note: this will only close a pair of trades. If only 1 trade is open, it will not close anything.
Please Do Not PM Me With Coding Enquiries
  • #5
  • Feb 22, 2016 2:45am Feb 22, 2016 2:45am
Script only closes the currency pair it is attached to.
How to make it work for multi currencies when the script is only attached to a single chart?

Sequence order pairs could be
i.e.

Order 1: EURUSD
Order 2: USDCAD

Order 3: GBPJPY
Order 4: AUDUSD

Could be of any different currency pair.

Thank you!
  • #6
  • Feb 22, 2016 6:20am Feb 22, 2016 6:20am
I have given you an example loop.
Expand on it to do what you want it to do.
Please Do Not PM Me With Coding Enquiries
  • #7
  • Feb 24, 2016 1:42am Feb 24, 2016 1:42am
Quoting johnnybegood
Why this decrements for loop? for(x=total-1;x>=0;x--) would increment for loop works?
In this case, it would make no difference.
When looping through orders to close trades and using SELECT_BY_POSITION, you should always decrement.
Please Do Not PM Me With Coding Enquiries
  • #8
  • Feb 24, 2016 1:58am Feb 24, 2016 1:58am
I keep getting error code 129 and is troubleshooting.
  • #9
  • Feb 26, 2016 6:30am Feb 26, 2016 6:30am
This should allow you to operate with symbols other than just the chart symbol
Inserted Code
   int slippage=10;
   double minimum_profit=100.00;
   int x;
   double trades[][2];
   int total=OrdersTotal();
   if(total>1)
     {
      ArrayResize(trades,total);
      for(x=total-1;x>=0;x--)
        {
         if(OrderSelect(x,SELECT_BY_POS,MODE_TRADES))
           {
            trades[x][0]=OrderTicket();
            trades[x][1]=OrderProfit()+OrderCommission()+OrderSwap();
           }
        }
      ArraySort(trades,WHOLE_ARRAY,0,MODE_ASCEND);
      x=0;
      while(x<total-1)
        {
         double profit=trades[x][1]+trades[x+1][1];
         if(profit>=minimum_profit)
           {
            if(OrderSelect((int)trades[x][0],SELECT_BY_TICKET))
               if(!OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),slippage,clrNONE))
                  Print("Error closing #",IntegerToString(OrderTicket())," Error code ",GetLastError());
            if(OrderSelect((int)trades[x+1][0],SELECT_BY_TICKET))
               if(!OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),slippage,clrNONE))
                  Print("Error closing #",IntegerToString(OrderTicket())," Error code ",GetLastError());
           }
         x+=2;
        }
     }

Not tested
Please Do Not PM Me With Coding Enquiries
  • #10
  • Mar 1, 2016 12:25am Mar 1, 2016 12:25am
Thanks!
Do you know how to rewrite this in mql5 for MT5?
  • #11
  • Mar 1, 2016 4:14am Mar 1, 2016 4:14am
Quoting johnnybegood
Thanks! Do you know how to rewrite this in mql5 for MT5?
I have done a small amount of work with indicators for MT5, but never been able to get my head around dealing with trades in EAs
Please Do Not PM Me With Coding Enquiries
  • #12
  • Mar 1, 2016 4:48am Mar 1, 2016 4:48am
Quoting Gumrai
{quote} I have done a small amount of work with indicators for MT5, but never been able to get my head around dealing with trades in EAs
hi dear

i cannot PM you i have 3 message per day here for PM can you send my you email to close EA issue with you
  • #13
  • Mar 2, 2016 6:37pm Mar 2, 2016 6:37pm
who can i ask to translate to mql5?
  • #14
  • Mar 2, 2016 7:26pm Mar 2, 2016 7:26pm
Quoting Zahedalani
{quote} hi dear i cannot PM you i have 3 message per day here for PM can you send my you email to close EA issue with you
Using the word "issue" makes it sound like you have had a problem with an EA that I have coded for you. As I have never coded an EA or anything for you, this is not the case. I think that it is just a poor choice of word as you have only made an enquiry.
Please Do Not PM Me With Coding Enquiries
  • #15
  • Last Post: Mar 4, 2016 7:44pm Mar 4, 2016 7:44pm
that was another dude, not me
0 traders viewing now