Loop problem | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Problem Remove Script: MT4 While loop 2 replies

Help with EA (FOR LOOP Problem) 0 replies

stuck in a loop 1 reply

While loop in Script not updating... 1 reply

Using Bid in While Loop? 11 replies

Attachments: Loop problem
Exit Attachments

Loop problem

  • #1
  • First Post: Feb 4, 2016 6:55am Feb 4, 2016 6:55am
Can someone tell me why this coding is wrong? whats wrong with it? what is wrong with this loop?
thanks..

Inserted Code
 
         if ((O4>C4 && O3>C3 && O2<C2 && O1<C1)){
              int s=2; int l=0;
              while(s<10){
              if ((MathAbs(Close[i+s]-Open[i+s])/Poin)==1) l++; s++;}
              if (l>=4)
              Ext1Buffer[i+1]=0.45;}
          if ((O4<C4 && O3<C3 && O2>C2 && O1>C1)){
              int p=2; int e=0;
              while(p<10){
              if ((MathAbs(Close[i+p]-Open[i+p])/Poin)==1) e++; p++;}
              if (e>=4)
              Ext2Buffer[i+1]=0.45;}
Attached File(s)
File Type: mq4 test1.mq4   3 KB | 370 downloads
  • #2
  • Feb 4, 2016 8:35am Feb 4, 2016 8:35am
Hi, tried to fix your problem.

image1 (metatrader) + image2 (charts)

1) in the line : "if ((MathAbs(Close[i+1]-Open[i+1[)/Poin)==1) l++; s++;}" => "if ((MathAbs(Close[i+1]-Open[i+1[)/Poin)==1); l++; s++;}" a semicolon before 'l++' has been added.
2) test1.mq4 is EA; mine is saved as an custom indicator
3) I have placed the declaration of variables at the beginning of the initialization, not in the loop (...it's a habit... :-))

In het chart-image the middle indicator is the result i get.


hope this helps

Greetz
Attached Image(s) (click to enlarge)
Click to Enlarge Name: Image1.png Size: 120 KB
Click to Enlarge Name: Image2.png Size: 37 KB
  • #3
  • Feb 4, 2016 3:03pm Feb 4, 2016 3:03pm
hi Nofratrader, thank you for replying..
its not fixed Nofra, because now this coding add 1 to ''l'' and ''e'' everytime in loop...
  • #4
  • Feb 4, 2016 3:57pm Feb 4, 2016 3:57pm
if ((MathAbs(Close[i+s]-Open[i+s])/Poin)==1)
First of all, what is Poin? Have you declared it elsewhere? Do you mean Point?
You should never compare calculated doubles to an integer, you may think that it should result in 1, but it may be represented as 0.999999 and so comparing to 1 will result in false.
Rounding may help you to solve your problem.
Try
if(MathRound((MathAbs(Close[i+s]-Open[i+s])/Point))==1)
Please Do Not PM Me With Coding Enquiries
  • #5
  • Feb 4, 2016 4:23pm Feb 4, 2016 4:23pm
ah.. im an idiot.. you're right Gumrai..
i was comparing double with integer...
thanks man, you saved me..
  • #6
  • Last Post: Feb 6, 2016 6:32am Feb 6, 2016 6:32am
deleted
0 traders viewing now