Trying to capture Time/Date info in an Array | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Please add Start Date / End Date to Basket Stats Indi 2 replies

Two Dimensional Array vs One Dimensional Array 13 replies

Cool Time And Date Zone Website and Time Zone Converter. :) 3 replies

Calculate Stochastic Formula on a array (non indicator buffer array) 2 replies

mql Q : how to use cci array? 4 replies

Trying to capture Time/Date info in an Array

  • #1
  • First Post: Edited 1:03am Jan 7, 2016 12:43am | Edited 1:03am
Hi All,

I would like to keep a separate record of the dates when trade signals have appeared, which I can then export to a CSV file for further analysis. I thought this could be easily achieved using an array, which would keep a running list of all the dates for each trade signal taken but I'm having some difficulties.

When I compile my code I get the "possible loss of data due to type conversion" error with the following line : BuyTradesArray[index][0]=BuySignalTime;

BuyTradesArray is defined as a double
index is defined as an INT (index increases by 1 each time a new trade signal appears)
BuySignalTime is defined as a datetime ( as it contains time/date info)

What am I doing wrong?

Any advice appreciated.....

PS. I would like my array to contain to pieces of information; both Signal Time/Date and Open Price. For this reason I did not declare the array as datetime to begin with.


Thanks in advance,

CCH
  • #2
  • Jan 7, 2016 1:28am Jan 7, 2016 1:28am
Your error is because BuySignalTime and BuyTradesArray haven't the same definition (double and datetime).

If your array is to save a time value, then declare it as a datetime instead of double.
MT4/MT5 EAs/Indicators/Alerts coder
  • #3
  • Jan 7, 2016 1:30am Jan 7, 2016 1:30am
Quoting Chorlton
PS. I would like my array to contain to pieces of information; both Signal Time/Date and Open Price. For this reason I did not declare the array as datetime to begin with.
Oh just saw this !

So try this : BuyTradesArray[index][0]=(double)BuySignalTime
MT4/MT5 EAs/Indicators/Alerts coder
  • #4
  • Jan 7, 2016 1:55am Jan 7, 2016 1:55am
Quoting FerruFx
{quote} Oh just saw this ! So try this : BuyTradesArray[index][0]=(double)BuySignalTime

Aha... so thats how its done !!

Thanks Ferru.....
  • #5
  • Jan 7, 2016 1:57am Jan 7, 2016 1:57am
Quoting Chorlton
{quote} Aha... so thats how its done !! Thanks Ferru.....
MT4/MT5 EAs/Indicators/Alerts coder
  • #6
  • Jan 7, 2016 2:56am Jan 7, 2016 2:56am
You could use a struct
Inserted Code
   struct TradeSignals
     {
      double            SignalPrice;
      datetime          SignalTime;
     };
   TradeSignals BuyTradesArray[];
   
   if(Signal)
   {
   int as=ArrayRange(BuyTradesArray,0);
   ArrayResize(BuyTradesArray,as+1);
   BuyTradesArray[as].SignalPrice=price;
   BuyTradesArray[as].SignalTime=time;
   }

Of course, Signal, price and time will have to be given values in the code
Please Do Not PM Me With Coding Enquiries
  • #7
  • Jan 7, 2016 6:52am Jan 7, 2016 6:52am
Quoting Gumrai
You could use a struct struct TradeSignals { double SignalPrice; datetime SignalTime; }; TradeSignals BuyTradesArray[]; if(Signal) { int as=ArrayRange(BuyTradesArray,0); ArrayResize(BuyTradesArray,as+1); BuyTradesArray[as].SignalPrice=price; BuyTradesArray[as].SignalTime=time; } Of course, Signal, price and time will have to be given values in the code
Hi Gumrai,

Interesting approach... I haven't really spent any time learning OOP. Does such code work more efficiently with MT4 or it is more tailored for MT5?
  • #8
  • Jan 7, 2016 2:13pm Jan 7, 2016 2:13pm
I don't know about whether it is more or less efficient.
I have used multi-dimensional arrays to store trade details, but if you want to store a string, it requires to use a separate array.
With a struct, all variable types can be stored in 1 array. Also, as the elements are named, it makes them easier to identify.
Please Do Not PM Me With Coding Enquiries
  • #9
  • Jan 7, 2016 2:21pm Jan 7, 2016 2:21pm
Quoting Chorlton
Hi All, I would like to keep a separate record of the dates when trade signals have appeared, which I can then export to a CSV file for further analysis. I thought this could be easily achieved using an array, which would keep a running list of all the dates for each trade signal taken but I'm having some difficulties. When I compile my code I get the "possible loss of data due to type conversion" error with the following line : BuyTradesArray[index][0]=BuySignalTime; BuyTradesArray is defined as a double index is defined as an INT (index increases...
Sorry I am a bit late on this band wagon... but just a thought...

Why do you want to store this info in an array, and THEN write it to a csv later? Why don't you just write it to a csv as the signals come through?

Vlad
  • #10
  • Last Post: Jan 8, 2016 4:45am Jan 8, 2016 4:45am
Quoting Vlad13685
{quote} Sorry I am a bit late on this band wagon... but just a thought... Why do you want to store this info in an array, and THEN write it to a csv later? Why don't you just write it to a csv as the signals come through? Vlad
Good Question. I'm actually using the next few bars after the signal bar to form part of a calculation and then I write the calculation result together with the signal date / time to my output file.
0 traders viewing now