please check my code for errors | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Average Daily Range (ADR) - code check 11 replies

Errors in TMA Indicator- Could someone please fix :) 2 replies

Errors in Indicator - Could someone please fix :) 3 replies

Need Help please : Check code on Divergence Indicator 4 replies

Can somebody check my code??? 3 replies

Attachments: please check my code for errors
Exit Attachments

please check my code for errors

  • #1
  • First Post: Nov 29, 2015 12:33am Nov 29, 2015 12:33am
please check my code and correct errors if any.

also is it possible to make the code execute every minute instead of every tick, because sl once set may not be needed to be checked for atleast one minute.

what i am trying to do is display a counter of trades with no stop loss at top right [ cnt ]

update stoploss if not present to be after price moves 10 pips.

upldate stoploss of all trades if present to fixed value when i want


Attached File(s)
File Type: mq4 stoploss.mq4   3 KB | 421 downloads
  • #2
  • Edited 8:41pm Nov 29, 2015 7:06am | Edited 8:41pm
Attached File(s)
File Type: mq4 StopLoss.mq4   9 KB | 410 downloads

Put this statement in OnInit()
EventSetTimer(60);

Put this statement in OnDeinit(const int reason)
EventKillTimer();

Change OnTick() to OnTimer()

Here's code that may be interesting to you.
  • #3
  • Nov 29, 2015 9:11pm Nov 29, 2015 9:11pm
Quoting lukeb
{file} Put this statement in OnInit() EventSetTimer(60); Put this statement in OnDeinit(const int reason) EventKillTimer(); Change OnTick() to OnTimer() Here's code that may be interesting to you.
thanks, maybe i should modify other indicators too where levels are calculated after 24 hours.
  • #4
  • Nov 30, 2015 12:38am Nov 30, 2015 12:38am
Quoting PatienceFx
please check my code and correct errors if any. also is it possible to make the code execute every minute instead of every tick, because sl once set may not be needed to be checked for atleast one minute. what i am trying to do is display a counter of trades with no stop loss at top right [ cnt ] update stoploss if not present to be after price moves 10 pips. upldate stoploss of all trades if present to fixed value when i want {file}
i am having trouble with the counter

i want a count of trades where stoploss is 0 ;

and when the stop loss is set it should reduce the count, it keeps adding the counter with every tick

even with 2 open trades where sl is not yet set the counter keeps increasing.

Attached Image (click to enlarge)
Click to Enlarge Name: LKI4k7I.png Size: 23 KB
  • #5
  • Nov 30, 2015 5:57pm Nov 30, 2015 5:57pm
PatienceFX, "it keeps adding the counter with every tick"
Up in the global area, you define the count integer:
int cnt = 0;
Every time there is a tick, the code starts executing with entry into OnTick (or OnTimer if you changed it), where the statement
cnt++;
is encountered. cnt is never returned to zero.

Compare to code I provided you - every timer event results in a call to count the orders, where the first statement makes the count start at zero:
CountOrdersWithoutSL(void)
{
int cnt=0;
  • #6
  • Last Post: Dec 30, 2015 10:34pm Dec 30, 2015 10:34pm
Improved code - but not exactly what PatienceFx wanted - it adds SL and TP with every button press.
Attached File(s)
File Type: mq4 StopLoss.mq4   11 KB | 464 downloads
0 traders viewing now