Can't get EA to close 2 Open positions??? | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

EA Close out all open positions on certain level of equity 56 replies

EA "Close all positions at profit target" closed all positions at loss ? 9 replies

Need close all open positions EA 5 replies

Simple EA to open/close positions with TP and SL 0 replies

Help for Script to close all open positions 4 replies

Can't get EA to close 2 Open positions???

  • #1
  • First Post: Aug 7, 2006 6:17am Aug 7, 2006 6:17am
I have an EA that is suppose to close 2 open buys or sells when the conditions are right (one of the EA's functions)

I used the EA generator at that one website.

Anyways, it works alot of the time but sometimes it only closes 1 buy.
I even put in a short delay between closes because I thought it was a timing issue.

Is there a function to close ALL open buys or Sells in one shot? The Generator goes through 1 by 1 and closes them.

I can't think of why this won't close both all the time
taking series 3 and 34
  • #2
  • Aug 14, 2006 5:28am Aug 14, 2006 5:28am
I'm not sure, but I think that always EA closes Order by OrderClose or OrderCloseBy functions - which closes only one order - it depends of EA how many times and how it use this function. If You wish to close all orders You should use it in loop (of course You shoul be aware not to close another orders eg. from another EA etc.

See: http://articles.mql4.com/145
http://articles.mql4.com/44

and another articles on ww.mql4.com


Regards,

Andrew
  • #3
  • Aug 14, 2006 6:26pm Aug 14, 2006 6:26pm
i'll read those..

I'm reshaping this EA to Close all positions and KEEP trying to close until allopen trades = 0.
THEN move on to rest of code..
kind of a WHILE DO function.

HOPEFULLY I can code this write cuz I understand about 50% of MQL language
taking series 3 and 34
  • #4
  • Last Post: Aug 21, 2006 5:30am Aug 21, 2006 5:30am
here is the solution from metaquotes.net forum:
Quote
Slawa 02.06.06 10:43

See example. You have 5 orders
0 - 110001
1 - 110002
2 - 110003
3 - 110004
4 - 110005

You select first order (index 0) and close it. Your list changed
0 - 110002
1 - 110003
2 - 110004
3 - 110005

Next index is 1 (trade++). You select second order and close it
0 - 110002
1 - 110004
2 - 110005

Next index is 2. You select and close
0 - 110002
1 - 110004

Next index is 3. But You have not order with index 3.
so the correct code would look something like this (I tested it):
Inserted Code
      int total  = OrdersTotal();
      for (int cnt = total; cnt == 0; cnt--)
      {
         OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES);
         if (OrderMagicNumber() == MagicNumber) {
            if(OrderType()==OP_BUY) {
               OrderClose(OrderTicket(),OrderLots(),Bid,Slippage,Violet);
               // Sleep(1000);
            }
            if(OrderType()==OP_SELL) {
               OrderClose(OrderTicket(),OrderLots(),Ask,Slippage,Violet);
               // Sleep(1000);
            }
         }
      }
What I am not sure yet is how would this do live as I've heard that there could be some broker issues when you try to open/close multiple orders at once and a "Sleep" function might be required.
0 traders viewing now