Attachments: Problem with deleting pending orders

Problem with deleting pending orders

#1
First Post: Jul 4, 2015 10:57am Jul 4, 2015 10:57am

hewi
| Joined May 2014 | Status: Trader | 25 Posts

Hello traders,

need help with my EA coding. I need to detele the pending order after the activation of one.
I have given two pending orders SELLSTOP and BUYSTOP after activation of one of them I need to delete the reverse pending order.

Inserted Code

   int long= -1;
   int short= -1;
   int noactiveorder = true;
  
      for(s = 0; s < total; s++)
      {
      OrderSelect(s, SELECT_BY_POS, MODE_TRADES);
         if(OrderSymbol()==Symbol() && OrderMagicNumber() == magic)
         {
           if(OrderType() == OP_BUYSTOP)
             long= OrderTicket();
            
            if(OrderType() == OP_SELLSTOP)
              short= OrderTicket();
              
            if(OrderType() == OP_BUY || OrderType() == OP_SELL)
               noactiveorder= false;
         }
      }
      
      if(short == -1 && long != -1)
      OrderDelete(long);
      
      if(long == -1 && short != -1)
      OrderDelete(short);

Big thanks for reply and answers. Have a nice weekend.

hewi

#2
Jul 4, 2015 3:46pm Jul 4, 2015 3:46pm

hewi
| Joined May 2014 | Status: Trader | 25 Posts

Still not working

need delete reverse pending order after activation one of them ....

Inserted Code

   int long= -1;
   int short= -1;
   
      for(s = 0; s < total; s++)
      {
      OrderSelect(s, SELECT_BY_POS, MODE_TRADES);
         if(OrderSymbol()==Symbol() && OrderMagicNumber() == magic)
         {
           if(OrderType() == OP_BUYSTOP)
             long= OrderTicket();
             
            if(OrderType() == OP_SELLSTOP)
              short= OrderTicket();
              
         }
      }
      
      if(OrderType() == OP_BUY)
      OrderDelete(short);
      
      if(OrderType() == OP_SELL)
      OrderDelete(long);

Is there anybody who help me please

?
Hope you understand...
Thanks ...

#3
Jul 4, 2015 7:52pm Jul 4, 2015 7:52pm

Gumrai
Joined Oct 2012 | Status: Trader | 1,959 Posts

I think that your first code is more viable
What is the value of the variable total? Where does it get its value from?
When you place the pending orders are you giving them the magic number?

Please Do Not PM Me With Coding Enquiries

#4
Jul 5, 2015 5:43am Jul 5, 2015 5:43am

hewi
| Joined May 2014 | Status: Trader | 25 Posts

magic is used..

Inserted Code

magic = 1515;
total = OrdersTotal();

Still not working...after activation of one of them still remains reverse order !

Code has not any errors or warnings.....

#5
Jul 5, 2015 6:20am Jul 5, 2015 6:20am

Gumrai
Joined Oct 2012 | Status: Trader | 1,959 Posts

You didn't answer.
When the pending orders are placed, are they given the magic number?
Where is total=OrdersTotal()?
Why use an intermediary variable? Just use OrdersTotal()

Please Do Not PM Me With Coding Enquiries

#6
Jul 5, 2015 9:10am Jul 5, 2015 9:10am

hewi
| Joined May 2014 | Status: Trader | 25 Posts

magic can not be 1515 if there two pending orders?...i gave 12345 and it did not help...

Inserted Code

//PENDING ORDERS

if(TimeHour(TimeCurrent()) == start)
{
                  ticket = OrderSend(Symbol(),OP_BUYSTOP,Size,high,0,SL*Point,
                  PT*point,"Buy order", magic ,TimeCurrent()+ validity*3600,Green);
                  
                  
                  
                  ticket = OrderSend(Symbol(),OP_SELLSTOP,Size,low,0,SL*Point,
                  PT*Point,"Sell order",magic,TimeCurrent()+ validity*3600,Red);
}

I also fix total. I put OrdersTotal(). Still not work...

I can send my code in PM please

#7
Jul 5, 2015 10:17am Jul 5, 2015 10:17am

hewi
| Joined May 2014 | Status: Trader | 25 Posts

I do not understand why it took order buy when the candle is not there yet.... why it took a buy order??? It makes it almost everywhere

Attached Image

#8
Jul 5, 2015 2:17pm Jul 5, 2015 2:17pm

Gumrai
Joined Oct 2012 | Status: Trader | 1,959 Posts

Quoting hewi

Disliked

I do not understand why it took order buy when the candle is not there yet.... why it took a buy order??? It makes it almost everywhere {image}

Ignored

Buy orders are placed at the Ask price, the chart is Bid price. So Ask may hit a level when Bid doesn't.

I can't see why your orders are not being deleted. The only other thing that I can think of is that you have a return somewhere before the code so it is never executed.

Please Do Not PM Me With Coding Enquiries

#9
Jul 5, 2015 3:25pm Jul 5, 2015 3:25pm

fxindikator
| Joined Oct 2010 | Status: Trader | 167 Posts

Quoting hewi

Disliked

I do not understand why it took order buy when the candle is not there yet.... why it took a buy order??? It makes it almost everywhere {image}

Ignored

Set the "Ask line" active on your chart, and buy order are executed based on these line.

#10
Jul 6, 2015 4:31am Jul 6, 2015 4:31am

rockit
Joined Oct 2013 | Status: Trader | 1,025 Posts

Try:

Inserted Code

bool cancel=false;
int ticket=-1;
for(int s=0; s<OrdersTotal(); s++) {
  if(OrderSelect(s, SELECT_BY_POS) && OrderSymbol()==Symbol() && OrderMagicNumber()==magic) {
    if(OrderType()<2) {
      if(ticket>0) {
        bool r=OrderDelete(ticket);
        return;
      }
      else cancel=true;
    }
    else if(cancel) {
      bool r=OrderDelete(OrderTicket());
      return;
    }
    else ticket=OrderTicket();
  }
}

Return To Disorder

#11
Edited 4:58am Jul 6, 2015 4:37am | Edited 4:58am

hewi
| Joined May 2014 | Status: Trader | 25 Posts

Quoting Gumrai

Disliked

{quote} Buy orders are placed at the Ask price, the chart is Bid price. So Ask may hit a level when Bid doesn't. I can't see why your orders are not being deleted. The only other thing that I can think of is that you have a return somewhere before the code so it is never executed.

Ignored

How I can fix this problem with Ask/Bid? Directly in the code in command OrderSend() ? Something like if Bid > high so buy?

I'll try to write another code to delete pending orders, or Can I send my code to you in PM okay ?
Thanks.....

#12
Jul 6, 2015 4:56am Jul 6, 2015 4:56am

Gumrai
Joined Oct 2012 | Status: Trader | 1,959 Posts

Quoting hewi

Disliked

{quote} How I can fix this problem with Ask/Bid? Directly in the code in command OrderSend() ? I'll try to write another code to delete pending orders, or Can I send my code to you in PM okay ? Thanks.....

Ignored

It is not a problem with ask/bid, it is just the way it is.
I don't think that code can be attached in a PM, but I haven't checked that for a while.

Please Do Not PM Me With Coding Enquiries

#13
Jul 6, 2015 5:01am Jul 6, 2015 5:01am

Gumrai
Joined Oct 2012 | Status: Trader | 1,959 Posts

You can copy and paste your code in a PM if you like

Please Do Not PM Me With Coding Enquiries

#14
Jul 6, 2015 5:09am Jul 6, 2015 5:09am

hewi
| Joined May 2014 | Status: Trader | 25 Posts

Quoting rockit

Disliked

Try: bool cancel=false; int ticket=-1; for(int s=0; s<OrdersTotal(); s++) { if(OrderSelect(s, SELECT_BY_POS) && OrderSymbol()==Symbol() && OrderMagicNumber()==magic) { if(OrderType()<2) { if(ticket>0) { bool r=OrderDelete(ticket); return; } else cancel=true; } else if(cancel) { bool r=OrderDelete(OrderTicket()); return; } else ticket=OrderTicket(); } }

Ignored

Thanks, but still does not work...maybe I'm doing something stupid, I'm a beginner.....

Attached Image

#15
Jul 6, 2015 5:14am Jul 6, 2015 5:14am

rockit
Joined Oct 2013 | Status: Trader | 1,025 Posts

Quoting hewi

Disliked

Thanks, but still does not work...

Ignored

I made a small mistake

now:

Inserted Code

bool cancel=false;
int ticket=-1;
for(int s=0; s<OrdersTotal(); s++) {
  if(OrderSelect(s, SELECT_BY_POS) && OrderSymbol()==Symbol() && OrderMagicNumber()==magic) {
    if(OrderType()<2) {
      if(ticket>0) {
        bool r=OrderDelete(ticket);
        return;
      }
      else cancel=true;
    }
    else {
      if(cancel) {
        bool r=OrderDelete(OrderTicket());
        return;
      }
      else ticket=OrderTicket();
    }
  }
}

Return To Disorder

#16
Jul 6, 2015 5:19am Jul 6, 2015 5:19am

hewi
| Joined May 2014 | Status: Trader | 25 Posts

Quoting Gumrai

Disliked

You can copy and paste your code in a PM if you like

Ignored

I sent it....

#17
Jul 6, 2015 5:21am Jul 6, 2015 5:21am

hewi
| Joined May 2014 | Status: Trader | 25 Posts

Quoting rockit

Disliked

{quote} I made a small mistake now: bool cancel=false; int ticket=-1; for(int s=0; s<OrdersTotal(); s++) { if(OrderSelect(s, SELECT_BY_POS) && OrderSymbol()==Symbol() && OrderMagicNumber()==magic) { if(OrderType()<2) { if(ticket>0) { bool r=OrderDelete(ticket); return; } else cancel=true; } else { if(cancel) { bool r=OrderDelete(OrderTicket()); return; } else ticket=OrderTicket(); } } }

Ignored

I sent my code to Gumrai...still does not work....

Thanks.....

#18
Jul 6, 2015 5:28am Jul 6, 2015 5:28am

rockit
Joined Oct 2013 | Status: Trader | 1,025 Posts

I cannot see why it would not work. Is your code in the new mql style? What does the log say?

Return To Disorder

#19
Jul 6, 2015 5:29am Jul 6, 2015 5:29am

4extrader
| Joined Apr 2013 | Status: Trader | 5 Posts

hi, i´m not a programmer, my idea is:
Is it possible to send the orders as "OCO" orders

#20
Jul 6, 2015 5:58am Jul 6, 2015 5:58am

Gumrai
Joined Oct 2012 | Status: Trader | 1,959 Posts

I received your code
I have no idea what this is intended to do

Inserted Code

 for(q=0; q<OrdersTotal(); q++)
     {
      if(OrderSelect(q,SELECT_BY_POS,MODE_TRADES) && OrderMagicNumber()==magic)
        {
         return;
        }
     }

but what it means is that if the EA has an open order, then it returns from OnTick, so the code to delete the order cannot be executed.
I suggestyed this as a possibility in post #8
Remove that block of code

Please Do Not PM Me With Coding Enquiries

Platform Tech
/
Problem with deleting pending orders
Reply to Thread
- Page 1 2
- Page 1 2

0 traders viewing now

Options

Similar Threads

Problem with deleting pending orders