Trailing Stop EA | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Looking for Trailing Stop EA like default MT4 trailing stop 7 replies

Trailing stop after up some pips and question trailing step 3 replies

Trailing step and trailing stop optimization 0 replies

Buy Stop and Sell Stop orders with OCO and Trailing Stop 0 replies

To Trailing Stop or Not To Trailing Stop.... 36 replies

Trailing Stop EA

  • #1
  • First Post: Jun 15, 2015 7:35am Jun 15, 2015 7:35am
I have been working on an EA that (based on presses of chart object buttons);

 

  1. Opens trades at market price caluculating lot size based my risk % using a SL line that I place on the chart.
  2. Sets pending trades (and calculates right lot size based on risk %) using a Entry and SL line that I place on the chart.
  3. Various types of closing functions (all open, all pendings, all O&P, all profit, all loss etc...)
  4. Moves trades to BE + enough to cover comm. and swaps
  5. I have been working on a trailing SL function which works fine and does what it is suppsoed to do but only the first time. I press the button, it figures out where price is and moves the SL accordingly. Again this determines how much to move based on initial risk (as SL moves I use the open price and a fixed say 5:1 take profit for calculating the how much to move as these are set factors that won't move and mess up the calcs).

What I am trying to do is to set a loop of sorts where I press the button once on the chart and it moves the SL. Then if price hits a new level it moves the SL again without having to hit the trailing SL buttion again. I realize that if I change TF etc... and we ReInit that I have to re hit the button. Can this code be put into a loop that keep checking and moving the SL after the first hit of the button? I have tried some things like using "while" but it just messes things up and the SL bounces back and forth. If I put continue; after each if then it stops after the first line...

I hope someone can help. I am sure it is a stupid error on my part or something simple I am not seeing. I am still quite new to coding.

Inserted Code
 if(sparam=="TSLButton") // Trail SL button has been pressed
        {
         ObjectSetInteger(0,"TSLButton",OBJPROP_STATE,false);
         bool TSL = false;
         double TickValue = MarketInfo(Symbol(),MODE_TICKVALUE);
         double GGG = OrderCommission()+OrderSwap();
         double GGG1= NormalizeDouble(OrderCommission()+OrderSwap(),Digits)*Point;
         double XXX = GGG1/TickValue;
         double XXY = (OrderOpenPrice()-OrderTakeProfit())/TPFactor;
         int orders_cnt = 0;
         int total = OrdersTotal();
         for(int i=0; i<total; i++)
           {
            if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==false)continue;
            if(OrderSymbol()==Symbol()) orders_cnt++;
            ObjectSetInteger(0,"TSLButton",OBJPROP_COLOR,ButtonTxtCLR);
            ObjectSetInteger(0,"TSLButton",OBJPROP_BGCOLOR,Red);
            ObjectSetInteger(0,"TSLButton",OBJPROP_BORDER_COLOR,Red);
            RefreshRates();
            if(OrderType()==OP_BUY)
              {
               if(Bid>(OrderOpenPrice()+(XXY*2)))
               {TSL = OrderModify(OrderTicket(),OrderOpenPrice(),(OrderOpenPrice()-(XXX)),OrderTakeProfit(),0,clrNONE);}
               if(Bid>(OrderOpenPrice()+(XXY*3)))
               {TSL = OrderModify(OrderTicket(),OrderOpenPrice(),((OrderOpenPrice()-(XXX))+(XXY)),OrderTakeProfit(),0,clrNONE);}
               if(Bid>(OrderOpenPrice()+(XXY*4)))
               {TSL = OrderModify(OrderTicket(),OrderOpenPrice(),((OrderOpenPrice()-(XXX))+(XXY*3)),OrderTakeProfit(),0,clrNONE);}
              }
            if(OrderType()==OP_SELL)
              {
               if(Ask<(OrderOpenPrice()-(XXY*2)))
               {TSL=OrderModify(OrderTicket(),OrderOpenPrice(),(OrderOpenPrice()+(XXX)),OrderTakeProfit(),0,clrNONE);}
               if(Ask<(OrderOpenPrice()-(XXY*3)))
               {TSL=OrderModify(OrderTicket(),OrderOpenPrice(),((OrderOpenPrice()+(XXX))-(XXY)),OrderTakeProfit(),0,clrNONE);}
               if(Ask<(OrderOpenPrice()-(XXY*4)))
               {TSL=OrderModify(OrderTicket(),OrderOpenPrice(),((OrderOpenPrice()+(XXX))-(XXY*3)),OrderTakeProfit(),0,clrNONE);}
              }
           }
        }
Today's zone = Tomorrow's opportunity!
  • #2
  • Jun 15, 2015 8:04am Jun 15, 2015 8:04am
Hi press78,

You don't have to put your code on a loop but instead calling it on each "OnTick" event.

The thing to do as a general idea is that your button should turn on/off your trailing stop, then persistently store that (in a file for example) and check that value on the OnInit function, then in the OnTick, you call your trailing stop code if that variable is on or off.
Simplicity is the Ultimate Sophistication.
  • #3
  • Jun 15, 2015 9:01am Jun 15, 2015 9:01am
Quoting broketrader
Hi press78, You don't have to put your code on a loop but instead calling it on each "OnTick" event. The thing to do as a general idea is that your button should turn on/off your trailing stop, then persistently store that (in a file for example) and check that value on the OnInit function, then in the OnTick, you call your trailing stop code if that variable is on or off.
Thank you for the response. That points me in the direction of what I need to study up on :nerd: then because I have not had to code anything like what you describe before!
Today's zone = Tomorrow's opportunity!
  • #4
  • Edited 10:25am Jun 24, 2015 9:37am | Edited 10:25am
Getting closer. Have the trailing stop working well under the tick function. However it tries to modify ALL open trades (whether buy or sells) based on the first opened trade. The first opened trade everything works perfect. Moves SL when it should by the right amount...

Let's say trade 1 is a buy on EUR USD...

Trade 2 is buy trade on a different pair... the SL starts going crazy based on what EURUSD is doing.

Trade 3 is a sell trade on yet a different pair... again the SL starts going crazy based on what trade 1 is doing.

I had both buy and sell trades under a single turn on/off trail SL option. Thought by breaking them apart into their own turn on/off options would fix the issue but it does not.

How can I get the trail SL function to look at each trade individually and manage them as such?

Here is what I have for code under the OnTick.

Inserted Code
   if (TrailBuySL == true)
   {
   bool TSLBuy=false;
   TotalNumberOfOrders = OrdersTotal();
   for(PositionIndex = TotalNumberOfOrders -1; PositionIndex >=0; PositionIndex --)
   {
   if (!OrderSelect(PositionIndex,SELECT_BY_POS,MODE_TRADES))continue;
   if(OrderType()==OP_BUY && OrderSymbol()==Symbol())
   {
   if(MarketInfo(Symbol(),MODE_BID)>(OrderStopLoss()+(BuyRisk*TrailFactor)))
   TSLBuy=OrderModify(OrderTicket(),OrderOpenPrice(),((OrderStopLoss()+(BuyRisk*TrailMove))-BECSAdd),OrderTakeProfit(),0,clrNONE);
   }
   }
   }
   if (TrailSellSL == true)
   {
   bool TSLSell=false;
   TotalNumberOfOrders = OrdersTotal();
   for(PositionIndex = TotalNumberOfOrders -1; PositionIndex >=0; PositionIndex --)
   {
   if (!OrderSelect(PositionIndex,SELECT_BY_POS,MODE_TRADES))continue;
   if(OrderType()==OP_SELL && OrderSymbol()==Symbol())
   {
   if(MarketInfo(Symbol(),MODE_ASK)<(OrderStopLoss()-(SellRisk*TrailFactor)))
   TSLSell=OrderModify(OrderTicket(),OrderOpenPrice(),((OrderStopLoss()-(SellRisk*TrailMove))+BECSAdd),OrderTakeProfit(),0,clrNONE);
   }
   }
   }
Today's zone = Tomorrow's opportunity!
  • #5
  • Edited 1:01pm Jun 24, 2015 12:24pm | Edited 1:01pm
Quoting pres78
Getting closer. Have the trailing stop working well under the tick function. However it tries to modify ALL open trades (whether buy or sells) based on the first opened trade. The first opened trade everything works perfect. Moves SL when it should by the right amount... Let's say trade 1 is a buy on EUR USD... Trade 2 is buy trade on a different pair... the SL starts going crazy based on what EURUSD is doing. Trade 3 is a sell trade on yet a different pair... again the SL starts going crazy based on what trade 1 is doing. I had both buy and sell...
Ok so I added a magic number and by filtering the trail SL to manage trades only if Symbol, OrderType and MagicNumber match the order information. This seems to have stopped the crazy SL moving when looking at 2 trades (opposing directions for this test) on different pairs. Too early to tell if the trail will actually work. Time will tell on both trades.

I am very curious however why the in place filter of OrderSymbol and OrdeType was not protecting trades on other charts and even of the opposing trade type from being affected by the trail SL???

Based on this theory if I wanted to open multiple trades on the same pair and have the trail manage them seperately I will have to open multiple charts for the same pair and apply the EA with different magic numbers?

If anyone has any other infomation or help that would still be greatly appreciated.
Today's zone = Tomorrow's opportunity!
  • #6
  • Jun 24, 2015 2:35pm Jun 24, 2015 2:35pm
Are you asking how to implement a TS? - You need (per order) a trail distance and I suggest a step (i.e. one pip or more, and not sub-pip).
From there it's easy and the plain TS code looks i.e. something like this:
Inserted Code
if(OrderSelect(...)) {
  if(OrderType()==OP_BUY && (MarketInfo(OrderSymbol(),MODE_BID)-traildistance>OrderStopLoss())) {
    if(!OrderModify(OrderTicket(), OrderOpenPrice(), NormalizeDouble(MarketInfo(OrderSymbol(),MODE_BID)-traildistance+step, Digits-1), OrderTakeProfit(), 0));
  }
  else
  if(OrderType()==OP_SELL && (MarketInfo(OrderSymbol(),MODE_ASK)+traildistance<OrderStopLoss())) {
    if(!OrderModify(OrderTicket(), OrderOpenPrice(), NormalizeDouble(MarketInfo(OrderSymbol(),MODE_ASK)+traildistance-step, Digits-1), OrderTakeProfit(), 0));
  }
}
Return To Disorder
  • #7
  • Jun 24, 2015 4:00pm Jun 24, 2015 4:00pm
Quoting rockit
Are you asking how to implement a TS? - You need (per order) a trail distance and I suggest a step (i.e. one pip or more, and not sub-pip). From there it's easy and the plain TS code looks i.e. something like this: if(OrderSelect(...)) { if(OrderType()==OP_BUY && (MarketInfo(OrderSymbol(),MODE_BID)-traildistance>OrderStopLoss())) { if(!OrderModify(OrderTicket(), OrderOpenPrice(), NormalizeDouble(MarketInfo(OrderSymbol(),MODE_BID)-traildistance+step, Digits-1), OrderTakeProfit(), 0)); } else if(OrderType()==OP_SELL && (MarketInfo(OrderSymbol(),MODE_ASK)+traildistance<OrderStopLoss()))...
Not quite. My EA is risk % based and as such my trailing distance and step are determined by the trade itself using information like stop loss, entry price and take profit. I have it working ok with my code however it only works for first trade. After that trades 1,2 etc... even if different pairs or trade type we moving the SS based on trade 0. I can't figure out how to have the trail function look at and manage each trade as its own based on its own trade information. That is what has me puzzled. Adding the magic number seems to have stopped some of it but I am wondering if something in my code for order select is not right as the filters I had for symbol and buy versus sell alone weren't doing it and I'm not sure why. A sell trade was being affected by a buy trade trail. do
Today's zone = Tomorrow's opportunity!
  • #8
  • Jun 24, 2015 4:54pm Jun 24, 2015 4:54pm
If your algo works for one order, it works for any (because the process is not different). However, this presumes that all variables are correctly assigned anew the data of the next order. So, chances are you are failing at this auxiliary step.
Return To Disorder
  • #9
  • Jun 24, 2015 5:17pm Jun 24, 2015 5:17pm
That's why I posted my code. Hoping someone could help pick out where I went wrong in my code. It works for trade 0 regardless of whether it's a buy or sell. Trades 1,2,3 etc..
Are messed up and seem to be running based on trade 0.

Thank you for your replies.
Today's zone = Tomorrow's opportunity!
  • #10
  • Jun 25, 2015 1:40am Jun 25, 2015 1:40am
I cannot quite assess the relevance of this, but you are not calculating BuyRisk/SellRisk/TrailFactor/TrailMove/BECSAdd variables for each order, but use the same values for all orders (and also, you are not normalising the final value(s), what you probably should).
Return To Disorder
  • #11
  • Jun 25, 2015 4:46am Jun 25, 2015 4:46am
Quoting rockit
I cannot quite assess the relevance of this, but you are not calculating BuyRisk/SellRisk/TrailFactor/TrailMove/BECSAdd variables for each order, but use the same values for all orders (and also, you are not normalising the final value(s), what you probably should).
They are for each order;

SellRisk and BuyRisk use the two fixed, never changing order information of Open Price and Take Profit (which is based on the risk set by the original SL / open price). Therefore these are both order specifc. The answer of these formula's is in the correct format to be added to any of the order numbers like open price, stop loss etc.. and don't need to be normalized. These two items are under my global variables but do become order specific (I hope anyway)

Inserted Code
double SellRisk    = ((OrderOpenPrice()-OrderTakeProfit())/TPFactor);
double BuyRisk    = ((OrderTakeProfit()-OrderOpenPrice())/TPFactor);

Inserted Code
extern double TrailFactor = 2.0
extern double TrailMove = 1.0

Neither of these need to be normalized as these are factors to multiple values that are already in the correct format giving me the amount of "pips" to be used in the move. Settings of 2.0 and 1.0 is equal to a 1:1 trail. Once price has move 2 risk units away from the "stop loss" it moves the "stop loss" up or down 1 unit. After the trade is open once price hits 1:1 I get a move to BE etc...

BECSadd was normalized up in my global variables as these is the value of commission and swaps in $ turned into pips so when moving the SL it looks in enough pips to guarantee no loss if BE is hit.

As I said before ALL of this works one order at a time regardless of trade direction. It's when there is more than one open order that something is not right.
Today's zone = Tomorrow's opportunity!
  • #12
  • Jun 25, 2015 6:29am Jun 25, 2015 6:29am
Quoting pres78
As I said before ALL of this works one order at a time regardless of trade direction. It's when there is more than one open order that something is not right.
This fact suggest that you are not calculating the values per order.
It is difficult to follow what you are really doing because it seems each time you present a different code.
In the second code you are clearly using the same values for all orders because you have that loop in there.
Return To Disorder
  • #13
  • Jun 25, 2015 7:54am Jun 25, 2015 7:54am
Quoting rockit
{quote} This fact suggest that you are not calculating the values per order. It is difficult to follow what you are really doing because it seems each time you present a different code. In the second code you are clearly using the same values for all orders because you have that loop in there.
Sorry if I have confused however the latest code posted yesterday is where I was sitting at the time. I have the code in a loop under OnTick so that it will keep checking and updating the trades once open until closed. I showed above how I was calcualating my trail and step amounts in pips which I hoped gave me a by trade trailing stop loss.

Using my risk based model how can I get the trail to be managed by order and continue to manage the stop loss for each trade until either SL or TP is hit?

That is my conundrum... Back to the drawing board.

Rockit... thank you for your time.
Today's zone = Tomorrow's opportunity!
  • #14
  • Edited 9:36am Jun 25, 2015 9:21am | Edited 9:36am
Quoting pres78
Using my risk based model how can I get the trail to be managed by order and continue to manage the stop loss for each trade until either SL or TP is hit?
You have to calculate risk once per order and then save it, so that you can re-use it (via ticket).
Return To Disorder
  • #15
  • Jun 25, 2015 9:53am Jun 25, 2015 9:53am
Quoting rockit
{quote} You have to calculate risk once per order and then save it, so that you can re-use it (via ticket).
Thanks again.
Today's zone = Tomorrow's opportunity!
  • #16
  • Jun 26, 2015 6:50am Jun 26, 2015 6:50am
Rockit,

Thank you for steering me back on course. I have taken your comments, done some more research, re-wrote the trailing code and it's now working perfectly. Manages each trade seperatley based on the individual risk information for each trade.

Perfect!

Thanks again.
Today's zone = Tomorrow's opportunity!
  • #17
  • Sep 25, 2018 6:13pm Sep 25, 2018 6:13pm
Digging into this old thread hoping for another round of help. I have researched and tried several bits of code unsuccessfully.

What I am trying to add to my EA is the following;

 

  1. I want the EA to look from the last closed bar a set period (say 15 from bar 1).
  2. I want it to look only at H1 bars regardless of what TF I am on.
  3. I want it to look only at the current chart I am on.
  4. During this look-back I want it to look for the iHighest volume bar within that period of bars.
  5. I want it to then do the following;

    1. Either apply a fib with 0,50 and 100 levels on the highest volume bar from the look-back period (i.e from the H to the L of that H1 bar).
    2. or apply TL's (rayed to the right) at all 3 levels.

  6. As each new bar opens I want it to check the last closed bar (now bar 1) and if it is now the iHighest volume bar from the period delete the old fib or TL's and draw new ones on the new bar 1.

Today's zone = Tomorrow's opportunity!
  • #18
  • Last Post: Sep 26, 2018 6:31pm Sep 26, 2018 6:31pm
Quoting pres78
Digging into this old thread hoping for another round of help. I have researched and tried several bits of code unsuccessfully. What I am trying to add to my EA is the following; I want the EA to look from the last closed bar a set period (say 15 from bar 1). I want it to look only at H1 bars regardless of what TF I am on. I want it to look only at the current chart I am on. During this look-back I want it to look for the iHighest volume bar within that period of bars. I want it to then do the following; Either apply a fib with 0,50 and 100 levels...
Figured it out so nevermind.
Today's zone = Tomorrow's opportunity!
0 traders viewing now