Sending algorithmic string to buy signal in mt4 | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Simplest EA needed: buy on signal, sell on signal 2 replies

MT4 Global String Variables 16 replies

Sort String Array by String Length 2 replies

String of losers.... 16 replies

Case Insensitive String Compare OR Uppercase function? 3 replies

Sending algorithmic string to buy signal in mt4

  • #1
  • First Post: Jun 12, 2015 4:35am Jun 12, 2015 4:35am
I'm testing a number of buy signals in an EA and want to send an algorithm as a "string" to execute. If I copy and paste the string into the buy signal it works but if I keep it as a variable it does not work, or works differently. It should work exactly the same. In this example, if I copy and paste OpenTradeSignal 1 without the quotes which is (Close[1] > Close[X]) into the parenthesis where BuySignal is, it works fine, but if I want it to read from the code it doesn't. What am I doing wrong here?

Inserted Code
extern int OpenTradeSignal = 1;
 
//////////
 
string BuySignal;
string SellSignal;
 
if (OpenTradeSignal == 1)
BuySignal = "(Close[1] > Close[X])";
SellSignal = "(Close[1] < Close[X])";
 
if (OpenTradeSignal == 2)
BuySignal = "(Close[1] < Close[X])";
SellSignal = "(Close[1] > Close[X])";
 
if (BuySignal)
 
{          Comment(TimeToStr(TimeCurrent(),TIME_SECONDS), "  X > Y  BUY SIGNAL  ", Ask);
            Print(TimeToStr(TimeCurrent(),TIME_SECONDS), "  X > Y  BUY SIGNAL  ", Ask);
{
      
            if (countL1 < NP)
            
            fBuy1();
}
}
 
if (SellSignal)
 
{           Comment(TimeToStr(TimeCurrent(),TIME_SECONDS), " X < Y SELL SIGNAL  ", Bid);
//            Print(TimeToStr(TimeCurrent(),TIME_SECONDS), "  X < Y  SELL SIGNAL  ", Bid);
{
      
            if (countS1 < NP)
 
            fSell1();
  • #2
  • Edited 8:21am Jun 12, 2015 6:56am | Edited 8:21am
You still do not know to code in mql. That's the problem. Your code has logic/syntax flaws.
1. Your 1st/2nd if-statements (both) are terminated after the first statement that follows.
2. You are using strings (3th/4th outer if-statements) instead of a boolean (rational) expression (the compiler will not evaluate the meaning of the string!).
Return To Disorder
  • #3
  • Jun 15, 2015 6:35pm Jun 15, 2015 6:35pm
Got it. Thank you. Did this instead. Thanks again.

example (for others to see if they come across this):

Inserted Code
if (OpenTradeSignalA == 1) {
if ((Open[Y] > Open[X]) BuySignalA = true;
if ((Open[Y] < Open[X]) SellSignalA = true; }
 
if (OpenTradeSignalA == 2) {
if ((Close[Y] > Close[X]) BuySignalA = true;
if ((Close[Y] < Close[X]) SellSignalA = true; }
etc. and then

if BuySignalA then Buy etc.
  • #4
  • Jun 16, 2015 2:25am Jun 16, 2015 2:25am
I would write it like below, if it were me:

Inserted Code
OpenTradeSignalA = TRUE;          //--assign true or false value to your variable    
                                        //--then use if expressions
      if(OpenTradeSignalA){             //--variable is either true or false
                                        //--three possible choices: greater, less or equal
         if(Open[y] > Open[x]){         //--greater
            BuySignalA = true;
         }else if(Open[y] < Open[x]){   //--less
            SellSignalA = true;
         }else{                         //--equal
            //------------------------------no signal - keep staring at chart
         }
      }else{                            //--OpenTradeSignalA is false...
         if(Close[y] > Close[x]){       //--greater
            BuySignalA = true;
         }else if(Close[y] < Close[x]){ //--less
            SellSignalA = true;
         }else{                         //--equal
            //---------------------------no signal - keep staring at chart
         }
      }

In your example, you have too many left parantheses and you haven't explicitly dealt with prices being equal.

My true or false may not be correct in this example, as I wasn't sure if you were using 1 or 2 as true....

Hope the above is helpful?

OD
  • #5
  • Last Post: Jun 16, 2015 10:38pm Jun 16, 2015 10:38pm
Yeah you're right. Too many parens. I copied and pasted incorrectly.

As far as the logic goes, the actual EA code has if (OpenTradeSignalA == 1) as INT and it goes from 1 through 20(for 20 different signals). I have it that way so I can test which of the 20 signals were recently most effective.
0 traders viewing now