Issues with trying to sort | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Can MT4 sort a data array from largest to smallest? 3 replies

Demo account Explorers - Should be a sticky of some sort 0 replies

Sort String Array by String Length 2 replies

How to sort an array? 35 replies

Issues with trying to sort

  • #1
  • First Post: Jun 7, 2015 11:36pm Jun 7, 2015 11:36pm
Hello All,

I'm having real difficulty trying to resolve this coding problem and would welcome any advice:

I want to loop through all my open trades, arrange them in order depending on how much open profit/loss each one has and then output the ticket number for the trade that has the least amount of profit but ignoring those trades which are currently sitting on a loss.

As an example, say I have 6 open trades as follows:

(Ticket Number | Trade Type | Amount of current Profit/Loss $

Ticket 001 | BUY | $ 54
Ticket 002 | SELL | - $25
Ticket 003 | BUY | $ 4
Ticket 004 | SELL | $84
Ticket 005 | BUY | - $10
Ticket 006 | BUY | $ 154

Based on the above, the ticket number that I would want would be Ticket 003.


Any Ideas on how to achieve this? I know that I will need to create an Array but I'm struggling to know what to code.


Any help, as always, appreciated.

Chorlton
  • #2
  • Jun 8, 2015 12:25am Jun 8, 2015 12:25am
Not tested, but may help you

Inserted Code
   double orders_array[][2];
   int total=OrdersTotal();
   ArrayResize(orders_array,total);
   int index;
   for(index=total-1;index>=0;index--)
      if(OrderSelect(index,SELECT_BY_POS))
        {
         orders_array[index][0]=OrderProfit();
         orders_array[index][1]=OrderTicket();
        }
   ArraySort(orders_array,WHOLE_ARRAY,0,MODE_ASCEND);
   int Ticket=0;
   index=0;
   while(index<total)
     {
      if(orders_array[index][0]>0)
        {
         Ticket=(int)orders_array[index][1];
         break;
        }
      index++;
     }
   if(Ticket>0)
      Print("Ticket Number=",Ticket," Profit=",DoubleToStr(orders_array[index][0],2));
   else
      Print("No Order With Profit");
Please Do Not PM Me With Coding Enquiries
  • #3
  • Jun 8, 2015 1:49am Jun 8, 2015 1:49am
Quoting Gumrai
Not tested, but may help you double orders_array[][2]; int total=OrdersTotal(); ArrayResize(orders_array,total); int index; for(index=total-1;index>=0;index--) if(OrderSelect(index,SELECT_BY_POS)) { orders_array[index][0]=OrderProfit(); orders_array[index][1]=OrderTicket(); } ArraySort(orders_array,WHOLE_ARRAY,0,MODE_ASCEND); int Ticket=0; index=0; while(index<total) { if(orders_array[index][0]>0) { Ticket=(int)orders_array[index][1]; break; } index++; } if(Ticket>0) Print("Ticket Number=",Ticket," Profit=",DoubleToStr(orders_array[index][0],2));...

Hi Gumrai,

I finally managed to find a crude solution which ended up being almost 3 times as many lines of codes as your elegant solution above !!

I have now replaced it with your code and am working my way through it to try to understand it fully.


Many Thanks for taking the time to reply.

Chorlton
  • #4
  • Jun 8, 2015 3:15am Jun 8, 2015 3:15am
If the sole purpose is to output the least (positive) profit, no sorting at all is needed; just loop through the queue and save the ticket with the least current profit.
In example you start with the first in queue, save its ticket in a variable. If the next one has less profit, put its ticket in the variable instead. Until loop done.
Return To Disorder
  • #5
  • Jun 8, 2015 3:46am Jun 8, 2015 3:46am
Quoting rockit
If the sole purpose is to output the least (positive) profit, no sorting at all is needed; just loop through the queue and save the ticket with the least current profit. In example you start with the first in queue, save its ticket in a variable. If the next one has less profit, put its ticket in the variable instead. Until loop done.

Hi Rockit,

Thanks for the reply.

This is in essence what I coded up myself but my code ended up being a lot longer that what Gumrai kindly posted and for some reason it wasn't working 100% correctly. This is no doubt due to my current inexperience with MQL4.

Cheers..
  • #6
  • Jun 8, 2015 4:18am Jun 8, 2015 4:18am
Ok the simple version should go like this :
Inserted Code
double profit = DBL_MAX;
int ticket = -1;
for(int i = OrdersTotal()-1; i >= 0; i--) {
  if(OrderSelect(i,SELECT_BY_POS)&&OrderType()<2&&OrderProfit()>=0&&OrderProfit()<profit) {
    profit = OrderProfit();
    ticket = OrderTicket();
  }
}
if(ticket != -1) Print("current least profitable ticket is: ", ticket);
else Print("currently no profitable ticket");
Return To Disorder
  • #7
  • Jun 8, 2015 4:40am Jun 8, 2015 4:40am
Quoting rockit
Ok the simple version should go like this
Similar to my first thought.
I included the array because Chorlton requested
"I want to loop through all my open trades, arrange them in order depending on how much open profit/loss each one has"
What you have done, by not including untriggered stop and limit orders, makes perfect sense.
Please Do Not PM Me With Coding Enquiries
  • #8
  • Last Post: Jun 8, 2015 8:09am Jun 8, 2015 8:09am
Quoting rockit
Ok the simple version should go like this : double profit = DBL_MAX; int ticket = -1; for(int i = OrdersTotal()-1; i >= 0; i--) { if(OrderSelect(i,SELECT_BY_POS)&&OrderType()<2&&OrderProfit()>=0&&OrderProfit()<profit) { profit = OrderProfit(); ticket = OrderTicket(); } } if(ticket != -1) Print("current least profitable ticket is: ", ticket); else Print("currently no profitable ticket");

Hi Rockit,

double profit = DBL_MAX

I never heard of this function until now. I've just done some reading on it and I can see the benefits of using it... Thanks
0 traders viewing now