My EA Gift to Traders | Page 56 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Screen shot indicator free gift 0 replies

DECEMA - Xmas gift! 6 replies

Vegas 1HR GIFT: Big opportunity coming! 5 replies

Attachments: My EA Gift to Traders
Exit Attachments

My EA Gift to Traders

  • #1,101
  • Edited 12:38pm Apr 16, 2015 1:27am | Edited 12:38pm
Just updated the 2015 data files to 15th April. Strategy Optimizer is now also at Post #1

Outstanding items

Reversal trades and Traders Dynamic Index closures.
Strategies on other timeframes.
Multiple instances of the same strategy. (including multiple straddle trades up to 5 days ahead - for example news events)

I'd appreciate some feedback on the need for phased closure of trades. My current thinking is that the trade management principles are working quite well and that there is really no need for phased closure. If you look at all the trade explorers on my profile page (all started with a balance of $10,000 around the beginning of Feb.), they are going along quite nicely with the current money management techniques. In the process of redoing all the optimized set files for the most current 3 month time period for posting at Page 1.

Another item for discussion is how to determine when an EA or group of related EA's have run their course. I have mentioned previously that my belief is around 3 months and the current EA's are up around that timeframe. The close trades EA, in that it can manage a group of EA's, can be used as a form of trailing stop loss for the group as a whole. I invite your response.
  • #1,102
  • Apr 16, 2015 4:19am Apr 16, 2015 4:19am
Quoting Dave_C
Just updated the 2015 data files to 15th April. Strategy Optimizer is now also at Post #1 Outstanding items Reversal trades and Traders Dynamic Index closures. Strategies on other timeframes. Multiple instances of the same strategy. (including multiple straddle trades up to 5 days ahead - for example news events) I'd appreciate some feedback on the need for phased closure of trades. My current thinking is that the trade management principles are working quite well and that there is...
Thank you for your hard work Dave!
  • #1,103
  • Apr 16, 2015 9:28am Apr 16, 2015 9:28am
Hi Dave thanks for the great EA. Was looking for a place to start on an EA and this seems like a great one to contribute too lol.

I seem to keep getting Ordersend 131 and ordermodify 4051 in the back test... Not sure where this is coming from I get a few trades and works great up until that time.

I did some poking and noticed
Inserted Code
if (LotSize == 0 && RiskBasis == 0) Wager = NormalizeDouble(AccountEquity() * MaximumRiskPercentage / 100000 ,2);

I beleive the 100000 is for how much each lot is worth? My Brokers is sometimes a PITA and does not do everything standard so I updated to

Inserted Code
if (LotSize == 0  && RiskBasis == 0) Wager = NormalizeDouble(AccountEquity() * MaximumRiskPercentage / MarketInfo(Symbol(), MODE_LOTSIZE),2);

To get my brokers lotsize. I also updated in the other wager's. Let me know if I misread that code lol hopefully I didn't make it worse. If I didn't might be something to make it more standardized. Probably could just pull it out in the init and store it in a variable so we don't query the marketinfo everytime we want to open a trade if it causes any performance impact.

Still trying to figure out what the heck is up with my broker and why I keep getting the ordermodify and ordersend errors.

Again thanks for the great EA can tell a lot of work was put into it.
  • #1,104
  • Apr 16, 2015 9:57am Apr 16, 2015 9:57am
Quoting Dave_C
{quote} All problems should now be resolved. Download the update here.
Hi,

The splash screen issue is resolved (thanks for that), however, the issue where I put half a percent into the risk percentage and this generates no trades is still present. An interesting side-note to this is if I plug in 0.75 risk percentage, SO does generate trades in the report but (as far as I can tell), the report is identical to 1% risk percentage (the total is identical to 1%).

It appears that the risk percentage is being rounded up to next integer (ceiling: https://msdn.microsoft.com/en-us/lib...code-snippet-1)

Rick
  • #1,105
  • Edited 11:06am Apr 16, 2015 10:18am | Edited 11:06am
Appears to be another one off with my broker lol Like I said a PITA. I changed the lots size normalization to 1.

I put in a Extern variable hlp1g to set this and then at the end of the SetWager function normalized the entire Wager to that value.

Inserted Code
extern string Hlpf = "Numbers after decimal in lot size";
extern double normalizedLots = 1;

Then at the end of the SetWager Function

Inserted Code
​ Wager = NormalizeDouble(Wager,normalizedLots);
   PrevWager = Wager;
   PrevEquity = AccountEquity();
   AdjStopLoss = StopLoss;

Attached is the changes I made in the code.

Please don't use this version! Use the one Dave linked in post 1 if he feels I didn't break anything he may apply the changes to that version lol.
Attached File(s)
File Type: mq4 TradersGift.mq4   106 KB | 445 downloads
  • #1,106
  • Apr 16, 2015 10:26am Apr 16, 2015 10:26am
Quoting Dave_C
I'd appreciate some feedback on the need for phased closure of trades. My current thinking is that the trade management principles are working quite well and that there is really no need for phased closure.
Agreed. This is not a feature that I have/would ever use. It also increases the complexity of the EA.

The EA is very complete as it is. The only feature I would like to see is pyramiding with two input parameters: one for distance to the next pyramid/extension and one indicating the maximum number of extensions. I have not asked for this feature because it means a dramatic increase in the EA logic. Multiple trades would have to be managed instead of managing just one per chart.
Quoting Dave_C
In the process of redoing all the optimized set files for the most current 3 month time period for posting at Page 1.
I got these new files. Thanks.
Quoting Dave_C
Another item for discussion is how to determine when an EA or group of related EA's have run their course. I have mentioned previously that my belief is around 3 months and the current EA's are up around that timeframe. The close trades EA, in that it can manage a group of EA's, can be used as a form of trailing stop loss for the group as a whole. I invite your response
I think that is a good solution. I was thinking something a lot more simple, and manual, like re-running an optimization on each chart/settings every month to make sure the strategy is still viable. This method does have a flaw, the strategy can collapse quickly at the beginning of the month or in the middle of the month. I would rate this as unlikely. Most of the time, a strategy goes through a transition phase where the return is diminished (that is the warning) before it collapses completely. This solution would also have the benefit of having a replacement in-the-wings when the strategy does collapse.

Rick

Rick
  • #1,107
  • Edited 12:28pm Apr 16, 2015 11:57am | Edited 12:28pm
Quoting maxss280
Appears to be another one off with my broker lol Like I said a PITA. I changed the lots size normalization to 1. I put in a Extern variable hlp1g to set this and then at the end of the SetWager function normalized the entire Wager to that value. extern string Hlpf = "Numbers after decimal in lot size"; extern double normalizedLots = 1; Then at the end of the SetWager Function ​ Wager = NormalizeDouble(Wager,normalizedLots); PrevWager = Wager; PrevEquity = AccountEquity(); AdjStopLoss = StopLoss; Attached is the changes I made in the code....
I'm not aware of lot size issues with other posters and you can make whatever changes suit you and your broker. You may be aware that I removed the copyright disclaimer at the top of my code. Regards Dave.
  • #1,108
  • Edited 1:30pm Apr 16, 2015 12:25pm | Edited 1:30pm
Quoting rsmereka
{quote} Agreed. This is not a feature that I have/would ever use. It also increases the complexity of the EA. The EA is very complete as it is. The only feature I would like to see is pyramiding with two input parameters: one for distance to the next pyramid/extension and one indicating the maximum number of extensions. I have not asked for this feature because it means a dramatic increase in the EA logic. Multiple trades would have to be managed instead of managing just one per chart. {quote} I got these new files. Thanks. {quote} I think that...
Thanks for your feedback. It was always my stated intention to review the EA's every month to maintain optimized settings for the last 3 month time period and you are quite correct that an EA can take some time to "bed down". Starting an EA on a Monday morning when the Market can be directionless is not a good idea. I haven't amended the current EA's because they are running quite well but I did remove the 21 example EA's from Post #1. That is why I proposed the use of The CloseTrades EA, which had been previously included, as a management tool for collapsing EA's. I have included this with this post. The coding is quite simple and Traders Gift recognises the dummy BuyLimit order that it creates as a signal not to trade. At the moment the input is a hard Stop Loss and Take Profit and trading is reopened at start of next day, but it would be easy enough to set a trailing stop loss.

I had quite a number of requests both by PM and on the forum for the MACD CDL strategy which I am reluctant to fulfil because it may have run it's course at this stage. At any rate it is easy enough for anybody to run their own optimizations now with the Strategy Optimizer. Just select MACD and CDL strategies along with the example ticks in the money management area plus add ticks to the bottom 3 inputs in the yellow money management panels. The point is, the EA is not designed for hand holding rather to provoke thought and input.

Regarding Risk Percentage, any input is acceptable as all calculations are rounded to 2 decimal points. With the issue of no trades, if you select more than 1 strategy, make sure the lookback bars are taken out to 5 on at least one strategy otherwise the events will have to be simultaneous for trades to be taken. Regarding multiple trades and pyramid/extensions and multiple trades, the solution is to have multiple charts of the same currency pair each with their own Magic Numbers handling whatever requirements you need.
Attached File(s)
File Type: mq4 CloseTrades.mq4   2 KB | 234 downloads
  • #1,109
  • Apr 16, 2015 2:21pm Apr 16, 2015 2:21pm
Thank you so much Dave...
I will test this EA and hoping the best result..
MAKE SURE you still can TRADE tomorrow
  • #1,110
  • Apr 16, 2015 2:41pm Apr 16, 2015 2:41pm
Thanks,Dave....But,now I got the alert: "Data Read Error." I have downloaded the new datafiles...
  • #1,111
  • Apr 16, 2015 2:57pm Apr 16, 2015 2:57pm
I have just uploaded 28 optimized example strategies to Post #1.

Of particular interest is the Divergence/Candle strategy which is looking for divergence on the MACD or RSI indicators combined with a Candlestick reversal indication. Of the 4 separate strategies over the 7 major currency pairs, this strategy was the best performer on back tests since the beginning of the year. The USDCHF back tests did not commence until 17th January because of the CHF float mid January.

Every optimization except one was carried out on 60 min. timeframe because of my own experiences with lower timeframes. Excessive trades means extra commission and you all realise what a dramatic effect commission + spread has on outcomes. The other optimization was on the USDCHF 15 min chart as an experiment because the back test on the 60 min timeframe was inconclusive whereas the 15 min chart produced much better results. Anyway you can see for yourselves if you load these set files into Strategy Optimizer. They can be improved if you optimize the last 3 inputs in the Money Management panel which weren't optimized in my tests.

In the course of my optimizations, I found 2 small errors in my code for Divergence and Volume which have now been fixed and the new download of Strategy Optimizer is also at Post #1.
  • #1,112
  • Apr 16, 2015 3:00pm Apr 16, 2015 3:00pm
Eur/Usd from 2014.01.01 to today. Fixed 0.05 lot. H1. Tp/Sl 100 pip. Break-even 20 pips. Deposit 1000$. DD% 14%

Attached Image (click to enlarge)
Click to Enlarge Name: eurusd.gif Size: 11 KB
  • #1,113
  • Edited 6:27pm Apr 16, 2015 3:00pm | Edited 6:27pm
Quoting bazze
Thanks,Dave....But,now I got the alert: "Data Read Error." I have downloaded the new datafiles...
I need much more detail to be able to help you. Please think before you post!

I have had to download the zip file myself and test all data files in case there is a problem. No such problem exists so in the future please take care.
Attached Image(s) (click to enlarge)
Click to Enlarge Name: 2015-04-17 06_05_16-Strategy Optimizer.jpg Size: 27 KB
Click to Enlarge Name: 2015-04-17 06_05_44-Strategy Optimizer.jpg Size: 27 KB
Click to Enlarge Name: 2015-04-17 06_06_07-Strategy Optimizer.jpg Size: 26 KB
Click to Enlarge Name: 2015-04-17 06_06_30-Strategy Optimizer.jpg Size: 26 KB
Click to Enlarge Name: 2015-04-17 06_06_52-Strategy Optimizer.jpg Size: 28 KB
Click to Enlarge Name: 2015-04-17 06_07_15-Strategy Optimizer.jpg Size: 27 KB
Click to Enlarge Name: 2015-04-17 06_07_34-Strategy Optimizer.jpg Size: 26 KB
  • #1,114
  • Edited 6:58pm Apr 16, 2015 3:34pm | Edited 6:58pm
Quoting karolisl
Eur/Usd from 2014.01.01 to today. Fixed 0.05 lot. H1. Tp/Sl 100 pip. Break-even 20 pips. Deposit 1000$. DD% 14% {image}
We all appreciate your input but your post does give any info on your strategy. Could you please post your .set file (as .txt in order to upload) and I will be able to comment. I suspect your settings could be vastly enhanced particularly in the money management area.

I wouldn't recommend an extended back test period as trading methods change with time.
  • #1,115
  • Edited 2:20am Apr 17, 2015 12:49am | Edited 2:20am
Signal Reversal and Traders Dynamic Index trade closure modes have been enabled in Strategy Optimizer. Download at Post #1

I'm not totally convinced about either strategy but since they are in the EA, I have added them to Strategy Optimizer.

Regarding trade reversal, the only indicator that seems to work successfully, is RSI. TDI stifles the advanced money management techniques. Money management is the primary reason that this EA is working so well. It's not because we have found a magic mix of indicators. If you look at the Trade Explorers, most strategies mark time taking small profits waiting to be in a position to capitalize on the good trade.

There is no need to seek exotic combinations such as triple crosses and use of non standard indicators to gain an edge because trading is more about discipline and very sound money management. There is scope for technical indicators, particularly with the non major crosses where fundamentals are not so relevant. Keeping your indicators relatively simple is a fundamental principle. For the people who are back testing strategiies such as MA crosses over extended periods, forget about it and look more towards sound money management with BreakEven, MinPipGain, DecreaseStopLoss and SL &TP Multiples. Probably a good time to explore some of the links on Post 1.

I look forward to some input.
  • #1,116
  • Apr 17, 2015 1:18am Apr 17, 2015 1:18am
Quoting Dave_C
{quote} We all appreciate your input but your post does give any info on your strategy. Could you please post your .set file (as .txt in order to upload) and I will be able to comment. I suspect your settings could be vastly enhanced particularly in the money management area. I wouldn't recommend an extended back test period as trading methods change with time.

Sure, when i get back home.
  • #1,117
  • Apr 17, 2015 3:18am Apr 17, 2015 3:18am
It certainly says something about humanity when there are 536 downloads since Apr 1 and maybe 10 posters!
  • #1,118
  • Apr 17, 2015 4:38am Apr 17, 2015 4:38am
Quoting Dave_C
{quote} I need much more detail to be able to help you. Please think before you post! I have had to download the zip file myself and test all data files in case there is a problem. No such problem exists so in the future please take care. {image} {image} {image} {image} {image} {image} {image}
  • #1,119
  • Edited 9:08am Apr 17, 2015 5:53am | Edited 9:08am
Hey Dave I noticed when you click through the Optimization results it shows the previous one you had selected. Not sure if that was intended or a bug so just throwing it out there.

Attached Image
Attached Image


Also just a suggestion for the clear all selections, maybe make that just reset everything to the default settings like when you first start the program. The reason I say that is because when I was testing somehow the ATR got set to 5 and I was going nuts trying to figure out why my results were weird even though I kept resetting between testing, it wasn't resetting to 0 just unchecking the options.
  • #1,120
  • Apr 17, 2015 8:49am Apr 17, 2015 8:49am
Quoting Dave_C
{quote} We all appreciate your input but your post does give any info on your strategy. Could you please post your .set file (as .txt in order to upload) and I will be able to comment. I suspect your settings could be vastly enhanced particularly in the money management area. I wouldn't recommend an extended back test period as trading methods change with time.
I think like you, that settings could be enhanced more. I just change indicator settings. Here you go. Time frame 1H.

Attached File(s)
File Type: txt H1 fixed lot.txt   13 KB | 259 downloads
2 traders viewing now